Commit Graph

259 Commits

Author SHA1 Message Date
Arnaud Rachez 5db2adf93c MAINT Removed deprecated stuff. 2015-10-21 10:24:23 +02:00
Raghav R V e3afc0e8c9 MAINT move custom error/warning classes into sklearn.exceptions
ENH NonBLASDotWarning -> EfficiencyWarning; Improve error message
DOC Add exceptions module to modules/classes.rst
MAINT Move ConvergenceWarning, UndefinedMetricWarning et al into exceptions
MAINT Remove ChangedBehaviorWarning from base
DOC/FIX Improve DataConversionWarning's docstring
2015-10-19 22:35:35 +02:00
Raghav R V a87011262a FIX precision to float64 across the codebase 2015-10-16 11:20:29 +02:00
MechCoder c805fbc79b Refactor tests 2015-10-10 22:05:40 -04:00
MechCoder 5a0db1717a 1. Added parameter prefit to pass in a fitted estimator.
2. Use assert_warns instead of catch_warnings
3. Remove depracation warnings in common tests.
2015-10-09 01:57:36 -04:00
MechCoder acf5f160a8 Merge SelectFromModel and L1-selection examples
Add test to check the threshold can be set without refitting
2015-10-05 11:25:07 -04:00
MechCoder 2ee718cc75 Add narrative docs and fix examples 2015-10-05 11:25:06 -04:00
MechCoder 10176d9897 Now a fitted estimator can be passed to SelectFromModel 2015-10-05 11:25:06 -04:00
MechCoder 3d41053d67 Minor doc changes and removed _set_threshold and _set_importances 2015-10-05 11:25:06 -04:00
MechCoder 9cee0d95f8 Added example to depict feature selction using SelectFromModel and Lasso 2015-10-05 11:24:02 -04:00
MechCoder 459cb9ba3d Remove warm start 2015-10-05 11:19:57 -04:00
MechCoder 8a28ea8169 fix test failures 2015-10-05 11:19:57 -04:00
maheshakya c438f78996 Implemented SelectFromModel meta-transformer 2015-10-05 11:19:57 -04:00
Raghav R V 882c346abd DOC Make cv documentation consistent across our codebase 2015-09-10 09:15:13 +05:30
Vighnesh Birodkar 2f099334f9 MAINT deprecate 1d input arrays for all estimators
Passing 1D arrays to check_array, without setting `ensure_2d` to false now
raises a deprecation warning before reshaping it. This will later throw an
error.

All Scaler classes also throw warnings when 1D arrays are passed.

All unit tests/doctests are modified to ensure that no 1D arrays are passed,
except in explicit 1D array tests where the warnings have been silenced.

Additional tests are also included which check for different 1D array cases.

2D array tests with one samples and one features are also added and where
they failed, `check_array` call has been modified to give a more useful error
message
2015-09-09 15:49:58 +02:00
Andreas Mueller 434ee958aa test for accepted sparse matrices 2015-08-26 22:00:55 -04:00
Raghav R V 62325cbb58 MAINT merge _check_cv into check_cv as indices argument is removed in 0.17 2015-06-08 16:37:03 +05:30
Andreas Mueller 0650d5502e DOC adding backlinks to docstrings 2015-06-03 00:24:04 -04:00
Andreas Mueller f369d3ab0f Fix RFE / RFECV estimator tags 2015-05-29 11:36:38 -04:00
Andreas Mueller 79ea587e05 FIX make rfe feature importance test deterministic. 2015-04-28 18:26:22 -04:00
Wei Xue c165327940 Add regression test for the number of subsets of features 2015-04-20 12:58:29 -04:00
Wei Xue 7bbf10a598 ENH optimize rfecv by eliminating the for loop 2015-04-20 12:27:31 -04:00
Vincent Michel 0f0e58d35e Fix RFE - Add the possibility to use feature_importances rather than coef_ when existing, see #2121 2015-04-02 14:56:48 +02:00
Wei Xue 17ee7dd79b DOC & COSMIT deprecate estimator_params in RFE and RFE_CV in docstring 2015-03-29 12:47:53 -04:00
Vinayak Mehta 8702801c13 used special.fdtrc instead of fprob
added integer division
2015-03-23 21:46:59 +05:30
Raghav R V cd2ee7e454 MAINT docstring --> comments to prevent nose from using doc in verbose mode 2015-03-21 11:16:49 +05:30
Olivier Grisel c6f6cf365c Merge pull request #4368 from xuewei4d/deprecate_estimator_params
[MRG + 1] Deprecate estimator_params in RFE and RFECV #4292
2015-03-20 13:15:57 +01:00
Wei Xue b741aa3e5c FIX coding style #4292 2015-03-10 14:46:10 -04:00
Wei Xue 9f312a72b3 Correct warning messages and move warnings to fit method #4292 2015-03-10 10:47:15 -04:00
Martin Ku 2bc7ffef1c Add "See also" for selectors and scoring funs
Details:
- Reference uni variate selectors and scoring funcs
- Indicate chi2 is only for non-negative features
- Add "See also" formatting rules to contributing
- Add example of good "References" in docstrings
- Misc small doc updates for uni feature selection
  - Add missing periods (for consistency)
  - Anova -> ANOVA (for consistency)
  - Make a numbered list render per item per line (for readability)
  - Capitalize the first letter of a numbered list (for readability)
2015-03-10 21:40:25 +08:00
Wei Xue 08b97b32c2 Deprecate estimator_params in RFE and RFECV #4292 2015-03-09 16:45:46 -04:00
Andreas Mueller 9bc4de8dae some fixes for sphinx and in examples 2015-03-02 12:50:53 -05:00
Andreas Mueller f12a441655 raise noise in test again, be ascii 2015-02-24 16:26:24 -05:00
Olivier Grisel 95f1d9562b FIX DOC TST: alpha is an uppper bound on FDR 2015-02-24 16:26:24 -05:00
Andreas Mueller 700babc43f extensive (excessive?) testing of FDR 2015-02-24 16:26:24 -05:00
Andrew Tulloch 1add39ff11 [Feature Selection] Fix SelectFDR thresholding bug (#2771)
From https://github.com/scikit-learn/scikit-learn/issues/2771, we were
not correctly scaling the alpha
parameter (http://en.wikipedia.org/wiki/False_discovery_rate#Benjamini.E2.80.93Hochberg_procedure)
with the number of features (== hypothesis).  Thus, the alpha
parameter was not invariant wrt the number of features.

The correction is as suggested in the original issue, and a test has
been added that verifies that for various numbers of features, an
appropriate false discovery rate is generated when using the selector.
2015-02-24 16:25:58 -05:00
Loïc Estève 5c0c5c672c MAINT use absolute imports in tests
as per the guideline in:
http://scikit-learn.org/stable/developers/#coding-guidelines
2015-02-10 13:40:31 +01:00
jnothman 95681eecca Merge pull request #4206 from ogrisel/fix-strict-select-fdr
[MRG] explicit warning message for strict selectors

Also fixes #4059
2015-02-07 21:54:45 +11:00
Olivier Grisel 2ce9eac717 TST more strict selectors with empty support 2015-02-07 11:37:06 +01:00
Olivier Grisel bc5b403af3 FIX #4059: explicit warning for strict selectors 2015-02-06 12:06:34 +01:00
bhsu 97e3b96801 PEP8 compliance 2015-02-05 15:26:46 -05:00
bhsu 13b6aec5f3 non-inheriting estimator added for rfe, cross validation, and pipeline tests
non-inheriting estimator added for cross validation

non-inheriting estimator added for pipeline

reconciled diffs
2015-01-29 22:02:38 -05:00
Andreas Mueller a413f875f1 DOC minor fixes do docstrings, don't document deprecated parameters. 2015-01-16 11:55:02 -05:00
Raghav R V b3fbccca38 FIX various mismatch between docstring and signature params
DOC max_iterations -> max_iter. Make it consistent with kmeans

MAINT Replace the deprecated dx parameter with d in the docstrings

MAINT Deprecation warning for max_iterations parameter.
2015-01-16 11:54:57 -05:00
Raghav R V abd31d2cad MAINT Make uniform the error raised for not fitted condition 2015-01-12 00:33:40 +05:30
Raghav R V 88555987cc PEP8 Fix E101, E111 errors and W191, W293, W293 and W391 warnings. 2015-01-08 04:28:24 +05:30
Andreas Mueller 46c1c42131 remove deprecated ``n_bootstraps`` parameter in Bootstrap cv object, verbose in FactorAnalysis and SelectorMixin. Also adjust some deprecation strings. 2014-12-29 13:53:42 -05:00
Andreas Mueller 41e2c10a9e rename decorator 2014-12-19 17:27:27 -05:00
Andreas Mueller 86f4ee1fa4 don't give names to decorators 2014-12-18 17:49:46 -05:00
Joel Nothman 94f37f43fa FIX ducktyping for meta-estimators 2014-12-18 17:48:56 -05:00