Commit Graph

149 Commits

Author SHA1 Message Date
Rémy Léone 9b7176dd9d [DOC] Fix broken links 2016-03-23 12:45:34 -07:00
giorgiop 140a5acda8 MAINT depr of center_data, normalize in linear_model 2016-02-17 14:26:50 -05:00
Andreas Mueller fb123ed24b More doc fixes. Latex builds again. 2015-11-20 16:30:45 -05:00
Raghav R V 3f8743f47b Main Commits - Major
--------------------

* ENH Reogranize classes/fn from grid_search into search.py
* ENH Reogranize classes/fn from cross_validation into split.py
* ENH Reogranize cls/fn from cross_validation/learning_curve into validate.py

* MAINT Merge _check_cv into check_cv inside the model_selection module
* MAINT Update all the imports to point to the model_selection module
* FIX use iter_cv to iterate throught the new style/old style cv objs
* TST Add tests for the new model_selection members
* ENH Wrap the old-style cv obj/iterables instead of using iter_cv

* ENH Use scipy's binomial coefficient function comb for calucation of nCk
* ENH Few enhancements to the split module
* ENH Improve check_cv input validation and docstring
* MAINT _get_test_folds(X, y, labels) --> _get_test_folds(labels)
* TST if 1d arrays for X introduce any errors
* ENH use 1d X arrays for all tests;
* ENH X_10 --> X (global var)

Minor
-----

* ENH _PartitionIterator --> _BaseCrossValidator;
* ENH CVIterator --> CVIterableWrapper
* TST Import the old SKF locally
* FIX/TST Clean up the split module's tests.
* DOC Improve documentation of the cv parameter
* COSMIT consistently hyphenate cross-validation/cross-validator
* TST Calculate n_samples from X
* COSMIT Use separate lines for each import.
* COSMIT cross_validation_generator --> cross_validator

Commits merged manually
-----------------------

* FIX Document the random_state attribute in RandomSearchCV
* MAINT Use check_cv instead of _check_cv
* ENH refactor OVO decision function, use it in SVC for sklearn-like
  decision_function shape
* FIX avoid memory cost when sampling from large parameter grids

ENH Major to Minor incremental enhancements to the model_selection

Squashed commit messages - (For reference)

Major
-----

* ENH p --> n_labels
* FIX *ShuffleSplit: all float/invalid type errors at init and int error at split
* FIX make PredefinedSplit accept test_folds in constructor; Cleanup docstrings
* ENH+TST KFold: make rng to be generated at every split call for reproducibility
* FIX/MAINT KFold: make shuffle a public attr
* FIX Make CVIterableWrapper private.
* FIX reuse len_cv instead of recalculating it
* FIX Prevent adding *SearchCV estimators from the old grid_search module
* re-FIX In all_estimators: the sorting to use only the 1st item (name)
    To avoid collision between the old and the new GridSearch classes.
* FIX test_validate.py: Use 2D X (1D X is being detected as a single sample)
* MAINT validate.py --> validation.py
* MAINT make the submodules private
* MAINT Support old cv/gs/lc until 0.19
* FIX/MAINT n_splits --> get_n_splits
* FIX/TST test_logistic.py/test_ovr_multinomial_iris:
    pass predefined folds as an iterable
* MAINT expose BaseCrossValidator
* Update the model_selection module with changes from master
  - From #5161
  -  - MAINT remove redundant p variable
  -  - Add check for sparse prediction in cross_val_predict
  - From #5201 - DOC improve random_state param doc
  - From #5190 - LabelKFold and test
  - From #4583 - LabelShuffleSplit and tests
  - From #5300 - shuffle the `labels` not the `indxs` in LabelKFold + tests
  - From #5378 - Make the GridSearchCV docs more accurate.
  - From #5458 - Remove shuffle from LabelKFold
  - From #5466(#4270) - Gaussian Process by Jan Metzen
  - From #4826 - Move custom error / warnings into sklearn.exception

Minor
-----

* ENH Make the KFold shuffling test stronger
* FIX/DOC Use the higher level model_selection module as ref
* DOC in check_cv "y : array-like, optional"
* DOC a supervised learning problem --> supervised learning problems
* DOC cross-validators --> cross-validation strategies
* DOC Correct Olivier Grisel's name ;)
* MINOR/FIX cv_indices --> kfold
* FIX/DOC Align the 'See also' section of the new KFold, LeaveOneOut
* TST/FIX imports on separate lines
* FIX use __class__ instead of classmethod
* TST/FIX import directly from model_selection
* COSMIT Relocate the random_state documentation
* COSMIT remove pass
* MAINT Remove deprecation warnings from old tests
* FIX correct import at test_split
* FIX/MAINT Move P_sparse, X, y defns to top; rm unused W_sparse, X_sparse
* FIX random state to avoid doctest failure
* TST n_splits and split wrapping of _CVIterableWrapper
* FIX/MAINT Use multilabel indicator matrix directly
* TST/DOC clarify why we conflate classes 0 and 1
* DOC add comment that this was taken from BaseEstimator
* FIX use of labels is not needed in stratified k fold
* Fix cross_validation reference
* Fix the labels param doc

FIX/DOC/MAINT Addressing the review comments by Arnaud and Andy

COSMIT Sort the members alphabetically
COSMIT len_cv --> n_splits
COSMIT Merge 2 if; FIX Use kwargs
DOC Add my name to the authors :D
DOC make labels parameter consistent
FIX Remove hack for boolean indices; + COSMIT idx --> indices; DOC Add Returns
COSMIT preds --> predictions
DOC Add Returns and neatly arrange X, y, labels
FIX idx(s)/ind(s)--> indice(s)
COSMIT Merge if and else to elif
COSMIT n --> n_samples
COSMIT Use bincount only once
COSMIT cls --> class_i / class_i (ith class indices) -->
perm_indices_class_i

FIX/ENH/TST Addressing the final reviews

COSMIT c --> count
FIX/TST make check_cv raise ValueError for string cv value
TST nested cv (gs inside cross_val_score) works for diff cvs
FIX/ENH Raise ValueError when labels is None for label based cvs;
TST if labels is being passed correctly to the cv and that the
ValueError is being propagated to the cross_val_score/predict and grid
search
FIX pass labels to cross_val_score
FIX use make_classification
DOC Add Returns; COSMIT Remove scaffolding
TST add a test to check the _build_repr helper
REVERT the old GS/RS should also be tested by the common tests.
ENH Add a tuple of all/label based CVS
FIX raise VE even at get_n_splits if labels is None
FIX Fabian's comments
PEP8
2015-10-23 17:28:08 +02:00
Raghav R V e3afc0e8c9 MAINT move custom error/warning classes into sklearn.exceptions
ENH NonBLASDotWarning -> EfficiencyWarning; Improve error message
DOC Add exceptions module to modules/classes.rst
MAINT Move ConvergenceWarning, UndefinedMetricWarning et al into exceptions
MAINT Remove ChangedBehaviorWarning from base
DOC/FIX Improve DataConversionWarning's docstring
2015-10-19 22:35:35 +02:00
Andreas Mueller c66689c4f4 FIX Don't compare arrays to strings!!!! 2015-10-15 16:07:17 -04:00
Raghav R V 21fab6e8ec FIX Move validation from helper to main function 2015-10-15 18:21:51 +02:00
Raghav R V 4f4c3598e6 FIX dtypes to conform to the stricter type cast rules of numpy 1.10
FIX set copy to (copy & whiten).

FIX/DOC Use float outputs for doctest
2015-10-15 18:21:51 +02:00
Andreas Mueller af56154a77 Merge pull request #5238 from rvraghav93/cvdoc
[MRG+1] DOC Make cv documentation consistent across our codebase
2015-09-13 13:29:27 -04:00
Andreas Mueller 6dd6f8ffe8 minor fixes to the doc build 2015-09-11 17:32:51 -04:00
Raghav R V 882c346abd DOC Make cv documentation consistent across our codebase 2015-09-10 09:15:13 +05:30
mhg 53324a1677 docstrings updated with considerations regarding small alphas when positive=True. 2015-08-28 13:12:52 +09:00
mhg db1f67bd51 pep-8 fix 2015-08-26 01:53:29 +09:00
mhg f157606a32 positive option passed on to LarsCV estimator 2015-08-25 15:14:41 +09:00
mhg 7e16f9d12b fit_intercept docstring comment removed from lars_path method 2015-08-25 14:34:59 +09:00
mhg 535536e537 merge with upstream/master 2015-08-25 14:07:56 +09:00
mhg 6c1c6eca36 agramfort code review input 2015-08-25 12:45:19 +09:00
mhg c369af4e81 doctest fix. 2015-08-18 15:05:21 +09:00
mhg 7f1bf0de45 positivity constrained can now also be used for the CV estimators. 2015-08-18 14:30:11 +09:00
mhg b2cea17053 cleanup 2015-08-18 13:14:41 +09:00
mhg e3f46cbff4 docstrings added + fit_intercept reintroduced. 2015-08-18 13:10:51 +09:00
mhg d6908a971e todos for pull request 2015-08-17 13:59:03 +09:00
mhg ceb066d29a cleanup 2015-08-17 13:45:02 +09:00
mhg e50aaba7dc "nonnegative" -> "positive" + cleanup 2015-08-17 13:25:14 +09:00
mhg 8e3b22ccdc lars_path method complemented with nonnegative option. 2015-08-17 13:25:14 +09:00
Andreas Mueller 99eff75e8d fix TheilSenRegressor input validation, LassoLarsIC input validation 2015-07-31 10:34:39 -04:00
Raghav R V 62325cbb58 MAINT merge _check_cv into check_cv as indices argument is removed in 0.17 2015-06-08 16:37:03 +05:30
Andreas Mueller 0650d5502e DOC adding backlinks to docstrings 2015-06-03 00:24:04 -04:00
Olivier Grisel dd9641f707 FIX #4597: LassoLarsCV on with readonly folds 2015-05-07 15:43:37 +01:00
trevorstephens 09e6e12f7b fix LarsCV and LassoLarsCV fails for numpy 1.8.0 2015-03-19 20:47:54 -07:00
Andreas Mueller cd5166e82f make check_array convert object to float.
fix dtype check, add test. unfriend all multi-output estimators on facebook.

try to fix what is happening to y (by doing nothing to y)

make test work...

Make everything accept object y or say "invalid label"

fix multioutput linear models

add test for sensible error message.
2015-02-15 12:13:41 -05:00
Raghav R V b3fbccca38 FIX various mismatch between docstring and signature params
DOC max_iterations -> max_iter. Make it consistent with kmeans

MAINT Replace the deprecated dx parameter with d in the docstrings

MAINT Deprecation warning for max_iterations parameter.
2015-01-16 11:54:57 -05:00
Raghav R V 88555987cc PEP8 Fix E101, E111 errors and W191, W293, W293 and W391 warnings. 2015-01-08 04:28:24 +05:30
trevorstephens 7c50e6c8eb various docstring fixes for web docs 2014-11-30 17:59:42 -08:00
MechCoder 90e5b2a817 DOC: Document criterion_ attribute in LassoLarsIC 2014-10-07 17:13:25 +02:00
Olivier Grisel 78fbd2576f ENH comment on drop for good not being triggered in the tests 2014-09-11 13:58:24 -07:00
Olivier Grisel d9067fa295 FIX #3370: better lars alpha path inequality checks for 32 bit support 2014-09-11 13:58:23 -07:00
Olivier Grisel cb1798ad1f FIX more tolerant early stopping for least angle 2014-09-04 19:17:51 +02:00
Lars Buitinck a228e8a49b FIX division by zero warning in LassoLarsIC
Fixes #3576. First time I named a variable after myself.
2014-09-04 15:52:47 +02:00
Olivier Grisel ff948965fa FIX finfo.eps should be used instead of tiny for equality checks 2014-09-04 10:06:47 +02:00
Olivier Grisel dbfb25e51e FIX heisenfailure in test_lasso_lars_path_length
Tentative fix for #3370: random failure under Python 32 bit and
Windows.
2014-09-03 16:17:46 +02:00
Joel Nothman b3bdb08964 DOC fix formatting of attributes etc. in docstrings 2014-07-28 19:04:59 +10:00
MechCoder c508965201 MAINT: Fixed a few docstrings and cosmits 2014-07-22 15:09:39 +02:00
MechCoder d72ca5974f Added n_iter attribute to OMP (and CV) 2014-07-22 15:09:39 +02:00
MechCoder c838c382b9 FIX: Preserve public API by introducing return_n_iter param 2014-07-22 15:09:39 +02:00
MechCoder bbb140aaf0 ENH: Added n_iter_ parameters across all iterative solvers 2014-07-22 15:09:39 +02:00
Andreas Mueller 6e2a83b4e1 remove check_arrays stuff and old input validation 2014-07-20 13:31:45 +02:00
Fabian Pedregosa cc36ba1b15 Cosmetic np.abs -> abs 2014-07-14 18:21:00 +02:00
Fabian Pedregosa 0295fdae71 FIX: check with tolerance on lars_path
Hopefully this will fix issue #3370 but I haven't checked.
2014-07-14 18:21:00 +02:00
GaelVaroquaux 9c80d11efc TST: relax warning class checked in lars 2014-04-02 13:47:41 +02:00