Commit Graph

227 Commits

Author SHA1 Message Date
Matteo Visconti di Oleggio Castello 589fcadbb7 [DOC] fix reference to examples 2016-04-05 20:22:20 +02:00
Davide Lasagna edd0eabf14 change "lasso_path" to use "return_n_iter" argument 2016-03-13 18:06:01 +00:00
giorgiop 140a5acda8 MAINT depr of center_data, normalize in linear_model 2016-02-17 14:26:50 -05:00
Gael Varoquaux 317dea8a05 Merge pull request #6005 from seales/SpellingFix
[MRG+1] General spelling fixes
2016-01-04 13:42:20 +01:00
michiaki ariga 003496fd27 Remove extra `+` in document 2016-01-03 03:16:26 +09:00
seales 0485ada58b General spelling fixes 2015-12-16 09:46:42 -08:00
Andreas Mueller fb123ed24b More doc fixes. Latex builds again. 2015-11-20 16:30:45 -05:00
Raghav R V 3f8743f47b Main Commits - Major
--------------------

* ENH Reogranize classes/fn from grid_search into search.py
* ENH Reogranize classes/fn from cross_validation into split.py
* ENH Reogranize cls/fn from cross_validation/learning_curve into validate.py

* MAINT Merge _check_cv into check_cv inside the model_selection module
* MAINT Update all the imports to point to the model_selection module
* FIX use iter_cv to iterate throught the new style/old style cv objs
* TST Add tests for the new model_selection members
* ENH Wrap the old-style cv obj/iterables instead of using iter_cv

* ENH Use scipy's binomial coefficient function comb for calucation of nCk
* ENH Few enhancements to the split module
* ENH Improve check_cv input validation and docstring
* MAINT _get_test_folds(X, y, labels) --> _get_test_folds(labels)
* TST if 1d arrays for X introduce any errors
* ENH use 1d X arrays for all tests;
* ENH X_10 --> X (global var)

Minor
-----

* ENH _PartitionIterator --> _BaseCrossValidator;
* ENH CVIterator --> CVIterableWrapper
* TST Import the old SKF locally
* FIX/TST Clean up the split module's tests.
* DOC Improve documentation of the cv parameter
* COSMIT consistently hyphenate cross-validation/cross-validator
* TST Calculate n_samples from X
* COSMIT Use separate lines for each import.
* COSMIT cross_validation_generator --> cross_validator

Commits merged manually
-----------------------

* FIX Document the random_state attribute in RandomSearchCV
* MAINT Use check_cv instead of _check_cv
* ENH refactor OVO decision function, use it in SVC for sklearn-like
  decision_function shape
* FIX avoid memory cost when sampling from large parameter grids

ENH Major to Minor incremental enhancements to the model_selection

Squashed commit messages - (For reference)

Major
-----

* ENH p --> n_labels
* FIX *ShuffleSplit: all float/invalid type errors at init and int error at split
* FIX make PredefinedSplit accept test_folds in constructor; Cleanup docstrings
* ENH+TST KFold: make rng to be generated at every split call for reproducibility
* FIX/MAINT KFold: make shuffle a public attr
* FIX Make CVIterableWrapper private.
* FIX reuse len_cv instead of recalculating it
* FIX Prevent adding *SearchCV estimators from the old grid_search module
* re-FIX In all_estimators: the sorting to use only the 1st item (name)
    To avoid collision between the old and the new GridSearch classes.
* FIX test_validate.py: Use 2D X (1D X is being detected as a single sample)
* MAINT validate.py --> validation.py
* MAINT make the submodules private
* MAINT Support old cv/gs/lc until 0.19
* FIX/MAINT n_splits --> get_n_splits
* FIX/TST test_logistic.py/test_ovr_multinomial_iris:
    pass predefined folds as an iterable
* MAINT expose BaseCrossValidator
* Update the model_selection module with changes from master
  - From #5161
  -  - MAINT remove redundant p variable
  -  - Add check for sparse prediction in cross_val_predict
  - From #5201 - DOC improve random_state param doc
  - From #5190 - LabelKFold and test
  - From #4583 - LabelShuffleSplit and tests
  - From #5300 - shuffle the `labels` not the `indxs` in LabelKFold + tests
  - From #5378 - Make the GridSearchCV docs more accurate.
  - From #5458 - Remove shuffle from LabelKFold
  - From #5466(#4270) - Gaussian Process by Jan Metzen
  - From #4826 - Move custom error / warnings into sklearn.exception

Minor
-----

* ENH Make the KFold shuffling test stronger
* FIX/DOC Use the higher level model_selection module as ref
* DOC in check_cv "y : array-like, optional"
* DOC a supervised learning problem --> supervised learning problems
* DOC cross-validators --> cross-validation strategies
* DOC Correct Olivier Grisel's name ;)
* MINOR/FIX cv_indices --> kfold
* FIX/DOC Align the 'See also' section of the new KFold, LeaveOneOut
* TST/FIX imports on separate lines
* FIX use __class__ instead of classmethod
* TST/FIX import directly from model_selection
* COSMIT Relocate the random_state documentation
* COSMIT remove pass
* MAINT Remove deprecation warnings from old tests
* FIX correct import at test_split
* FIX/MAINT Move P_sparse, X, y defns to top; rm unused W_sparse, X_sparse
* FIX random state to avoid doctest failure
* TST n_splits and split wrapping of _CVIterableWrapper
* FIX/MAINT Use multilabel indicator matrix directly
* TST/DOC clarify why we conflate classes 0 and 1
* DOC add comment that this was taken from BaseEstimator
* FIX use of labels is not needed in stratified k fold
* Fix cross_validation reference
* Fix the labels param doc

FIX/DOC/MAINT Addressing the review comments by Arnaud and Andy

COSMIT Sort the members alphabetically
COSMIT len_cv --> n_splits
COSMIT Merge 2 if; FIX Use kwargs
DOC Add my name to the authors :D
DOC make labels parameter consistent
FIX Remove hack for boolean indices; + COSMIT idx --> indices; DOC Add Returns
COSMIT preds --> predictions
DOC Add Returns and neatly arrange X, y, labels
FIX idx(s)/ind(s)--> indice(s)
COSMIT Merge if and else to elif
COSMIT n --> n_samples
COSMIT Use bincount only once
COSMIT cls --> class_i / class_i (ith class indices) -->
perm_indices_class_i

FIX/ENH/TST Addressing the final reviews

COSMIT c --> count
FIX/TST make check_cv raise ValueError for string cv value
TST nested cv (gs inside cross_val_score) works for diff cvs
FIX/ENH Raise ValueError when labels is None for label based cvs;
TST if labels is being passed correctly to the cv and that the
ValueError is being propagated to the cross_val_score/predict and grid
search
FIX pass labels to cross_val_score
FIX use make_classification
DOC Add Returns; COSMIT Remove scaffolding
TST add a test to check the _build_repr helper
REVERT the old GS/RS should also be tested by the common tests.
ENH Add a tuple of all/label based CVS
FIX raise VE even at get_n_splits if labels is None
FIX Fabian's comments
PEP8
2015-10-23 17:28:08 +02:00
Gael Varoquaux 744d161d37 Merge pull request #5431 from hlin117/nan-targets
[MRG + 2] Add check to regression models to raise error when targets are NaN
2015-10-22 09:36:12 +02:00
Arnaud Rachez 5db2adf93c MAINT Removed deprecated stuff. 2015-10-21 10:24:23 +02:00
hlin117 6df1fe27c1 #5322: Added check for MultiTaskElasticNet and MultiTaskLasso 2015-10-20 10:36:47 -05:00
Raghav R V e3afc0e8c9 MAINT move custom error/warning classes into sklearn.exceptions
ENH NonBLASDotWarning -> EfficiencyWarning; Improve error message
DOC Add exceptions module to modules/classes.rst
MAINT Move ConvergenceWarning, UndefinedMetricWarning et al into exceptions
MAINT Remove ChangedBehaviorWarning from base
DOC/FIX Improve DataConversionWarning's docstring
2015-10-19 22:35:35 +02:00
Olivier Grisel 330189376b Merge pull request #5413 from amueller/cleanup_tests
Cleanup tests
2015-10-16 09:10:49 +02:00
Alexandre Gramfort b1619d0532 DOC : update docstring of l1_ratio for E-Net CV classes 2015-10-15 22:32:51 +02:00
Andreas Mueller c66689c4f4 FIX Don't compare arrays to strings!!!! 2015-10-15 16:07:17 -04:00
Olivier Grisel da9a7cd95f Merge pull request #5362 from MechCoder/lasso_fix
[MRG] Lasso and ElasticNet should handle non-integer dtypes for fit_intercept=False
2015-10-12 13:31:33 +02:00
MechCoder 1d5b473705 Lasso and ElasticNet should handle non-float dtypes for fit_intercept=False 2015-10-07 16:49:28 -04:00
Olivier Grisel 808fa6450e FIX consistency of memory layout for linear CD solver 2015-10-04 18:32:05 +02:00
Raghav R V 882c346abd DOC Make cv documentation consistent across our codebase 2015-09-10 09:15:13 +05:30
Andreas Mueller 434ee958aa test for accepted sparse matrices 2015-08-26 22:00:55 -04:00
Arthur Mensch 2ed0c22c17 Added check_input in Lasso for DictLearning performance 2015-08-20 11:36:24 +02:00
Raghav R V cd9eb96942 FIX import column_or_1d from utils.validation directly 2015-08-02 22:44:26 +05:30
Andreas Mueller 77ecf16af4 Merge pull request #4775 from arthurmensch/cd_fast_readonly_array_brainfix
[MRG+1] Read-only data compatibility for Lasso
2015-07-31 10:43:00 -04:00
Andreas Mueller 2afbc0f7e2 FIX make sure y is 1d in svm regressor, add common test for regressor shapes. 2015-07-31 10:34:39 -04:00
Arthur Mensch fead69a4ac Bugfix : type in cd changed for read only memmap compatibility 2015-07-31 12:12:40 +02:00
Raghav R V 62325cbb58 MAINT merge _check_cv into check_cv as indices argument is removed in 0.17 2015-06-08 16:37:03 +05:30
Andreas Mueller 0650d5502e DOC adding backlinks to docstrings 2015-06-03 00:24:04 -04:00
Andreas Mueller 188fb11968 COSMIT use consistent shape description in docstring. 2015-04-01 10:24:58 -04:00
Andreas Mueller d89c215013 Add tags to classifiers and regressors to identify them as such. 2015-03-31 19:59:49 -04:00
Loïc Estève a13a5859e8 DOC remove sphinx warnings when generating the doc
and fixes a few other doc problems while I was at it.

The main take-home message is to remember that you need a backslash when
your parameter type description exceeds one line.
2015-03-18 15:49:30 +01:00
Olivier Grisel feceab6f62 FIX test for consistent handling on empty input data 2015-02-26 10:45:06 +01:00
Andreas Mueller cd5166e82f make check_array convert object to float.
fix dtype check, add test. unfriend all multi-output estimators on facebook.

try to fix what is happening to y (by doing nothing to y)

make test work...

Make everything accept object y or say "invalid label"

fix multioutput linear models

add test for sensible error message.
2015-02-15 12:13:41 -05:00
Andreas Mueller cd931fa6ba Merge pull request #4136 from amueller/test_dtypes_all
[MRG+1] More robust input validation, more testing.
2015-02-13 17:13:59 -05:00
Raghav R V 3ac2da61bd FIX Use resolution instead of min from np.finfo(float) 2015-02-12 02:10:05 +05:30
Raghav R V 5fb923aacc FIX Return np.zeros(n_alphas) when the targets are uniform 2015-02-11 22:58:15 +05:30
Andreas Mueller e3e0827243 FIX check (and enforce) that estimators can accept different dtypes. 2015-02-10 15:37:15 -05:00
Raghav R V b3fbccca38 FIX various mismatch between docstring and signature params
DOC max_iterations -> max_iter. Make it consistent with kmeans

MAINT Replace the deprecated dx parameter with d in the docstrings

MAINT Deprecation warning for max_iterations parameter.
2015-01-16 11:54:57 -05:00
Raghav R V abd31d2cad MAINT Make uniform the error raised for not fitted condition 2015-01-12 00:33:40 +05:30
MechCoder f79ac7c187 MAINT: Remove deprecation warnings in enet_path and lasso_path 2014-12-27 00:47:32 +01:00
MechCoder 26901932d7 FIX: Bug in sparse coordinate solver in lazy centering 2014-12-26 22:53:52 +01:00
trevorstephens 7c50e6c8eb various docstring fixes for web docs 2014-11-30 17:59:42 -08:00
MechCoder 5e1faefe10 Expose positive option in elasticnet and lasso path 2014-10-16 15:03:20 +02:00
MechCoder 7cb3ba1802 TST: Added tests to test Deprecation warning 2014-10-04 11:13:29 +02:00
Manoj-Kumar-S e915fcc3ab Changed default argument of precompute in ElasticNet and Lasso
Setting precompute to "auto" was found to be slower when n_samples > n_features
since the computation of the Gram matrix is computationally expensive and
outweighs the benefit of fitting the Gram for just one alpha.
2014-10-03 18:25:12 +02:00
Luis Pedro Coelho 5d3b42f3c0 DOC Fix n_jobs documentation
You can take advantage of multiple CPUS for the different folds, not
just different values of l1_ratio
2014-09-24 11:29:28 +02:00
MechCoder ca3ad7b756 FIX: Memory crashes for _alpha_grid in ENetCV 2014-08-18 16:33:55 +02:00
jnothman e1891d801b Merge pull request #3489 from jnothman/attributes-doc
[MRG] DOC fix formatting of Attributes sections in documentation
2014-08-02 20:14:53 +10:00
MechCoder cf4cf60b7e ENH Stochastic Coordinate Descent for ElasticNet & Lasso 2014-07-29 10:23:33 +02:00
Joel Nothman b3bdb08964 DOC fix formatting of attributes etc. in docstrings 2014-07-28 19:04:59 +10:00
MechCoder d72ca5974f Added n_iter attribute to OMP (and CV) 2014-07-22 15:09:39 +02:00