Commit Graph

297 Commits

Author SHA1 Message Date
Mark Szepieniec 0a094b90e8 Fix grammar bug in docstring of SelectFromModel 2016-04-06 17:37:40 +01:00
Rémy Léone 9b7176dd9d [DOC] Fix broken links 2016-03-23 12:45:34 -07:00
MechCoder 528533dab7 MAINT: Simplify n_features_to_select in RFECV 2016-03-21 01:16:04 -04:00
Lars Buitinck 2e4aafd19c MAINT remove my email address
I'm getting too many individual support requests. People should
use the mailing list.
2016-03-04 10:43:41 +01:00
Andreas Mueller e6cc86172b fix floating point indexing in generic univariate 2016-02-15 14:09:18 +01:00
dsquareindia 71ec574a3f DOC: Fix redundant doc for f_regression. 2016-02-10 13:25:58 -05:00
Nikolay Mayorov daa73c7429 BUG: Remove non-ASCII symbols from mutual_info_.py 2016-01-22 00:27:17 +05:00
Nikolay Mayorov a36edf2a3d DOC: Modify SelectKBest and SelectPercentile docstrings slightly 2016-01-22 00:27:17 +05:00
Nikolay Mayorov e1bc05628a MAINT: Add a clarification comment in mutual_info_.py 2016-01-22 00:27:16 +05:00
Nikolay Mayorov b48a10870a DOC: Add one more reference for mutual info methods 2016-01-22 00:27:16 +05:00
Nikolay Mayorov 5b3f51515b MAINT: Get rid of classes in test_mutual_info.py 2016-01-22 00:27:16 +05:00
Nikolay Mayorov 094a077af5 MAINT: Small refactoring in mutual_info_.py 2016-01-22 00:27:16 +05:00
Nikolay Mayorov d60636a4a8 DOC: Small fixes in mutual_info_.py documentation 2016-01-22 00:27:16 +05:00
Nikolay Mayorov 375b070263 TST: Speed up 2 tests related to mutual info 2016-01-22 00:27:16 +05:00
Nikolay Mayorov d3a497aec4 BUG: Fix copy logic for mutual info functions 2016-01-22 00:27:16 +05:00
Nikolay Mayorov ec172895f8 DOC: Add short descriptions of methods for mutual info estimation 2016-01-22 00:27:16 +05:00
Nikolay Mayorov 786999258d MAINT: Slightly improve copy logic in _estimate_mi 2016-01-22 00:27:16 +05:00
Nikolay Mayorov 051d3a285d MAINT: Slightly improve logic of discrete-continuous MI estimation 2016-01-22 00:27:16 +05:00
Nikolay Mayorov ffc4fe91da TST: Change tolerance checks in test_mutual_info.py 2016-01-22 00:27:16 +05:00
Nikolay Mayorov ad2f5f5275 MAINT: Add check_classification_targets to mutual_info_classif 2016-01-22 00:27:15 +05:00
Nikolay Mayorov 8394c1bfcc MAINT: Add blank lines between parameters in mutual_info_.py 2016-01-22 00:27:15 +05:00
Nikolay Mayorov 835102ab6a API: Split mutual_info into _regression and _classif 2016-01-22 00:27:15 +05:00
Nikolay Mayorov c1aea3f868 MAINT: Renamed module mutual_info to mutual_info_ 2016-01-22 00:27:15 +05:00
Nikolay Mayorov 0245fc8aec MAINT: Use six.moves.zip in mutual_info 2016-01-22 00:27:15 +05:00
Nikolay Mayorov 54c078311e DOC: Documentation update related to mutual_info 2016-01-22 00:27:15 +05:00
Nikolay Mayorov df08defb05 ENH: Implemented mutual_info function 2016-01-22 00:27:15 +05:00
MechCoder 729be74708 Use row_norms in f_regression 2016-01-10 11:04:09 -05:00
seales 0485ada58b General spelling fixes 2015-12-16 09:46:42 -08:00
MechCoder d13f519ba5 Parallelize embarrassingly parallel loop in RFECV.fit 2015-12-06 20:58:06 -05:00
Andreas Mueller fb123ed24b More doc fixes. Latex builds again. 2015-11-20 16:30:45 -05:00
Andreas Mueller de3a527905 Merge pull request #5692 from amueller/skip_32_bit_tests
[MRG] Skip 32 bit tests that fail, skip doctests on 32bit
2015-11-05 10:33:33 -05:00
KamalakerDadi f2e35411fa Added more versions of 0.17 2015-11-04 00:02:52 +01:00
Andreas Mueller 776e53b127 skip unstable tests on 32bit platform 2015-11-02 15:21:22 -05:00
Andreas Mueller 2a98fc6ee9 Don't use floats to index numpy arrays 2015-11-02 13:56:21 -05:00
Gilles Louppe d591ac4ba6 Merge pull request #5592 from antialias/correct-typo
corrected typo
2015-10-26 07:19:18 +01:00
Thomas Hallock c81164cbef corrected typo 2015-10-25 20:00:08 -04:00
Thomas Hallock 16798e3ee8 s/labe/label 2015-10-25 19:55:44 -04:00
Raghav R V 3f8743f47b Main Commits - Major
--------------------

* ENH Reogranize classes/fn from grid_search into search.py
* ENH Reogranize classes/fn from cross_validation into split.py
* ENH Reogranize cls/fn from cross_validation/learning_curve into validate.py

* MAINT Merge _check_cv into check_cv inside the model_selection module
* MAINT Update all the imports to point to the model_selection module
* FIX use iter_cv to iterate throught the new style/old style cv objs
* TST Add tests for the new model_selection members
* ENH Wrap the old-style cv obj/iterables instead of using iter_cv

* ENH Use scipy's binomial coefficient function comb for calucation of nCk
* ENH Few enhancements to the split module
* ENH Improve check_cv input validation and docstring
* MAINT _get_test_folds(X, y, labels) --> _get_test_folds(labels)
* TST if 1d arrays for X introduce any errors
* ENH use 1d X arrays for all tests;
* ENH X_10 --> X (global var)

Minor
-----

* ENH _PartitionIterator --> _BaseCrossValidator;
* ENH CVIterator --> CVIterableWrapper
* TST Import the old SKF locally
* FIX/TST Clean up the split module's tests.
* DOC Improve documentation of the cv parameter
* COSMIT consistently hyphenate cross-validation/cross-validator
* TST Calculate n_samples from X
* COSMIT Use separate lines for each import.
* COSMIT cross_validation_generator --> cross_validator

Commits merged manually
-----------------------

* FIX Document the random_state attribute in RandomSearchCV
* MAINT Use check_cv instead of _check_cv
* ENH refactor OVO decision function, use it in SVC for sklearn-like
  decision_function shape
* FIX avoid memory cost when sampling from large parameter grids

ENH Major to Minor incremental enhancements to the model_selection

Squashed commit messages - (For reference)

Major
-----

* ENH p --> n_labels
* FIX *ShuffleSplit: all float/invalid type errors at init and int error at split
* FIX make PredefinedSplit accept test_folds in constructor; Cleanup docstrings
* ENH+TST KFold: make rng to be generated at every split call for reproducibility
* FIX/MAINT KFold: make shuffle a public attr
* FIX Make CVIterableWrapper private.
* FIX reuse len_cv instead of recalculating it
* FIX Prevent adding *SearchCV estimators from the old grid_search module
* re-FIX In all_estimators: the sorting to use only the 1st item (name)
    To avoid collision between the old and the new GridSearch classes.
* FIX test_validate.py: Use 2D X (1D X is being detected as a single sample)
* MAINT validate.py --> validation.py
* MAINT make the submodules private
* MAINT Support old cv/gs/lc until 0.19
* FIX/MAINT n_splits --> get_n_splits
* FIX/TST test_logistic.py/test_ovr_multinomial_iris:
    pass predefined folds as an iterable
* MAINT expose BaseCrossValidator
* Update the model_selection module with changes from master
  - From #5161
  -  - MAINT remove redundant p variable
  -  - Add check for sparse prediction in cross_val_predict
  - From #5201 - DOC improve random_state param doc
  - From #5190 - LabelKFold and test
  - From #4583 - LabelShuffleSplit and tests
  - From #5300 - shuffle the `labels` not the `indxs` in LabelKFold + tests
  - From #5378 - Make the GridSearchCV docs more accurate.
  - From #5458 - Remove shuffle from LabelKFold
  - From #5466(#4270) - Gaussian Process by Jan Metzen
  - From #4826 - Move custom error / warnings into sklearn.exception

Minor
-----

* ENH Make the KFold shuffling test stronger
* FIX/DOC Use the higher level model_selection module as ref
* DOC in check_cv "y : array-like, optional"
* DOC a supervised learning problem --> supervised learning problems
* DOC cross-validators --> cross-validation strategies
* DOC Correct Olivier Grisel's name ;)
* MINOR/FIX cv_indices --> kfold
* FIX/DOC Align the 'See also' section of the new KFold, LeaveOneOut
* TST/FIX imports on separate lines
* FIX use __class__ instead of classmethod
* TST/FIX import directly from model_selection
* COSMIT Relocate the random_state documentation
* COSMIT remove pass
* MAINT Remove deprecation warnings from old tests
* FIX correct import at test_split
* FIX/MAINT Move P_sparse, X, y defns to top; rm unused W_sparse, X_sparse
* FIX random state to avoid doctest failure
* TST n_splits and split wrapping of _CVIterableWrapper
* FIX/MAINT Use multilabel indicator matrix directly
* TST/DOC clarify why we conflate classes 0 and 1
* DOC add comment that this was taken from BaseEstimator
* FIX use of labels is not needed in stratified k fold
* Fix cross_validation reference
* Fix the labels param doc

FIX/DOC/MAINT Addressing the review comments by Arnaud and Andy

COSMIT Sort the members alphabetically
COSMIT len_cv --> n_splits
COSMIT Merge 2 if; FIX Use kwargs
DOC Add my name to the authors :D
DOC make labels parameter consistent
FIX Remove hack for boolean indices; + COSMIT idx --> indices; DOC Add Returns
COSMIT preds --> predictions
DOC Add Returns and neatly arrange X, y, labels
FIX idx(s)/ind(s)--> indice(s)
COSMIT Merge if and else to elif
COSMIT n --> n_samples
COSMIT Use bincount only once
COSMIT cls --> class_i / class_i (ith class indices) -->
perm_indices_class_i

FIX/ENH/TST Addressing the final reviews

COSMIT c --> count
FIX/TST make check_cv raise ValueError for string cv value
TST nested cv (gs inside cross_val_score) works for diff cvs
FIX/ENH Raise ValueError when labels is None for label based cvs;
TST if labels is being passed correctly to the cv and that the
ValueError is being propagated to the cross_val_score/predict and grid
search
FIX pass labels to cross_val_score
FIX use make_classification
DOC Add Returns; COSMIT Remove scaffolding
TST add a test to check the _build_repr helper
REVERT the old GS/RS should also be tested by the common tests.
ENH Add a tuple of all/label based CVS
FIX raise VE even at get_n_splits if labels is None
FIX Fabian's comments
PEP8
2015-10-23 17:28:08 +02:00
Arnaud Rachez 5db2adf93c MAINT Removed deprecated stuff. 2015-10-21 10:24:23 +02:00
Raghav R V e3afc0e8c9 MAINT move custom error/warning classes into sklearn.exceptions
ENH NonBLASDotWarning -> EfficiencyWarning; Improve error message
DOC Add exceptions module to modules/classes.rst
MAINT Move ConvergenceWarning, UndefinedMetricWarning et al into exceptions
MAINT Remove ChangedBehaviorWarning from base
DOC/FIX Improve DataConversionWarning's docstring
2015-10-19 22:35:35 +02:00
Raghav R V a87011262a FIX precision to float64 across the codebase 2015-10-16 11:20:29 +02:00
MechCoder c805fbc79b Refactor tests 2015-10-10 22:05:40 -04:00
MechCoder 5a0db1717a 1. Added parameter prefit to pass in a fitted estimator.
2. Use assert_warns instead of catch_warnings
3. Remove depracation warnings in common tests.
2015-10-09 01:57:36 -04:00
MechCoder acf5f160a8 Merge SelectFromModel and L1-selection examples
Add test to check the threshold can be set without refitting
2015-10-05 11:25:07 -04:00
MechCoder 2ee718cc75 Add narrative docs and fix examples 2015-10-05 11:25:06 -04:00
MechCoder 10176d9897 Now a fitted estimator can be passed to SelectFromModel 2015-10-05 11:25:06 -04:00
MechCoder 3d41053d67 Minor doc changes and removed _set_threshold and _set_importances 2015-10-05 11:25:06 -04:00
MechCoder 9cee0d95f8 Added example to depict feature selction using SelectFromModel and Lasso 2015-10-05 11:24:02 -04:00
MechCoder 459cb9ba3d Remove warm start 2015-10-05 11:19:57 -04:00
MechCoder 8a28ea8169 fix test failures 2015-10-05 11:19:57 -04:00