Commit Graph

251 Commits

Author SHA1 Message Date
Adam Li 67eb4e5c24
[MAINT] Separate unit tests in `test_tree.py` for pickling and min_impurity_decrease (#22915) 2022-03-25 10:41:45 +01:00
Christian Lorentzen f89a40bd92
MNT fix typo in tree test name (#22943) 2022-03-24 23:24:18 +01:00
Maxwell e5736afb31
API Deprecate max_feature=`auto` for tree classes (#22476)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
2022-03-23 17:59:23 +01:00
Thomas J. Fan 1fc86b6aac
MNT Update black to stable version (#22474) 2022-02-15 11:36:26 +01:00
Thomas J. Fan 4ff0767087
ENH Better error message for check_scalar (#22218)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2022-02-11 16:15:30 +01:00
genvalen b80138fccb
MAINT Use check_scalar in BaseGradientBoosting (#21632)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2022-02-07 15:32:22 -05:00
Christian Lorentzen 2b15b908c1
FIX poisson proxy_impurity_improvement (#22191) 2022-01-26 14:52:27 +01:00
genvalen 7879eb1193
MAINT Use check_scalar in BaseDecisionTree (#21990)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2022-01-24 20:25:36 +01:00
Loïc Estève 8dcde1e4d4
Support cross 32bit/64bit pickles for decision tree (#21552)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
2021-11-25 17:08:51 +01:00
Guillaume Lemaitre cc81c4f2ba
MNT remove X_idx_sorted parameter in decision trees (#21593) 2021-11-08 08:08:43 +01:00
Loïc Estève 46485a93be
Test decision tree pickle for different endianness (#21539) 2021-11-04 14:39:09 +01:00
Dimitri Papadopoulos Orfanos f71c031314
DOC Typos found by codespell (#21069) 2021-09-17 19:04:54 +02:00
Thomas J. Fan 44c40b35d0
STY Removes trailing comma in lists for nicer black formatting (#20627) 2021-07-28 16:08:42 -07:00
Thomas J. Fan 3ae7c76153
STY Enables black with experimental_string_processing=true (#20412) 2021-06-29 09:47:04 +02:00
Olivier Grisel d402cd18ac
FIX sphinx warning on @deprecated n_features_ property (#20418) 2021-06-28 14:09:30 -04:00
Thomas J. Fan 82df48934e
MNT Applies black formatting to most of the code base (#18948) 2021-06-17 14:21:09 -04:00
Jérémie du Boisberranger 240542fc78
MNT deprecate n_features_ in trees in favor of n_features_in_ (#20272) 2021-06-15 20:36:13 +02:00
Jérémie du Boisberranger ef71c8597e
MNT Clean deprecations for 1.0 | trees (#19336) 2021-06-15 18:18:47 +02:00
Tom Dupré la Tour f6e6ad2d9e
MNT clean futurewarning for 1.0 | _deprecate_positional_args (#20002)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2021-05-14 11:30:27 -04:00
Christian Lorentzen 2bd3a4db52
ENH Consistent loss name for absolute error (#19733) 2021-05-10 22:10:21 +02:00
Christian Lorentzen b9d6db81ec
[MRG] ENH Consistent loss name for squared error (#19310) 2021-03-19 15:21:34 +01:00
Guillaume Lemaitre 2218ec4622
MNT change 0.25 to 1.0 and 0.26 to 1.1 in deprecation messages (#19005)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-12-18 16:09:19 +00:00
Olivier Grisel f0e9d298be
FIX numerical rounding issue causing test_poisson_zero_nodes to fail at random (#18737)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-11-04 20:39:06 +01:00
Christian Lorentzen de59efe7cb
[MRG] ENH add Poisson splitting criterion for single trees (#17386) 2020-11-02 16:32:29 +01:00
Juan Carlos Alfaro Jiménez e4ebcbcafd
MNT Deprecate X_idx_sorted in tree module (#17614) 2020-06-17 13:58:47 -04:00
Lucy Liu f27adc51d5
TST Replace Boston dataset in test_tree (#17290) 2020-06-01 16:55:26 -04:00
Nicolas Hug ac8cbb3799
[MRG] More deprecation for 0.24 (#17142)
* normalize_components in sparsePCA

* changed default strategy of Dummy to prior and removed outputs_2d ttribute

* removed usage of None to drop estimator in ensemble and behaviour param of IsolationForest

* remove support for drop=None in Voting

* removed some warning decorators

* remove feature_extraction.extract_patches

* removed VectorizerMixin and copy parameter from TFIDFVectorizer

* kernel.set_params now raises attributeerror

* removed fig from plot_partial_dependence

* removed iid parameter of search estimators

* removed brier_scorer

* raise error in split when shuffle is False and random_state is not None

* removed MultiOutputEstimator

* removed base classes of NaiveBayes

* removed drop from pipeline

* removed utils in random_projection

* removed presort and classes_ in trees

* flake8

* fixed some tests

* flake

* fixed docstring

* fixed other one

* some left

* mmmm
2020-05-20 16:04:14 -04:00
Roman Yurchak 1cbe59ee06
CI Check for unused imports when linting (#16678)
* Check for missing imports in linting

* Exclude externals

* Remove unused imports
2020-03-12 12:56:35 +01:00
Sergul Aydore 78dc5974d5
TST check sample_weight shape added to common tests (#11598) 2020-02-21 10:04:09 -05:00
Alexandre Batisse 0db80b90c7
FIX support of float32 read only input in trees (#16331) 2020-02-01 15:08:22 +01:00
Nicolas Hug 42e17b3487 MNT Removed deprecated attributes and parameters -- ctnd (#15804) 2019-12-13 15:05:51 -05:00
Nicolas Hug 12c2b40761
MNT Remaining deprecations in sklearn/file.py (#15399) 2019-11-04 14:22:42 -05:00
Fanny bcb8eda383 MNT Standardize sample weights validation in BaseDecisionTree (#15495)
* Standardize sample weights validation in BaseDecisionTree

Co-authored-by: Sallie Walecka <sallie.walecka@gmail.com>

* Use DOUBLE var instead of np.float64 & refactored test

Co-authored-by: Sallie Walecka <sallie.walecka@gmail.com>
2019-11-04 17:13:38 +01:00
Nicolas Hug 19ad136223 MNT Replace DeprecationWarning with FutureWarning (#15080)
* bruteforce renaming

* WIP

* WIP

* some more

* removed weird line

* update -Werror

* testiforest

* again

* Fixed some tests

* fixed some tests

* removed -Werror

* fixed test_docstring_param issue

* fixed some tests

* some more

* renamed to SklearnDeprecationWarning

* pep8

* updated docs

* pep8

* merge

* changed to FutureWarning

* fixes

* Update doc/developers/tips.rst

Co-Authored-By: Adrin Jalali <adrin.jalali@gmail.com>

* avoid duplicates

* fixed warning for deprecations

* Still make CI break if DeprecationWarning isn't caught

* updated one warning

* fixed test

* fixed some renamings

* updated new dep warnings

* fixed bad import

* ignore warnings

* update again

* ignore futurewarning when walking packages

* Fixed test

* pep8

* Added whatsnew
2019-10-29 15:39:26 +01:00
Nicolas Hug b92455a6b2 MAINT Deprecate all of utils.testing except all_estimators (#15367) 2019-10-28 17:28:56 +01:00
Adrin Jalali 437ca0553c MNT Makes modules in tree and ensemble private (#14964) 2019-10-16 10:39:00 -04:00
Rok Mihevc 5e4b2757d6 TST Adding multi-output checks to common tests (#13392) 2019-10-01 14:20:11 +02:00
Adrin Jalali 186629b60a MNT Deprecate {n_}classes_ attribute for tree regressors (#15028) 2019-09-20 07:27:21 -04:00
Adrin Jalali 99d3d34d61
MNT deprecating presort in DecisionTree* and GradeintBoosting* (#14907)
* deprecating presort

* pep8

* address comments, add whats_new

* recomment HistGradientBoosting

* address comments
2019-09-10 20:39:52 +02:00
Samesh Lakhotia e74e03294a MAINT: Fix assert raises in `sklearn/tree/tests/` (#14737) 2019-08-28 10:00:58 +03:00
Thomas J Fan 67c94c7e2a Add Minimal Cost-Complexity Pruning to Decision Trees (#12887) 2019-08-20 09:02:45 -04:00
Adrin Jalali 19c068a2ec MNT towards removing assert_equal, etc (#14222) 2019-07-01 09:13:32 -04:00
Thomas J Fan bec83089f7
MAINT Uses pytest-xdist to parallelize tests (#13041) 2019-06-13 16:47:12 -04:00
jeremiedbb 5bc3edccab BUG Fix missing 'const' in a few memoryview declaration in trees. (#13626) 2019-04-16 07:08:04 -04:00
Roman Yurchak cf9a740598 [MRG+1] Use astype(.., copy=False) when possible (#11973)
* Use astype(.., copy=False) when possible

* Use Use astype(.., copy=False) also in tests

* Fix CI

* Guillaume's comments

* Address review comments

* Add what's new

* Fix CI

* Lint

* Fix merge issues

* More merge conflict fixes

* Fix failing test

* Lint

* Use copy=True in cluster/hierarchical

* More fixes
2019-03-01 11:07:10 +01:00
Mitar 95993a4b2b FIX Fixes tree and forest classification for non-numeric multi-target (#11458)
* Fixes tree and forest classification for non-numeric multi-target.

Fixes #11451.

* Renaming test functions, adding dtype to predictions array in tree.py.

* Fixing flake8 issue.

* Adding ignore warning to test_forest.py.

* Switching to iris data for tests.
2019-02-19 10:46:30 +01:00
Bartosz Michałowski fa98a72dcc MNT Replaced all occurrences of assert_true and assert_false with assert (#12588) 2018-11-28 09:16:26 +08:00
Adrin Jalali 02dc9ed680 Fix max_depth overshoot in BFS expansion of trees (#12344)
* fix the issue with max_depth and BestFirstTreeBuilder

* fix the test

* fix max_depth overshoot in BFS expansion

* fix forest tests

* remove the warning, add whats_new entry

* remove extra line

* add affected classes to changed classes

* add other affected estimators to the whats_new changed models

* shorten whats_new changed models entry
2018-11-13 13:10:33 -05:00
Adrin Jalali a80bbd9403 ENH add get_n_leaves() and get_max_depth() to DesicionTrees (#12300) 2018-10-10 22:01:11 +11:00
Joel Nothman 79f5d147ea MNT Revert the deprecation of min_samples_leaf and min_weight_fraction_leaf (#11998) 2018-09-08 16:43:21 +02:00