* Fixed random number generation on windows. See https://github.com/cjlin1/liblinear/pull/28
* Added correct PR number
* Fixed random number generator for libsvm on windows targets
* Updated comments
* Suppressed C4293 warnings using explicit cast.
* Suppressed C4293 warnings using explicit cast.
* Following code review: `myrand` is now inline, and all integer size checks for random generation fix are now static.
* Dummy comment edit to re-trigger build
* Fixed include error
* Attempt to provide a better and faster result by using a mersene twister random number generator as suggested by https://codeforces.com/blog/entry/61587
* Attempt to integrate the extra compiler arg requesting for explicit C++11 support
* Attempt to integrate the extra compiler arg requesting for explicit C++11 support. liblinear extension.
* the `extra_compile_args` for C++11 was not working when used in `config.add_extension` so now pre-creating liblinear library first with the flag.
* Fixed liblinear extension build: there was a missing library dependency.
* Fixed liblinear library dependency for extension compilation.
* Fixed liblinear library compilation: added tron
* Now correctly setting the seed in libsvm
* Now correctly setting the seed in liblinear. This is done using a new interface function `set_seed`.
* Updated what's new accordingly
* Increased tolerance when comparing `_average_precision` with `_average_precision_slow`. Indeed `_average_precision` is based on predictions ordering and has errors in case of ties (e.g. several 0.5 prediction values)
* Minor improvement of this test method for readability (no change in output)
* Minor doc update as per review
* dropped commented line
* Reverted test readability improvement change
* Using double barticks
* Clarified all comments
* removed useless space
* Clarified all comments, and included a `set_seed` method as per code review.
* Updated what's new about changed models as suggested by review.
* Replaced random number generator: now using a `bounded_rand_int` using tweaked Lemire post-processor from http://www.pcg-random.org/posts/bounded-rands.html)
* Updated readme rst and moved it to 0.22
* Whats new moved from 0.222 to 0.23
* Updated docs
* Update doc/whats_new/v0.23.rst
Co-Authored-By: Chiara Marmo <cmarmo@users.noreply.github.com>
* Dummy change to re-trigger the CI build
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.22.rst
* As per code review: added LogisticRegression in the list of changes, and repeated the list of classes affected in changelog.
* New random number generator used in libsvm / liblinear is now in an independent header file `newrand/newrand.h`.
* Update sklearn/svm/src/liblinear/linear.cpp
* Fixed dates in headers and added a header to newrand.h
* Added a sentence in the changelog to explain the impact in user-friendly terms.
* Added link to PR in readme file and removed commented lines as per code review
Co-authored-by: Sylvain MARIE <sylvain.marie@se.com>
Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
* Rewriting of cythonization in setup.py
By using Cython.Build.cythonize and switching between .c and .pyx files
as appropriate cython dependencies are correctly taken into account.
* Use cythonize once on the root config rather than in each subpackage
* Fix for Windows
* Remove caching from Travis
Cython dependencies are taken care of by Cython.Build.cythonize and
based on file timestamps, so .C and .so files will always be rebuild
from scratch on each build in Travis.
* Specify .pyx in setup.files for cython generated extensions
More natural this way. Tweak the extensions to generate from .c and .cpp
files for a release.
* COSMIT Remove commented out code
* Check cython version is greater than 0.23
* COSMIT better names for functions
* flake8 fix (imported module not at top of file)
* Install cython 0.23 for Python 2.6
now that cython >= 0.23 requirement is enforced in setup.py
* Use module constant for minimum required cython version
* Fix Travis install.sh
No easy way to put comments inside multi-line command
Thomas J. Fan