Commit Graph

33 Commits

Author SHA1 Message Date
Olivier Grisel 4ca4f3bbcd
FIX make the shape of LogisticRegression(solver="liblinear") consistent with other solvers (#21998)
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
2022-02-15 16:40:10 +01:00
Guillaume Lemaitre 229bd226ab
MNT remove _pairwise attribute (#21594) 2022-02-09 16:58:01 +01:00
Christian Ritter 8cf09596bd
ENH Check for nonfinite dual gap estimation (#22149)
* test for nonfinite dual gap estimation. Co-authored-by: Norbert Preining <norbert@preining.info>

* added changelog

* test for nonfinite dual gap estimation.

Co-authored-by: Norbert Preining <norbert@preining.info>

* added changelog

* improved ValueError for finite message in dual gap estimation

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>

* refactoring finite coeff check in dual gap, and test

* expanded changelog entry for non-finite param estimation dual gap

* Apply suggestions from code review

Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Norbert Preining <norbert@preining.info>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
2022-01-22 06:43:13 +01:00
Juan Martin Loyola efdc92d0b6
[MRG] Expose `n_iter_` to BaseLibSVM (#21408)
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
2021-12-21 18:48:46 +01:00
Haidar Almubarak 8d3304a866
FIX validate parameters in `fit` in all SVM estimators (#21436)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2021-11-05 17:03:32 +01:00
Thomas J. Fan 1bf13d567d
FIX Prevents segfault in SVC when internals are altered (#21336)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>
2021-10-20 14:30:06 +02:00
genvalen 642127806a
DOC use backticks for n_samples and n_features in X docstring (#20914) 2021-09-02 13:35:03 +02:00
genvalen 28ce1e3b0c
DOC Replace the phrase "where n_samples in the number" with "where n_samples is the number" (#20822) 2021-08-23 21:15:05 -04:00
Harutaka Kawamura 8cf87a30bb
MNT Replace `@property` on predict methods with `@available_if` (#20667)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2021-08-13 18:00:21 -04:00
Juan Martin Loyola b4b2846719
DOC Ensures that NuSVR passes numpydoc validation (#20643) 2021-08-02 10:32:59 +02:00
Juan Martin Loyola 9c2b3b66f6
DOC Ensures that SVC passes numpydoc validation (#20457)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2021-07-13 14:42:02 +02:00
Thomas J. Fan 3ae7c76153
STY Enables black with experimental_string_processing=true (#20412) 2021-06-29 09:47:04 +02:00
Thomas J. Fan 383b53fa91
FIX Uses code literals in deprecated to prevent linking (#20410)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2021-06-28 15:49:19 +02:00
Thomas J. Fan 82df48934e
MNT Applies black formatting to most of the code base (#18948) 2021-06-17 14:21:09 -04:00
Thomas J. Fan 9a13bdfaf1
MNT Adds black config and fixes formatting before black (#19031)
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
2021-06-12 17:14:09 +02:00
Guillaume Lemaitre 7d728d357e
FIX missing space in import in svm/_base.py (#19852) 2021-04-09 19:36:36 +02:00
Thomas J. Fan 5946f8bfed
ENH Adds n_features_in_ checks to linear and svm modules (#18578)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>
2021-01-02 22:42:08 +01:00
Guillaume Lemaitre 2218ec4622
MNT change 0.25 to 1.0 and 0.26 to 1.1 in deprecation messages (#19005)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-12-18 16:09:19 +00:00
Thomas J. Fan 02fa8f1adb
ENH Deprecates _pairwise attribute and adds pairwise to estimator tags (#18143) 2020-10-07 21:53:36 +11:00
Frans Larsson f8fdd1db11
DOC Add None as valid option to random_state in svm module (#18233) 2020-08-22 17:31:45 +02:00
Thomas J Fan e770715c43
MNT Completes position arg deprecation (#17272)
* ENH Adds public functions with position args warning

* BUG Circlar import

* STY

* BUG Add keywords

* BUG Fixes warnings

* ENH Adds other public functions

* CLN Suggestion

* CLN Suggestion

* REV Revert pairwise

* ENH Positoinal args for compute_class_weight
2020-05-19 09:07:25 +02:00
Nicolas Hug e3e9137811
DOC Updates to SVM User Guide (#16769)
* WIP

* WIP

* Updates to the math section

* so apparently crammer-singer isn't consistent (http://www.cs.columbia.edu/\~rocco/papers/icml13.html)

* reorganized example links and described pictures

* Added references

* more refs

* Added scaler to docstring examples

* doc about dual coefs

* WIP

* note about shrinking and gram matrix

* ellipsis

* ellipsis again

* maybe fixed doc issue

* details for regression

* training error -> margin error

* Apply suggestions from code review

Co-Authored-By: Adrin Jalali <adrin.jalali@gmail.com>

* put back links + addressed rest of comments

* small detail about margin boundaries and SVs

* Addressed comments from Thomas and Adrin

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
2020-04-06 15:06:12 +02:00
Nicolas Hug 16b3bf7f18
MNT Raise error when parameter isn't correct in SVC and… (#16736) 2020-04-04 21:17:31 -04:00
Roman Yurchak 5a4340834d
Fix mypy errors (#16726) 2020-03-30 15:41:05 +02:00
Alex Henrie 438bb3a438
MNT Remove unused imports (#16665) 2020-03-11 10:01:51 +11:00
Nicolas Hug d205638475
MNT Introduction of n_features_in_ attr with _validate_data mtd (#16112) 2020-02-29 09:05:11 -05:00
Roman Feldbauer 9b39c4c4d2
TST Fix unreachable code in tests (#16110) 2020-02-16 14:41:26 +01:00
Georgi Peev 84bc8d341e
FIX Arbitrary SVC kernels (#11296) 2020-02-02 08:37:00 +11:00
Pierre Delanoue 2eff916be9
DOC improve random state descriptions for SVMs (#16316) 2020-01-31 16:48:17 +01:00
Thomas J Fan 8ea05cbd41 [MRG] API Deprecates probA_ and probB_ in OneClassSVM and svm.SVR (#15558) 2020-01-28 19:47:07 +01:00
Hye Sung Jung 3424f72469 DOC spelling fixes (#16247) 2020-01-28 12:52:17 +11:00
Titus Christian afe6e513a4 DOC improve svm module docstring per guidlines (#16060) 2020-01-09 19:02:28 +01:00
Nicolas Hug 5c5635feb7 MNT make files private in sklearn.svm (#15165) 2019-10-18 16:18:33 -04:00