Commit Graph

909 Commits

Author SHA1 Message Date
Thomas J. Fan d4aad64b1e
MNT Update to black 22.3.0 to resolve click error (#22983)
* MNT Update to black 22.3.0 to resolve click error

* STY Update for new black version
2022-03-29 12:04:41 +02:00
Christian Lorentzen bf0ece817d
ENH add sample_weight to sparse coordinade descent (#22808) 2022-03-25 11:09:28 +01:00
Jérémie du Boisberranger d76f87c8eb
Fix Ridge sparse + sample_weight + intercept (#22899)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2022-03-22 20:15:54 +01:00
Gabriel Stefanini Vicente ffa0898d5a
API Add data_transposed argument and warning to make_sparse_coded_signal (#21425)
Co-authored-by: Andreas Mueller <t3kcit@gmail.com>
Co-authored-by: jeremie du boisberranger <jeremiedbb@yahoo.fr>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
2022-03-22 16:01:42 +01:00
Richard Taylor 02f8ffd55f
MNT Replace pytest.warns(None) in test_ridge.py (#22917) 2022-03-22 08:47:38 -04:00
Jérémie du Boisberranger 7414a7c4c5
FIX LinearRegression sparse + intercept + sample_weight (#22891) 2022-03-18 17:47:26 +01:00
Richard Taylor ea290e2d61
TST remove pytest.warns(None) in test_logistic.py (#22877) 2022-03-18 16:16:42 +01:00
Richard Taylor 850d44992e
replace pytest.warns(None) in test_least_angle.py (#22889) 2022-03-18 16:15:28 +01:00
Richard Taylor aee564c544
TST Replace pytest.warns(None) in test_omp.py (#22886) 2022-03-17 20:13:51 -04:00
Richard Taylor ebad97800f
TST replace pytest.warns(None) in test_coordinate_descent.py (#22878) 2022-03-17 13:51:33 -04:00
Richard Taylor 615c68a6aa
TST replace pytest.warns(None) in linear_model test_base.py (#22876) 2022-03-17 13:33:30 +01:00
Christian Lorentzen f856bfbd1d
TST check sparse dense equality for Lasso and ElasticNet (#22767) 2022-03-11 14:22:07 -05:00
Jérémie du Boisberranger d135a0f8db
MNT additional cleaning in test for 1.1 (#22661) 2022-03-03 10:31:02 +01:00
JSchuerz 4a52eb6de9
DOC Use :doi: and :arxiv: directives for references (#22603)
Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
2022-03-02 15:15:44 +01:00
Jérémie du Boisberranger f14af688b7
FIX Make Ridge*CV warn about rescaling alphas with scaling (#22585) 2022-03-02 13:59:04 +01:00
Jérémie du Boisberranger 34f9dbf541
MNT Clean fixes and compat for old versions of our dependencies (#22642)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2022-03-02 11:32:06 +01:00
Meekail Zain 7a2a0f74ca
ENH Bayesian regression model `dtype` consistency (#22525)
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Imbert Arthur <arthur.imbert@inria.fr>
2022-02-27 08:38:37 -05:00
Arturo Amor 34d39c7da6
MNT Add validation for parameter alphas in LassoCV (#22305)
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2022-02-26 11:22:11 -05:00
Olivier Grisel 4ca4f3bbcd
FIX make the shape of LogisticRegression(solver="liblinear") consistent with other solvers (#21998)
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
2022-02-15 16:40:10 +01:00
Thomas J. Fan 1fc86b6aac
MNT Update black to stable version (#22474) 2022-02-15 11:36:26 +01:00
Christian Lorentzen d8d5637cfe
ENH Loss module LogisticRegression (#21808)
* ENH replace loss in linear logistic regression

* MNT remove logistic regression's own loss functions

* CLN remove comment

* DOC add whatsnew

* DOC more precise whatsnew

* CLN restore improvements of #19571

* ENH improve fit time by separating mat-vec in multiclass

* DOC update whatsnew

* not only a bit ;-)

* DOC note memory benefit for multiclass case

* trigger CI

* trigger CI

* CLN rename variable to hess_prod

* DOC address reviewer comments

* CLN remove C/F for 1d arrays

* CLN rename to gradient_per_sample

* CLN rename alpha to l2_reg_strength

* ENH respect F-contiguity

* TST fix sag tests

* CLN rename to LinearModelLoss

* CLN improve comments according to review

* CLN liblinear comment

* TST add / move test to test_linear_loss.py

* CLN comment placement

* trigger CI

* CLN add comment about contiguity of raw_prediction

* DEBUG debian-32

* DEBUG test only linear_model module

* Revert "DEBUG test only linear_model module"

This reverts commit 9d6e6987ff.

* DEBUG test -k LogisticRegression

* Revert "DEBUG test -k LogisticRegression"

This reverts commit c203167041.

* Revert "DEBUG debian-32"

This reverts commit ef0b98f232.

* DEBUG set n_jobs=1

* Revert "DEBUG set n_jobs=1"

This reverts commit c7f6f72a8c.

* CLN always use n_threads=1

* CLN address review

* ENH avoid array copy

* CLN simplify L2 norm

* CLN rename w to weights

* CLN rename to hessian_sum and hx_sum

* CLN address review

* CLN rename to init arg and attribute to base_loss

* CLN apply review suggestion

Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>

* CLN base_loss instead of _loss attribute

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
2022-02-14 11:55:17 +01:00
Thomas J. Fan 4ff0767087
ENH Better error message for check_scalar (#22218)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2022-02-11 16:15:30 +01:00
Meekail Zain 9d415dc16d
TST Improved testing logic in `tests/test_logistic.py` (#22314)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2022-02-08 20:08:19 +01:00
Thomas J. Fan 9f85c9d449
TST Better info when checking for no warnings in tests (#22362) 2022-02-03 11:42:48 +01:00
Sultan Orazbayev cd892f9688
DOC use the arxiv directive in the docstrings (#21418)
Co-authored-by: aufarkari <aufar.di.sini@gmail.com>
Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2022-01-28 17:55:55 +01:00
Arturo Amor d7fc1df9fb
MNT Add validation for parameters in `ElasticNet` (#22240)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2022-01-22 11:21:44 -05:00
Christian Ritter ddbf5b37d4
ENH Check for nonfinite coordinate descent (#22148)
Co-authored-by: Norbert Preining <norbert@preining.info>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
2022-01-20 14:26:39 +01:00
Yar Khine Phyo 702be7c986
FIX Fix warning for ElasticNetCV l1_ratio=0 (#21724)
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
2022-01-12 16:12:46 +01:00
Adrian Trujillo Duron 1c24595c74
MAINT rename base_estimator to estimator in RANSACRegressor (#22062) 2022-01-06 19:12:44 +01:00
Takeshi Oura 5dfa5d979a
ENH Preserving dtype for np.float32 in *DictionaryLearning, SparseCoder and orthogonal_mp_gram (#22002) 2021-12-30 12:16:41 +01:00
Thomas J. Fan 5de723d2f9
CI Fixes wheel building (#22051) 2021-12-24 14:06:21 +01:00
Venkatachalam N 9cc494d424
ENH support sparse data input for QuantileRegressor (#21086)
only for highs* solvers
2021-12-15 13:43:59 +01:00
András Simon d72bd02b09
TST Speed up slow test linear_model/tests/test_quantile.py::test_asymmetric_error (#21546) 2021-12-10 15:34:51 +01:00
Olivier Grisel 670133dbc4
MAINT reduce scope of test_linear_models_cv_fit_for_all_backends to reduce CI usage (#21918)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2021-12-10 02:43:27 +01:00
Arturo Amor 3e0f49b623
MNT Add validation for parameter `alphas` in `RidgeCV` (#21606)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
2021-12-01 18:56:21 +01:00
Arturo Amor cacc034bba
MNT Add validation of scalar parameters in Ridge (#21341)
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2021-12-01 12:05:18 +01:00
Guillaume Lemaitre 4f6a28f2eb
FIX/API Fix AIC/BIC in LassoLarsIC and introduce noise_variance (#21481) 2021-11-23 21:32:26 +01:00
ArturoAmor 2cf3c55807
MNT Postpone conversion of `RidgeCV`'s `alphas` out of `__init__` (#21506) 2021-11-03 18:41:21 +01:00
Guillaume Lemaitre 90e04a5f15
FIX add support for multilabel classification in RidgeClassifier* (#19869)
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
2021-10-27 15:18:02 +02:00
Olivier Grisel 1a7eec8af1
XFAIL test_linear_model_normalize_deprecation_message on macos (#21396) 2021-10-22 13:08:47 +02:00
Olivier Grisel bd8528db3d
MAINT Shorten parametrized test names with long error messages (#21364)
* Apply suggestions from code review

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2021-10-19 15:38:18 -07:00
Tom Dupré la Tour 762eca546a
FIX improve error message for large sparse matrix input in LogisticRegression (#21093) 2021-09-24 11:05:53 +02:00
Dimitri Papadopoulos Orfanos f71c031314
DOC Typos found by codespell (#21069) 2021-09-17 19:04:54 +02:00
Guillaume Lemaitre 047cc2ec0c
TST solve issues in PyPy (#20978)
* TST fix brittle test in pypy for error message

* iter

* Update test_sgd.py

* Update test_sgd.py

* remove pypy3 in PRs
2021-09-09 15:10:14 +02:00
Guillaume Lemaitre d44fd44f91
API fix params validation in SGD inherited models (#20683) 2021-08-16 15:35:17 +02:00
Shao Yang Hong e648c4cb91
API deprecate default of `min_samples` for `RANSACRegressor` (#19390)
Co-authored-by: Michael Sloma <michael_sloma@urmc.rochester.edu>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2021-08-15 16:51:40 -04:00
Shao Yang Hong 4f33e4de32
FIX raise error when enet_path and lasso_path receive unknown parameters (#19391)
* Resolves #10598 

Updated the code, sorry for putting in lackluster pull requests. Will put in more attention to detail, something silly like putting in commands after the function ended was easy to prevent.

* Update coordinate_descent.py

* Update coordinate_descent.py

* Move params checking to top and fix test

* Flake8

* make sure to not pass normalize and fit_intercept as path params

* TST check the error message

* typo

* iter

* iter

Co-authored-by: Elliot Kang <kkang2097@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2021-08-05 09:20:10 +02:00
gregorystrubel 0b45ac56f1
FIX adjust inliner criteria in RANSACRegressor (#19499)
Co-authored-by: Gregory Strubel <greg@Air-de-Ali.local>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2021-07-30 15:28:12 +02:00
Toshihiro NAKAE 18eef9adf9
FEA Add positive argument to Ridge using L-BFGS-B solver (#20231) 2021-07-04 22:43:32 +02:00
Thomas J. Fan 3ae7c76153
STY Enables black with experimental_string_processing=true (#20412) 2021-06-29 09:47:04 +02:00