Commit Graph

74 Commits

Author SHA1 Message Date
Meekail Zain e821a9e8a0
ENH preserves dtypes for GenericUnivariateSelect class (#22370)
Co-authored-by: Thierry Gameiro <titigmr@MacBook-Air-de-Thierry.local>
Co-authored-by: titigmr <thierry.gmr@outlook.fr>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2022-02-14 18:24:29 +01:00
Thomas J. Fan 9f85c9d449
TST Better info when checking for no warnings in tests (#22362) 2022-02-03 11:42:48 +01:00
Juan Carlos Alfaro Jiménez 7de08f5ced
ENH add a parameter force_finite to r_regression and f_regression (#17819)
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2021-12-20 08:40:09 +01:00
Thomas J. Fan 82df48934e
MNT Applies black formatting to most of the code base (#18948) 2021-06-17 14:21:09 -04:00
naozin555 9406b3d2a4
TST Removed assert_warns_message from feature_selection/tests (#20158) 2021-05-28 13:53:10 +02:00
Julien Jerphanion d5ebdca662
[MRG] Refactor `feature_selection.f_regression` and introduce `feature_selection.r_regression` (#17169)
Co-authored-by: Dmytro S Lituiev <d.lituiev@gmail.com>
Co-authored-by: Chiara Marmo <chiara.marmo@u-psud.fr>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2021-04-21 10:49:18 +02:00
Thomas J. Fan 7cc0177f8e
MNT Replaces numpy alias with builtin typse (#17687)
* MNT Replaces numpy alias with builtin typse

* STY Lint error
2020-06-24 16:51:51 +02:00
Adrin Jalali c3817500cc
API feature_selection's constructor params -> kwonly (#16867) 2020-04-10 14:26:56 -04:00
Nicolas Hug b92455a6b2 MAINT Deprecate all of utils.testing except all_estimators (#15367) 2019-10-28 17:28:56 +01:00
Thomas J Fan 4a95e33e63 MNT Make modules private in sklearn.datasets (#15307) 2019-10-27 17:17:23 -04:00
Samesh Lakhotia a2968c2e4f MNT Fix assert raises in sklearn/feature_selection/tests/ (#14697) 2019-08-21 15:35:19 +08:00
Adrin Jalali 19c068a2ec MNT towards removing assert_equal, etc (#14222) 2019-07-01 09:13:32 -04:00
Roman Yurchak 5674122c97 MAINT More test runtime optimizations (#14136)
* Feature extraction / feature selection

* Metrics, manifold, impute, GP optimization

* Optimize mixture

* Optimize model_selection

* Fix tests

* Lint
2019-06-22 10:44:06 +03:00
surgan12 62d2059804 MNT remove __future__ imports (#12791) 2019-02-02 22:05:06 +08:00
Hanmin Qin 43e3a02085
MNT Remove unused assert_true imports (#12560) 2018-11-11 11:08:37 +08:00
Yaroslav Halchenko 362cb3bcab TST autoreplace assert_true(...==...) with plain assert (#12547) 2018-11-11 09:05:34 +08:00
Roman Yurchak f049ec72eb TST Pytest parametrization part3 - feature_extraction, gaussian_process modules (#11143) 2018-06-04 22:23:29 +08:00
Bastian Venthur 7400775633 [MRG+1] MAINT Replace assert_array_equal with -assert_array_almost_equal where necessary. (#9774) 2017-09-18 19:55:23 +10:00
Daniel LeJeune 456fb5697f [MRG + 2] Allow f_regression to accept a sparse matrix with centering (#8065)
* Updated centering for f_regression

Allows f_regression to accept a sparse matrix when centering=True.

* Fixed E226 spacing issue.

* Added f_regression sparse update to whats_new.rst
2016-12-20 14:23:32 +01:00
affanv14 ee3e61754b [MRG+2] adding multilabel support for score_func (#7676)
* added multilabel support for score function

* added test for multilabel score function

* updated whats_new.rst

* updated whats_new.rst with working link
2016-10-20 13:08:23 -04:00
Meng, Peng 2caa1445fb [MGR + 2] fix selectFdr bug (#7490) 2016-10-20 13:06:32 +11:00
Nikolay Mayorov 375b070263 TST: Speed up 2 tests related to mutual info 2016-01-22 00:27:16 +05:00
Nikolay Mayorov d3a497aec4 BUG: Fix copy logic for mutual info functions 2016-01-22 00:27:16 +05:00
Nikolay Mayorov 835102ab6a API: Split mutual_info into _regression and _classif 2016-01-22 00:27:15 +05:00
Nikolay Mayorov df08defb05 ENH: Implemented mutual_info function 2016-01-22 00:27:15 +05:00
Vighnesh Birodkar 2f099334f9 MAINT deprecate 1d input arrays for all estimators
Passing 1D arrays to check_array, without setting `ensure_2d` to false now
raises a deprecation warning before reshaping it. This will later throw an
error.

All Scaler classes also throw warnings when 1D arrays are passed.

All unit tests/doctests are modified to ensure that no 1D arrays are passed,
except in explicit 1D array tests where the warnings have been silenced.

Additional tests are also included which check for different 1D array cases.

2D array tests with one samples and one features are also added and where
they failed, `check_array` call has been modified to give a more useful error
message
2015-09-09 15:49:58 +02:00
Raghav R V cd2ee7e454 MAINT docstring --> comments to prevent nose from using doc in verbose mode 2015-03-21 11:16:49 +05:30
Andreas Mueller f12a441655 raise noise in test again, be ascii 2015-02-24 16:26:24 -05:00
Olivier Grisel 95f1d9562b FIX DOC TST: alpha is an uppper bound on FDR 2015-02-24 16:26:24 -05:00
Andreas Mueller 700babc43f extensive (excessive?) testing of FDR 2015-02-24 16:26:24 -05:00
Andrew Tulloch 1add39ff11 [Feature Selection] Fix SelectFDR thresholding bug (#2771)
From https://github.com/scikit-learn/scikit-learn/issues/2771, we were
not correctly scaling the alpha
parameter (http://en.wikipedia.org/wiki/False_discovery_rate#Benjamini.E2.80.93Hochberg_procedure)
with the number of features (== hypothesis).  Thus, the alpha
parameter was not invariant wrt the number of features.

The correction is as suggested in the original issue, and a test has
been added that verifies that for various numbers of features, an
appropriate false discovery rate is generated when using the selector.
2015-02-24 16:25:58 -05:00
Olivier Grisel 2ce9eac717 TST more strict selectors with empty support 2015-02-07 11:37:06 +01:00
Olivier Grisel bc5b403af3 FIX #4059: explicit warning for strict selectors 2015-02-06 12:06:34 +01:00
MechCoder 0bd095f9d6 FIX: Raise warnings in f_classif a given feature is constant throughout 2014-10-08 19:32:47 +02:00
Olivier Grisel e01749068c MAINT fix prng in test_f_oneway_ints
Not fixing the PRNG cause the test to fail randomly under windows
where the 4 decimals place check can be too strict for some unlucky
random draws of test data.
2014-07-29 08:54:47 +02:00
Olivier Grisel f3afd4e5e2 FIX unstable test on 32 bit windows 2014-07-23 19:11:53 +02:00
Andreas Mueller 6e2a83b4e1 remove check_arrays stuff and old input validation 2014-07-20 13:31:45 +02:00
Arnaud Joly db4230a776 TST improve parameter checking + use nose assert_ functions 2014-05-08 20:56:21 +02:00
Arnaud Joly e58405d6f6 MAINT remove redundant class hierarchy + fix api perform parameter check in fit 2014-05-08 20:56:21 +02:00
Will Myers f1e2e1c874 Fixed SelectKBest corner case: k=0
Without this fix k = 0 will have the same behavior as k = 'all' based on how
the array indexing was written.

I've included a test that demonstrates proper behaviour.
2014-03-27 15:18:50 -04:00
VirgileFritsch 4c129e57c1 f_regression and degress of freedom: update whats_new + minor. 2014-02-07 19:28:46 +01:00
VirgileFritsch 4d18fd8837 BF in f_regression: variable naming + use assert_*array*_almost_equal. 2014-02-07 19:28:06 +01:00
VirgileFritsch 8e0b4be57e BF: Correct degrees of freedom in f_regression + test. 2014-02-07 19:28:05 +01:00
ai8rahim 921deade51 Changed assert_array_equal() in Line 45 and 46 to assert_array_almost_equal(,,decimal=5). This has fixed the AssertionError, which occurs during the installation test. 2014-01-12 21:03:11 +08:00
Alexandre Gramfort 44270ddc83 fix f_oneway with ints 2013-12-16 22:02:05 +01:00
dengemann e1bdd99ea6 ENH: add assert_warn_message 2013-11-29 13:55:39 +01:00
Lars Buitinck b46ea718af FIX remove warnings from univariate FS
These warnings are issued practically always when using
frequency-valued or boolean data.

Switched to a stable sort to get reproducible results.
2013-08-19 14:56:37 +02:00
jnothman 2b57e4e52e Merge pull request #1935 from jnothman/base_filter_inv_transform
Small improvements to inverse_transform used in feature_selection.
2013-05-07 05:26:58 -07:00
Joel Nothman 35b4045ff9 FIXTST fix errors introduced to feature selection tests 2013-05-07 16:00:05 +10:00
Joel Nothman 4fd975ce80 ENH sparse _BaseFilter.inverse_transform 2013-05-07 16:00:05 +10:00