Commit Graph

35 Commits

Author SHA1 Message Date
Jack Liu f12987de98
MNT Replace if_delegate_has_method with available_if in feature_selection (#20593)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
2022-03-13 21:13:45 +01:00
Thomas J. Fan 071f98f0a7
FIX Remove warnings when fitting a dataframe (#21578)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2021-11-29 17:55:37 +01:00
Guillaume Lemaitre d6144caead DOC ensure that RFE is passing numpydoc validation 2021-08-31 19:14:37 +02:00
Thomas J. Fan 786c4e5e39
DOC Adds feature_names_in_ to docstrings (#20787) 2021-08-26 13:44:45 +02:00
Shuhei Kayawari daec880bff
API Replacing grid_scores_ by cv_results_ in _rfe.py and test_rfe.py (#20161)
Co-authored-by: arka204 <kmichalik204@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2021-07-30 18:01:49 +02:00
Felipe Rodrigues eb901df93f
ENH Allow `sample_weight` and other `fit_params` in RFE (#20380)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
2021-07-27 18:24:35 +02:00
Jesse Lima aa1fca5bf3
DOC Ensures that RFECV passes numpydoc validation (#20452)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2021-07-07 10:44:57 +02:00
Jesse Lima e59a6c0a5a
DOC Ensures that RFE passes numpydoc validation (#20419)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2021-06-30 00:29:24 +02:00
lacrosse91 555ade2e09
DOC Fix docstring summary line in _rfe.py (#20280)
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
2021-06-18 15:51:12 +02:00
Thomas J. Fan 82df48934e
MNT Applies black formatting to most of the code base (#18948) 2021-06-17 14:21:09 -04:00
Guillaume Lemaitre 95afec8742
TST create instances from exotic estimators for docstring params check (#20243)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2021-06-11 18:38:22 +02:00
Tom Dupré la Tour f6e6ad2d9e
MNT clean futurewarning for 1.0 | _deprecate_positional_args (#20002)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2021-05-14 11:30:27 -04:00
Guillaume Lemaitre 255718b4ad
introduce _safe_tags for estimator not inheriting from BaseEstimator (#18797)
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2020-12-02 11:18:53 +01:00
Guillaume Lemaitre 7dcb1ac560
FIX allow to output error_score if a scoring failure happen (#18343)
Co-authored-by: Devi Sandeep Endluri <dsandeep97@tamu.edu>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2020-10-09 15:12:57 +02:00
Thomas J. Fan 06d6f8a9f6
FIX Passes global configuration when spawning joblib jobs (#17634)
* WIP

* BUG Passes context to joblib jobs

* BUG Fix

* BUG Fix

* CLN Moves delayed into fixes

* CLN Adds linter

* REV Revert diff

* DOC Adds comment for removal

* Use a simple implementation
2020-09-21 16:59:42 +02:00
Albert Villanova del Moral 647fcb1ac1
DOC Fix A to uppercase in See Also docstring section (#18332) 2020-09-04 10:35:01 -04:00
Albert Villanova del Moral 875d32fe55
DOC Fix versionadded/versionchanged for 0.24 (#18312) 2020-09-01 10:51:01 +02:00
Nicolas Hug 5bf37e8425
FEA Add sequential feature selection transformer (#17159)
Co-authored-by: rasbt <mail@sebastianraschka.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-08-21 19:57:05 +02:00
Lisa Schwetlick 911137f0de
ENH Enable percentage for n_features_to_select in RFE(Fix PR #16228) (#17090)
* added code from PR #14627

* fixed error handling None as n_features_to_select

* added test for error message and percentage passing

* linting

* more linting

* even more linting

* sklearn/feature_selection/_rfe.py make int casting simpler

Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>

* exchange redundant test case with small float

* add what's new

* removed useless import

* lint

* Fix whats_new/v0.24.rst

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>

* move whats new section

* disambiguate choice between 1 feature and 100% of features

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>

* move checking for negatives to _fit

* update error to include nones

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>

* markdown style in what's new

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>

* Update sklearn/feature_selection/tests/test_rfe.py

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>

* forgot to delete line

* fix test for negative n_features error

* BUG Fixes issues

* added case for float >1 and more detailed error messages

* lint

* more lint

* more lint

* CLN Minor adjustments

* BLD Force build on ci

Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-06-26 22:40:25 -04:00
Kendrick Cetina 2c7107089c
DOC improve attributes and parameters descriptions in RFE and RFECV (#17721)
Co-authored-by: Beatriz San Miguel <beatriz.sanmiguelgonzalez@uk.fujitsu.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-06-25 18:46:31 +02:00
Thomas J. Fan 7cc0177f8e
MNT Replaces numpy alias with builtin typse (#17687)
* MNT Replaces numpy alias with builtin typse

* STY Lint error
2020-06-24 16:51:51 +02:00
pwalchessen 89b80a6c67
DOC add missing attributes in several modules (#15521)
Co-authored-by: Patricia Walchessen <pwalchessen@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-06-18 11:18:23 +02:00
Aura Munoz 5297365ebe
DOC Standarize default documentation for feature_selection (#17465)
* doc: Standarize default documentation for feature_selection

- Change `default` documentation of parameters to follow `default=<value>`
template

* remove space at end-of-line

* fix linting issues

* address comments

* missing file
2020-06-07 17:27:36 +02:00
Pardeep Singh 2653fa939b
DOC shorten estimators links for sklearn/feature_selection/* and sklearn/experimental/* modules (#17466)
* Shorten Estimators Links for sklearn/experimental/* module docs

* Shorten Estimators Links for sklearn/feature_selection/* module docs
2020-06-06 12:42:59 -04:00
Venkatachalam N f6b8bc0ece
ENH add importance_getter to RFE* and SelectFromModel 2020-05-20 16:15:32 +10:00
brigi dbc35934a6
DOC Version added and changed labels added for v0.18 (#wimlds) (#16222)
* Versionlabels added to v0.18 (#wimlds)

* documentation issues: label changed and added for version 0.18

* fix intends and shorten description

Co-authored-by: Hannah <32333241+hhnnhh@users.noreply.github.com>
Co-authored-by: Brigitte@home <unger@nue.tu-berlin.de>
2020-04-27 18:43:47 -04:00
Ekaterina Borovikova 4755ae76d2
DOC Add versionchanged and versionadded for v0.20 (#16199)
Co-Authored-By: Adrin Jalali <adrin.jalali@gmail.com>
Co-Authored-By: Chiara Marmo <cmarmo@users.noreply.github.com>
Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
2020-04-26 09:29:36 -04:00
Adrin Jalali 02309ffbda
API kwonly args in manifold, metrics, mixture, model_selection, multclass, multioutput (#16982) 2020-04-24 17:24:24 -04:00
Nicolas Hug 089c8a17a1
[MRG] MNT requires_y tag with y=None validation (#16622) 2020-04-22 22:41:45 +10:00
Adrin Jalali c3817500cc
API feature_selection's constructor params -> kwonly (#16867) 2020-04-10 14:26:56 -04:00
Alex Henrie 438bb3a438
MNT Remove unused imports (#16665) 2020-03-11 10:01:51 +11:00
Nicolas Hug d205638475
MNT Introduction of n_features_in_ attr with _validate_data mtd (#16112) 2020-02-29 09:05:11 -05:00
Divyaprabha M 63cfc5ff6b
ENH add multioutput support for RFE (#16103) 2020-02-04 20:33:35 +01:00
Alec Peters 70b0ddea99 FEA Allow nan/inf in feature selection (#11635) 2019-11-05 11:34:59 +11:00
Thomas J Fan 6769490424 MNT Make modules private in feature_selection (#15376) 2019-10-29 11:00:32 +08:00