Commit Graph

29 Commits

Author SHA1 Message Date
Takeshi Oura cb4688ad15
ENH Preserving dtype for np.float32 in SparsePCA and MiniBatchSparsePCA (#22111)
Co-authored-by: takoika <>
2022-01-04 17:39:14 +01:00
Thomas J. Fan 87838c20cc
ENH Adds feature names out to decomposition module (#21334)
* ENH Adds feature names out to decomposition module

* DOC Adds whats enw

* REV Removes module not in decomposition

* ENH Uses a mixin

* REV Better merge
2021-10-27 13:08:37 +02:00
Alberto Mario Ceballos-Arroyo d742a58b9d
DOC Added meaning of default=None for n_components in MiniBatchSparsePCA and MiniBatchDictionaryLearning (#21428) 2021-10-25 17:41:27 +02:00
Alberto Mario Ceballos-Arroyo dde2716c6f
DOC Added the meaning of the default=None case in SparsePCA (#21421)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2021-10-23 12:35:23 -04:00
genvalen 642127806a
DOC use backticks for n_samples and n_features in X docstring (#20914) 2021-09-02 13:35:03 +02:00
genvalen 43c9c66ebe
DOC Ensures that MiniBatchSparsePCA passes numpydoc validation (#20870) 2021-08-31 18:31:34 +02:00
Thomas J. Fan 786c4e5e39
DOC Adds feature_names_in_ to docstrings (#20787) 2021-08-26 13:44:45 +02:00
genvalen 28ce1e3b0c
DOC Replace the phrase "where n_samples in the number" with "where n_samples is the number" (#20822) 2021-08-23 21:15:05 -04:00
Iván Pulido 67eb690640
DOC ensures SparsePCA docstring passes numpydoc validation (#20395)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2021-07-13 12:55:55 +02:00
Thomas J. Fan 351ace7935
STY Uses black's with target_version >= 3.7 (#20294) 2021-06-17 15:50:27 -04:00
Thomas J. Fan 82df48934e
MNT Applies black formatting to most of the code base (#18948) 2021-06-17 14:21:09 -04:00
Guillaume Lemaitre 1cd282d600
DOC add n_features_in_ in the documentation (#20236) 2021-06-09 16:58:03 +02:00
Tom Dupré la Tour f6e6ad2d9e
MNT clean futurewarning for 1.0 | _deprecate_positional_args (#20002)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2021-05-14 11:30:27 -04:00
Jérémie du Boisberranger 7404a82891
[DOC] Clarify the docstring of dict learning about the inits (#19227) 2021-01-22 19:06:01 +01:00
Olivier Grisel 548a4524b4
MNT n_features_in_ consistency in decomposition (#18557)
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
2020-10-08 09:47:24 -04:00
Albert Villanova del Moral 647fcb1ac1
DOC Fix A to uppercase in See Also docstring section (#18332) 2020-09-04 10:35:01 -04:00
Frans Larsson 30f201f914
DOC Add None as valid option to random_state (#18234) 2020-08-22 17:30:45 +02:00
clmbst 46b7d8a76c
DOC Fix documentation of default values in decomposition module (#17739)
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-08-21 22:42:44 +02:00
Thomas J. Fan b364028ecd
MNT Enables subset_invariance tests to run with SparsePCA (#17319) 2020-06-03 19:11:34 +02:00
Nicolas Hug ac8cbb3799
[MRG] More deprecation for 0.24 (#17142)
* normalize_components in sparsePCA

* changed default strategy of Dummy to prior and removed outputs_2d ttribute

* removed usage of None to drop estimator in ensemble and behaviour param of IsolationForest

* remove support for drop=None in Voting

* removed some warning decorators

* remove feature_extraction.extract_patches

* removed VectorizerMixin and copy parameter from TFIDFVectorizer

* kernel.set_params now raises attributeerror

* removed fig from plot_partial_dependence

* removed iid parameter of search estimators

* removed brier_scorer

* raise error in split when shuffle is False and random_state is not None

* removed MultiOutputEstimator

* removed base classes of NaiveBayes

* removed drop from pipeline

* removed utils in random_projection

* removed presort and classes_ in trees

* flake8

* fixed some tests

* flake

* fixed docstring

* fixed other one

* some left

* mmmm
2020-05-20 16:04:14 -04:00
Thomas J Fan e770715c43
MNT Completes position arg deprecation (#17272)
* ENH Adds public functions with position args warning

* BUG Circlar import

* STY

* BUG Add keywords

* BUG Fixes warnings

* ENH Adds other public functions

* CLN Suggestion

* CLN Suggestion

* REV Revert pairwise

* ENH Positoinal args for compute_class_weight
2020-05-19 09:07:25 +02:00
Mateusz Górski 41b18fea37
ENH Added n_components_ to SparsePCA and MiniBatchSparsePCA (#16981)
* Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA

* Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA

* Add whatsnew entry

* Fix documentation

* Apply suggestions from code review

Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>

* Add suggested changes

* Update test_sparse_pca.py

Co-authored-by: Mateusz Górski <mateuszg122@gmail.com>
Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
2020-04-27 17:32:19 -04:00
Nicolas Hug 2d03d781a9
MNT simplify xfail check marking logic (#16949)
Co-Authored-By: Roman Yurchak <rth.yurchak@gmail.com>
2020-04-17 13:44:09 -04:00
Adrin Jalali d6d624db5d
API make __init__ params in decomposition kwonly (#16722)
* DOC make __init__ params in decomposition kwonly

* test fixes

* pep8
2020-03-31 10:28:36 +02:00
Nicolas Hug d205638475
MNT Introduction of n_features_in_ attr with _validate_data mtd (#16112) 2020-02-29 09:05:11 -05:00
Roman Yurchak 1c1f273d10
ENH XFAIL in common tests with estimator tags (#16502) 2020-02-20 22:28:54 +01:00
Sarat Addepalli cd6e4d52d9 DOC improve random_state docstring from decomposition module (#11902)
* [MRG] Fix random_state docstrings in decomposition module

* Add more details, and specify reproducibility

* [MRG] docs for random_state in decomposition module

Update the wording for reproducible results.

* [MRG] Update doc for optional parameter to match numpy doc style

* apply new style

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-01-08 18:53:01 +01:00
Nicolas Hug 19ad136223 MNT Replace DeprecationWarning with FutureWarning (#15080)
* bruteforce renaming

* WIP

* WIP

* some more

* removed weird line

* update -Werror

* testiforest

* again

* Fixed some tests

* fixed some tests

* removed -Werror

* fixed test_docstring_param issue

* fixed some tests

* some more

* renamed to SklearnDeprecationWarning

* pep8

* updated docs

* pep8

* merge

* changed to FutureWarning

* fixes

* Update doc/developers/tips.rst

Co-Authored-By: Adrin Jalali <adrin.jalali@gmail.com>

* avoid duplicates

* fixed warning for deprecations

* Still make CI break if DeprecationWarning isn't caught

* updated one warning

* fixed test

* fixed some renamings

* updated new dep warnings

* fixed bad import

* ignore warnings

* update again

* ignore futurewarning when walking packages

* Fixed test

* pep8

* Added whatsnew
2019-10-29 15:39:26 +01:00
Thomas J Fan 5756a9934b MNT Make modules private in decomposition (#15344) 2019-10-28 22:46:16 +08:00