Commit Graph

27 Commits

Author SHA1 Message Date
Jihane d14fd82cf4
ENH Preserving dtypes for ICA (#22806)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
2022-03-28 18:07:53 +02:00
Thomas J. Fan 1fc86b6aac
MNT Update black to stable version (#22474) 2022-02-15 11:36:26 +01:00
Julien Jerphanion c48dba0718
EHN Support unit-variance whitening for `FastICA` (#19490)
Co-authored-by: Facundo Ferrín <facundo.ferrin@e-campus.uab.cat>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2021-11-08 15:43:49 +01:00
Thomas J. Fan 87838c20cc
ENH Adds feature names out to decomposition module (#21334)
* ENH Adds feature names out to decomposition module

* DOC Adds whats enw

* REV Removes module not in decomposition

* ENH Uses a mixin

* REV Better merge
2021-10-27 13:08:37 +02:00
Hannah Bohle 6f720c5e12
FIX validate parameters in `fit` for `FastICA` (#21432)
Co-authored-by: Maren Westermann <maren.westermann@gmail.com>
2021-10-23 19:35:54 -04:00
genvalen 642127806a
DOC use backticks for n_samples and n_features in X docstring (#20914) 2021-09-02 13:35:03 +02:00
Thomas J. Fan 786c4e5e39
DOC Adds feature_names_in_ to docstrings (#20787) 2021-08-26 13:44:45 +02:00
Leonardo Rocco 255ff88b86
DOC ensures FastICA estimator pass the numpydoc validation (#20405)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2021-07-20 18:24:32 +02:00
Thomas J. Fan 3ae7c76153
STY Enables black with experimental_string_processing=true (#20412) 2021-06-29 09:47:04 +02:00
Thomas J. Fan 351ace7935
STY Uses black's with target_version >= 3.7 (#20294) 2021-06-17 15:50:27 -04:00
Thomas J. Fan 82df48934e
MNT Applies black formatting to most of the code base (#18948) 2021-06-17 14:21:09 -04:00
Guillaume Lemaitre 1cd282d600
DOC add n_features_in_ in the documentation (#20236) 2021-06-09 16:58:03 +02:00
Tom Dupré la Tour f6e6ad2d9e
MNT clean futurewarning for 1.0 | _deprecate_positional_args (#20002)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2021-05-14 11:30:27 -04:00
Maxwell 66ec10f341
MAINT Clean up code in FastICA (#19796)
* FIX code cleanup in FastICA

* keep syntax X_mean

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2021-04-19 09:50:10 +02:00
sadak 2ea49a64e6
ENH Sets check_finite=False in sklearn.decomposition (#18857) 2020-11-18 12:24:55 -05:00
Olivier Grisel 548a4524b4
MNT n_features_in_ consistency in decomposition (#18557)
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
2020-10-08 09:47:24 -04:00
Thomas J. Fan 339fe04e32
CLN Removes unneeded attribute in FastICA (#18445) 2020-09-28 09:01:18 -06:00
Frans Larsson 30f201f914
DOC Add None as valid option to random_state (#18234) 2020-08-22 17:30:45 +02:00
clmbst 46b7d8a76c
DOC Fix documentation of default values in decomposition module (#17739)
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-08-21 22:42:44 +02:00
bmaisonn 2fc535fb11
DOC Fix documentation of default values in fastica.py (#17989) 2020-08-05 15:51:09 -04:00
Thomas J. Fan 256949676e
DOC Small doc formatting fixes in decomposition (#17918) 2020-07-14 11:33:52 +02:00
Srimukh Sripada 180646fa18
PERF Dot product optimizations using multi_dot (#17737) 2020-07-04 10:58:59 +02:00
Thomas J Fan e770715c43
MNT Completes position arg deprecation (#17272)
* ENH Adds public functions with position args warning

* BUG Circlar import

* STY

* BUG Add keywords

* BUG Fixes warnings

* ENH Adds other public functions

* CLN Suggestion

* CLN Suggestion

* REV Revert pairwise

* ENH Positoinal args for compute_class_weight
2020-05-19 09:07:25 +02:00
Adrin Jalali d6d624db5d
API make __init__ params in decomposition kwonly (#16722)
* DOC make __init__ params in decomposition kwonly

* test fixes

* pep8
2020-03-31 10:28:36 +02:00
Nicolas Hug d205638475
MNT Introduction of n_features_in_ attr with _validate_data mtd (#16112) 2020-02-29 09:05:11 -05:00
Sarat Addepalli cd6e4d52d9 DOC improve random_state docstring from decomposition module (#11902)
* [MRG] Fix random_state docstrings in decomposition module

* Add more details, and specify reproducibility

* [MRG] docs for random_state in decomposition module

Update the wording for reproducible results.

* [MRG] Update doc for optional parameter to match numpy doc style

* apply new style

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-01-08 18:53:01 +01:00
Thomas J Fan 5756a9934b MNT Make modules private in decomposition (#15344) 2019-10-28 22:46:16 +08:00