* added v0.19.1 and wip v0.19
* finished adding vchanged strings for v0.19
Towards #15426
@adrinjalali #wimlds #scikitlearnsprint
* fixing linter issues
* caught line issues with flake8
* caught the last line issue
* added lines and cleaned gtiignore
* Update sklearn/multiclass.py
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
* Update sklearn/multiclass.py
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
* support a scalar fit param
* pep8
* TST add test for desired behavior
* FIX introduce _check_fit_params to validate parameters
* DOC update whats new
* TST tests both grid-search and randomize-search
* PEP8
* DOC revert unecessary change
* TST add test for _check_fit_params
* olivier comments
* TST fixes
* DOC whats new
* DOC whats new
* TST revert type of error
* add olivier suggestions
* address olivier comments
* address thomas comments
* PEP8
* comments olivier
* TST fix test by passing X
* avoid to call twice tocsr
* add case column/row sparse in check_fit_param
* provide optional indices
* TST check content when indexing params
* PEP8
* TST update tests to check identity
* stupid fix
* use a distribution in RandomizedSearchCV
* MNT add lightgbm to one of the CI build
* move to another build
* do not install dependencies lightgbm
* MNT comments on the CI setup
* address some comments
* Test fit_params compat without dependency on lightgbm
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
* print train scores when verbose > 3 in _fit_and_score
* train_scores computed if verbose > 3, and 3 decimals places only
* flake8 warnings solved
* print train score if return_train_score
test coverage increased
* added test for multimetric;
tests cleaned using pytest parametrize
* fixing failed tests for python2...
* revert changes in _scorer
* modified whats_new
* modified whats_new again
#### Reference Issues/PRs
<!--
Example: Fixes#1234. See also #3456.
Please use keywords (e.g., Fixes) to create link to the issues or pull requests
you resolved, so that they will automatically be closed when your pull request
is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests
-->
This PR addresses issue #12466.
#### What does this implement/fix? Explain your changes.
This PR does the 3 following things:
- Rewrite the `cv` parameter description in `GridSearchCV`
- Link the new `CV splitter` description to an existing example
- Add an example with a custom iterable
Thanks for reviewing this!
Close#12466
* add FutureWarning for methods with defaults=3
* add explicit cv values to fix assertion errors
* add tests for catching the FutureWarning
* Write current deprecation version
* Add deprecation in docstring
* change default cv value to None
* change cv from 3 to 5 in the examples
* upgrade doctests
* update doctest in tutorial
* update doctest in cross-validation doc
* fix tests
* add entry to whats new
* address Gael comments
* address Gael comments 2
* fix wrong indentation
* update doc
* add docstring deprecation warning in CV subclasses
* address Andy's comments
* fix PR number
* fix flake8
* add filterwarnings in tests
* fix doctests
* cv=None mendatory in Ridge
* fix warning related errors
* skip some doctests warnings
* make travis happy
* change from deprecated to versionchanged
* fix doctests and remove skipping
* address comments