Commit Graph

99 Commits

Author SHA1 Message Date
Juan Carlos Alfaro Jiménez 0e33229351
FIX Extract estimator objects before aggregating dict of scores (#17745)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-06-26 21:15:41 -04:00
Thomas J. Fan 67bf1e78f5
ENH _fit_and_score now returns a dictionary (#17332)
* ENH _fit_and_score now returns a dictionary

* MRG

* REV

* LOL

* Removing things in gitignore is fun
2020-06-26 12:38:12 +02:00
Hirofumi Suzuki c95ed757b4
DOC add explanation of n_jobs in sklearn/model_selection/_validation.py (#17717) 2020-06-25 14:25:16 +02:00
Thomas J. Fan 7cc0177f8e
MNT Replaces numpy alias with builtin typse (#17687)
* MNT Replaces numpy alias with builtin typse

* STY Lint error
2020-06-24 16:51:51 +02:00
Chiara Marmo fc0d2c3210
[MRG] ENH Show split/candidate ids in verbose output of SearchCV (#16935) 2020-06-19 11:26:58 +02:00
Ekaterina Borovikova 4755ae76d2
DOC Add versionchanged and versionadded for v0.20 (#16199)
Co-Authored-By: Adrin Jalali <adrin.jalali@gmail.com>
Co-Authored-By: Chiara Marmo <cmarmo@users.noreply.github.com>
Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
2020-04-26 09:29:36 -04:00
Adrin Jalali 02309ffbda
API kwonly args in manifold, metrics, mixture, model_selection, multclass, multioutput (#16982) 2020-04-24 17:24:24 -04:00
Stephen Marsh 361bf75544
DOC Fix link to user guide (#16989) 2020-04-24 09:25:39 -04:00
Noa Tamir 5e2d74bc5f
DOC add versionadded versionchanged v0.19 (#16233)
* added v0.19.1 and wip v0.19

* finished adding vchanged strings for v0.19

Towards #15426

@adrinjalali #wimlds #scikitlearnsprint

* fixing linter issues

* caught line issues with flake8

* caught the last line issue

* added lines and cleaned gtiignore

* Update sklearn/multiclass.py

Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>

* Update sklearn/multiclass.py

Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>

Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
2020-04-15 10:36:51 +02:00
stareh daec09e6b4
DOC added the link for the reference in permutation_test_score (#16202)
* added the link for an open pdf of the article

* Address comment

Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
2020-02-03 13:59:27 +01:00
rachelcjordan 5c9957764a DOC improve random state docstring in the _validation module (#16231) 2020-01-26 20:29:11 +01:00
indecisiveuser f6a19a7e8d DOC Format docstrings in validation module (#16134) 2020-01-22 06:22:57 -05:00
Qizhi Jiang e3ee768a0c DOC Docstring improvements to confusion_matrix and splitters (#16072) 2020-01-11 18:42:10 +01:00
Adrin Jalali 46001e7cfb FIX support scalar values in fit_params in SearchCV (#15863)
* support a scalar fit param

* pep8

* TST add test for desired behavior

* FIX introduce _check_fit_params to validate parameters

* DOC update whats new

* TST tests both grid-search and randomize-search

* PEP8

* DOC revert unecessary change

* TST add test for _check_fit_params

* olivier comments

* TST fixes

* DOC whats new

* DOC whats new

* TST revert type of error

* add olivier suggestions

* address olivier comments

* address thomas comments

* PEP8

* comments olivier

* TST fix test by passing X

* avoid to call twice tocsr

* add case column/row sparse in check_fit_param

* provide optional indices

* TST check content when indexing params

* PEP8

* TST update tests to check identity

* stupid fix

* use a distribution in RandomizedSearchCV

* MNT add lightgbm to one of the CI build

* move to another build

* do not install dependencies lightgbm

* MNT comments on the CI setup

* address some comments

* Test fit_params compat without dependency on lightgbm

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2019-12-31 13:02:45 +01:00
lkubin 88963f86fb ENH Make cross_val_predict support method="predict_proba" and y=None (#15918) 2019-12-24 09:34:49 +11:00
Gregory Morse a05a5bc2b3 ENH Yield stack trace information in resilient mode model_selection warnings (#15622) 2019-12-14 15:32:59 -05:00
Andreas Mueller 3d606cf8ba FIX clone parameters in gridsearch etc (#15096)
* clone estimator again after setting parameters

* add more tests

* add some comments

* more tests

* don't clone estimators, just clone parameters
2019-10-29 15:42:14 +01:00
Nicolas Hug bcd399f4cb FIX Fixed some imports after deprecations (#15345) 2019-10-23 16:59:52 +02:00
Nicolas Hug e947689c90 MAINT Make files private for sklearn.metrics and sklearn.metrics.cluster (#15306) 2019-10-23 15:20:28 +02:00
Adrin Jalali 0eebade264 DOC docstring (shape= -> of shape) (#14640) 2019-10-02 20:54:32 -04:00
Nicolas Hug 96c988cdde
MNT Make safe_indexing private (#15104) 2019-10-02 11:47:46 -04:00
Shubham Mehta 80a4cf0501 DOC Changed Cross Validate Return Section Doc (#14924) 2019-09-28 21:25:32 +10:00
Thomas J Fan fbb2c7c700 ENH Adds _MultimetricScorer for Optimized Scoring (#14593) 2019-09-11 08:04:16 +10:00
Thomas J Fan 14f5302b70 DOC Link items explictly (#14817)
* DOC Link items explictly

* STY

* DOC Link another
2019-09-05 11:37:05 +02:00
Vincent Jeanselme e070b74517 DOC improve cross_val_predict docs (#14212) 2019-07-25 23:49:42 +10:00
Guillaume Lemaitre e68f6f3e6a DOC Make explicit that groups required *Group* splitter (#14235) 2019-07-02 11:17:01 -04:00
Roman Yurchak 1015caf54d MAINT Remove imports from sklearn.utils._joblib (#13676)
* Remove sklearn.utils._joblib imports

* Lint

* More fixes
2019-06-18 18:37:14 +04:00
Nicolas Hug 120009b12a DOC fix user guide for learning_curve (#14099) 2019-06-17 14:52:24 +02:00
H4dr1en b28aadf6ef Added fit and score times for learning_curve (#13938) 2019-06-14 14:34:26 -04:00
Thomas J Fan 2e7e06b78f [MRG] Doctest with print change only adjusts default options for doctest (#13991) 2019-06-01 10:53:45 +02:00
Guillaume Lemaitre 9adba491a2 [MRG] DEP change the default of cv and n_splits (#13839) 2019-05-29 23:39:20 +10:00
Stéphane Couvreur 0bfa52dad7 DEP Change default of error_score in cross-validation (#13840) 2019-05-22 09:28:45 +10:00
Stephen Cowley e7ca6236c5 Fix spacing and formatting inconsistencies (#13747) 2019-05-02 01:29:49 +10:00
Thomas J Fan 8edd9f9f15 ENH Add verbose option to Pipeline, FeatureUnion, and ColumnTransformer (#11364) 2019-04-22 00:51:21 +10:00
Stephen Hoover 24df999c10 ENH cross_val_predict now handles multi-output predict_proba (#8773) 2019-04-06 22:22:35 +11:00
Bharat Raghunathan eaca1729bd DOC Make scoring metric info uniform across scikit-learn (#13449) 2019-03-17 20:31:28 +11:00
Bharat Raghunathan a62775e99f DOC Add scoring metric info in cross_val_score (#13445) 2019-03-14 20:07:47 +11:00
Guillaume Fournier 50946b3ef2 Fix bad double to integer cast in __fit_and_predict for cross_val_predict (#13368)
* Fix bad double to integer cast in __fit_and_predict for cross_val_predict

* Fix flake8 errors

* Add documentation to changelog
2019-03-03 08:19:06 +01:00
Roman Yurchak 0e3bb17e62 MAINT Run pyupgrade following Python2 deprecation (#12997) 2019-02-08 20:13:34 +08:00
surgan12 62d2059804 MNT remove __future__ imports (#12791) 2019-02-02 22:05:06 +08:00
Roman Yurchak acb8106472 MNT Use list and dict comprehension (#12668) 2019-01-08 09:32:34 +11:00
Andreas Mueller 952ef6637a MRG Drop legacy python / remove six dependencies (#12639) 2019-01-03 15:50:05 +02:00
Marc Torrellas f6f7e3cfd3 [MRG + 2] Print train scores in _fit_and_score (#12613)
* print train scores when verbose > 3 in _fit_and_score

* train_scores computed if verbose > 3, and 3 decimals places only

* flake8 warnings solved

* print train score if return_train_score
test coverage increased

* added test for multimetric;
tests cleaned using pytest parametrize

* fixing failed tests for python2...

* revert changes in _scorer

* modified whats_new

* modified whats_new again
2018-11-21 20:22:24 -05:00
Thomas Moreau d25da1be20 FIX make joblib utils private, and remove mentions of externals.joblib (#12345) 2018-11-20 10:53:52 +11:00
Quentin Batista 4b78d7abf4 DOC: Clarify `cv` parameter description in `GridSearchCV` (#12495)
#### Reference Issues/PRs
<!--
Example: Fixes #1234. See also #3456.
Please use keywords (e.g., Fixes) to create link to the issues or pull requests
you resolved, so that they will automatically be closed when your pull request
is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests
-->

This PR addresses issue #12466.

#### What does this implement/fix? Explain your changes.

This PR does the 3 following things:
- Rewrite the `cv` parameter description in `GridSearchCV`
- Link the new `CV splitter` description to an existing example
- Add an example with a custom iterable

Thanks for reviewing this!

Close #12466
2018-11-12 15:10:15 -05:00
Andreas Mueller fb7be879a3 [MRG + 1] return_train_score deprecation (#12241) 2018-10-03 19:24:14 +02:00
Hanmin Qin 9b8fd0b0d0 DOC Correct default n_jobs & reference the glossary (#11808)
Also improves the glossary entry for n_jobs.
2018-08-18 19:57:10 +10:00
Olivier Grisel 40e6c43cb4
Joblib 0.12.2 (#11741)
* joblib 0.12.2

* Export _joblib's register_parallel_backend

* Use latest version of coverage
2018-08-03 12:34:25 +02:00
Samuel O. Ronsin 6b38970fce ENH Expose errors_score in cross_validate and cross_val_score (#11583) 2018-07-27 12:27:16 +10:00
Alexandre Boucaud f158e2dfe2 [MRG+1] Change CV defaults to 5 (#11557)
* add FutureWarning for methods with defaults=3

* add explicit cv values to fix assertion errors

* add tests for catching the FutureWarning

* Write current deprecation version

* Add deprecation in docstring

* change default cv value to None

* change cv from 3 to 5 in the examples

* upgrade doctests

* update doctest in tutorial

* update doctest in cross-validation doc

* fix tests

* add entry to whats new

* address Gael comments

* address Gael comments 2

* fix wrong indentation

* update doc

* add docstring deprecation warning in CV subclasses

* address Andy's comments

* fix PR number

* fix flake8

* add filterwarnings in tests

* fix doctests

* cv=None mendatory in Ridge

* fix warning related errors

* skip some doctests warnings

* make travis happy

* change from deprecated to versionchanged

* fix doctests and remove skipping

* address comments
2018-07-19 14:46:11 +02:00