Commit Graph

117 Commits

Author SHA1 Message Date
Thomas J. Fan 7cc0177f8e
MNT Replaces numpy alias with builtin typse (#17687)
* MNT Replaces numpy alias with builtin typse

* STY Lint error
2020-06-24 16:51:51 +02:00
Nicolas Hug ac8cbb3799
[MRG] More deprecation for 0.24 (#17142)
* normalize_components in sparsePCA

* changed default strategy of Dummy to prior and removed outputs_2d ttribute

* removed usage of None to drop estimator in ensemble and behaviour param of IsolationForest

* remove support for drop=None in Voting

* removed some warning decorators

* remove feature_extraction.extract_patches

* removed VectorizerMixin and copy parameter from TFIDFVectorizer

* kernel.set_params now raises attributeerror

* removed fig from plot_partial_dependence

* removed iid parameter of search estimators

* removed brier_scorer

* raise error in split when shuffle is False and random_state is not None

* removed MultiOutputEstimator

* removed base classes of NaiveBayes

* removed drop from pipeline

* removed utils in random_projection

* removed presort and classes_ in trees

* flake8

* fixed some tests

* flake

* fixed docstring

* fixed other one

* some left

* mmmm
2020-05-20 16:04:14 -04:00
Hugo Le Moine 8abe0a822e
MNT Replaced kwargs by named args for train_test_split (#17216) 2020-05-14 09:21:01 -04:00
Kyle Kosic b4e215c01c
FEA Additional `TimeSeriesSplit` Functionality (#13204)
Co-authored-by: Kyle Kosic <kylekosic@Kyles-MacBook-Pro.local>
Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
2020-05-11 21:48:01 -04:00
brigi dbc35934a6
DOC Version added and changed labels added for v0.18 (#wimlds) (#16222)
* Versionlabels added to v0.18 (#wimlds)

* documentation issues: label changed and added for version 0.18

* fix intends and shorten description

Co-authored-by: Hannah <32333241+hhnnhh@users.noreply.github.com>
Co-authored-by: Brigitte@home <unger@nue.tu-berlin.de>
2020-04-27 18:43:47 -04:00
Adrin Jalali 02309ffbda
API kwonly args in manifold, metrics, mixture, model_selection, multclass, multioutput (#16982) 2020-04-24 17:24:24 -04:00
Roman Yurchak 5a4340834d
Fix mypy errors (#16726) 2020-03-30 15:41:05 +02:00
Roman Yurchak 75d3f29e72
MAINT Remove outdated numpy and scipy backports (#16725)
* Remove unecessary numpy & scipy backports

* More fixes

* Remove unused imports
2020-03-20 13:57:18 +01:00
Edward Qian 0904058399
DOC improve random state docstring in model_selection/split (#15575) 2020-02-11 18:17:49 +01:00
Marielle d67647fcac DOC improve docstring following doc guideline in model_selection module (#16207) 2020-01-27 22:27:54 +01:00
Qizhi Jiang e3ee768a0c DOC Docstring improvements to confusion_matrix and splitters (#16072) 2020-01-11 18:42:10 +01:00
Madhura Jayaratne 1c422ca736 DOC Update docs to indicate shuffle=True still maintains sample order within each split (#16085) 2020-01-10 14:03:58 +11:00
Reshama Shaikh cc8d2d26b8 DOC add versionadded directive to some estimators (#15849) 2019-12-19 14:07:03 +01:00
Hanmin Qin 64750e561b DOC correct indents in docstring _split.py (#15843) 2019-12-10 14:46:57 +01:00
edvardlindelof 51edab8201 DOC clarify StratifiedShuffleSplit supports 2d y (#15456) 2019-11-02 15:31:40 -04:00
Nicolas Hug 19ad136223 MNT Replace DeprecationWarning with FutureWarning (#15080)
* bruteforce renaming

* WIP

* WIP

* some more

* removed weird line

* update -Werror

* testiforest

* again

* Fixed some tests

* fixed some tests

* removed -Werror

* fixed test_docstring_param issue

* fixed some tests

* some more

* renamed to SklearnDeprecationWarning

* pep8

* updated docs

* pep8

* merge

* changed to FutureWarning

* fixes

* Update doc/developers/tips.rst

Co-Authored-By: Adrin Jalali <adrin.jalali@gmail.com>

* avoid duplicates

* fixed warning for deprecations

* Still make CI break if DeprecationWarning isn't caught

* updated one warning

* fixed test

* fixed some renamings

* updated new dep warnings

* fixed bad import

* ignore warnings

* update again

* ignore futurewarning when walking packages

* Fixed test

* pep8

* Added whatsnew
2019-10-29 15:39:26 +01:00
Nicolas Hug 7effc37174
MNT Warn when shuffle is False but random_state is not None (#15353) 2019-10-24 16:33:12 -04:00
Nicolas Hug 96c988cdde
MNT Make safe_indexing private (#15104) 2019-10-02 11:47:46 -04:00
DrGFreeman ca9ceba558 FIX implement repr for RepeatedKFold and RepeatedStratifiedKFold (#14983) 2019-09-16 13:58:02 +02:00
Jesper Dramsch b99f4541d6 DOC Add example for GroupShuffleSplit (#14906) 2019-09-13 14:29:20 -04:00
Joel Nothman 3de368d405 FIX reimplement StratifiedKFold to avoid variation in test size (#14704) 2019-08-24 20:48:05 +08:00
Owen Flanagan cd20f1a5ba DOC Correct description of test_size in GroupShuffleSplit (#13441) 2019-08-11 20:27:10 +10:00
wolframalpha e90f11640f DOC fix in docstring of LeavePOut (#14517) 2019-07-30 15:26:11 +02:00
Roman Yurchak 2fc3a85b3f MAINT Use isinstance(x, numbers.Integral) to check for integer dtype (#14004) 2019-06-12 19:24:59 -04:00
Thomas J Fan 2e7e06b78f [MRG] Doctest with print change only adjusts default options for doctest (#13991) 2019-06-01 10:53:45 +02:00
Guillaume Lemaitre 9adba491a2 [MRG] DEP change the default of cv and n_splits (#13839) 2019-05-29 23:39:20 +10:00
Joel Nothman f3a6a1a6c8 TST avoid nose collecting train_test_split as a test (#13951) 2019-05-26 22:25:01 +03:00
Stephen Cowley 612a04e4e4 DOC Fix more formatting inconsistencies (#13787) 2019-05-05 22:05:58 +08:00
Nicolas Hug 14bdb9d7a8 FEA Add a stratify option to utils.resample (#13549) 2019-04-24 23:16:38 +02:00
jeremiedbb 358c6922f6 API/MNT Update default test_size of ShuffleSplit for 0.21 (#13483)
completing deprecation
2019-03-26 09:33:19 +11:00
Nicolas Hug 2718d6212f ENH Raise ValueError when trainset is empty in CVSplitters (#12861) 2019-03-22 23:04:10 -04:00
Owen Flanagan f4e5224500 DOC parameter applies to groups not samples. (#13414) 2019-03-12 22:43:30 +11:00
Andreas Mueller d879b5cdbe MNT be more friendly in the deprecation warning of cv=3 (#13395)
* be more friendly in the deprecation of cv=3

* add hint on specifying cv

* catch all the right warnings
2019-03-05 19:28:34 +01:00
Hanmin Qin afc6cc58da FIX Shuffle each class's samples with different random_state in StratifiedKFold (#13124)
* Enable StratifiedKFold to produce different splits

* what's new

* redundant statement

* update what's new

* redundant comment

* add a test

* move what's new entry

* review comment

* review comment
2019-02-27 14:31:21 +01:00
Roman Yurchak 0e3bb17e62 MAINT Run pyupgrade following Python2 deprecation (#12997) 2019-02-08 20:13:34 +08:00
surgan12 62d2059804 MNT remove __future__ imports (#12791) 2019-02-02 22:05:06 +08:00
Prabakaran Kumaresshan 41aa3edd78 MNT Remove build_tools/windows/windows_testing_downloader.ps1 (#12974) 2019-01-15 09:28:51 +01:00
Rüdiger Busche d300f406ae MAINT Simplify super() calls (#12812) 2019-01-10 22:27:06 +01:00
Roman Yurchak 701144559f MAINT Remove unused utils.fixes (#12928)
This continues the work done in https://github.com/scikit-learn/scikit-learn/pull/12639 on dropping the python 2 support by,
 - ~~removing unnecessary `from __future__` imports~~
 - removing unused `sklearn.utils.fixes` assuming we can agree in https://github.com/scikit-learn/scikit-learn/issues/12927 that `sklearn.utils.fixes` are private as was stated e.g. in https://github.com/scikit-learn/scikit-learn/issues/6616#issuecomment-245109979
2019-01-08 12:43:49 +11:00
Andreas Mueller 952ef6637a MRG Drop legacy python / remove six dependencies (#12639) 2019-01-03 15:50:05 +02:00
Dowon 0e5feb6bf7 DOC improving import convenience in class examples (#12846) 2018-12-23 09:37:43 +08:00
Dror Atariah 440c08684f FIX Add more validation for size parameters in train_test_split (#12733)
* Fixed typo in an example

* Removed un-needed lines from example

* Added tests on the validity of parameters

* Fixed error msg for train_size issue

* Added tests to check the validation of test and train sizes

* Switched to parameterized test

* Fixed typo in error msg

* Swithced to pytest.raises

* Swithced to pytest.raises also when checking msg

* Improved the validity tests and their unit testing
2018-12-19 12:36:53 +01:00
Adrin Jalali 2bd87f6ed8 Remove python < 3.5 from CI (#12746) 2018-12-14 10:53:12 +01:00
Sam Waterbury 1d579556d2 DOV consistency of parameters for GroupKFold and LeaveOneGroupOut (#12581) 2018-11-18 10:05:48 +11:00
Quentin Batista 4b78d7abf4 DOC: Clarify `cv` parameter description in `GridSearchCV` (#12495)
#### Reference Issues/PRs
<!--
Example: Fixes #1234. See also #3456.
Please use keywords (e.g., Fixes) to create link to the issues or pull requests
you resolved, so that they will automatically be closed when your pull request
is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests
-->

This PR addresses issue #12466.

#### What does this implement/fix? Explain your changes.

This PR does the 3 following things:
- Rewrite the `cv` parameter description in `GridSearchCV`
- Link the new `CV splitter` description to an existing example
- Add an example with a custom iterable

Thanks for reviewing this!

Close #12466
2018-11-12 15:10:15 -05:00
Guillaume Lemaitre 5431a1a9bf BUG: check equality instead of identity in check_cv (#12155) 2018-09-25 19:00:27 +08:00
Zijie (ZJ) Poh 41178cd62d DOC Fix: require n_splits > 1 in TimeSeriesSplit (#11937) 2018-08-29 17:51:46 +10:00
Hanmin Qin 5533deb8e0 [MRG] FIX Support cv=None in *CV (#11761) 2018-08-07 11:53:59 +10:00
ZJ Poh adddf00433 [MRG] np.ones -> np.full (#11628) 2018-07-23 09:49:01 +02:00
Alexandre Boucaud f158e2dfe2 [MRG+1] Change CV defaults to 5 (#11557)
* add FutureWarning for methods with defaults=3

* add explicit cv values to fix assertion errors

* add tests for catching the FutureWarning

* Write current deprecation version

* Add deprecation in docstring

* change default cv value to None

* change cv from 3 to 5 in the examples

* upgrade doctests

* update doctest in tutorial

* update doctest in cross-validation doc

* fix tests

* add entry to whats new

* address Gael comments

* address Gael comments 2

* fix wrong indentation

* update doc

* add docstring deprecation warning in CV subclasses

* address Andy's comments

* fix PR number

* fix flake8

* add filterwarnings in tests

* fix doctests

* cv=None mendatory in Ridge

* fix warning related errors

* skip some doctests warnings

* make travis happy

* change from deprecated to versionchanged

* fix doctests and remove skipping

* address comments
2018-07-19 14:46:11 +02:00