Commit Graph

41 Commits

Author SHA1 Message Date
adrinjalali c9ca1d7d32
Revert "ENH Uses binned values from training to find missing values (#16883)"
This reverts commit e5cc2b0e20.
2020-06-25 15:42:37 +02:00
Thomas J. Fan e5cc2b0e20
ENH Uses binned values from training to find missing values (#16883)
* ENH Uses training data to find missing values

* CLN Uses the binned data to find missing value
2020-06-25 14:24:12 +02:00
simonamaggio a109dff722
DOC add missing attributes in HistGradientBoostingRegressor (#17677)
Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-06-24 19:27:07 +02:00
Chiara Marmo 5ea5da4ae4
DOC add missing attributes in HistGradientBoostingClassifier (#17678)
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
2020-06-24 19:15:37 +02:00
Hao Chun Chang f58c2bc2df
FEA Add staged_predict to HistGradientBoosting (#16985) 2020-05-17 10:02:34 -04:00
Christian Lorentzen a93b15f19b
ENH Poisson loss for HistGradientBoostingRegressor (#16692) 2020-04-23 10:27:35 -04:00
Geoffrey Bolmier 9d366a4f74
ENH Add custom loss support for HistGradientBoosting (#16908) 2020-04-15 13:38:22 -04:00
Lucy Liu 9a4bd3702d
DOC replace Boston in gradient_boosting.py (#16891) 2020-04-10 13:10:34 -04:00
Thomas J Fan 37776a0506
CLN Removes unneeded code in histgradientboosting (#16820) 2020-04-01 13:42:03 -04:00
Adrin Jalali 97a6b08544
API make __init__ args in ensemble kwonly (#16724) 2020-04-01 06:35:37 +11:00
Nicolas Hug 36ebf3e371
[MRG] Monotonic constraints for GBDT (#15582) 2020-03-24 20:27:00 +01:00
Thomas J Fan cdbda0eddb
BUG Fixes HistGradientBoosting when warm_start is on + early_stopping is on + no validation (#16663) 2020-03-11 09:39:25 +01:00
Alex Henrie 438bb3a438
MNT Remove unused imports (#16665) 2020-03-11 10:01:51 +11:00
Nicolas Hug d205638475
MNT Introduction of n_features_in_ attr with _validate_data mtd (#16112) 2020-02-29 09:05:11 -05:00
Adrin Jalali e24998f19c
ENH Support sample weights in HGBT (#14696) 2020-02-24 13:45:50 -05:00
Johann Faouzi ee6b369b82
FEA Turn on early stopping in histogram GBDT by default (#14516) 2020-02-12 10:45:21 -05:00
Oleksandr Pavlyk 32d333501d
DOC Docstring example of classifier should import classifier (#16430) 2020-02-11 12:00:17 -05:00
judithabk6 05476a1d38
TST Add test for documentation of the classes_ attribute (#16277)
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
2020-01-31 14:12:43 +01:00
Pierre Delanoue 9c2d889d1f
Update random_state gradient_boosting doc (#16315) 2020-01-30 17:06:05 +01:00
SanthoshBala18 cc2fbeddfa BUG max_depth=1 should be decision stump in HistGradientBoosti… (#16182) 2020-01-28 13:07:42 -05:00
Thomas J Fan 1c546cd9b1 CLN Move gradient and hessian closer to for loop in hist GBDT (#15686) 2019-11-20 16:03:25 -05:00
Nicolas Hug 97958c174f FIX fix bug when warm starting with early stopping in Hist GBDT (#15624) 2019-11-15 11:02:38 +01:00
Natasha Borders 3ca653af12 DOC adding versionadded labels to several estimators (#15476) 2019-11-04 18:25:24 +11:00
Adrin Jalali 0eebade264 DOC docstring (shape= -> of shape) (#14640) 2019-10-02 20:54:32 -04:00
Chiara Marmo 6bd8df099f DOC Fix warnings about references and links (#14976) 2019-09-23 11:49:08 -04:00
Adrin Jalali 38af35db9c FIX raise error when using categorical_crossentropy in binary problem in HGBDT (#14869) 2019-09-20 10:23:34 +02:00
Johann Faouzi 78c06e504c [MRG] MNT Use one single random seed for warm start and subsampling in HGBDT (#14999) 2019-09-19 09:33:36 -04:00
Nicolas Hug 5cf88db244 EHN Implement least absolute deviation loss in GBDTs (#13896) 2019-09-09 10:26:52 +02:00
Andreas Mueller 03ea20db0f Fix mixin inheritance order, allow overwriting tags (#14884) 2019-09-05 10:13:30 +02:00
Guillaume Lemaitre 947dffcc9c FIX encode target for scoring when using early stopping in HistGradientBoostinClassifier (#14710)
* FIX encode target for scoring when using early stopping in HistGradientBoostingClassifier

* add line

* reviews
2019-08-22 15:22:38 +02:00
Nicolas Hug 4b6273b874 ENH Native support for missing values in GBDTs (#13911)
* Added NaN support in mapper

* pep

* WIP

* some more

* WIP

* WIP

* bug fix

* basic tests

* some doc

* avoid some interactions

* Added tag

* better test

* decent test + fix bug

* add missing_fraction param to benchmark

* bin training and validation data separately

* shorter test

* Map missing values to first bin instead of last

* pep8

* Added whats new entry

* avoid some python interactions

* make predict_binned work

* fixed bug due to offset in bin_thresholds_ attribute

* more sensible binning strat

* typo

* user name

* Add small test

* convert to fortran array in tests

* some doc

* Added function test

* pep8

* Bin validation data using binmaper of training data

* Allocate first bin for missing entries based on the whole data, not just
training data.

* Addressed Thomas' comments

* Update sklearn/ensemble/_hist_gradient_boosting/tests/test_grower.py

* Addressed Guillaume's comments

* always allocate first bin for missing values

* reduce diff

* minor more consistent test

* typo

* WIP

* some doc

* reduce diff

* pep8

* minor

* remove prints

* towards nan only splits

* don't check right to left on split_on_nan

* cleaups

* format and comment

* Fixed bug + added more tests

* refactor tests

* put back n_threads to max value

* minor changes

* minor cleaning

* Add (failing) test that checks equivalence with min max imputation

* Decrease the likelihood of ties when training the trees

* More robust test

* Fix pytest parametrization

* Check bin thresholds in test

* Try to make the test even easier to see if the Linux 32bit build would pass in this case

* Don't check last non-missing bin if there's no nan

* Improve min-max imputation test

* FIX: _find_best_bin_to_split_right_to_left is still required even when left to right wants to split on nans

* comments

* remove split_on_nan

* ooops deleted useless files

* Got rid of individual checks in predictor code

+inf thresholds are only allowed in a split on nan situation.
Thresholds that are computed as +inf are capped to a very high constant
value

* can also remove special case in binning code

* minor typos + more consistent test

* renamed types -> common

* 1e300 -> almost inf

* added user guide section on missing values

* Addressed Olivier's comment + updated whatsnew

* addressed comments

* Fix doctest formatting

* Fix nan predictive doctest
2019-08-21 11:22:00 +02:00
Andreas Mueller 92af3dabbb MAINT simplify check_is_fitted to use any fitted attributes (#14545) 2019-08-13 22:09:07 +02:00
Nicolas Hug 2df846281f DOC User guide section for histogram-based GBDTs (#14525)
* User guide for histogram based GBDTs

* Added backlinks to user guide in classes

* typos

* Roman's comments

* reduce diff

* Update doc/modules/ensemble.rst

* Addressed comments

* Added why it's faster explanation

* references at the end

* Update doc/modules/ensemble.rst

* Update doc/modules/ensemble.rst

* Update doc/modules/ensemble.rst

* added where code is parallel

* removed missing values section
2019-08-05 18:57:36 +02:00
Nicolas Hug dd78658d25 [MRG] Support for infinite values in GBDTs (#14406) 2019-07-19 14:58:53 +02:00
Nicolas Hug 0eaaeafd1b EHN Fast PDPs for histogram-based GBDT (#13769) 2019-07-11 14:52:55 +02:00
Johann Faouzi db2342f416 [MRG] Use resample to compute the small training set in HistGBT (#14194) 2019-07-08 09:57:02 +02:00
Adrin Jalali 71bc5ab38d MNT use relative imports in hist-gradient-boosting (#14211) 2019-06-28 11:04:58 -04:00
Johann Faouzi da96da96f0 EHN Add warm_start parameter to HistGradientBoosting (#14012) 2019-06-21 15:18:24 +02:00
Johann Faouzi 227ebc4815 DOC fix the default value of learning_rate in docstring of HistGBC. (#14072) 2019-06-12 15:09:21 +02:00
Nicolas Hug 2a7194de7a FIX Bin training and validation data separately in GBDTs (#13933) 2019-05-28 10:46:41 -04:00
Nicolas Hug 9f68c992ae [MRG+2] Faster Gradient Boosting Decision Trees with binned features (#12807) 2019-04-26 21:14:59 +02:00