Commit Graph

279 Commits

Author SHA1 Message Date
Rüdiger Busche d300f406ae MAINT Simplify super() calls (#12812) 2019-01-10 22:27:06 +01:00
Andreas Mueller 952ef6637a MRG Drop legacy python / remove six dependencies (#12639) 2019-01-03 15:50:05 +02:00
Thomas Moreau d25da1be20 FIX make joblib utils private, and remove mentions of externals.joblib (#12345) 2018-11-20 10:53:52 +11:00
Joel Nothman 1128094271 BLD we should ensure continued support for joblib 0.11 (#12350) 2018-11-06 22:10:23 +01:00
Pierre Glaser f24e3000b8 Impose shared memory when fitting a SGDClassifier (#12498) 2018-11-05 15:38:15 +01:00
Nicolas Hug 4e2da4af92 [MRG] Added FutureWarning in sgd models for tol parameter (#12399)
* Added ChangedBehaviorWarning in sgd models

if tol is None while max_iter is set

* Changed to FutureWarning and clarified None meaning

* Ignored warningin tests

* Ignore warnings in tests, round 2
2018-10-24 11:00:43 -04:00
Matthew Roeschke 5af272ac61 MNT Remove unused variables (#12230) 2018-10-22 12:48:40 +11:00
Olivier Grisel 7d72720ee8
[MRG] Crash when using SGDClassifier with early stopping in a parallel grid search (#12122) 2018-09-26 12:04:11 +02:00
Andreas Mueller aa53493e86 fix typo 2018-09-14 13:29:35 -04:00
Hanmin Qin 9b8fd0b0d0 DOC Correct default n_jobs & reference the glossary (#11808)
Also improves the glossary entry for n_jobs.
2018-08-18 19:57:10 +10:00
Oren Milman 6e97763298 fix the docstring (#11789) 2018-08-10 11:25:40 -07:00
Olivier Grisel 40e6c43cb4
Joblib 0.12.2 (#11741)
* joblib 0.12.2

* Export _joblib's register_parallel_backend

* Use latest version of coverage
2018-08-03 12:34:25 +02:00
Andreas Mueller 8e2c2aa35d
raise DeprecationWarnings and FutureWarnings as errors (#11570)
Towards #11252.
In the end we'd like to make these errors so we can keep this cleaner in the future.
2018-07-17 15:31:45 -05:00
Joel Nothman 14e7c328df Restructure access to vendored/site Joblib (#11471)
In order to fix #11408, this swaps `joblib` and `_joblib`. It however, allows users to access joblib's `Memory` or `Parallel` functionality without accessing `sklearn.externals._joblib` by importing `Memory`, `Parallel`, etc. into `sklearn.utils`.
2018-07-17 18:02:11 +02:00
Nicolas Hug e860fd2d12 DOC parameters for gaussian_process and linear_model modules (#11415) 2018-07-15 16:06:05 +10:00
Tom Dupré la Tour 0fc7ce6bb8 [MRG+1] Add a stopping criterion in SGD, based on the score on a validation set (#9043) 2018-07-05 16:25:34 +02:00
Joel Nothman a7e17117bb [MRG] Large sparse matrix support (#11327) 2018-06-25 15:15:11 +00:00
Aniruddha Dave 5d9a686be1 FIX: predict_proba and predict_log_proba access before fit in SGDClassifier (#10961) 2018-04-17 07:26:50 +02:00
Mohamed Ali Jamaoui 58f84694a8 DOC Add reference to the glossary in the warm_start parameter description of public APIs (#10699) 2018-02-26 20:21:17 +08:00
Andreas Mueller 90a05845a2 make SGDClassifier deprecation warnings nice again (#10286) 2017-12-12 04:52:10 +01:00
Matthias Feurer 57bcd075c3 DOC add docs about sgd and warmstarting (#10011) (#10087)
In particular, clarify for SGDClassifier, SGDRegressor,
PassiveAggressiveClassifier and PassiveAggressiveRegressor how
the attribute warm_start and the methods `fit` and `partial_fit`
interact.

Fixes #10011
2017-11-29 22:10:28 +11:00
siftikha f485a9edf9 [MRG+1] fix for erroneous max_iter and tol warnings for SGDClassifier when using partial_fit (#10053)
* partial fit warnings disabled

* partial fit warnings disabled for regressor

* style improved

* tests added

* pycodestyle passing

* rejiggered format

* fixed style issues
2017-11-15 13:38:59 -08:00
Hanmin Qin 9092347b48
DOC Fix dead links in SGD (#10109) 2017-11-11 16:29:56 +08:00
Andreas Mueller 1f2f167e3b make warning look way nicer in SGDClassifier (#10050) 2017-11-02 11:27:06 +01:00
Vinit 71402efc2f [MRG] DOC Fix default learning_rate in SGDRegressor docstring (#10018)
* [MRG] Fix learning_rate in SGDRegressor docstring(#10012)

* Update SGDRegressor's learning_rate [default]

* Removed pep8 error

* Restored blank line

* Resolved pep8 error
2017-11-02 16:06:05 +08:00
Vrishank Bhardwaj 5f863aa991 ENH avoid FutureWarning in BaseSGD.set_params (#9802) 2017-09-27 14:39:33 +10:00
Albert Thomas 45dc891c96 [MRG+2] Clean common tests (#9340)
* rm dupes

* add check_supervised_y_no_nan in classifier checks: this implies changes for Ridge classifiers

* fix docstrings/comments

* FIX check fitting 1d X array raises error and FIX check fitting 2d array with only 1 feature either works or returns informative message

* modify check_fit2d_1sample in common tests so that it checks fitting either works or returns an informative message

* rm SpectralClustering case for the moment

* uniformize error messages for 1 sample case and fix SpectralClustering with ensure_min_samples=2

* add unit test for mean_shift when n_samples * quantile < 1

* FIX travis with ensure_min_samples=2 in _PLS

* try fix for failing tSNE test

* typos

* take @agramfort's review into account

* sc to fix string in gaussian_process

* add the class that is present to preserve information of previous message in gpc.py
2017-09-26 18:13:15 +02:00
Andreas Mueller c7ca0c58ee [MRG+1] FIX n_iter -> max_iter conversion in SGDClassifier (#9558)
* move n_iter -> max_iter conversion and warning into _check_params in SGDClassifier for proper deprecation.

* move validate_params so we have self._max_iter in _fit

* validate params in init because the tests wants me to

* better check for input validation

* fix deprecation tests to call _validate_params

* fix parameter validation in PA classifier

* fix max_iter in doctests

* pep8 /doctest whitespace

* more doctests

* maybe I'll find them all....
2017-08-16 16:25:53 -07:00
(Venkat) Raghav, Rajagopalan b6f8865b0a [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (#9206)
* add automatic test of docstrings for function / method signatures using numpydoc
2017-07-11 18:42:10 +02:00
Andreas Mueller 5271a193c3 MRG Sphinx fixes (#9155) 2017-06-28 17:00:13 +02:00
Alexandre Gramfort 733e92dfa6 typo in message in sgd 2017-06-25 18:34:14 +02:00
Tom Dupré la Tour edeb3af217 Deprecate n_iter in SGDClassifier and implement max_iter (#5036) 2017-06-23 21:49:29 +02:00
Naoya Kanai 6579220588 [MRG+1] Drop NumPy < 1.8 (#8874) 2017-06-07 17:06:06 +02:00
Guillaume Lemaitre e3c9ae204f [MRG+1] DOC improve description and consistency of random_state (#8689)
* DOC improve description of random_state in train_test_split

* DOC Make random_state consistent through documentation

* FIX reverse doc mistake

* FIX address comment of Tom

* DOC address comments

* DOC remove empty line

* DOC remove unecessary white spaces
2017-04-05 17:43:21 -07:00
Ekaterina Krivich be305cebaf TST/FIX Add check for estimator: parameters not modified by `fit` (#7846)
ensure that estimators only add private attributes and attributes with
  trailing _

  in cases when existing estimators don't follow this new rule, we deprecate the
  attributes and make them follow this rule
2017-01-20 11:33:17 +11:00
Loïc Estève e542efafe2 TST Ensure that attributes ending _ are not set in __init__ (#7464) 2016-12-12 21:57:43 +11:00
Andreas Mueller 5c4b1bb231 [MRG+1] Housekeeping Deprecations for v0.19 (#7927)
* remove stuff to be removed 0.19

* more changes

* remove classes from 0.19 whatsnew

* remove _LearntSelectorMixin

* remove ProjectedGradientNMF, load_lwf_*

* minor fixes

* remove more copy from logistic regression path

* remove lda, qda from __init__.__all__

* remove pg solver in nmf from tests etc

* remove class_weight="auto" from tests

* doctest change for decision_function_shape="ovr"

* remove transfrom from tree test, minor fixes to tree tests

* some fixes in the tests

* undo changes in functions which still allow 1d input...

* also allow 1d in scale

* more test fixes...

* last test fixes in forest and tree

* svm default value change doctest failures

* pep8

* remove more class_weight="auto" stuff

* minor cosmetics in docstrings deprecated / removed behavior.

* say that store_covariance has been moved to __init__ in discriminant_analysis
2016-12-09 12:43:38 -05:00
Olivier Grisel ebb0645966 DOC reference CalibratedClassifierCV in SGDClassifier.predict_proba (#7281) 2016-08-29 21:44:27 +10:00
Joel Nothman 55de9bb30c DOC improve formatting for learning_rate docstrings 2016-08-17 15:13:15 +10:00
seales 0485ada58b General spelling fixes 2015-12-16 09:46:42 -08:00
Andrew Lamb 176427e284 Fix SGD partial_fit multiclass w/ average.
See https://github.com/scikit-learn/scikit-learn/issues/5246#issuecomment-140062688.

`_fit_multiclass` was setting `self.intercept_` to a single element of the intercept, instead of the entire intercept.
2015-10-07 11:39:57 +02:00
Alexandre Gramfort e7c50de502 misc + pep8 2015-10-04 16:27:12 +02:00
Rohan Ramanath f8486a5b25 fixes scikit-learn/scikit-learn#5329 2015-10-01 21:42:27 -07:00
TomDLT 94eb61960a ENH add sag solver in LogisticRegression and Ridge 2015-09-10 13:28:02 -04:00
Joel Nothman 87aaabc06a DOC backticks in attribute docstrings unnecessaru since #3489 2015-06-12 05:13:02 +10:00
Andreas Mueller 3be9b9762b Fix deprecation of decision function in SGD 2015-06-04 16:50:56 -04:00
Andreas Mueller 0650d5502e DOC adding backlinks to docstrings 2015-06-03 00:24:04 -04:00
Andreas Mueller eedc1cddab Use more natural class_weight="auto" heuristic 2015-06-01 12:49:53 -04:00
TomDLT 89c1018c64 ENH improve check_array
ENH improve check_array to warn on dtype conversions

ENH make check_array accept several dtypes

ENH change validation with improved check_array

ENH change astype to avoid copy if possible

ENH remove warn_if_not_float
2015-05-19 16:13:42 +02:00
Andreas Mueller d89c215013 Add tags to classifiers and regressors to identify them as such. 2015-03-31 19:59:49 -04:00