Commit Graph

33 Commits

Author SHA1 Message Date
Andreas Mueller 952ef6637a MRG Drop legacy python / remove six dependencies (#12639) 2019-01-03 15:50:05 +02:00
Adrin Jalali dd700f44df MNT hasattr->getattr on coef_ (#11698) 2018-08-12 17:20:14 +10:00
Nihar Sheth 211ded8fbc [MRG+1] Select k-best features in SelectFromModel (#9616)
#### Reference Issue
Continuation of work from [PR #6717](https://github.com/scikit-learn/scikit-learn/pull/6717).


#### What does this implement/fix? Explain your changes.
Will merge in master (this branch is a year old) and make changes as discussed in previous PR discussion to make it ready for merging in.
2018-07-16 14:15:25 -05:00
Joel Nothman c3bdc0a89a
DOC clean up assorted type specifications (#10441) 2018-01-11 09:11:17 +11:00
James Bourbeau c5c51c6c40 Updates SelectFromModel docstring to detail supported estimators (#9238)
* Updates SelectFromModel docstring

* Updates docstring
2017-06-28 13:39:27 +10:00
Naoya Kanai 6579220588 [MRG+1] Drop NumPy < 1.8 (#8874) 2017-06-07 17:06:06 +02:00
Andreas Mueller 1c41368bac [MRG+1] Uncontroversial fixes from estimator tags branch (#8086)
* some bug fixes.

* minor fixes to whatsnew

* typo in whatsnew

* add test for n_components = 1 transform in dict learning

* feature extraction doc fix

* fix broken test

* revert aggressive input validation changes

* in SelectFromModel, don't store threshold_ in transform. If we called "fit", use estimates from last "fit".

* move score from EllipticEnvelope to OutlierDetectionMixin

* revert changes to Tfidf documentation

* remove dummy input validation from whatsnew

* fix text feature tests

* rewrite from_model threshold again...

* remove stray condition

* fix self.estimator -> estimator, slightly more interesting test

* typo in comment

* Fix issues in SparseEncoder, add tests.
more explicit explanation of SparseEncoder change, add issue numbers to whatsnew

* minor fixes in whats_new.rst

* slightly more consistency with tuples for shapes

* not longer typo
2017-06-06 16:34:47 +02:00
Tahar 6f771d5186 [MRG] Remove unnecessary backticks around parameter name in docstrings (#8432) 2017-02-22 16:17:04 +01:00
Andreas Mueller 5c4b1bb231 [MRG+1] Housekeeping Deprecations for v0.19 (#7927)
* remove stuff to be removed 0.19

* more changes

* remove classes from 0.19 whatsnew

* remove _LearntSelectorMixin

* remove ProjectedGradientNMF, load_lwf_*

* minor fixes

* remove more copy from logistic regression path

* remove lda, qda from __init__.__all__

* remove pg solver in nmf from tests etc

* remove class_weight="auto" from tests

* doctest change for decision_function_shape="ovr"

* remove transfrom from tree test, minor fixes to tree tests

* some fixes in the tests

* undo changes in functions which still allow 1d input...

* also allow 1d in scale

* more test fixes...

* last test fixes in forest and tree

* svm default value change doctest failures

* pep8

* remove more class_weight="auto" stuff

* minor cosmetics in docstrings deprecated / removed behavior.

* say that store_covariance has been moved to __init__ in discriminant_analysis
2016-12-09 12:43:38 -05:00
Andreas Mueller 9667ff292f [MRG + 2] Fixed parameter setting in SelectFromModel (#7764)
* Fixed cloning ``estimator`` again when calling fit a second time in SelectFromModel

* fix link in whatsnew
2016-11-09 20:34:04 +01:00
Antoine Wendlinger 74a9756fa7 [MRG+2] Norm inconsistency between RFE and SelectFromModel (was _LearntSelectorMixin) #2121 (#6181)
* Norm inconsistency between RFE and SelectFromModel (was _LearntSelectorMixin) #2121

* safe_pwr utility

* Norm fix

* Removed safe_pwr

* 1D arrays support for norm fix

* Test case for 2d coef in SelectFromModel

* Fix numpy version requirement for norm fix

* Implement fixes suggested by @jnothman

* Add numpy version requiring the fix.
2016-10-24 14:01:49 -04:00
fukatani 3a106fc792 Fix _get_importances. (#7487)
Not to use hasattr.
2016-09-25 11:48:04 -07:00
Joel Nothman 62ad5fed90 FIX Revert unintentionally committed code 2016-09-08 18:47:02 +10:00
Joel Nothman 22e43054fc TST fix test to match altered deprecation msg 2016-09-08 10:29:06 +10:00
Mark Szepieniec 0a094b90e8 Fix grammar bug in docstring of SelectFromModel 2016-04-06 17:37:40 +01:00
seales 0485ada58b General spelling fixes 2015-12-16 09:46:42 -08:00
KamalakerDadi f2e35411fa Added more versions of 0.17 2015-11-04 00:02:52 +01:00
Raghav R V e3afc0e8c9 MAINT move custom error/warning classes into sklearn.exceptions
ENH NonBLASDotWarning -> EfficiencyWarning; Improve error message
DOC Add exceptions module to modules/classes.rst
MAINT Move ConvergenceWarning, UndefinedMetricWarning et al into exceptions
MAINT Remove ChangedBehaviorWarning from base
DOC/FIX Improve DataConversionWarning's docstring
2015-10-19 22:35:35 +02:00
MechCoder c805fbc79b Refactor tests 2015-10-10 22:05:40 -04:00
MechCoder 5a0db1717a 1. Added parameter prefit to pass in a fitted estimator.
2. Use assert_warns instead of catch_warnings
3. Remove depracation warnings in common tests.
2015-10-09 01:57:36 -04:00
MechCoder acf5f160a8 Merge SelectFromModel and L1-selection examples
Add test to check the threshold can be set without refitting
2015-10-05 11:25:07 -04:00
MechCoder 2ee718cc75 Add narrative docs and fix examples 2015-10-05 11:25:06 -04:00
MechCoder 10176d9897 Now a fitted estimator can be passed to SelectFromModel 2015-10-05 11:25:06 -04:00
MechCoder 3d41053d67 Minor doc changes and removed _set_threshold and _set_importances 2015-10-05 11:25:06 -04:00
MechCoder 9cee0d95f8 Added example to depict feature selction using SelectFromModel and Lasso 2015-10-05 11:24:02 -04:00
MechCoder 459cb9ba3d Remove warm start 2015-10-05 11:19:57 -04:00
MechCoder 8a28ea8169 fix test failures 2015-10-05 11:19:57 -04:00
maheshakya c438f78996 Implemented SelectFromModel meta-transformer 2015-10-05 11:19:57 -04:00
Raghav R V abd31d2cad MAINT Make uniform the error raised for not fitted condition 2015-01-12 00:33:40 +05:30
Andreas Mueller 87b23ba18a DOC explain SelectorMixin strategy with multiple classes. 2014-11-05 16:29:58 -05:00
Lars Buitinck 2fca6ce244 MAINT remove deprecated code from trees and forests 2014-07-22 15:52:48 +02:00
Andreas Mueller 6e2a83b4e1 remove check_arrays stuff and old input validation 2014-07-20 13:31:45 +02:00
Joel Nothman 9a8845e913 ENH Create FeatureSelectionMixin for shared [inverse_]transform code
Also rename FeatureSelectionMixin -> SelectorMixin -> _LearntSelectorMixin
And rename sklearn.feature_selection.{selector_mixin -> from_model}
2013-05-21 13:53:12 +10:00