Commit Graph

88 Commits

Author SHA1 Message Date
Thomas Fan 625dafe1dc DOC Update contributing style (#12998) 2019-01-17 17:43:16 +08:00
Jérémie Méhault 41a2174fde DOC: add install mode to contribute (#12850) 2019-01-10 09:03:37 +11:00
Hanmin Qin cdfb5728fb DOC Update note on code contribution: use issue tracker not mailing list (#12917) 2019-01-08 07:00:55 +11:00
Gael Varoquaux 301c18e310 DOC How to deal with stalled PR (#12894) 2019-01-05 22:47:44 +08:00
Andreas Mueller 952ef6637a MRG Drop legacy python / remove six dependencies (#12639) 2019-01-03 15:50:05 +02:00
Nicolas Hug fda8f4786d DOC Added tips for reading the code base (#12874)
* Added tips for reading the code base

* Put it in contributing.rst

* Added bullet point about inheritance
2018-12-31 18:37:57 +01:00
Andreas Mueller 3c6ab5fa8e DOC link to dev docs instead of contributing docs in the menu (#12885) 2018-12-29 09:11:13 +08:00
Albert Thomas d6095eb036 DOC add sentence about line length of rst files (#12883) 2018-12-28 17:46:37 +02:00
Reshama Shaikh 552a88e7f8 DOC Shorten and improve CONTRIBUTING.md (#12801)
* Reuse intro from contributing.rst

* Removed content already on rst

Simplified CONTRIBUTING.md by removing content that already
exists in contributing.rst. Added Code of Conduct reference
as seen in a few other CONTRIBUTING.md of popular libraries.

* Update contributing.rst

In shortening `CONTRIBUTING.md`, material deleted from `how to contribute` section are added onto `contributing.rst` if it doens't exist on the latter.

* added full link to .rst file + removed 'Full' in 'Full Docum...'
2018-12-19 11:14:01 +01:00
Hanmin Qin 037ee933af DOC (0.21) update Circle CI doc 2018-12-15 23:46:06 +08:00
Adrin Jalali 0be2d7356d DOC update min required versions in some remaining docs (#12778) 2018-12-14 21:10:45 +08:00
Adrin Jalali dbd28e70be DOC add joblib to doc-build deps (#12691) 2018-11-29 09:40:28 +11:00
Roman Yurchak 66507a25a4 MAINT Use CircleCI for linting (#12606) 2018-11-19 11:00:55 +08:00
Federico Caselli d42d0d7ae4 DOC fix broken link in doc/developers/contributing.rst (#12508) 2018-11-02 17:30:15 +01:00
Nicolas Hug bea1eb51b3 [MRG] Clarified indempotence of fit (#12305)
<!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist
-->

#### Reference Issues/PRs
<!--
Example: Fixes #1234. See also #3456.
Please use keywords (e.g., Fixes) to create link to the issues or pull requests
you resolved, so that they will automatically be closed when your pull request
is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests
-->


#### What does this implement/fix? Explain your changes.

As far as I understand it, the fact that `fit` is idempotent means that repeated calls to `fit` with the same data doesn't change the estimator.

The contributing guide was a bit unclear about this.

#### Any other comments?


<!--
Please be aware that we are a loose team of volunteers so patience is
necessary; assistance handling other issues is very welcome. We value
all user contributions, no matter how minor they are. If we are slow to
review, either the pull request needs some benchmarking, tinkering,
convincing, etc. or more likely the reviewers are simply busy. In either
case, we ask for your understanding during the review process.
For more information, see our FAQ on this topic:
http://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.

Thanks for contributing!
-->
2018-10-16 16:00:52 -04:00
TakingItCasual 1e052e9da9 Converting http to https (2)... (#12292) 2018-10-04 23:06:14 +02:00
TakingItCasual 74b56dbc57 MNT Converting http to https (#12277) 2018-10-04 22:37:57 +08:00
TakingItCasual e9cdb5588b MNT Updated PyPI URLs (#12274) 2018-10-04 15:55:34 +08:00
janvanrijn ab82f5739f [MRG] Openml data loader (#11419) 2018-08-15 17:21:20 +10:00
Alexandre Boucaud b21f9b4f98 MNT Add sklearn show_versions() method (#11596) 2018-08-01 09:12:51 +10:00
Ronan Lamy 5592a2eda9 [MRG] PyPy support for all but a couple of estimators (#11010) 2018-07-20 14:39:53 +10:00
Hanmin Qin 58fa28e3e5 DOC Typo in contributing.rst 2018-07-17 16:47:50 +08:00
Hanmin Qin bb0dd8290b DOC Typo in contributing.rst 2018-07-17 10:15:21 +08:00
Hanmin Qin 2716c8e4df DOC: Instructions for changing default value of a certain parameter (#11469) 2018-07-16 17:12:03 +02:00
Andreas Mueller b25e222328 MNT misc sphinx website build fixes and dead links (#11532) 2018-07-16 09:13:20 +08:00
Nicolas Hug 23b0d484d2 DOC Consistent shape indications in contributing.rst (#11457) 2018-07-14 20:25:02 +08:00
Nicolas Hug bf9e405311 DOC clearer doc in contributing guidelines (#11404) 2018-07-03 11:53:08 +08:00
Andreas Mueller a320c085b7 DOC clean up installation doc organization (#10698) 2018-06-29 07:44:51 +10:00
Joel Nothman 5a9ce9fe3f CI fix scipy-dev build for good (#11377)
Also add commit flag [scipy-dev] to run scipy-dev build in Travis, which is very useful in a PR
to make sure that the scipy-dev passes.
2018-06-28 16:49:51 +02:00
Joel Nothman fdb3c7c556 [MRG] DOC encourage contributors to look at related projects too (#11335) 2018-06-21 13:55:19 +02:00
Joel Nothman 14764061f8
[MRG] DOC fix some sphinx warnings (#11241) 2018-06-21 20:43:21 +10:00
twosigmajab 0612769b2c DOC replace OpenHub/ohloh badge with star button (#11288) 2018-06-16 11:53:30 +08:00
twosigmajab fb9e13d2c9 DOC add missing requirements for building docs (#11292)
Fixes #11286.
2018-06-15 12:58:58 -07:00
Joel Nothman 160693655e DOC better rendering of math in documentation (#10253) 2018-04-16 09:31:34 +02:00
Mohamed Ali Jamaoui 6233150f44 DOC Put "Filing bugs" subsection under "Submitting bug report" section. (#10917) 2018-04-10 18:34:41 +08:00
Loïc Estève 69e9111b43 DC Small reorganization of contributing.rst documentation section. (#10685) 2018-02-25 15:13:49 +11:00
Saqib Nizam Shamsi ff5aac0c9e Fix "We probably shouldn't recommend autopep8" (#10650) 2018-02-18 16:06:28 +01:00
Loïc Estève 34155a222b [MRG+1] CircleCI: run only modified examples in CircleCI (#10407) 2018-01-15 03:19:43 -08:00
Joel Nothman 840f632e8f DOC A glossary of concepts and API elements (#9517)
Skeleton for a glossary of concepts and API elements.

This responds to at least three issues:

* Many aspects of scikit-learn API for users and developers are known
  tacitly by core contributors (and the stack overflow crowd), but are
  not written down in a consistent place.
* What is written is in an ad-hoc narrative style which may be useful
  for introduction, but is difficult to refer to and to maintain.
* Parameters such as `n_jobs` and methods like `decision_function` are
  described repeatedly in documentation giving sometimes more sometimes
  less information. This glossary allows us to use "See :term:`the
  glossary <n_jobs>`." so that parameter descriptions in the
  API reference can remain brief (just as not every numpy operation
  needs to describe broadcasting).
2018-01-02 10:14:07 +01:00
Nihar Sheth cec3458b03 DOC Fix broken links in docs (#10353) 2017-12-22 18:23:29 +01:00
Loïc Estève e824fa1480 MAINT revert unwanted changes in 58ff9b8 2017-12-21 15:13:07 +01:00
Vrishank Bhardwaj 58ff9b8600 ENH Remove check_array for X in DummyRegressor/DummyClassifier and replace X.shape[0] with _num_samples (#9835) 2017-12-21 08:10:22 +11:00
Viraj Navkal ef54931f32 DOC fix typo in estimator documentation (#10344) 2017-12-20 09:25:31 +11:00
Loïc Estève 01476b9421 [MRG] Run examples with Python 2 and 3 on CircleCI (#10167) 2017-12-19 17:17:15 +01:00
Loïc Estève b933b09027
DOC fix rst excessive bullet point indentation (#10335) 2017-12-18 11:03:16 +01:00
James Bourbeau e9299adce6 DOC Updates contributing.rst with doc build instructions (#10272) 2017-12-13 07:41:07 +11:00
Loïc Estève e7e05d844f [MRG+1] Remove nose from CIs and documentation (#9840) 2017-11-16 20:20:35 +01:00
Joel Nothman e260119564 DOC document some useful canned responses (#10131) 2017-11-16 15:46:33 +01:00
Hanmin Qin 8544ce553a DOC Encourage contributors to use keywords to close issue automatically (#9954) 2017-10-20 17:04:52 +11:00
Loïc Estève 7be4465fe6 [MRG] DOC good first issue and help wanted labels (#9950) 2017-10-20 17:04:05 +11:00