Commit Graph

89 Commits

Author SHA1 Message Date
Clement Joudet 6252f99c16 [MRG+1] Fixing Math domain error on NMF due to numpy.dot (#8765)
* Fixing overflow error on NMF due to numpy.dot
2017-05-20 09:47:43 +02:00
Guillaume Lemaitre e3c9ae204f [MRG+1] DOC improve description and consistency of random_state (#8689)
* DOC improve description of random_state in train_test_split

* DOC Make random_state consistent through documentation

* FIX reverse doc mistake

* FIX address comment of Tom

* DOC address comments

* DOC remove empty line

* DOC remove unecessary white spaces
2017-04-05 17:43:21 -07:00
Tom Dupré la Tour ae4f7104d6 [MRG+1] Add multiplicative-update solver in NMF, with all beta-divergence (#5295) 2016-12-12 16:10:39 +01:00
Andreas Mueller 5c4b1bb231 [MRG+1] Housekeeping Deprecations for v0.19 (#7927)
* remove stuff to be removed 0.19

* more changes

* remove classes from 0.19 whatsnew

* remove _LearntSelectorMixin

* remove ProjectedGradientNMF, load_lwf_*

* minor fixes

* remove more copy from logistic regression path

* remove lda, qda from __init__.__all__

* remove pg solver in nmf from tests etc

* remove class_weight="auto" from tests

* doctest change for decision_function_shape="ovr"

* remove transfrom from tree test, minor fixes to tree tests

* some fixes in the tests

* undo changes in functions which still allow 1d input...

* also allow 1d in scale

* more test fixes...

* last test fixes in forest and tree

* svm default value change doctest failures

* pep8

* remove more class_weight="auto" stuff

* minor cosmetics in docstrings deprecated / removed behavior.

* say that store_covariance has been moved to __init__ in discriminant_analysis
2016-12-09 12:43:38 -05:00
Joel Nothman 8570622a44 [MRG+1] DOC insert spaces before colons in parameter lists (#7920)
* DOC insert spaces before colons in parameter lists

Complies with numpydoc to improve rendering and automatic quality
assurance such as #7793. Affects listings of Parameters Attributes,
Returns.

Performed with the help of:

    grep -nE '^(    )+[a-zA-Z][a-zA-Z0-9_]*: ' sklearn -R | grep -v -e
    externals -e tests | grep -v -e default: -e else: -e Warning: -e Note:
    -e TRAIN: -e Default: -e True: -e False: -e DOI: -e In: | gsed
    's|\([^:]*\):\([0-9]*\):\([^:]*\):\(.*\)|--- a/\1\n+++ b/\1\n@@ -\2,1
    +\2,1 @@\n-\3:\4\n+\3 :\4|' | git apply --unidiff-zero -

* DOC fix numpydoc format for param
2016-11-25 10:59:22 +01:00
Ekaterina Krivich 02cc6f5d3a [MRG] TST Ensure __dict__ is unmodified by predict, transform, etc (#7553)
* Add test for __dict__ for estimator checks

  check that "predict", "transform", "decision_function" or
"predict_proba" methods do not change the state of __dict__ of any
estimator

  see #7297

* Add a test to test_check_estimator

  that shows that check_estimator fails on an estimator that violates this

* Fixed bug where NMF's n_iter_ attribute was set by calls to transform
2016-11-05 21:44:53 +11:00
Olivier Grisel 252b356939 FIX broken NMF test with numpy 1.7.1 2016-08-11 16:24:18 +02:00
Joel Nothman b28043281c DOC insert missing function description
Otherwise sphinx latexpdf build breaks here
2016-06-07 23:08:57 +10:00
nadya-p 4854454016 [MRG+1] Parameter check in NMF and IsolationForest (#6814)
* FIX #6793 parameter check in NMF and IsolationForest
* replaced six.integer_types with numbers.Integral

* fix test_nmf

* added an int64 test for non_negative_factorization

* cosmetic change

* dummy commit for triggering tests in github

* added a unit test for iforest
2016-05-26 13:51:17 +02:00
Olivier Grisel 97ad719f4e STYLE minor flake8 fixes in nmf.py 2016-04-22 17:20:52 +02:00
Sasank Chilamkurthy c3b212ac0d NMF Bug fix when init='custom'
* Update nmf.py for bug during transform 

when init='custom' and transform is used, W should not be checked for initialisation.

* added test for nmf custom init

* minor changes for custom init test
2016-04-07 19:06:52 +02:00
Lars Buitinck 2e4aafd19c MAINT remove my email address
I'm getting too many individual support requests. People should
use the mailing list.
2016-03-04 10:43:41 +01:00
Anish Shah a6604c3c1d inverse_transformation for NMF decomposition 2016-02-11 23:30:10 +05:30
Yaroslav Halchenko 625471bb29 DOC: few minor typos spotted 2015-12-15 20:56:34 -05:00
Andreas Mueller fb123ed24b More doc fixes. Latex builds again. 2015-11-20 16:30:45 -05:00
KamalakerDadi f2e35411fa Added more versions of 0.17 2015-11-04 00:02:52 +01:00
KamalakerDadi 2249daaea8 Version added for all new classes 2015-11-03 23:54:42 +01:00
Lars Buitinck 1eb9bed151 COSMIT nicer output from NMF with verbose > 0
Used to print "('violation:', 1.0)". Now "violation: 1.0".
2015-10-21 13:14:56 +02:00
Raghav R V e3afc0e8c9 MAINT move custom error/warning classes into sklearn.exceptions
ENH NonBLASDotWarning -> EfficiencyWarning; Improve error message
DOC Add exceptions module to modules/classes.rst
MAINT Move ConvergenceWarning, UndefinedMetricWarning et al into exceptions
MAINT Remove ChangedBehaviorWarning from base
DOC/FIX Improve DataConversionWarning's docstring
2015-10-19 22:35:35 +02:00
Lars Buitinck 46edeec111 COSMIT some refactoring in NMF
* de-indent loop
* move regularization calculations out of loop
2015-10-02 00:07:01 +02:00
Lars Buitinck e7ecc4f976 BUG shuffle components, not samples in NMF CD 2015-09-30 21:45:03 +02:00
TomDLT ceeef70037 ENH refactor NMF and add CD solver 2015-09-21 11:42:07 +02:00
Lars a6c6e732c5 Merge pull request #3659 from chyikwei/onlineldavb
ENH Latent Dirichlet Allocation (LDA) with online variational Bayes
2015-08-09 19:13:01 +02:00
Olivier Grisel 71feb53bf6 FIX seed the initialization of NMF 2015-07-23 08:46:14 +02:00
Stephen Hoover a1d6bb1e2f DOC Fix doc for NMF `init` default
Docs had claimed that the `init` argument defaulted to "nndsvdar" when `n_components < n_features`, but it actually defaults to "nndsvd".

Resolves issue #4929 .
2015-07-11 10:47:29 -05:00
Andreas Mueller 0650d5502e DOC adding backlinks to docstrings 2015-06-03 00:24:04 -04:00
Chyi-Kwei Yau 6b16e9de61 move check_non_negative to utils/validation.py 2015-05-15 23:01:12 -04:00
Raghav R V b3fbccca38 FIX various mismatch between docstring and signature params
DOC max_iterations -> max_iter. Make it consistent with kmeans

MAINT Replace the deprecated dx parameter with d in the docstrings

MAINT Deprecation warning for max_iterations parameter.
2015-01-16 11:54:57 -05:00
Raghav R V abd31d2cad MAINT Make uniform the error raised for not fitted condition 2015-01-12 00:33:40 +05:30
Joel Nothman b3bdb08964 DOC fix formatting of attributes etc. in docstrings 2014-07-28 19:04:59 +10:00
MechCoder bbb140aaf0 ENH: Added n_iter_ parameters across all iterative solvers 2014-07-22 15:09:39 +02:00
Andreas Mueller c235c3b566 ENH add allowed_sparse named argument for @ogrisel 2014-07-20 15:31:28 +02:00
Andreas Mueller 6e2a83b4e1 remove check_arrays stuff and old input validation 2014-07-20 13:31:45 +02:00
Andreas Mueller e6e9fb6490 Make fit_transform and fit().transform() equivalent in nmf 2014-07-18 17:22:02 +02:00
Andreas Mueller c7db70ac9f removed unused variables and imports, add used imports where missing. 2014-06-08 21:44:01 +02:00
Lars Buitinck fb795ebef0 ENH factor out squared norm helper 2014-04-08 23:02:54 +02:00
Lars Buitinck 0abe21eaac MAINT remove some deprecated stuff 2014-03-12 13:33:42 +01:00
Lars Buitinck abe3d05b4c COSMIT micro-optimize norm computation in NMF
... for clarity, although it should also be slightly faster, and
corrected a docstring while I was there.
2013-10-30 23:31:13 +01:00
Lars Buitinck 02d972644a ENH micro-optimize NMF inner loop
Also fixed the random seed on the example.
2013-10-20 19:17:26 +02:00
Lars Buitinck a2a4257bc6 ENH optimize NMF inner loop
The call to np.maximum was taking 20% of the time.
Multiplying by Hn > 0 is about twice as fast.

This reverts commit 6ef08cfac2.
2013-10-01 18:09:58 +02:00
Lars Buitinck 6ef08cfac2 FIX failing test in NMF due to negative zeros 2013-09-02 14:03:06 +02:00
Lars Buitinck 841fb88727 ENH prettier output from NMF example
Better stopword and noise filtering, increased n_samples to 2000
since the recent optimizations to tf-idf and NMF allow this.

Also some micro-optimizations to NMF itself.
2013-09-01 19:04:56 +02:00
Lars Buitinck c64163f822 wip 2013-09-01 16:47:04 +02:00
Lars Buitinck 41b3ddd2d6 ENH speed up NMF (about 30% off topic extraction runtime) 2013-08-30 03:19:28 +02:00
Vlad Niculae 7aac367666 Use scipy.nnls.optimize for dense data 2013-07-27 16:12:19 +02:00
Vlad Niculae ae74c9df86 Use same parameters when solving the transform 2013-07-27 16:12:19 +02:00
Vlad Niculae 206d22793d Use projected gradient solver in transform to support sparse matrices 2013-07-27 16:12:19 +02:00
Lars Buitinck 77695ee27a COSMIT pep8 2013-07-11 11:50:23 +02:00
Jaques Grobler 8861833ec9 DOC spellfixes 2013-06-29 16:18:23 +03:00
Jaques Grobler 2ffb484adb COSMIT pep8 2013-05-04 10:43:39 +02:00