Commit Graph

7 Commits

Author SHA1 Message Date
Alexandre Gramfort dbc2eaff10 bug fix in coordinate descent for GLMNET 2010-05-06 16:30:02 +02:00
Alexandre Gramfort 1e68aaccff changing interface of lasso + enet for consistency with GLMNET 2010-05-06 16:30:02 +02:00
Fabian Pedregosa 88e9d3a4eb Refactor lasso coordinate descent code.
The code of coordinate descent was optimized algorithmically reducing
the number of matrix operations and eliminating callbacks. The
resulting code is thus simpler but less flexible in theory, although
in my oppinion this feature was not really used.

In my computer this gives a 150x speed improvement on the example
plot_lasso_coordinate_descent_path.py.

Further improvements should be done, notably those that exploit
sparsity. This is planned but not done in this commit.

Other changes:

  * squash enet_cd_fast.pyx and lasso_cd_fast.pyx into cd_fast.pyx.
  * remove python code that duplicates functionality of cython code.
  * Refactor test for this module, as they where mostly based on the
    callback code.
  * Modify plot_lasso_coordinate_descent_path.py to compute only the
    lasso path.
  * throw a warning if dual gap > tolerance.
2010-05-06 16:29:25 +02:00
Olivier Grisel 90eb5b71e9 add some print statements to monitor lasso/enet progress and tweaks parameters to make it faster to run
git-svn-id: https://scikit-learn.svn.sourceforge.net/svnroot/scikit-learn/trunk@688 22fbfee3-77ab-4535-9bad-27d1bd3bc7d8
2010-04-22 09:45:08 +00:00
Alexandre Gramfort 6d1c9f64bc uniforming the access to the primal variables (the "w") with a "coef_" property
in the lasso and enet coordinate methods.

git-svn-id: https://scikit-learn.svn.sourceforge.net/svnroot/scikit-learn/trunk@682 22fbfee3-77ab-4535-9bad-27d1bd3bc7d8
2010-04-21 18:05:56 +00:00
Gael Varoquaux d09d6174fa DOC: Improve the example docstrings.
git-svn-id: https://scikit-learn.svn.sourceforge.net/svnroot/scikit-learn/trunk@680 22fbfee3-77ab-4535-9bad-27d1bd3bc7d8
2010-04-21 17:04:36 +00:00
Fabian Pedregosa c0695e840e Generate examples dinamically.
git-svn-id: https://scikit-learn.svn.sourceforge.net/svnroot/scikit-learn/trunk@633 22fbfee3-77ab-4535-9bad-27d1bd3bc7d8
2010-04-14 08:25:23 +00:00