Commit Graph

365 Commits

Author SHA1 Message Date
Agamemnon Krasoulis 19192c0427 MAINT Replace manual checks with `check_is_fitted` (#13013) 2019-05-07 14:54:56 +10:00
Guillaume Lemaitre b34751b7ed [MRG] MAINT: add fixture for init and clean-up with matplotlib (#13708) 2019-05-06 09:41:46 +02:00
Kevin Yu-Sheng Li 519bedc70e DOC Fix note range in contributing.html (#13722) 2019-05-05 23:12:10 +08:00
Joel Nothman ee986788cb DOC Add commit contributors 2019-04-29 23:04:51 +10:00
Joel Nothman 9548e8f4cd DOC new convention is :pr: not :issue: 2019-04-28 00:44:22 +10:00
Bharat Raghunathan f0ed930800 DOC: Add SLEP and Governance in Dev Docs (#13688) 2019-04-23 15:46:27 +10:00
Nicolas Hug 83dca7eb1b MNT Correctly handle deprecated attribute warnings and docstrings (#13635) 2019-04-18 10:21:40 -07:00
jeremiedbb 0fb7cc7520 BLD: check OpenMP support and add a switch to build without it (#13543) 2019-04-17 08:29:37 +10:00
Mohammed AbdelAal e8c6cb151c DOC fix typo in contributing.rst (#13593) 2019-04-08 08:39:33 +10:00
Nicolas Hug 277bf27972 DOC Added doc on how to override estimator tags (#13550) 2019-04-02 23:29:32 +08:00
Martin Gubri 26f690961a DOC Fix missing space after backquotes (#13551) 2019-04-01 08:51:37 +08:00
William de Vazelhes 4d8883c2af DOC Fix typo in contributing (#13544)
This fixes a typo that has the effect to not resolve a link
2019-03-28 18:44:13 +01:00
Nicolas Hug 5b747cf440 DOC Added additional tips for pytest usage (#13540)
* Added additional tips for pytest

* Added --ff option

* typo
2019-03-28 16:16:18 +01:00
Adrin Jalali ab399a675a
DOC better clarify upstream synchronization in contributing guide (#13505)
* clarify upstream synchronization

* apply Nicolas's comment

* fix typo

* don't mention the rebase

* move the notes

* fix branch name
2019-03-26 10:43:32 +01:00
Shiyu Duan 777a5e448f DOC Fix typos in doc/developers/contributing.rst (#13475) 2019-03-19 11:41:09 +08:00
Joel Nothman 0344a2a704 DOC update and extend maintainer docs for making releases (#13377) 2019-03-04 20:31:51 +08:00
Joel Nothman cd1cb303ea [MRG] MNT Tools for working with what's new (#11800) 2019-03-04 10:36:00 +01:00
Olivier Grisel 5cb422334f
DOC reference the HTTPS url for the nightly builds (#13270) 2019-02-27 08:28:55 +01:00
Andreas Mueller ab2f539a32 API: Estimator tags (#8022) 2019-02-23 22:54:41 +01:00
Christos Aridas 0be2a1efd4 DOC Remove a repeated sentence from the contributing guide (#13196) 2019-02-19 23:02:18 +01:00
jeremiedbb 8e824df33b MNT refs to travis/flake8_diff -> circle/flake8_diff (#13163) 2019-02-15 09:06:31 +11:00
Bharat Raghunathan 1a850eb5b6 DOC Correct code example in doc/developers/contributing.rst (#13098) 2019-02-07 18:13:59 +08:00
Thomas Fan 1582926101 [MRG] DOC Adds _pairwise property to dev docs (#13094) 2019-02-07 11:22:23 +11:00
Thomas Fan 18bac2edc2 [MRG] DOC Adds explicit reference to clang (#13093) 2019-02-06 06:45:22 +11:00
jeremiedbb 7307b56992 MNT Update setup and travis to support OpenMP (#13053) 2019-02-04 21:41:11 +11:00
jeremiedbb 79a905977b DOC Clean up the advanced installation doc to remove python < 3.5 parts (#13064) 2019-01-30 11:10:49 +11:00
Thomas Fan 625dafe1dc DOC Update contributing style (#12998) 2019-01-17 17:43:16 +08:00
Thomas Fan a7b8b9e9e1 MAINT Removes total_seconds completely in benchmarks (#12969) 2019-01-13 16:41:28 +01:00
Jérémie Méhault 41a2174fde DOC: add install mode to contribute (#12850) 2019-01-10 09:03:37 +11:00
Hanmin Qin cdfb5728fb DOC Update note on code contribution: use issue tracker not mailing list (#12917) 2019-01-08 07:00:55 +11:00
Gael Varoquaux 301c18e310 DOC How to deal with stalled PR (#12894) 2019-01-05 22:47:44 +08:00
Andreas Mueller 952ef6637a MRG Drop legacy python / remove six dependencies (#12639) 2019-01-03 15:50:05 +02:00
Nicolas Hug fda8f4786d DOC Added tips for reading the code base (#12874)
* Added tips for reading the code base

* Put it in contributing.rst

* Added bullet point about inheritance
2018-12-31 18:37:57 +01:00
Andreas Mueller 3c6ab5fa8e DOC link to dev docs instead of contributing docs in the menu (#12885) 2018-12-29 09:11:13 +08:00
Albert Thomas d6095eb036 DOC add sentence about line length of rst files (#12883) 2018-12-28 17:46:37 +02:00
Nicolas Hug 7455078880 DOC Fixed typo in contributors guide (#12868) 2018-12-27 09:53:15 +08:00
Reshama Shaikh 552a88e7f8 DOC Shorten and improve CONTRIBUTING.md (#12801)
* Reuse intro from contributing.rst

* Removed content already on rst

Simplified CONTRIBUTING.md by removing content that already
exists in contributing.rst. Added Code of Conduct reference
as seen in a few other CONTRIBUTING.md of popular libraries.

* Update contributing.rst

In shortening `CONTRIBUTING.md`, material deleted from `how to contribute` section are added onto `contributing.rst` if it doens't exist on the latter.

* added full link to .rst file + removed 'Full' in 'Full Docum...'
2018-12-19 11:14:01 +01:00
Hanmin Qin 037ee933af DOC (0.21) update Circle CI doc 2018-12-15 23:46:06 +08:00
Adrin Jalali 0be2d7356d DOC update min required versions in some remaining docs (#12778) 2018-12-14 21:10:45 +08:00
Shivam Kotwalia bfa3aaaa8e DOC Fix joblib URL (#12698) 2018-11-30 13:16:57 +01:00
Adrin Jalali dbd28e70be DOC add joblib to doc-build deps (#12691) 2018-11-29 09:40:28 +11:00
Olivier Grisel 6f9b1b6284 DOC use twine to upload wheels to pypi (#12661) 2018-11-26 15:18:14 +11:00
Peter Hausamann ac327c5ad6 [MRG] DOC Windows build dependencies (#12615) 2018-11-20 15:31:49 +11:00
Roman Yurchak 66507a25a4 MAINT Use CircleCI for linting (#12606) 2018-11-19 11:00:55 +08:00
Federico Caselli d42d0d7ae4 DOC fix broken link in doc/developers/contributing.rst (#12508) 2018-11-02 17:30:15 +01:00
Nicolas Hug bea1eb51b3 [MRG] Clarified indempotence of fit (#12305)
<!--
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist
-->

#### Reference Issues/PRs
<!--
Example: Fixes #1234. See also #3456.
Please use keywords (e.g., Fixes) to create link to the issues or pull requests
you resolved, so that they will automatically be closed when your pull request
is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests
-->


#### What does this implement/fix? Explain your changes.

As far as I understand it, the fact that `fit` is idempotent means that repeated calls to `fit` with the same data doesn't change the estimator.

The contributing guide was a bit unclear about this.

#### Any other comments?


<!--
Please be aware that we are a loose team of volunteers so patience is
necessary; assistance handling other issues is very welcome. We value
all user contributions, no matter how minor they are. If we are slow to
review, either the pull request needs some benchmarking, tinkering,
convincing, etc. or more likely the reviewers are simply busy. In either
case, we ask for your understanding during the review process.
For more information, see our FAQ on this topic:
http://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.

Thanks for contributing!
-->
2018-10-16 16:00:52 -04:00
Dmitry Vukolov c8a4132774 DOC check_array() and check_X_y() documentation update (#12340) 2018-10-10 21:16:44 +11:00
TakingItCasual 1e052e9da9 Converting http to https (2)... (#12292) 2018-10-04 23:06:14 +02:00
TakingItCasual 74b56dbc57 MNT Converting http to https (#12277) 2018-10-04 22:37:57 +08:00
TakingItCasual e9cdb5588b MNT Updated PyPI URLs (#12274) 2018-10-04 15:55:34 +08:00