Commit Graph

47 Commits

Author SHA1 Message Date
Andreas Mueller f12a441655 raise noise in test again, be ascii 2015-02-24 16:26:24 -05:00
Olivier Grisel 95f1d9562b FIX DOC TST: alpha is an uppper bound on FDR 2015-02-24 16:26:24 -05:00
Andreas Mueller 700babc43f extensive (excessive?) testing of FDR 2015-02-24 16:26:24 -05:00
Andrew Tulloch 1add39ff11 [Feature Selection] Fix SelectFDR thresholding bug (#2771)
From https://github.com/scikit-learn/scikit-learn/issues/2771, we were
not correctly scaling the alpha
parameter (http://en.wikipedia.org/wiki/False_discovery_rate#Benjamini.E2.80.93Hochberg_procedure)
with the number of features (== hypothesis).  Thus, the alpha
parameter was not invariant wrt the number of features.

The correction is as suggested in the original issue, and a test has
been added that verifies that for various numbers of features, an
appropriate false discovery rate is generated when using the selector.
2015-02-24 16:25:58 -05:00
Olivier Grisel 2ce9eac717 TST more strict selectors with empty support 2015-02-07 11:37:06 +01:00
Olivier Grisel bc5b403af3 FIX #4059: explicit warning for strict selectors 2015-02-06 12:06:34 +01:00
MechCoder 0bd095f9d6 FIX: Raise warnings in f_classif a given feature is constant throughout 2014-10-08 19:32:47 +02:00
Olivier Grisel e01749068c MAINT fix prng in test_f_oneway_ints
Not fixing the PRNG cause the test to fail randomly under windows
where the 4 decimals place check can be too strict for some unlucky
random draws of test data.
2014-07-29 08:54:47 +02:00
Olivier Grisel f3afd4e5e2 FIX unstable test on 32 bit windows 2014-07-23 19:11:53 +02:00
Andreas Mueller 6e2a83b4e1 remove check_arrays stuff and old input validation 2014-07-20 13:31:45 +02:00
Arnaud Joly db4230a776 TST improve parameter checking + use nose assert_ functions 2014-05-08 20:56:21 +02:00
Arnaud Joly e58405d6f6 MAINT remove redundant class hierarchy + fix api perform parameter check in fit 2014-05-08 20:56:21 +02:00
Will Myers f1e2e1c874 Fixed SelectKBest corner case: k=0
Without this fix k = 0 will have the same behavior as k = 'all' based on how
the array indexing was written.

I've included a test that demonstrates proper behaviour.
2014-03-27 15:18:50 -04:00
VirgileFritsch 4c129e57c1 f_regression and degress of freedom: update whats_new + minor. 2014-02-07 19:28:46 +01:00
VirgileFritsch 4d18fd8837 BF in f_regression: variable naming + use assert_*array*_almost_equal. 2014-02-07 19:28:06 +01:00
VirgileFritsch 8e0b4be57e BF: Correct degrees of freedom in f_regression + test. 2014-02-07 19:28:05 +01:00
ai8rahim 921deade51 Changed assert_array_equal() in Line 45 and 46 to assert_array_almost_equal(,,decimal=5). This has fixed the AssertionError, which occurs during the installation test. 2014-01-12 21:03:11 +08:00
Alexandre Gramfort 44270ddc83 fix f_oneway with ints 2013-12-16 22:02:05 +01:00
dengemann e1bdd99ea6 ENH: add assert_warn_message 2013-11-29 13:55:39 +01:00
Lars Buitinck b46ea718af FIX remove warnings from univariate FS
These warnings are issued practically always when using
frequency-valued or boolean data.

Switched to a stable sort to get reproducible results.
2013-08-19 14:56:37 +02:00
jnothman 2b57e4e52e Merge pull request #1935 from jnothman/base_filter_inv_transform
Small improvements to inverse_transform used in feature_selection.
2013-05-07 05:26:58 -07:00
Joel Nothman 35b4045ff9 FIXTST fix errors introduced to feature selection tests 2013-05-07 16:00:05 +10:00
Joel Nothman 4fd975ce80 ENH sparse _BaseFilter.inverse_transform 2013-05-07 16:00:05 +10:00
Joel Nothman 313193fb0f ENH _BaseFilter.inverse_transform should respect dtype 2013-05-07 16:00:04 +10:00
Joel Nothman 40cf5c90ee TST ensure SelectKBest and SelectPercentile scores are best 2013-05-07 12:16:09 +10:00
Joel Nothman b80f6a80b0 ENH allow SelectKBest to select all features in a parameter search 2013-03-13 12:28:49 +01:00
Andreas Mueller 754c2d9533 COSMIT pep8 2012-12-22 16:48:17 +01:00
Andreas Mueller d70088c43d FIX small bug in feature selection error message. 2012-10-31 15:36:03 +00:00
Lars Buitinck b77804dcb4 BUG NaN handling in SelectPercentile and SelectKBest
Including non-regression test.
2012-10-16 12:53:27 +02:00
Lars Buitinck 19a1a41379 ENH perform feature selection on scores, not p-values, when possible
More stable in the case of chi2; allows for feature selectors that do not
perform significance tests.
2012-10-04 12:13:50 +02:00
Lars Buitinck 2e48248531 COSMIT + DOC univariate feature selection
rm deprecated properties
input validation in SelectPercentile
use super()
docstring fixes
2012-09-18 14:38:52 +02:00
Andreas Mueller 66c8a706d2 ENH fix percentile tiebreaking, add warning 2012-09-17 21:40:58 +01:00
Andreas Mueller fc3cdc7472 TST Simplified tests, test that sparse and dense versions give the same result, always return arrays, not matrices. 2012-08-16 17:51:00 +01:00
Andreas Mueller c520275f06 ENH sparse matrix support in univariate feature selection 2012-08-16 17:50:59 +01:00
Andreas Mueller 1ebcc4a486 COSMIT pep8 2012-05-15 21:18:30 +02:00
Gael Varoquaux 065b905aed BUG: casting error with recent numpys 2012-05-12 00:02:30 +02:00
Andreas Mueller eeb6dcc4cc ENH use random states everywhere, never call np.random. 2012-05-06 18:35:14 +02:00
Lars Buitinck 258f19383c BUG ensure that SelectKBest actually selects k features
Fixes Issue #805
2012-04-30 17:25:13 +02:00
Lars Buitinck b17a82023c ENH export f_oneway from feature_selection module
+ import in test as a user would
2012-04-30 17:10:55 +02:00
Alexandre Gramfort eb9ad47594 ENH : speed up f_regression 2012-03-29 15:21:08 +02:00
Satrajit Ghosh 239039c84c tst: added test for feature selection. this test would have failed in the previous case. closes #727 2012-03-26 09:59:07 -04:00
Alexandre Gramfort ad8e4912cb TST: use assert_true instead of assert + remove some relative imports 2012-02-11 15:43:03 +01:00
Andreas Mueller b0d10fc9c2 COSMIT: more pep8. enough for today... 2011-11-29 00:03:19 +01:00
Olivier Grisel 78dd8b5626 batch trailing spaces cleanup 2011-09-06 23:12:26 +02:00
Fabian Pedregosa ddf4b72109 Move project directory from scikits.learn to sklearn 2011-09-02 12:06:57 +02:00
Fabian Pedregosa 68f27e3790 Revert "Move project directory from scikits.learn to sklearn"
This reverts commit fd0d3b879d.
2011-09-02 12:03:18 +02:00
Fabian Pedregosa fd0d3b879d Move project directory from scikits.learn to sklearn 2011-09-02 11:38:24 +02:00