f12a441655
raise noise in test again, be ascii
2015-02-24 16:26:24 -05:00
95f1d9562b
FIX DOC TST: alpha is an uppper bound on FDR
2015-02-24 16:26:24 -05:00
700babc43f
extensive (excessive?) testing of FDR
2015-02-24 16:26:24 -05:00
1add39ff11
[Feature Selection] Fix SelectFDR thresholding bug ( #2771 )
...
From https://github.com/scikit-learn/scikit-learn/issues/2771 , we were
not correctly scaling the alpha
parameter (http://en.wikipedia.org/wiki/False_discovery_rate#Benjamini.E2.80.93Hochberg_procedure )
with the number of features (== hypothesis). Thus, the alpha
parameter was not invariant wrt the number of features.
The correction is as suggested in the original issue, and a test has
been added that verifies that for various numbers of features, an
appropriate false discovery rate is generated when using the selector.
2015-02-24 16:25:58 -05:00
5c0c5c672c
MAINT use absolute imports in tests
...
as per the guideline in:
http://scikit-learn.org/stable/developers/#coding-guidelines
2015-02-10 13:40:31 +01:00
95681eecca
Merge pull request #4206 from ogrisel/fix-strict-select-fdr
...
[MRG] explicit warning message for strict selectors
Also fixes #4059
2015-02-07 21:54:45 +11:00
2ce9eac717
TST more strict selectors with empty support
2015-02-07 11:37:06 +01:00
bc5b403af3
FIX #4059 : explicit warning for strict selectors
2015-02-06 12:06:34 +01:00
97e3b96801
PEP8 compliance
2015-02-05 15:26:46 -05:00
13b6aec5f3
non-inheriting estimator added for rfe, cross validation, and pipeline tests
...
non-inheriting estimator added for cross validation
non-inheriting estimator added for pipeline
reconciled diffs
2015-01-29 22:02:38 -05:00
88555987cc
PEP8 Fix E101, E111 errors and W191, W293, W293 and W391 warnings.
2015-01-08 04:28:24 +05:30
6039b1864b
Merge pull request #3824 from nmayorov/rfecv_bugfix
...
[MRG+1] FIX: Bug in RFECV when step is not 1
2014-12-15 09:06:41 +01:00
ad7e772422
Fixed a bug in RFECV when step != 1
2014-12-15 02:53:27 +03:00
081a554698
FIX P/R/F metrics and scorers are now for binary problems only by default
...
Scorers for different average parameters have been added.
2014-12-09 13:56:51 +11:00
2fecf6facf
Fix RFE n_features minimum value #3812 and make it simpler.
2014-11-24 18:05:00 +01:00
60cadce9d1
Fix RFE n_features minimum value #3812
2014-11-20 19:19:40 +01:00
0bd095f9d6
FIX: Raise warnings in f_classif a given feature is constant throughout
2014-10-08 19:32:47 +02:00
e01749068c
MAINT fix prng in test_f_oneway_ints
...
Not fixing the PRNG cause the test to fail randomly under windows
where the 4 decimals place check can be too strict for some unlucky
random draws of test data.
2014-07-29 08:54:47 +02:00
f3afd4e5e2
FIX unstable test on 32 bit windows
2014-07-23 19:11:53 +02:00
6e2a83b4e1
remove check_arrays stuff and old input validation
2014-07-20 13:31:45 +02:00
b12d1ac487
Remove deprecated 'score_func' and 'loss_func' parameters from sklearn.metrics.scorer.check_scoring. Amend the code in all the other places they were used.
2014-07-17 13:53:06 +01:00
9248948344
test case on rtfe grid_scores fix
2014-07-15 16:35:04 +02:00
724b63a16c
Replacing the test .todense() methods with .toarray()
2014-05-20 21:44:34 -04:00
db4230a776
TST improve parameter checking + use nose assert_ functions
2014-05-08 20:56:21 +02:00
e58405d6f6
MAINT remove redundant class hierarchy + fix api perform parameter check in fit
2014-05-08 20:56:21 +02:00
a3f81d9a04
Merge pull request #3010 from griffinmyers/fix-select-k-best
...
Fixed SelectKBest corner case: k=0
2014-03-28 09:32:31 +11:00
f1e2e1c874
Fixed SelectKBest corner case: k=0
...
Without this fix k = 0 will have the same behavior as k = 'all' based on how
the array indexing was written.
I've included a test that demonstrates proper behaviour.
2014-03-27 15:18:50 -04:00
2b2c5b2db8
FIX: np.random.randint expects signed 32 bit integers under Windows
2014-03-27 14:20:03 +01:00
4c129e57c1
f_regression and degress of freedom: update whats_new + minor.
2014-02-07 19:28:46 +01:00
4d18fd8837
BF in f_regression: variable naming + use assert_*array*_almost_equal.
2014-02-07 19:28:06 +01:00
8e0b4be57e
BF: Correct degrees of freedom in f_regression + test.
2014-02-07 19:28:05 +01:00
dbc26ce996
COSMIT remove unused imports and variables
2014-02-03 19:43:56 +11:00
6ebcf4d020
COSMIT fix PEP8 errors
2014-02-02 00:30:28 +11:00
921deade51
Changed assert_array_equal() in Line 45 and 46 to assert_array_almost_equal(,,decimal=5). This has fixed the AssertionError, which occurs during the installation test.
2014-01-12 21:03:11 +08:00
44270ddc83
fix f_oneway with ints
2013-12-16 22:02:05 +01:00
e1bdd99ea6
ENH: add assert_warn_message
2013-11-29 13:55:39 +01:00
e3002c5efc
FIX #2372 : non-shuffling StratifiedKFold implementation and updated tests
2013-09-25 15:56:47 +02:00
006a6cbaad
ENH add VarianceThreshold feature selection method
2013-08-20 14:24:08 +02:00
b46ea718af
FIX remove warnings from univariate FS
...
These warnings are issued practically always when using
frequency-valued or boolean data.
Switched to a stable sort to get reproducible results.
2013-08-19 14:56:37 +02:00
b0035bf9e8
Rename cv_scores(_) back to grid_scores(_) to keep the name free for a future refactoring
2013-07-28 17:10:14 +02:00
eae4fab2d8
Add catching of the deprecation warnings in rfe and ridge tests
2013-07-28 10:45:44 +02:00
11dfe44b1b
Add deprecation warnings in rfe
2013-07-28 10:45:44 +02:00
c01ed96b24
PY3 xrange, np.divide, string.uppsercase, None comparison
...
Fixes #2108 .
2013-06-30 14:37:06 +02:00
bc2acb519c
FIX yet another chi2 bug
2013-06-01 17:42:04 +02:00
b486875497
FIX bug (swapped args) in chi2
...
Added a non-regression test.
2013-06-01 17:26:20 +02:00
9a8845e913
ENH Create FeatureSelectionMixin for shared [inverse_]transform code
...
Also rename FeatureSelectionMixin -> SelectorMixin -> _LearntSelectorMixin
And rename sklearn.feature_selection.{selector_mixin -> from_model}
2013-05-21 13:53:12 +10:00
2b57e4e52e
Merge pull request #1935 from jnothman/base_filter_inv_transform
...
Small improvements to inverse_transform used in feature_selection.
2013-05-07 05:26:58 -07:00
35b4045ff9
FIXTST fix errors introduced to feature selection tests
2013-05-07 16:00:05 +10:00
4fd975ce80
ENH sparse _BaseFilter.inverse_transform
2013-05-07 16:00:05 +10:00
313193fb0f
ENH _BaseFilter.inverse_transform should respect dtype
2013-05-07 16:00:04 +10:00
Andreas Mueller