9bc4de8dae
some fixes for sphinx and in examples
2015-03-02 12:50:53 -05:00
f12a441655
raise noise in test again, be ascii
2015-02-24 16:26:24 -05:00
95f1d9562b
FIX DOC TST: alpha is an uppper bound on FDR
2015-02-24 16:26:24 -05:00
700babc43f
extensive (excessive?) testing of FDR
2015-02-24 16:26:24 -05:00
1add39ff11
[Feature Selection] Fix SelectFDR thresholding bug ( #2771 )
...
From https://github.com/scikit-learn/scikit-learn/issues/2771 , we were
not correctly scaling the alpha
parameter (http://en.wikipedia.org/wiki/False_discovery_rate#Benjamini.E2.80.93Hochberg_procedure )
with the number of features (== hypothesis). Thus, the alpha
parameter was not invariant wrt the number of features.
The correction is as suggested in the original issue, and a test has
been added that verifies that for various numbers of features, an
appropriate false discovery rate is generated when using the selector.
2015-02-24 16:25:58 -05:00
5c0c5c672c
MAINT use absolute imports in tests
...
as per the guideline in:
http://scikit-learn.org/stable/developers/#coding-guidelines
2015-02-10 13:40:31 +01:00
95681eecca
Merge pull request #4206 from ogrisel/fix-strict-select-fdr
...
[MRG] explicit warning message for strict selectors
Also fixes #4059
2015-02-07 21:54:45 +11:00
2ce9eac717
TST more strict selectors with empty support
2015-02-07 11:37:06 +01:00
bc5b403af3
FIX #4059 : explicit warning for strict selectors
2015-02-06 12:06:34 +01:00
97e3b96801
PEP8 compliance
2015-02-05 15:26:46 -05:00
13b6aec5f3
non-inheriting estimator added for rfe, cross validation, and pipeline tests
...
non-inheriting estimator added for cross validation
non-inheriting estimator added for pipeline
reconciled diffs
2015-01-29 22:02:38 -05:00
a413f875f1
DOC minor fixes do docstrings, don't document deprecated parameters.
2015-01-16 11:55:02 -05:00
b3fbccca38
FIX various mismatch between docstring and signature params
...
DOC max_iterations -> max_iter. Make it consistent with kmeans
MAINT Replace the deprecated dx parameter with d in the docstrings
MAINT Deprecation warning for max_iterations parameter.
2015-01-16 11:54:57 -05:00
abd31d2cad
MAINT Make uniform the error raised for not fitted condition
2015-01-12 00:33:40 +05:30
88555987cc
PEP8 Fix E101, E111 errors and W191, W293, W293 and W391 warnings.
2015-01-08 04:28:24 +05:30
46c1c42131
remove deprecated ``n_bootstraps`` parameter in Bootstrap cv object, verbose in FactorAnalysis and SelectorMixin. Also adjust some deprecation strings.
2014-12-29 13:53:42 -05:00
41e2c10a9e
rename decorator
2014-12-19 17:27:27 -05:00
86f4ee1fa4
don't give names to decorators
2014-12-18 17:49:46 -05:00
94f37f43fa
FIX ducktyping for meta-estimators
2014-12-18 17:48:56 -05:00
0597c23e85
TST/FIX ensure correct ducktyping for metaestimators
2014-12-18 17:48:56 -05:00
6039b1864b
Merge pull request #3824 from nmayorov/rfecv_bugfix
...
[MRG+1] FIX: Bug in RFECV when step is not 1
2014-12-15 09:06:41 +01:00
ad7e772422
Fixed a bug in RFECV when step != 1
2014-12-15 02:53:27 +03:00
081a554698
FIX P/R/F metrics and scorers are now for binary problems only by default
...
Scorers for different average parameters have been added.
2014-12-09 13:56:51 +11:00
5474983fd2
If step is explicitly zero or negative, raise a ValueError exception.
2014-11-27 18:23:25 +01:00
2fecf6facf
Fix RFE n_features minimum value #3812 and make it simpler.
2014-11-24 18:05:00 +01:00
60cadce9d1
Fix RFE n_features minimum value #3812
2014-11-20 19:19:40 +01:00
87b23ba18a
DOC explain SelectorMixin strategy with multiple classes.
2014-11-05 16:29:58 -05:00
bee0a98a1e
cosmit in warning message
2014-10-08 21:04:59 +02:00
22cc25fc61
ENH: More descriptive error which prints the feature indices
2014-10-08 20:09:32 +02:00
0bd095f9d6
FIX: Raise warnings in f_classif a given feature is constant throughout
2014-10-08 19:32:47 +02:00
842d80a8e1
ENH improved CSC matrix handling in VarianceThreshold
2014-09-03 13:47:48 +02:00
812242042a
FIX Verbose message in RFE to count from 1, not 0
2014-08-07 21:35:37 +10:00
e1891d801b
Merge pull request #3489 from jnothman/attributes-doc
...
[MRG] DOC fix formatting of Attributes sections in documentation
2014-08-02 20:14:53 +10:00
e01749068c
MAINT fix prng in test_f_oneway_ints
...
Not fixing the PRNG cause the test to fail randomly under windows
where the 4 decimals place check can be too strict for some unlucky
random draws of test data.
2014-07-29 08:54:47 +02:00
b3bdb08964
DOC fix formatting of attributes etc. in docstrings
2014-07-28 19:04:59 +10:00
f3afd4e5e2
FIX unstable test on 32 bit windows
2014-07-23 19:11:53 +02:00
2fca6ce244
MAINT remove deprecated code from trees and forests
2014-07-22 15:52:48 +02:00
c235c3b566
ENH add allowed_sparse named argument for @ogrisel
2014-07-20 15:31:28 +02:00
6e2a83b4e1
remove check_arrays stuff and old input validation
2014-07-20 13:31:45 +02:00
b12d1ac487
Remove deprecated 'score_func' and 'loss_func' parameters from sklearn.metrics.scorer.check_scoring. Amend the code in all the other places they were used.
2014-07-17 13:53:06 +01:00
9248948344
test case on rtfe grid_scores fix
2014-07-15 16:35:04 +02:00
85d39c3d0d
Quick fix on grid_scores, updating final value with len(cv)
...
self.grid_scores_ = scores / len(cv)
2014-07-15 16:35:04 +02:00
b8073a4e01
Improved documentation of the "estimator_params" argument for RFE and RFECV.
...
Changed the documentation for the "estimator_params" argument for both
RFE and RFECV to better indicate how it could be useful for doing a
grid search. Previously the documentation may have indicated that RFE
and RFECV would perform a grid search if "estimator_params" was passed
a grid of parameter values, which is not the actual behavior.
2014-05-27 10:44:58 -05:00
724b63a16c
Replacing the test .todense() methods with .toarray()
2014-05-20 21:44:34 -04:00
185beb3e78
DOC remove comment thanks to @jnothman
...
'All our feature selectors output masks now (as they should, IMO).
It will be turned back into indices only for sparse matrix indexing,
but only until we require scipy >= 0.14 (?).'
2014-05-08 20:56:36 +02:00
db4230a776
TST improve parameter checking + use nose assert_ functions
2014-05-08 20:56:21 +02:00
e58405d6f6
MAINT remove redundant class hierarchy + fix api perform parameter check in fit
2014-05-08 20:56:21 +02:00
a3f81d9a04
Merge pull request #3010 from griffinmyers/fix-select-k-best
...
Fixed SelectKBest corner case: k=0
2014-03-28 09:32:31 +11:00
f1e2e1c874
Fixed SelectKBest corner case: k=0
...
Without this fix k = 0 will have the same behavior as k = 'all' based on how
the array indexing was written.
I've included a test that demonstrates proper behaviour.
2014-03-27 15:18:50 -04:00
2b2c5b2db8
FIX: np.random.randint expects signed 32 bit integers under Windows
2014-03-27 14:20:03 +01:00
Andreas Mueller