Commit Graph

66 Commits

Author SHA1 Message Date
Guillaume Lemaitre 289326704e
MAINT remove option penalty='none' in LogisticRegression (#27857) 2023-11-27 23:37:46 +01:00
John Hopfensperger 6d273cb1df
MAINT Make logistic if statement more explicit (#27809)
Co-authored-by: s-banach <john@hopfensperger.family>
2023-11-20 11:35:47 +01:00
Guillaume Lemaitre c36ab3a6f3
DOC remove default parameter values for private function in logistic module (#27787) 2023-11-16 11:23:44 +01:00
Christian Lorentzen dda6337b2c
ENH scaling of LogisticRegression loss as 1/n * LinearModelLoss (#26721)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2023-10-06 23:49:37 +02:00
Guillaume Lemaitre 286f0c9d17
DOC fixes references issues given by sphinx (#27432) 2023-10-03 20:25:29 +02:00
Tialo 9faa522753
DOC Fixed some typos (#27410) 2023-09-19 12:35:02 +02:00
Adrin Jalali 36c5073601
MNT (SLEP6) remove other_params from provess_routing (#26909)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2023-07-27 17:43:45 +00:00
Malte Londschien 507095b265
DOC Specify primal/dual formulation in LogisticRegression (#26294) 2023-07-25 15:13:04 +02:00
Adrin Jalali 4e679023eb
CLN clean up some repeated code related to SLEP006 (#26836)
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
2023-07-17 15:26:41 +05:00
Omar Salman 02d20c1851
ENH Add routing to LogisticRegressionCV (#26525)
Co-authored-by: Omar Salman <omar.salman@arbisoft>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2023-07-14 19:00:35 +02:00
Adrin Jalali 42173fdb34
MNT add isort to ruff's rules (#26649) 2023-06-21 17:50:07 +02:00
Jérémie du Boisberranger 9c266cf5d6
MAINT Param validation: decorate all estimators with _fit_context (#26473) 2023-06-14 16:52:35 +02:00
Guillaume Lemaitre 9eea5b7092
MAINT unpack 0-dim NumPy array instead of implicit conversion (#26345)
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
2023-06-09 15:07:59 +02:00
Adrin Jalali 893d5accaf
MNT Update black to 23.3.0 (#26110) 2023-04-06 12:14:16 -04:00
Jérémie du Boisberranger e75d8a65bb
MAINT Clean-up remaining SGDClassifier(loss="log") (#25938) 2023-03-22 12:37:13 -04:00
Joey Ortiz 58f80daafa
MAINT LogisticRegression informative error msg when penaly=elasticnet and l1_ratio is None (#25925)
Co-authored-by: jeremiedbb <jeremiedbb@yahoo.fr>
2023-03-22 17:14:06 +01:00
Christian Veenhuis 610a0ce970
DOC unify usage of 'w.r.t.' (#25683) 2023-02-24 09:51:02 +01:00
Guillaume Lemaitre a7cd0ca44d
FIX propagate configuration to workers in parallel (#25363)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2023-01-20 12:44:35 -05:00
Jérémie du Boisberranger 1e9829ae1c
DOC Fix typo in LogisticRegressionCV (#25428) 2023-01-18 11:00:37 -05:00
david-cortes a7728f6036
DOC fix typo in logistic regression (#25263) 2022-12-31 15:17:01 +00:00
Christian Lorentzen bb080aa690
ENH add newton-cholesky solver to LogisticRegression (#24767) 2022-11-03 14:37:11 +01:00
Thomas J. Fan 02ebf9e68f
MNT Adds dict typing hint to _parameter_constraints for mypy (#24301) 2022-08-30 11:01:10 +02:00
Maxwell 3a9e708782
API deprecate penalty='none' for LogisticRegression (#23877)
Co-authored-by: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2022-07-27 15:50:42 +02:00
Jérémie du Boisberranger b9f623cff0
MAINT Param validation: add helper constraint for cv object (#24010) 2022-07-26 13:27:03 -04:00
Jiten Sidhpura 1f0c7e9823
MAINT validate parameters in LogisticRegression and LogisiticRegressionCV (#23565)
Co-authored-by: jeremie du boisberranger <jeremiedbb@yahoo.fr>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2022-06-27 09:20:05 +02:00
Thomas J. Fan 24cda2d780
MNT Fixes flake8 issues (#23542) 2022-06-07 10:08:10 +02:00
martin-kokos 25d5dd02df
DOC Fix extraneous noqa comments (#23285) 2022-05-05 09:46:16 -04:00
Olivier Grisel 4ca4f3bbcd
FIX make the shape of LogisticRegression(solver="liblinear") consistent with other solvers (#21998)
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
2022-02-15 16:40:10 +01:00
Christian Lorentzen d8d5637cfe
ENH Loss module LogisticRegression (#21808)
* ENH replace loss in linear logistic regression

* MNT remove logistic regression's own loss functions

* CLN remove comment

* DOC add whatsnew

* DOC more precise whatsnew

* CLN restore improvements of #19571

* ENH improve fit time by separating mat-vec in multiclass

* DOC update whatsnew

* not only a bit ;-)

* DOC note memory benefit for multiclass case

* trigger CI

* trigger CI

* CLN rename variable to hess_prod

* DOC address reviewer comments

* CLN remove C/F for 1d arrays

* CLN rename to gradient_per_sample

* CLN rename alpha to l2_reg_strength

* ENH respect F-contiguity

* TST fix sag tests

* CLN rename to LinearModelLoss

* CLN improve comments according to review

* CLN liblinear comment

* TST add / move test to test_linear_loss.py

* CLN comment placement

* trigger CI

* CLN add comment about contiguity of raw_prediction

* DEBUG debian-32

* DEBUG test only linear_model module

* Revert "DEBUG test only linear_model module"

This reverts commit 9d6e6987ff.

* DEBUG test -k LogisticRegression

* Revert "DEBUG test -k LogisticRegression"

This reverts commit c203167041.

* Revert "DEBUG debian-32"

This reverts commit ef0b98f232.

* DEBUG set n_jobs=1

* Revert "DEBUG set n_jobs=1"

This reverts commit c7f6f72a8c.

* CLN always use n_threads=1

* CLN address review

* ENH avoid array copy

* CLN simplify L2 norm

* CLN rename w to weights

* CLN rename to hessian_sum and hx_sum

* CLN address review

* CLN rename to init arg and attribute to base_loss

* CLN apply review suggestion

Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>

* CLN base_loss instead of _loss attribute

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
2022-02-14 11:55:17 +01:00
Thomas J. Fan 5f75acdd12
MNT Bump joblib version dependency to 1.0.0 (#22365) 2022-02-09 13:47:18 +01:00
Sultan Orazbayev cd892f9688
DOC use the arxiv directive in the docstrings (#21418)
Co-authored-by: aufarkari <aufar.di.sini@gmail.com>
Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2022-01-28 17:55:55 +01:00
Tom Dupré la Tour 762eca546a
FIX improve error message for large sparse matrix input in LogisticRegression (#21093) 2021-09-24 11:05:53 +02:00
genvalen 642127806a
DOC use backticks for n_samples and n_features in X docstring (#20914) 2021-09-02 13:35:03 +02:00
Thomas J. Fan 786c4e5e39
DOC Adds feature_names_in_ to docstrings (#20787) 2021-08-26 13:44:45 +02:00
Thomas J. Fan 3ae7c76153
STY Enables black with experimental_string_processing=true (#20412) 2021-06-29 09:47:04 +02:00
Luccas Quadros 209b096721
DOC Ensures that LogisticRegressionCV passes numpydoc validation (#20376)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2021-06-28 10:03:06 +02:00
Thomas J. Fan 351ace7935
STY Uses black's with target_version >= 3.7 (#20294) 2021-06-17 15:50:27 -04:00
Thomas J. Fan 82df48934e
MNT Applies black formatting to most of the code base (#18948) 2021-06-17 14:21:09 -04:00
Thomas J. Fan 9a13bdfaf1
MNT Adds black config and fixes formatting before black (#19031)
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
2021-06-12 17:14:09 +02:00
Guillaume Lemaitre 1cd282d600
DOC add n_features_in_ in the documentation (#20236) 2021-06-09 16:58:03 +02:00
michalkrawczyk bc91f01e54
DOC improve penalty/solver/muticlass support in LogisticRegression* (#19855)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2021-05-28 12:25:55 +02:00
Tom Dupré la Tour f6e6ad2d9e
MNT clean futurewarning for 1.0 | _deprecate_positional_args (#20002)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2021-05-14 11:30:27 -04:00
Julien Jerphanion 0c74b8b7d5
ENH Optimize dot product order for LogisticRegression for dense matrices (#19571)
* Use multi_dot for Hessian and gradient product. 
  np.linalg.multi_dot quickly chooses the best order for the multiplication of three matrices.
2021-03-14 15:43:51 +01:00
Yosuke KOBAYASHI 81a56bd8bf
FIX Don't overwrite input sample_weight in LogisticRegression (#19182) 2021-02-01 21:15:36 +01:00
Alex Henrie f35457f1fc
MNT Remove unnecessary assignments from LogisticRegression.fit (#18539) 2020-10-05 22:43:38 +02:00
Thomas J. Fan 06d6f8a9f6
FIX Passes global configuration when spawning joblib jobs (#17634)
* WIP

* BUG Passes context to joblib jobs

* BUG Fix

* BUG Fix

* CLN Moves delayed into fixes

* CLN Adds linter

* REV Revert diff

* DOC Adds comment for removal

* Use a simple implementation
2020-09-21 16:59:42 +02:00
Albert Villanova del Moral 647fcb1ac1
DOC Fix A to uppercase in See Also docstring section (#18332) 2020-09-04 10:35:01 -04:00
Nicolas Hug 1dedc7e6a8
[MRG] Prototype 4 for strict check_estimator mode (#17361) 2020-08-06 12:02:15 +02:00
Juan Carlos Alfaro Jiménez 9cd13a1fa1
FIX Change MRO for some estimators (#17837) 2020-07-05 13:52:42 +02:00
Roman Yurchak 8feb04524c
Common check for sample weight invariance with removed samples (#17176)
Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
2020-06-04 00:30:01 +02:00