Commit Graph

58 Commits

Author SHA1 Message Date
Nicolas Hug 0a5af0d2a1
FEA Successive halving for faster parameter search (#13900)
* More flexible grid search interface

* added info dict parameter

* Put back removed test

* renamed info into more_results

* Passed grroups as well since we need n_to use get_n_splits(X, y, groups)

* port

* pep8

* dabl -> sklearn

* add _required_parameters

* skipping check in rst file if pandas not installed

* Update sklearn/model_selection/_search_successive_halving.py

Co-Authored-By: Joel Nothman <joel.nothman@gmail.com>

* renamed into GridHalvingSearchCV and RandomHalvingSearchCV

* Addressed thomas' comments

* repr

* removed passing group as a parameter to evaluate_candidates

* Joels comments

* pep8

* reorganized user user guide

* renaming

* update user guide

* remove groups support + pass fit_params

* parameter renaming

* pep8

* r_i -> resource_iter

* fixed r_i issues

* examples + removed use of word budget

* Added inpute checking tests

* added cv_resutlts_ user guide

* minor title change

* fixed doc layout

* Addressed some comments

* properly pass down fit_params

* change default value of force_exhaust_resources and update doc

* should fix doc

* Used check_fit_params

* Update section about min_resources and number of candidates

* Clarified ratio section

* Use ~ to refer to classes

* fixed doc checks

* Apply suggestions from code review

Co-authored-by: Joel Nothman <joel.nothman@gmail.com>

* Addressed easy comments from Joel

* missed some

* updated docstring of run_search

* Used f strings instead of format

* remove candidate duplication checks

* fix example

* Addressed easy comments

* rotate ticks labels

* Added discussion in the intro as suggested by Joel

* Split examples into sections

* minor changes

* remove force_exhaust_budget and introduce min_resources=exhaust

* some minor validation

* Added a n_resources_ attribute

* update examples

* Addressed comments

* passing CV instead of X,y

* minor revert for handling fit_params

* updated docs

* fix len

* whatsnew

* Add test for sampling when all_list

* minor change to top-k

* Force CV splits to be consistent across calls

* reorder parameters

* reduced diff

* added tests for top_k

* put back doc for groups

* not sure what went wrong

* put import at its place

* some comment

* Addressed comments

* Added tests for cv_results_ and base estimator inputs

* pep8

* avoid monkeypatching

* rename df

* use Joel's suggestions for testing masks

* Made it experimental

* Should fix docs

* whats new entry

* Apply suggestions from code review

Co-authored-by: Andreas Mueller <t3kcit@gmail.com>

* Addressed comments to docs

* Addressed comments in examples

* minor doc update

* minor renaming in UG

* forgot some

* some sad note about splitter statefulness :'(

* Addressed comments

* ratio -> factor

Co-authored-by: Joel Nothman <joel.nothman@gmail.com>
Co-authored-by: Andreas Mueller <t3kcit@gmail.com>
2020-09-09 17:12:35 +02:00
Nicolas Hug 8061aace11
FIX DOC MNT Big revamp of cross-decomposition module (#17095) 2020-08-31 12:38:39 -04:00
Maren Westermann 4c314923de
DOC alphas_ documentation of LassoLarsIC (#18224) 2020-08-31 10:12:07 +02:00
Nicolas Hug 5bf37e8425
FEA Add sequential feature selection transformer (#17159)
Co-authored-by: rasbt <mail@sebastianraschka.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-08-21 19:57:05 +02:00
Jérémie du Boisberranger 5d2107e999
DOC document and deprecate missing attributes in MiniBatchKMeans (#17864) 2020-07-12 16:29:44 +02:00
Shail Shah a293a6ce7c
DOC added attributes in LassoLarsCV (#17838) 2020-07-10 12:33:06 +02:00
Yashika Sharma 0edfedb532
DOC Added missing attributes to OneVsRest Classifier (#17844)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-07-10 10:30:14 +02:00
Thomas J. Fan 233f2ce052
DEP deprecate grid_score_ and cv_alphas_ in GraphicalLassoCV (#16392)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-07-09 11:14:02 +02:00
t-kusanagi2 3c6db87ce2
DOC Add missing attrributes in ElasticNet and etc (#17740)
Co-authored-by: BenjaminLiu <imbenliu@gmail.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-07-06 15:44:33 +02:00
Juan Carlos Alfaro Jiménez 3561802bdc
MNT Deprecate coef_ and intercept_ in naive bayes estimators (#17427) 2020-07-05 21:03:30 +10:00
Jie Zheng 3491e07044
DOC add missing attributes to LocalOutlierFactor (#17696)
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-06-26 09:52:02 +02:00
Kendrick Cetina 2c7107089c
DOC improve attributes and parameters descriptions in RFE and RFECV (#17721)
Co-authored-by: Beatriz San Miguel <beatriz.sanmiguelgonzalez@uk.fujitsu.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-06-25 18:46:31 +02:00
Jie Zheng e781ae8e3c
DOC add missing attributes to MDS (#17697) 2020-06-25 10:12:51 +02:00
Naoki Hamada 7cc8503919
DOC add missing attributes in KernelDensity (#17705)
Co-authored-by: Naoki Hamada <hamada-naoki@jp.fujitsu.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>
2020-06-24 21:23:09 +02:00
simonamaggio a109dff722
DOC add missing attributes in HistGradientBoostingRegressor (#17677)
Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-06-24 19:27:07 +02:00
Kendrick Cetina 4a97ad49c1
DOC add missing attributes in GaussianProcessClassifier (#17698)
Co-authored-by: Beatriz San Miguel <beatriz.sanmiguelgonzalez@uk.fujitsu.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-06-24 18:38:28 +02:00
simonamaggio 683b3e51ee
DOC add missing attributes in GradientBoostingRegressor (#17671) 2020-06-24 08:56:47 +02:00
Louis Douge aec1f6dc09
DOC Adding missing attributes to the MLP classes docstring (#17669)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2020-06-24 08:54:43 +02:00
simonamaggio 3d098af4cc
DOC add missing attributes in RBFSampler (#17668)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-06-23 17:21:09 +02:00
beatrizsmg be9492ca1e
DOC add missing attributes in IsolationForest (#17667)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Kendrick Cetina <kendrick.cetina@uk.fujitsu.com>
2020-06-23 15:43:09 +02:00
simonamaggio c9f8f52a78
DOC add missing attributes in LatentDirichletAllocation (#17666) 2020-06-23 14:51:52 +02:00
t-kusanagi2 195f2f4d50
DOC document all attributes in PLSRegression (#17664) 2020-06-23 14:35:02 +02:00
pwalchessen 89b80a6c67
DOC add missing attributes in several modules (#15521)
Co-authored-by: Patricia Walchessen <pwalchessen@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-06-18 11:18:23 +02:00
Nicolas Hug 1931e142ed
Remove deprecated utils (#17133) 2020-05-20 22:03:54 +02:00
Hannah Bohle c36c1047fe
DOC Ensure All Attributes are Documented: OAS: location_ added (#17163) 2020-05-09 11:28:00 -04:00
Chiara Marmo f72d9711f5
ENH Add random_state parameter to AffinityPropagation (#16801)
* Added value checks and random state parameter to method

* Changed default parameter to None instead of 0

* Added numpy RandomState to the check

* Replaced inline validation with check_random_state from utils and pointed at glossery

* Needed a different default parameter to pass the default way this has been working in the past

* Updated to conform with flake8 stds

* Add random_state to AffinityPropagation class.

* Add test.

* Add what's new entry and versionadded directive.

* Add PR number.

* Fix lint error due to this PR.

* Use np.array_equal in test.

* Update sklearn/cluster/_affinity_propagation.py

Co-Authored-By: Adrin Jalali <adrin.jalali@gmail.com>

* Homogenize parametre descriptions, default random_state to None.

* Update sklearn/cluster/_affinity_propagation.py

Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

* Update sklearn/cluster/_affinity_propagation.py

Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

* Update sklearn/cluster/_affinity_propagation.py

Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

* Update doc/whats_new/v0.23.rst

Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

* Change test name.

* Modify check in test.

* Fix lint errors.

* Address comment.

* Address comment.

* Add 'deprecation' and its correspondent test.

* Fix lint errors.

* Add random_state parameter to tests, to avoid FutureWarnings.

* Move warning in fit. Modify tests.

* Modify example.

* Tentative fix for failures.

* Document default value to 0. Revert docstring.

* Explicit link to Glossary.

* Fix default value.

* Remove some warnings from tests.

* Validate and test docstring.

* Tentative fix.

* Tentative fix.

* Ignore FutureWarning in fit attribute test.

* Set random_state to avoid FutureWarning in test_fit_docstring_attributes.

* [doc build] Force documentation build.

* Clarify warning message.

Co-authored-by: rwoolston.admin <rwoolston.admin@LXO-DS-DEV.afcucorp.local>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
2020-05-05 16:40:38 +02:00
Nicolas Hug cb49ad4751
MNT removed _safe_tags utility (#16950) 2020-04-18 20:14:22 -04:00
Roman Yurchak 5a4340834d
Fix mypy errors (#16726) 2020-03-30 15:41:05 +02:00
Alexandre Gramfort 60b8fb221b
TST add test of fit attributes (#16286) 2020-03-04 13:52:13 +01:00
Roman Feldbauer 9b39c4c4d2
TST Fix unreachable code in tests (#16110) 2020-02-16 14:41:26 +01:00
judithabk6 05476a1d38
TST Add test for documentation of the classes_ attribute (#16277)
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
2020-01-31 14:12:43 +01:00
Guillaume Lemaitre a5542e9490 BUG fix pip3 ubuntu update by suffixing file (#15928) 2019-12-20 11:11:20 -05:00
Thomas J Fan f447dbcc1f MNT Uses pep562 to import private methods (#15431) 2019-11-04 10:08:31 +01:00
Nicolas Hug 19ad136223 MNT Replace DeprecationWarning with FutureWarning (#15080)
* bruteforce renaming

* WIP

* WIP

* some more

* removed weird line

* update -Werror

* testiforest

* again

* Fixed some tests

* fixed some tests

* removed -Werror

* fixed test_docstring_param issue

* fixed some tests

* some more

* renamed to SklearnDeprecationWarning

* pep8

* updated docs

* pep8

* merge

* changed to FutureWarning

* fixes

* Update doc/developers/tips.rst

Co-Authored-By: Adrin Jalali <adrin.jalali@gmail.com>

* avoid duplicates

* fixed warning for deprecations

* Still make CI break if DeprecationWarning isn't caught

* updated one warning

* fixed test

* fixed some renamings

* updated new dep warnings

* fixed bad import

* ignore warnings

* update again

* ignore futurewarning when walking packages

* Fixed test

* pep8

* Added whatsnew
2019-10-29 15:39:26 +01:00
Nicolas Hug b92455a6b2 MAINT Deprecate all of utils.testing except all_estimators (#15367) 2019-10-28 17:28:56 +01:00
Thomas J Fan bb3b3f9261 MNT Make modules private in feature_extraction (#15321) 2019-10-25 16:41:13 -04:00
Adrin Jalali 19c068a2ec MNT towards removing assert_equal, etc (#14222) 2019-07-01 09:13:32 -04:00
Antonio Gutierrez 8681ece373 ENH Fix unfriendly error message for documentation checks (#11967)
Previously error messages for mismatches parameters on function/method
signatures and docstrings were not explicit or user-friendly. This
changes provides a more explicit error message and in addition notifies
the relation of missing/mismatching parameters from signature to
docstring and from docstring to signature.
2019-06-21 17:06:57 -07:00
Hanmin Qin 575064b8e1
MNT More clean up after we remove python < 3.5 (#13078) 2019-02-02 22:01:13 +08:00
Adrin Jalali 2bd87f6ed8 Remove python < 3.5 from CI (#12746) 2018-12-14 10:53:12 +01:00
Thomas Moreau d25da1be20 FIX make joblib utils private, and remove mentions of externals.joblib (#12345) 2018-11-20 10:53:52 +11:00
Joel Nothman d0e99db0a2 TST don't test utils.fixes docstrings (#12576) 2018-11-13 16:25:11 +01:00
Roman Yurchak b91cbda20d [MRG] MNT Re-enable PyPy CI (#12039) 2018-09-18 23:09:07 +02:00
Nicolas Hug 72b2ed9ee1 DOC Added docstring checks for dataset module (#11407) 2018-07-24 10:57:13 +10:00
Nicolas Hug 6d15840432 DOC Fixed doc issues for utils module (#11445) 2018-07-22 15:23:11 +10:00
Ronan Lamy 5592a2eda9 [MRG] PyPy support for all but a couple of estimators (#11010) 2018-07-20 14:39:53 +10:00
Nicolas Hug 813d7de9b4 DOC Added docstring checks for feature_selection, kernel_approximation and neighbors modules (#11421) 2018-07-20 08:24:39 +10:00
Olivier Grisel b30e1cd4d0 Ignore DeprecationWarning in test_docstring_parameters caused by numpydoc on Python 3.7 2018-07-18 00:38:11 +02:00
Nicolas Hug 671fe79a5d [MRG] Added docstring checks for ensemble module (#11418)
* Added docstring checks for ensemble module
2018-07-17 17:02:43 +02:00
Nicolas Hug e860fd2d12 DOC parameters for gaussian_process and linear_model modules (#11415) 2018-07-15 16:06:05 +10:00