Commit Graph

368 Commits

Author SHA1 Message Date
Ankit Choraria 9120be9d65
DOC remove irrelevant parts in _validation.py (#18548) 2020-10-07 08:15:40 -04:00
Thomas J. Fan 02fa8f1adb
ENH Deprecates _pairwise attribute and adds pairwise to estimator tags (#18143) 2020-10-07 21:53:36 +11:00
Nicolas Hug e2583d45f7
DOC put back original anchor to avoid breaking links (#18551) 2020-10-06 23:45:16 -04:00
Nicolas Hug 521b3f289a
MNT Minor refactoring _fit_and_predict (#18471) 2020-09-30 12:35:46 +02:00
Frans Larsson c7d29e31bf
DOC Fix default values in _validation.py (#18337)
Co-authored-by: Juan Carlos Alfaro Jiménez <JuanCarlos.Alfaro@uclm.es>
2020-09-24 11:20:53 -04:00
Albert Villanova del Moral 547ed6b182
DOC Improve links in cross_validation's user guide (#18379) 2020-09-24 11:19:09 -04:00
Thomas J. Fan 06d6f8a9f6
FIX Passes global configuration when spawning joblib jobs (#17634)
* WIP

* BUG Passes context to joblib jobs

* BUG Fix

* BUG Fix

* CLN Moves delayed into fixes

* CLN Adds linter

* REV Revert diff

* DOC Adds comment for removal

* Use a simple implementation
2020-09-21 16:59:42 +02:00
Alex Itkes 8b68ea165c
DOC specify default of error_score in cross_validate (#14488) 2020-09-18 15:43:52 -04:00
Nicolas Hug 0a5af0d2a1
FEA Successive halving for faster parameter search (#13900)
* More flexible grid search interface

* added info dict parameter

* Put back removed test

* renamed info into more_results

* Passed grroups as well since we need n_to use get_n_splits(X, y, groups)

* port

* pep8

* dabl -> sklearn

* add _required_parameters

* skipping check in rst file if pandas not installed

* Update sklearn/model_selection/_search_successive_halving.py

Co-Authored-By: Joel Nothman <joel.nothman@gmail.com>

* renamed into GridHalvingSearchCV and RandomHalvingSearchCV

* Addressed thomas' comments

* repr

* removed passing group as a parameter to evaluate_candidates

* Joels comments

* pep8

* reorganized user user guide

* renaming

* update user guide

* remove groups support + pass fit_params

* parameter renaming

* pep8

* r_i -> resource_iter

* fixed r_i issues

* examples + removed use of word budget

* Added inpute checking tests

* added cv_resutlts_ user guide

* minor title change

* fixed doc layout

* Addressed some comments

* properly pass down fit_params

* change default value of force_exhaust_resources and update doc

* should fix doc

* Used check_fit_params

* Update section about min_resources and number of candidates

* Clarified ratio section

* Use ~ to refer to classes

* fixed doc checks

* Apply suggestions from code review

Co-authored-by: Joel Nothman <joel.nothman@gmail.com>

* Addressed easy comments from Joel

* missed some

* updated docstring of run_search

* Used f strings instead of format

* remove candidate duplication checks

* fix example

* Addressed easy comments

* rotate ticks labels

* Added discussion in the intro as suggested by Joel

* Split examples into sections

* minor changes

* remove force_exhaust_budget and introduce min_resources=exhaust

* some minor validation

* Added a n_resources_ attribute

* update examples

* Addressed comments

* passing CV instead of X,y

* minor revert for handling fit_params

* updated docs

* fix len

* whatsnew

* Add test for sampling when all_list

* minor change to top-k

* Force CV splits to be consistent across calls

* reorder parameters

* reduced diff

* added tests for top_k

* put back doc for groups

* not sure what went wrong

* put import at its place

* some comment

* Addressed comments

* Added tests for cv_results_ and base estimator inputs

* pep8

* avoid monkeypatching

* rename df

* use Joel's suggestions for testing masks

* Made it experimental

* Should fix docs

* whats new entry

* Apply suggestions from code review

Co-authored-by: Andreas Mueller <t3kcit@gmail.com>

* Addressed comments to docs

* Addressed comments in examples

* minor doc update

* minor renaming in UG

* forgot some

* some sad note about splitter statefulness :'(

* Addressed comments

* ratio -> factor

Co-authored-by: Joel Nothman <joel.nothman@gmail.com>
Co-authored-by: Andreas Mueller <t3kcit@gmail.com>
2020-09-09 17:12:35 +02:00
Albert Villanova del Moral 647fcb1ac1
DOC Fix A to uppercase in See Also docstring section (#18332) 2020-09-04 10:35:01 -04:00
Albert Villanova del Moral 875d32fe55
DOC Fix versionadded/versionchanged for 0.24 (#18312) 2020-09-01 10:51:01 +02:00
subrat93 192c2333fe
ENH Raises warning when getting non-finite score in SearchCV (#18266)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-08-29 10:34:02 -04:00
Frans Larsson c6579afdc4
DOC add None as valid option to random_state in model_selection module (#18232) 2020-08-22 17:32:36 +02:00
Nicolas Hug 28c1ed473f
[MRG] FIX len() of ParameterSampler (#18222)
* fix len

* whatsnew
2020-08-21 13:13:31 -04:00
Thomas J. Fan ad9cef3696
TST Uses regex for flaky test (#18209) 2020-08-21 08:03:08 +10:00
Lucy Liu 018de22323
DOC Add user guide for permutation_test_score (#18055)
* wip

* add user guide

* fix link to ex

* suggestion

* suggestions
2020-08-13 19:34:55 -04:00
Lucy Liu 793f974e26
DOC Add doc for permutation_test_score (#17373) 2020-07-31 09:42:36 +02:00
Lucy Liu d3a3d214fc
DOC Fix return docstring cross_val_predict (#18035) 2020-07-30 10:46:56 -07:00
Thomas J. Fan 9acfaab966
ENH Adds support for multimetric callable return a dictionary (#15126) 2020-07-16 17:55:40 +02:00
Lucy Liu 4746e2117a
DOC Clarify return of cross_val_predict (#17851) 2020-07-12 17:07:24 -04:00
Thomas J. Fan 88b1fa6f0e
MNT Small refactor for cross_validate (#17867) 2020-07-09 14:00:27 +10:00
Juan Carlos Alfaro Jiménez 9cd13a1fa1
FIX Change MRO for some estimators (#17837) 2020-07-05 13:52:42 +02:00
Christos Aridas ffbb1b4a0b
MNT Collapse an unnecessary enclosed if statement (#17766)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-07-02 08:16:56 -04:00
Juan Carlos Alfaro Jiménez 0e33229351
FIX Extract estimator objects before aggregating dict of scores (#17745)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-06-26 21:15:41 -04:00
Thomas J. Fan 67bf1e78f5
ENH _fit_and_score now returns a dictionary (#17332)
* ENH _fit_and_score now returns a dictionary

* MRG

* REV

* LOL

* Removing things in gitignore is fun
2020-06-26 12:38:12 +02:00
Hirofumi Suzuki c95ed757b4
DOC add explanation of n_jobs in sklearn/model_selection/_validation.py (#17717) 2020-06-25 14:25:16 +02:00
Thomas J. Fan 7cc0177f8e
MNT Replaces numpy alias with builtin typse (#17687)
* MNT Replaces numpy alias with builtin typse

* STY Lint error
2020-06-24 16:51:51 +02:00
Koki Nishihara e02e1bf7cb
FIX: Remove checks for old Scipy versions (#17685) 2020-06-24 10:02:15 +02:00
Chiara Marmo fc0d2c3210
[MRG] ENH Show split/candidate ids in verbose output of SearchCV (#16935) 2020-06-19 11:26:58 +02:00
Teon L Brooks 5d04910476
ENH add score_samples method in base search CV (#17478)
* add score_samples method in base search CV and add tests

* add tests and change implem

* fix pep8

* address some pr comments

* Update test_search.py

remove deprecation warnings

* address some linting issues

* Update test_search.py

* update whats_new

fix indenting

* update test_search.py

Co-authored-by: Mohamed Maskani <maskani.mohamed@gmail.com>
2020-06-08 18:14:12 +02:00
Zaccharie Ramzi d42611f11b
DOC Emphasized determinism of ParameterGrid in docs (#17383) 2020-05-31 21:26:50 -04:00
Benjamin Bossan 76df39f703
ENH allow to specify which methods should run a check in CheckingClassifier (#15230)
Co-authored-by: BenjaminBossan <b.bossan@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-05-26 11:37:12 +02:00
Nicolas Hug ac8cbb3799
[MRG] More deprecation for 0.24 (#17142)
* normalize_components in sparsePCA

* changed default strategy of Dummy to prior and removed outputs_2d ttribute

* removed usage of None to drop estimator in ensemble and behaviour param of IsolationForest

* remove support for drop=None in Voting

* removed some warning decorators

* remove feature_extraction.extract_patches

* removed VectorizerMixin and copy parameter from TFIDFVectorizer

* kernel.set_params now raises attributeerror

* removed fig from plot_partial_dependence

* removed iid parameter of search estimators

* removed brier_scorer

* raise error in split when shuffle is False and random_state is not None

* removed MultiOutputEstimator

* removed base classes of NaiveBayes

* removed drop from pipeline

* removed utils in random_projection

* removed presort and classes_ in trees

* flake8

* fixed some tests

* flake

* fixed docstring

* fixed other one

* some left

* mmmm
2020-05-20 16:04:14 -04:00
barberogaston 26b26789a6
DOC Fix RandomizedSearchCV's docstring by changing the cv_results_ data (#17275) 2020-05-20 14:11:46 +02:00
Hugo Le Moine 8abe0a822e
MNT Replaced kwargs by named args for train_test_split (#17216) 2020-05-14 09:21:01 -04:00
Kyle Kosic b4e215c01c
FEA Additional `TimeSeriesSplit` Functionality (#13204)
Co-authored-by: Kyle Kosic <kylekosic@Kyles-MacBook-Pro.local>
Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
2020-05-11 21:48:01 -04:00
Lucy Liu c7a4bc9b3a
TST Replace Boston dataset in test_validation (#17146) 2020-05-08 17:53:15 -04:00
Nicolas Hug ad6fc80425
DOC fix indentation in cv parameter description (#17161) 2020-05-08 16:03:43 -04:00
brigi dbc35934a6
DOC Version added and changed labels added for v0.18 (#wimlds) (#16222)
* Versionlabels added to v0.18 (#wimlds)

* documentation issues: label changed and added for version 0.18

* fix intends and shorten description

Co-authored-by: Hannah <32333241+hhnnhh@users.noreply.github.com>
Co-authored-by: Brigitte@home <unger@nue.tu-berlin.de>
2020-04-27 18:43:47 -04:00
Ekaterina Borovikova 4755ae76d2
DOC Add versionchanged and versionadded for v0.20 (#16199)
Co-Authored-By: Adrin Jalali <adrin.jalali@gmail.com>
Co-Authored-By: Chiara Marmo <cmarmo@users.noreply.github.com>
Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
2020-04-26 09:29:36 -04:00
Adrin Jalali 02309ffbda
API kwonly args in manifold, metrics, mixture, model_selection, multclass, multioutput (#16982) 2020-04-24 17:24:24 -04:00
Nicolas Hug 2587a03380
[MRG] DOC fix ref for ParameterSampler (#16983) 2020-04-24 10:28:56 -04:00
Stephen Marsh 361bf75544
DOC Fix link to user guide (#16989) 2020-04-24 09:25:39 -04:00
Noa Tamir 5e2d74bc5f
DOC add versionadded versionchanged v0.19 (#16233)
* added v0.19.1 and wip v0.19

* finished adding vchanged strings for v0.19

Towards #15426

@adrinjalali #wimlds #scikitlearnsprint

* fixing linter issues

* caught line issues with flake8

* caught the last line issue

* added lines and cleaned gtiignore

* Update sklearn/multiclass.py

Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>

* Update sklearn/multiclass.py

Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>

Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
2020-04-15 10:36:51 +02:00
Michael Shoemaker f31e25bbb5
ENH Better error message needed when accidentall… (#16861) 2020-04-10 14:32:24 -04:00
Roman Yurchak 5a4340834d
Fix mypy errors (#16726) 2020-03-30 15:41:05 +02:00
Roman Yurchak 75d3f29e72
MAINT Remove outdated numpy and scipy backports (#16725)
* Remove unecessary numpy & scipy backports

* More fixes

* Remove unused imports
2020-03-20 13:57:18 +01:00
Nicolas Hug d205638475
MNT Introduction of n_features_in_ attr with _validate_data mtd (#16112) 2020-02-29 09:05:11 -05:00
Roman Feldbauer 9b39c4c4d2
TST Fix unreachable code in tests (#16110) 2020-02-16 14:41:26 +01:00
Arie Pratama Sutiono c2e742c48c
API Deprecates the fit_grid_point function (#16401) 2020-02-13 22:07:06 -05:00