Commit Graph

16 Commits

Author SHA1 Message Date
Olivier Grisel 548a4524b4
MNT n_features_in_ consistency in decomposition (#18557)
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
2020-10-08 09:47:24 -04:00
Guillaume Lemaitre 21569e719c
TST Common test preserve dtype (#18054)
Co-authored-by: Sebastian Kießling <sebkies@gmail.com>
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
2020-09-08 10:13:53 +02:00
Frans Larsson 30f201f914
DOC Add None as valid option to random_state (#18234) 2020-08-22 17:30:45 +02:00
clmbst 46b7d8a76c
DOC Fix documentation of default values in decomposition module (#17739)
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-08-21 22:42:44 +02:00
indecisiveuser d5ae541a09
DOC fix formatting docstrings in pca module (#18182) 2020-08-18 14:28:10 +02:00
crispinlogan b3dca3d025
DOC update PCA random_state description (#17293) 2020-05-20 12:59:31 -04:00
Nicolas Hug 226e5c478d
MNT Use Vt instead of V as returned by svd() (#17100) 2020-05-05 19:52:07 +02:00
Thomas J Fan c531bd0d86
API Adds missing keyword only argument to PCA (#16975) 2020-04-21 16:21:48 +02:00
Nicolas Hug a655de515e
[MRG] MNT Fixes for PCA with n_components='mle' (#16841)
* Fixed off by one in MLE and better handling of small eigenvalues

* light update tests

* pep8

* Added test + threhsold on small log
2020-04-07 22:12:40 +02:00
Adrin Jalali d6d624db5d
API make __init__ params in decomposition kwonly (#16722)
* DOC make __init__ params in decomposition kwonly

* test fixes

* pep8
2020-03-31 10:28:36 +02:00
Lisa Schwetlick ea3181879c
FIX Adress decomposition.PCA mle option problem (#16224) 2020-03-04 16:26:50 +01:00
Nicolas Hug d205638475
MNT Introduction of n_features_in_ attr with _validate_data mtd (#16112) 2020-02-29 09:05:11 -05:00
krishnachaitanya9 fd12d5684a BUG take n_components strictly greater than fraction of explai… (#15669) 2020-01-22 13:49:45 -05:00
Sarat Addepalli cd6e4d52d9 DOC improve random_state docstring from decomposition module (#11902)
* [MRG] Fix random_state docstrings in decomposition module

* Add more details, and specify reproducibility

* [MRG] docs for random_state in decomposition module

Update the wording for reproducible results.

* [MRG] Update doc for optional parameter to match numpy doc style

* apply new style

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-01-08 18:53:01 +01:00
Alexandre de Siqueira cf21cf0ae6 DOC Applying numpydoc validation to decomposition.PCA (#15467) 2019-11-04 01:19:53 +01:00
Thomas J Fan 5756a9934b MNT Make modules private in decomposition (#15344) 2019-10-28 22:46:16 +08:00