548a4524b4
MNT n_features_in_ consistency in decomposition ( #18557 )
...
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
2020-10-08 09:47:24 -04:00
02fa8f1adb
ENH Deprecates _pairwise attribute and adds pairwise to estimator tags ( #18143 )
2020-10-07 21:53:36 +11:00
58451568d3
FIX TruncatedSVD.fit_transform returns the same as fit.transform ( #18528 )
...
Co-authored-by: zhengruifeng <ruifengz@foxmail.com>
2020-10-06 22:47:10 +02:00
49ec619232
DOC Fix missing References ( #18450 )
2020-09-29 15:17:43 -04:00
339fe04e32
CLN Removes unneeded attribute in FastICA ( #18445 )
2020-09-28 09:01:18 -06:00
06d6f8a9f6
FIX Passes global configuration when spawning joblib jobs ( #17634 )
...
* WIP
* BUG Passes context to joblib jobs
* BUG Fix
* BUG Fix
* CLN Moves delayed into fixes
* CLN Adds linter
* REV Revert diff
* DOC Adds comment for removal
* Use a simple implementation
2020-09-21 16:59:42 +02:00
21569e719c
TST Common test preserve dtype ( #18054 )
...
Co-authored-by: Sebastian Kießling <sebkies@gmail.com>
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
2020-09-08 10:13:53 +02:00
647fcb1ac1
DOC Fix A to uppercase in See Also docstring section ( #18332 )
2020-09-04 10:35:01 -04:00
30f201f914
DOC Add None as valid option to random_state ( #18234 )
2020-08-22 17:30:45 +02:00
46b7d8a76c
DOC Fix documentation of default values in decomposition module ( #17739 )
...
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-08-21 22:42:44 +02:00
a8bf63a8ed
DOC fix docstring in _dict_learning.py module ( #17897 )
...
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-08-21 17:40:45 +02:00
d5ae541a09
DOC fix formatting docstrings in pca module ( #18182 )
2020-08-18 14:28:10 +02:00
acf195cc74
FIX use specific threshold to discard eigenvalues with 32 bits fp( #18149 )
...
Co-authored-by: Sylvain MARIE <sylvain.marie@se.com>
2020-08-13 13:57:04 +02:00
f734e11a53
ENH: Add regularization to the main NMF class ( #17414 )
...
* ENH: Add regularization to the main NMF class
* Update _nmf with suggestions from code review
Update `_nmf.py` with suggestion from review
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
* Refactor tests, fix linter errors
* Change default value to None
* Revert back to default value of "both"
* Update default value documentation acc to @thomasjpfan
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
* CLN Places regularization at the end
* Add whatsnew entry
* DOC Fix
* DOC Fix
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-08-06 12:04:17 -07:00
2fc535fb11
DOC Fix documentation of default values in fastica.py ( #17989 )
2020-08-05 15:51:09 -04:00
9b3378fa0f
TST: Use assert_allclose instead of equality in FP comparison ( #18053 )
2020-08-01 10:00:28 +02:00
4a60ec129d
TST Added test for Incremental pca value error fix ( #17985 )
...
Co-authored-by: Allan <allanbutler9@gmail.com>
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
2020-07-26 10:34:08 +10:00
1bd869ae42
TST Test for both solvers in test_nmf_sparse_input ( #17947 )
2020-07-20 13:31:19 +02:00
598ed4cbf9
DOC cleaning parameter docstrings in decomposition/_dict_learning.py ( #17896 )
...
* update formatting for default value for consistency'
* Update sklearn/decomposition/_dict_learning.py
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
* update formatting for alpha default value for consistency
* Update sklearn/decomposition/_dict_learning.py
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
2020-07-14 11:56:25 +02:00
256949676e
DOC Small doc formatting fixes in decomposition ( #17918 )
2020-07-14 11:33:52 +02:00
5e193ec655
[MRG] varimax rotation for factor analysis ( #11064 )
...
* init varimax
* fix py2 and add example text
* fix print again
* test, docs
* fix test
* fix doctstring
* np.allclose for test
* add refrence
* address comments
* update
* Fix linting failure.
* Fix deprecation warning.
* a bit of cleanup
* Address @jnothman's review comments.
* Update section divider
* Add note in what's new page and versionadded to docstring.
Co-authored-by: Eric Prestat <eric.prestat@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-07-05 21:29:08 +02:00
180646fa18
PERF Dot product optimizations using multi_dot ( #17737 )
2020-07-04 10:58:59 +02:00
e4aab357e9
DOC improve attributes and parameters descriptions in KernelPCA ( #17747 )
...
Co-authored-by: Beatriz San Miguel <beatriz.sanmiguelgonzalez@uk.fujitsu.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
2020-06-26 18:00:50 +02:00
b0c03d1280
BUG fix SparseCoder to follow scikit-learn API and allow cloning ( #17679 )
...
* BUG fix SparseCoder to follow scikit-learn API
* TST check that get_params and set_params work as expected
* address comments
* PEP8
* iter
* Fixes #8675 , fix cloning for SparseCoder
* remove spaces
* Update _dict_learning.py
* fix confusing arguments
* remove unnecessary code
* Update test_common.py
* removes spaces
* PEP8
* iter
* fix merge
* ignore a mypy warning
* type: ignore
* remove one deprecated verification
* Update sklearn/decomposition/_dict_learning.py
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
* Update sklearn/decomposition/_dict_learning.py
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
* Update sklearn/decomposition/tests/test_dict_learning.py
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
* test clone produces different id
* review
* add one more test
* lint
* Update sklearn/decomposition/tests/test_dict_learning.py
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2020-06-25 23:05:19 +02:00
7cc0177f8e
MNT Replaces numpy alias with builtin typse ( #17687 )
...
* MNT Replaces numpy alias with builtin typse
* STY Lint error
2020-06-24 16:51:51 +02:00
9ea4edd970
DOC fix documentation of default values in decomposition._dict_learning ( #17645 )
...
Co-authored-by: BISOT Clemence (SAFRAN AIRCRAFT ENGINES) <clemence.bisot@safrangroup.com>
2020-06-24 11:13:21 +02:00
c9f8f52a78
DOC add missing attributes in LatentDirichletAllocation ( #17666 )
2020-06-23 14:51:52 +02:00
03f8a2ec15
DOC Improves doc formatting in SparseCoder and DictionaryLearning ( #17620 )
2020-06-17 13:55:20 -04:00
11c6705866
DOC add examples to SparseCoder and DictionaryLearning ( #17521 )
...
Co-authored-by: Mariam-ke <mariam.haji01@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-06-15 14:50:35 +02:00
98f0b832f8
[MRG+1] Make partial_fit ignore n_iter in MiniBatchDictionaryLearning ( #17433 )
...
* Make partial_fit ignore n_iter.
* Revert whiteline.
* Fix self.iter_offset.
* Add test on iter_offset_
* Add what's new entry
* Apply thomasjpfan suggestions.
2020-06-09 08:54:28 +02:00
b364028ecd
MNT Enables subset_invariance tests to run with SparsePCA ( #17319 )
2020-06-03 19:11:34 +02:00
0e0423943c
DOC Clarify how initial conditions are chosen for NMF. ( #17369 )
2020-06-03 09:39:16 -04:00
332aaa112b
DOC cleaning parameter docstrings in _dict_learning.py ( #17376 )
2020-06-01 12:20:51 -04:00
7494da6f52
MNT removed deprecated files generation ( #17132 )
2020-05-25 17:34:17 +02:00
ac8cbb3799
[MRG] More deprecation for 0.24 ( #17142 )
...
* normalize_components in sparsePCA
* changed default strategy of Dummy to prior and removed outputs_2d ttribute
* removed usage of None to drop estimator in ensemble and behaviour param of IsolationForest
* remove support for drop=None in Voting
* removed some warning decorators
* remove feature_extraction.extract_patches
* removed VectorizerMixin and copy parameter from TFIDFVectorizer
* kernel.set_params now raises attributeerror
* removed fig from plot_partial_dependence
* removed iid parameter of search estimators
* removed brier_scorer
* raise error in split when shuffle is False and random_state is not None
* removed MultiOutputEstimator
* removed base classes of NaiveBayes
* removed drop from pipeline
* removed utils in random_projection
* removed presort and classes_ in trees
* flake8
* fixed some tests
* flake
* fixed docstring
* fixed other one
* some left
* mmmm
2020-05-20 16:04:14 -04:00
b3dca3d025
DOC update PCA random_state description ( #17293 )
2020-05-20 12:59:31 -04:00
e770715c43
MNT Completes position arg deprecation ( #17272 )
...
* ENH Adds public functions with position args warning
* BUG Circlar import
* STY
* BUG Add keywords
* BUG Fixes warnings
* ENH Adds other public functions
* CLN Suggestion
* CLN Suggestion
* REV Revert pairwise
* ENH Positoinal args for compute_class_weight
2020-05-19 09:07:25 +02:00
b6e839cb67
CLN Remove duplicate line ( #17254 )
2020-05-16 22:36:42 -04:00
a4b59c793a
DOC fix links in truncated SVD docs ( #17194 )
2020-05-16 18:28:54 -04:00
226e5c478d
MNT Use Vt instead of V as returned by svd() ( #17100 )
2020-05-05 19:52:07 +02:00
41b18fea37
ENH Added n_components_ to SparsePCA and MiniBatchSparsePCA ( #16981 )
...
* Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA
* Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA
* Add whatsnew entry
* Fix documentation
* Apply suggestions from code review
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
* Add suggested changes
* Update test_sparse_pca.py
Co-authored-by: Mateusz Górski <mateuszg122@gmail.com>
Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
2020-04-27 17:32:19 -04:00
HaoYin
923d8879e2
DOC Fix a typo in comment ( #17037 )
2020-04-25 14:08:10 -04:00
c531bd0d86
API Adds missing keyword only argument to PCA ( #16975 )
2020-04-21 16:21:48 +02:00
2d03d781a9
MNT simplify xfail check marking logic ( #16949 )
...
Co-Authored-By: Roman Yurchak <rth.yurchak@gmail.com>
2020-04-17 13:44:09 -04:00
5e2d74bc5f
DOC add versionadded versionchanged v0.19 ( #16233 )
...
* added v0.19.1 and wip v0.19
* finished adding vchanged strings for v0.19
Towards #15426
@adrinjalali #wimlds #scikitlearnsprint
* fixing linter issues
* caught line issues with flake8
* caught the last line issue
* added lines and cleaned gtiignore
* Update sklearn/multiclass.py
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
* Update sklearn/multiclass.py
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
2020-04-15 10:36:51 +02:00
a655de515e
[MRG] MNT Fixes for PCA with n_components='mle' ( #16841 )
...
* Fixed off by one in MLE and better handling of small eigenvalues
* light update tests
* pep8
* Added test + threhsold on small log
2020-04-07 22:12:40 +02:00
b2bc40ca8b
FIX Improve TruncatedSVD.transform on sparse csc matrices ( #16837 )
2020-04-05 11:09:20 +02:00
557218c021
FIX Truncated SVD should raise a NotFittedError if not fitted ( #16821 )
2020-04-02 09:52:26 +02:00
d6d624db5d
API make __init__ params in decomposition kwonly ( #16722 )
...
* DOC make __init__ params in decomposition kwonly
* test fixes
* pep8
2020-03-31 10:28:36 +02:00
75d3f29e72
MAINT Remove outdated numpy and scipy backports ( #16725 )
...
* Remove unecessary numpy & scipy backports
* More fixes
* Remove unused imports
2020-03-20 13:57:18 +01:00
Olivier Grisel
HaoYin