Commit Graph

53 Commits

Author SHA1 Message Date
Christian Kastner 5af6561441
TST Change expected result type np.int64 -> np.int (#18089)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-08-07 08:46:53 +02:00
xavier dupré b0c03d1280
BUG fix SparseCoder to follow scikit-learn API and allow cloning (#17679)
* BUG fix SparseCoder to follow scikit-learn API

* TST check that get_params and set_params work as expected

* address comments

* PEP8

* iter

* Fixes #8675, fix cloning for SparseCoder

* remove spaces

* Update _dict_learning.py

* fix confusing arguments

* remove unnecessary code

* Update test_common.py

* removes spaces

* PEP8

* iter

* fix merge

* ignore a mypy warning

* type: ignore

* remove one deprecated verification

* Update sklearn/decomposition/_dict_learning.py

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

* Update sklearn/decomposition/_dict_learning.py

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

* Update sklearn/decomposition/tests/test_dict_learning.py

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

* test clone produces different id

* review

* add one more test

* lint

* Update sklearn/decomposition/tests/test_dict_learning.py

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2020-06-25 23:05:19 +02:00
Guillaume Lemaitre 129588c2db
MNT refactor tests for datasets (#17599)
* MNT refactor tests for datasets

* PEP8

* remove partial
2020-06-16 13:54:23 +02:00
Adrin Jalali 1ba06518c5
API make load_* args in datasets kwarg only (#16719)
* API male load_* args in datasets kwarg only

* more loaders

* pep8

* fix test_omp usage

* fix some usages

* Update sklearn/datasets/_samples_generator.py

Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
2020-04-27 14:41:35 -04:00
Roman Yurchak 1cbe59ee06
CI Check for unused imports when linting (#16678)
* Check for missing imports in linting

* Exclude externals

* Remove unused imports
2020-03-12 12:56:35 +01:00
wconnell ce91b6aaec
ENH add as_frame functionality for toy datasets (#15980) 2020-02-02 13:18:47 -05:00
Adrin Jalali 562c08b7e0 MNT remoe deprecated _refresh_cache usage (joblib related) (#16108) 2020-01-14 09:24:59 +08:00
Nicolas Hug 19ad136223 MNT Replace DeprecationWarning with FutureWarning (#15080)
* bruteforce renaming

* WIP

* WIP

* some more

* removed weird line

* update -Werror

* testiforest

* again

* Fixed some tests

* fixed some tests

* removed -Werror

* fixed test_docstring_param issue

* fixed some tests

* some more

* renamed to SklearnDeprecationWarning

* pep8

* updated docs

* pep8

* merge

* changed to FutureWarning

* fixes

* Update doc/developers/tips.rst

Co-Authored-By: Adrin Jalali <adrin.jalali@gmail.com>

* avoid duplicates

* fixed warning for deprecations

* Still make CI break if DeprecationWarning isn't caught

* updated one warning

* fixed test

* fixed some renamings

* updated new dep warnings

* fixed bad import

* ignore warnings

* update again

* ignore futurewarning when walking packages

* Fixed test

* pep8

* Added whatsnew
2019-10-29 15:39:26 +01:00
Thomas J Fan 4a95e33e63 MNT Make modules private in sklearn.datasets (#15307) 2019-10-27 17:17:23 -04:00
Samesh Lakhotia 7e53554a9f MAINT Uses pytest.raises in datasets tests (#14676) 2019-08-18 00:20:14 -04:00
Adrin Jalali da6611148f FIX introduce a refresh_cache param to `fetch_...` functions (#14197) 2019-07-12 18:02:06 +02:00
Adrin Jalali 19c068a2ec MNT towards removing assert_equal, etc (#14222) 2019-07-01 09:13:32 -04:00
Thomas J Fan be17713d85
MAINT Upgrade CI to PyPy 7.1.1, fix CI failure on master (#13912) 2019-06-24 13:39:10 -04:00
Thomas J Fan b0ab2891b6 TST: check deterministic order for load_sample_images (#13250) 2019-02-26 12:32:38 +01:00
Andreas Mueller 952ef6637a MRG Drop legacy python / remove six dependencies (#12639) 2019-01-03 15:50:05 +02:00
Bartosz Michałowski fa98a72dcc MNT Replaced all occurrences of assert_true and assert_false with assert (#12588) 2018-11-28 09:16:26 +08:00
Hanmin Qin 43e3a02085
MNT Remove unused assert_true imports (#12560) 2018-11-11 11:08:37 +08:00
Yaroslav Halchenko 362cb3bcab TST autoreplace assert_true(...==...) with plain assert (#12547) 2018-11-11 09:05:34 +08:00
Roman Yurchak d582e97944 TST Pytest parametrization part2 - cluster, datasets and decomposition modules (#11142) 2018-06-01 10:26:02 +08:00
Nicholas Nadeau, P.Eng., AVS 3e26fc63be MAINT Fixing Typos (#11017) 2018-04-24 09:32:25 +10:00
Chris Catalfo ff3230cdd1 ENH Return_X_y should be available on more dataset loaders/fetchers (#10734) (#10774) 2018-03-25 11:26:06 +08:00
jotasi afe540c7f2 Add deprecated scipy image-related functions in externals._pilutil (#10427) 2018-01-18 14:27:59 +01:00
Mohamed Maskani 7182a43a6f [MRG+1] Take over PR #7647 - Add a "filename" attribute to datasets that have a CSV file (#9101)
* add filename attribute for load_iris

* add filename attribute for load_boston

* add filename attribute for load_linnerud
2017-12-04 15:20:21 +01:00
Joan Massich 76494a1462 [MRG+1] Remove hard dependency on nose (#9670) 2017-09-10 13:21:40 +10:00
Sebastin Santy dc43486806 Remove unused imports (#9235) 2017-07-01 05:57:54 -07:00
jaroslaw-weber c2b0de59aa [MRG+1] added DESCR attribute in diabetes data (#8840)
*  added DESCR attribute in diabetes data

*  added DESCR attribute in diabetes data (fix flake8)

*  added DESCR attribute in diabetes data (added test)
2017-05-08 10:02:38 +02:00
Tyler Lanigan eb9fe80e50 DOC add example regarding feature scaling (#7912)
also add load_wine to datasets
2017-02-14 00:27:19 +11:00
Konstantin Podshumok 9b2aac9e5c [MRG + 1] [TST] (half-cosmetic) use less nose.tools import to simplify future transition to py.test (#7384)
* use less nose.tools import to simplify future transition to activly developing test suites/runners

* assert_equal -> assert_array_equal in test_feature_hasher_pairs_with_string_values

and one missed ImportError that should be replaced with AttributeError

* test for py2.6 compat with except AttributeError

* fix importing of SkipTest

* force using nose in python2.6 for now

* there was no assert_dict_equal in py2.6. but we can use assert_equal

although failed test will look a little bit ugly

* remove nose imports from doc/datasets
2016-10-07 12:46:52 -04:00
rickiepark 6c8a1b1fcd fix error in test code 2016-10-07 21:46:19 +09:00
rickiepark fd40cbcae3 add a test 2016-10-07 17:55:13 +09:00
Manvendra Singh 8994d0ef61 [MRG+1] added return_X_y option to toy datasets in sklearn.datasets (#7154)
* added return_X_y support to more dataset loaders

* fix typo

* updated whats_new.rst

* fix indentation for version added tag

* call astype before the branching

* better formatting in whats_new.rst

* better formatting

* updated what's new
2016-08-07 15:07:07 +02:00
Manvendra Singh c98adf7d58 [MRG] load_breast_cancer dataset: added return_X_y option (#7152)
* added return_X_y option to breast_cancer_dataset, tests included

* fix typo

* update whats_new

* removed extra space

* improved whats_new changelog
2016-08-06 11:52:23 +02:00
Manvendra Singh b8be0198b6 [MRG + 1] load_iris dataset: added return_X_y option (#7049)
* load_iris dataset:added return_X_y option

* Updated return type description

* improved return type description

* Removed extra line

* Added extra line

* Added test sentence.

* Remove sample text

* Fixes

* pep8

* Added version tag

* added entry in whats_new

* fixed extra space
2016-07-29 14:31:36 -04:00
Andreas Mueller e2bc2a756d add __dir__ to bunch for better autocomplete (#7090) 2016-07-27 10:36:36 +02:00
Loïc Estève ae70c555ce Fix reading of bunch pickles
that have been generated with scikit-learn < 0.17
2016-01-26 15:16:01 +01:00
Ishank Gulati c8406fbfcb Breast cancer dataset added 2015-10-01 16:47:01 -04:00
jfraj e4b9ff6c98 Adding test to ensure bunch consistency after pickle
Updated Bunch getattr definition to raise the appropriate error
(should raise Attribute error not KeyError)

See issue #4600
2015-04-16 18:25:13 -04:00
Michael Hanke 4c370a7357 BF: load_boston() return 13 features, but 14 feature names
Last column has the target value, hence only report first 13 names.
2014-02-17 15:24:35 +01:00
Arnaud Joly aac47a20fc ENH remove deprecated things (2) 2013-07-25 16:03:57 +02:00
Lars Buitinck 41b1f9a909 FIX charset -> encoding in load_files
Removed the deprecation of charse_error; this isn't going to be pickled
anyway. Renamed charset_error to decode_error, which I think is more
suggestive of its meaning than encoding_error.
2013-07-04 13:12:58 +02:00
Olivier Grisel a81df3b11b PY3: fix for string literals in datasets' test_base.py 2013-03-19 18:02:34 +01:00
Steven De Gryze 5993ef5082 PY3: use b() convenience function for string literals
Had to use an exception in lfw.py; six.u didn't work
2013-03-19 17:57:02 +01:00
Andreas Mueller 8df28b047e TST in testing deprecated load_filenames catch deprecation warning 2013-01-17 19:59:27 +01:00
Andreas Mueller 38f784b60a TST somewhat hacky fix for tests on image loading. 2013-01-05 19:49:16 +01:00
Brian Cajes c7fa3462e4 checking data.shape for each test dataset 2013-01-05 18:15:44 +01:00
Brian Cajes 305b9ecf94 bring datasets.base to 97% coverage with a few more tests 2013-01-05 18:15:17 +01:00
Brian Cajes 30dfa01328 Improving code coverage for datasets module. Moved dataset imports inside test_data_home, because it is preferable for import errors to only affect the tests that require those imported methods. My first commit to scikit. -bcajes 2013-01-05 18:15:17 +01:00
Brian Cajes 9364e3973f revert to original import placement style 2012-12-31 12:44:11 +01:00
Brian Cajes 2430f416f2 Improving code coverage for datasets module. Moved dataset imports inside test_data_home, because it is preferable for import errors to only affect the tests that require those imported methods. My first commit to scikit. -bcajes 2012-12-31 12:44:11 +01:00
Mathieu Blondel 6eec2e651b Even more sklearn.utils.testing. 2012-10-26 00:09:46 +09:00