Commit Graph

3108 Commits

Author SHA1 Message Date
Lucy Liu 18a4841667
DOC Add common pitfalls: data leakage (#18426)
* Add common pitfalls on data leakage (#18426)
2020-10-08 08:42:37 +02:00
Nicolas Hug e2583d45f7
DOC put back original anchor to avoid breaking links (#18551) 2020-10-06 23:45:16 -04:00
Albert Villanova del Moral 547ed6b182
DOC Improve links in cross_validation's user guide (#18379) 2020-09-24 11:19:09 -04:00
Chiara Marmo 54ce422269
DOC revamp model persistence documentation (#18046)
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
2020-09-23 22:54:27 +10:00
Joshua Newton 6d1104e332
DOC Restructure Multiclass and multilabel in User Guide (#17811) 2020-09-17 12:21:51 -04:00
hugorichard 370e5452b5
FEA Allow passing custom covariance estimators to LDA (#14446)
Co-authored-by: hugo richard <hugo.richard@inria.fr>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
2020-09-17 08:40:41 -04:00
Juan Carlos Alfaro Jiménez 2b79665b90
DOC Add enable_successive_halving module to the API Reference (#18402) 2020-09-15 15:08:14 -04:00
Rahul Jakhar 19eb458567
DOC Update doc for LinearSVC and supported loss with l1 penalty (#18362)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-09-13 16:55:58 -04:00
Nicolas Hug 0a5af0d2a1
FEA Successive halving for faster parameter search (#13900)
* More flexible grid search interface

* added info dict parameter

* Put back removed test

* renamed info into more_results

* Passed grroups as well since we need n_to use get_n_splits(X, y, groups)

* port

* pep8

* dabl -> sklearn

* add _required_parameters

* skipping check in rst file if pandas not installed

* Update sklearn/model_selection/_search_successive_halving.py

Co-Authored-By: Joel Nothman <joel.nothman@gmail.com>

* renamed into GridHalvingSearchCV and RandomHalvingSearchCV

* Addressed thomas' comments

* repr

* removed passing group as a parameter to evaluate_candidates

* Joels comments

* pep8

* reorganized user user guide

* renaming

* update user guide

* remove groups support + pass fit_params

* parameter renaming

* pep8

* r_i -> resource_iter

* fixed r_i issues

* examples + removed use of word budget

* Added inpute checking tests

* added cv_resutlts_ user guide

* minor title change

* fixed doc layout

* Addressed some comments

* properly pass down fit_params

* change default value of force_exhaust_resources and update doc

* should fix doc

* Used check_fit_params

* Update section about min_resources and number of candidates

* Clarified ratio section

* Use ~ to refer to classes

* fixed doc checks

* Apply suggestions from code review

Co-authored-by: Joel Nothman <joel.nothman@gmail.com>

* Addressed easy comments from Joel

* missed some

* updated docstring of run_search

* Used f strings instead of format

* remove candidate duplication checks

* fix example

* Addressed easy comments

* rotate ticks labels

* Added discussion in the intro as suggested by Joel

* Split examples into sections

* minor changes

* remove force_exhaust_budget and introduce min_resources=exhaust

* some minor validation

* Added a n_resources_ attribute

* update examples

* Addressed comments

* passing CV instead of X,y

* minor revert for handling fit_params

* updated docs

* fix len

* whatsnew

* Add test for sampling when all_list

* minor change to top-k

* Force CV splits to be consistent across calls

* reorder parameters

* reduced diff

* added tests for top_k

* put back doc for groups

* not sure what went wrong

* put import at its place

* some comment

* Addressed comments

* Added tests for cv_results_ and base estimator inputs

* pep8

* avoid monkeypatching

* rename df

* use Joel's suggestions for testing masks

* Made it experimental

* Should fix docs

* whats new entry

* Apply suggestions from code review

Co-authored-by: Andreas Mueller <t3kcit@gmail.com>

* Addressed comments to docs

* Addressed comments in examples

* minor doc update

* minor renaming in UG

* forgot some

* some sad note about splitter statefulness :'(

* Addressed comments

* ratio -> factor

Co-authored-by: Joel Nothman <joel.nothman@gmail.com>
Co-authored-by: Andreas Mueller <t3kcit@gmail.com>
2020-09-09 17:12:35 +02:00
Juan Carlos Alfaro Jiménez 5f0a89fd97
DOC Nitpicks in the API Reference (#18356) 2020-09-07 10:26:58 -04:00
Juan Carlos Alfaro Jiménez ec02cc989e
DOC Remove signature from base and mixin classes in API Reference (#18344) 2020-09-07 10:44:56 +02:00
Albert Villanova del Moral 647fcb1ac1
DOC Fix A to uppercase in See Also docstring section (#18332) 2020-09-04 10:35:01 -04:00
Guillaume Lemaitre 80c0a29382
DOC improve the ROC-AUC docstring (#18110)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-09-01 10:49:20 +02:00
Nicolas Hug 8061aace11
FIX DOC MNT Big revamp of cross-decomposition module (#17095) 2020-08-31 12:38:39 -04:00
Guillaume Lemaitre e030010c6c
ENH Adds plot_det_curve and associated display (#18176)
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-08-28 22:36:52 -04:00
Oleh Kozynets b50a29b616
DOC Fix docs for clustering.rst following doc guideline (#18230)
Co-authored-by: Oleh Kozynets <olehkss@github.com>
2020-08-23 09:27:26 +02:00
Nicolas Hug 5bf37e8425
FEA Add sequential feature selection transformer (#17159)
Co-authored-by: rasbt <mail@sebastianraschka.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-08-21 19:57:05 +02:00
Maren Westermann 70e1558607
DOC shorten links in doc/* modules (#17820)
* shorten links in doc modules

* fix links

* implement suggested changes

* try to fix links with tilde sign

* change back broken links in computing.rst and try make link in faq.rst work

* implement reviewer's suggested changes
2020-08-21 14:31:41 +02:00
Juan Carlos Alfaro Jiménez 395d6c171f
DOC/FIX Remove toctree from autosummary directives outside of the API (#17358) 2020-08-19 14:35:46 +02:00
Guillaume Lemaitre bf4714f401
ENH follow-up style improvements of DET curves #10591 (#18169)
* follow-up on #10591 

* DOC improvements

* TST add additional test for pos_label

Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
2020-08-19 12:39:56 +02:00
Sunitha Selvan ae7667ce22
DOC mention LOOCV instead of GCV in RidgeCV (#18154) 2020-08-18 11:32:21 +02:00
Daniel López daebcac781
FEA Add PolynomialCountSketch to Kernel Approximation module (#13003)
* Add Tensor Sketch algorithm

* Add user guide entry

* Add example

* Add benchmark

Co-authored-by: Christian Lorentzen <lorentzen.ch@googlemail.com>
Co-authored-by: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
2020-08-18 08:44:20 +02:00
Christian Lorentzen e0abd262ea
DOC improve model evaluation a bit (#18166) 2020-08-17 07:55:57 -04:00
Daniel Mohns 41d648ef88
[MRG] Add Detection Error Tradeoff (DET) curve classification metrics (#10591)
* Initial add DET curve to classification metrics

* Add DET to exports

* Fix DET-curve doctest errors

- Sample snippet in  model_evaluation documentation was outdated.

* Clarify wording in DET-curve computation

- Align to the wording of ranking module to make it consistent.
- Add correct describtion of input and outputs.
- Update and fix non-existent links

* Beautify DET curve documentation source

- Limit line length to 80 characters.

* Expand DET curve documentation

- Add an example plot to show difference between ROC and DET curves.
- Expand Usage Note section with background information and properties
of DET curves.

* Update DET-curve documentation

- Fix typos and some grammar improvements.
- Use named references to avoid potential conflicts with other sections.
- Remove unneeded references and improved existing ones by using e.g.
using versioned links.

* Select relevant DET points using slice object

* Remove some dubiety from DET curve doc-string

* Add DET curve contributors

* Add tests for DET curves

* Streamline DET test by using parametrization

* Increase verbosity of DET curve error handling

- Explicitly sanity check input before computing a DET curve.
- Add test for perfect scores.
- Adapt indentation style to match the test module.

* Add reference for DET curves in invariance test

* Add automated invariance checks for DET curves

* Resolve merge artifacts

* Make doctest happy

* Fix whitespaces for doctest

* Revert unintended whitespace changes

* Revert unintended white space changes #2

* Fix typos and grammar

* Fix white space in doc

* Streamline test code

* Remove rebase artifacts

* Fix PR link in doc

* Fix test_ranking

* Fix rebase errors

* Fix import

* Bring back newlines

- Swallowed by copy/paste

* Remove uncited ref link

* Remove matplotlib deprecation warning

* Bring back hidden reference

* Add motivation to DET example

* Fix lint

* Add citation

* Use modern matplotlib API

Co-authored-by: Jeremy Karnowski <jeremy.karnowski@gmail.com>
Co-authored-by: Julien Cornebise <julien@cornebise.com>
Co-authored-by: Daniel Mohns <daniel.mohns@zenguard.org>
2020-08-16 11:34:37 +02:00
rauwuckl eb7b15817e
DOC clarify the kernel gradient for GaussianProcesses (#18115) 2020-08-16 09:54:18 +10:00
Lucy Liu 018de22323
DOC Add user guide for permutation_test_score (#18055)
* wip

* add user guide

* fix link to ex

* suggestion

* suggestions
2020-08-13 19:34:55 -04:00
Lucy Liu 854f649307
DOC Expand Brier score, fix docstring (#18051)
* fix brier

* fix brier

* add ref

* add ref for lint

* Add link to PDF for calibration book chapter.

* Fix broken repeated ref by using qualified identifier

* Fix indentation

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
2020-08-13 19:25:01 -04:00
Nicolas Hug 25487f22d6
DOC Add example comparing PCR and PLS (#17151) 2020-08-11 14:46:33 -07:00
Bharat Raghunathan 54e85ffaba
DOC Correction in empirical covariance (#17587) 2020-08-07 14:00:00 +02:00
Bharat Raghunathan f734e11a53
ENH: Add regularization to the main NMF class (#17414)
* ENH: Add regularization to the main NMF class

* Update _nmf with suggestions from code review

Update `_nmf.py` with suggestion from review

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>

* Refactor tests, fix linter errors

* Change default value to None

* Revert back to default value of "both"

* Update default value documentation acc to @thomasjpfan

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>

* CLN Places regularization at the end

* Add whatsnew entry

* DOC Fix

* DOC Fix

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-08-06 12:04:17 -07:00
Chiara Marmo 075d424568
FEA Add Nonnegative LinearRegression (#17578)
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Joseph Knox <jknox13@uw.edu>
Co-authored-by: Joseph Knox <joseph.edward.knox@gmail.com>
2020-08-06 08:30:24 -04:00
Hitesh Somani 34d956b1ab
DOC Update tree.rst about lack of support of categorical data (#18106) 2020-08-06 10:51:06 +02:00
Thomas J. Fan cc7e6dbe6b
DOC Improves sidebar navigation for user guide (#16964) 2020-08-02 23:07:48 +10:00
Chiara Marmo 320b4c61f9
FEA Add iterable values support for dictvectorizer (#17367)
Co-authored-by: Peng Yu <peng.yu@shopify.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Joel Nothman <joel.nothman@gmail.com>
2020-08-01 22:10:36 +10:00
Lucy Liu 6a84f79465
DOC Add example of using CV iterator to split train test (#17550) 2020-07-31 10:43:46 +02:00
Lucy Liu effc436450
DOC Expand on sigmoid and isotonic in calibration.rst (#17725) 2020-07-22 12:16:48 -04:00
Thomas J. Fan 9acfaab966
ENH Adds support for multimetric callable return a dictionary (#15126) 2020-07-16 17:55:40 +02:00
oj_lappi 022ad0befd
DOC Fix math notation error in description of CCP (#16450)
Breiman, Friedman, Ohlsen, Stone use a T with a tilde to denote the terminal nodes of a tree. A simple T would imply we are counting the nodes in the whole tree.
2020-07-16 00:02:53 +02:00
Juan Carlos Alfaro Jiménez 0efd08b0fa
DOC Specify shape with parentheses in ensemble user guide (#17888) 2020-07-11 13:29:24 +02:00
Juan Carlos Alfaro Jiménez 8754470a78
DOC Specify shape with parentheses in decision tree guide (#17873) 2020-07-09 17:38:03 +02:00
Parthiv Chigurupati b78d62f9a3
DOC Updated cross validation accuracy metric (#17781)
* Updated cross validation accuracy metric

* Added deterministic results

* Update std value

Co-authored-by: Juan Carlos Alfaro Jiménez <JuanCarlos.Alfaro@uclm.es>

* Revert output

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>

Co-authored-by: Juan Carlos Alfaro Jiménez <JuanCarlos.Alfaro@uclm.es>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-07-06 14:39:05 -04:00
Adrin Jalali 3a49e5f209
MNT deprecate ChangedBehaviorWarning and NonBLASDotWarning (#17804)
* deprecate ChangedBehaviorWarning and NonBLASDotWarning

* add whats_new entry
2020-07-05 22:32:08 +02:00
Jona Sassenhagen 5e193ec655
[MRG] varimax rotation for factor analysis (#11064)
* init varimax

* fix py2 and add example text

* fix print again

* test, docs

* fix test

* fix doctstring

* np.allclose for test

* add refrence

* address comments

* update

* Fix linting failure.

* Fix deprecation warning.

* a bit of cleanup

* Address @jnothman's review comments.

* Update section divider

* Add note in what's new page and versionadded to docstring.

Co-authored-by: Eric Prestat <eric.prestat@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
2020-07-05 21:29:08 +02:00
Thomas9292 a8067f7190
DOC Add tiebreaking explanation to DecisionTreeClassifier docs (#17783)
Co-authored-by: Juan Carlos Alfaro Jiménez <JuanCarlos.Alfaro@uclm.es>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: thomas.wesselink@ing.com <thomas.wesselink@ing.com>
2020-07-04 16:35:16 -04:00
Ashutosh Hathidara 0ea3244061
Added mean_absolute_percentage_error in metrics fixes #10708 (#15007)
Co-authored-by: mohamed-ali <m.ali.jamaoui@gmail.com>
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Joel Nothman <joel.nothman@gmail.com>
Co-authored-by: Roman Yurchak <rth.yurchak@pm.me>
2020-07-04 13:24:20 +02:00
Ruby Werman 563257a141
DOC Change remove symbol nu from OutlierDetection (#17732)
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
2020-06-26 19:20:12 +02:00
Ruby Werman 2e47204a7e
DOC improve description of OneClassSVM when used for outlier detection (#17726) 2020-06-25 18:48:22 +02:00
Thomas J. Fan 6195a16505
DOC Removes FunctionTransformer example (#17318)
* DOC Removes FunctionTransformer example

* DOC Updates description
2020-06-25 14:27:38 +02:00
Thomas J. Fan 41488fcabe
MNT Remaining numpy alias (#17712) 2020-06-25 11:57:11 +02:00
Geoffrey Bolmier 62fc8bb94d
ENH Update NeighborsBase 'auto' heuristic (#17148) 2020-06-23 21:24:36 +02:00