* Fixed random number generation on windows. See https://github.com/cjlin1/liblinear/pull/28
* Added correct PR number
* Fixed random number generator for libsvm on windows targets
* Updated comments
* Suppressed C4293 warnings using explicit cast.
* Suppressed C4293 warnings using explicit cast.
* Following code review: `myrand` is now inline, and all integer size checks for random generation fix are now static.
* Dummy comment edit to re-trigger build
* Fixed include error
* Attempt to provide a better and faster result by using a mersene twister random number generator as suggested by https://codeforces.com/blog/entry/61587
* Attempt to integrate the extra compiler arg requesting for explicit C++11 support
* Attempt to integrate the extra compiler arg requesting for explicit C++11 support. liblinear extension.
* the `extra_compile_args` for C++11 was not working when used in `config.add_extension` so now pre-creating liblinear library first with the flag.
* Fixed liblinear extension build: there was a missing library dependency.
* Fixed liblinear library dependency for extension compilation.
* Fixed liblinear library compilation: added tron
* Now correctly setting the seed in libsvm
* Now correctly setting the seed in liblinear. This is done using a new interface function `set_seed`.
* Updated what's new accordingly
* Increased tolerance when comparing `_average_precision` with `_average_precision_slow`. Indeed `_average_precision` is based on predictions ordering and has errors in case of ties (e.g. several 0.5 prediction values)
* Minor improvement of this test method for readability (no change in output)
* Minor doc update as per review
* dropped commented line
* Reverted test readability improvement change
* Using double barticks
* Clarified all comments
* removed useless space
* Clarified all comments, and included a `set_seed` method as per code review.
* Updated what's new about changed models as suggested by review.
* Replaced random number generator: now using a `bounded_rand_int` using tweaked Lemire post-processor from http://www.pcg-random.org/posts/bounded-rands.html)
* Updated readme rst and moved it to 0.22
* Whats new moved from 0.222 to 0.23
* Updated docs
* Update doc/whats_new/v0.23.rst
Co-Authored-By: Chiara Marmo <cmarmo@users.noreply.github.com>
* Dummy change to re-trigger the CI build
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.21.rst
* Update doc/whats_new/v0.22.rst
* As per code review: added LogisticRegression in the list of changes, and repeated the list of classes affected in changelog.
* New random number generator used in libsvm / liblinear is now in an independent header file `newrand/newrand.h`.
* Update sklearn/svm/src/liblinear/linear.cpp
* Fixed dates in headers and added a header to newrand.h
* Added a sentence in the changelog to explain the impact in user-friendly terms.
* Added link to PR in readme file and removed commented lines as per code review
Co-authored-by: Sylvain MARIE <sylvain.marie@se.com>
Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
The leak resulted from two issues:
- not freeing the problem struct
- not freeing the number of iterations
The former was present in the initial version of ``liblinear_helper.c``
while latter appeared after c8c72fd96e
which introduced ``n_iter``.
Closes#8499
Adding test for decision_function on sparse matrices
Fixing typos
Fix Memory Leak
PEP8 fixes
COSMIT PEP8
Fixed class_weight_label problem
Fixed label problem in tests
renamed label_ to classes_
Fixed OneClass bug
Adding kernel tests for sparse matrices
Pass dense data to decision function
Don't check precomputed kernel
use safe_sparse_dot in test, regenerate cython
create a core-dump by testing the binary case... hurray?
Was: f9c13dff5ad1b32e4a67eaed77c13365a86c68d7
In get_decfun_coef and get_decfun_bias, a zero value is returned in all invalid
cases. We decide not to return NaN because we are not sure if it can be
properly assigned in all platforms. (For example, ``double nan = 0.0/0.0;''
won't compile in Visual Studio.)
Conflicts:
README
sklearn/svm/src/liblinear/linear.cpp
Was: d2f18015169e9981f82fb520af9532e1dbccecf3
replace long int with size_t in linear.cpp and train.c
Conflicts:
sklearn/svm/src/liblinear/linear.cpp
train.c
Also adds some new code, which I disabled because we don't need it. --LB
add two functions get_decfun_coef and get_decfun_bias
Conflicts:
README
matlab/predict.c
predict.c
python/README
python/liblinear.py
python/liblinearutil.py
sklearn/svm/src/liblinear/linear.cpp
sklearn/svm/src/liblinear/linear.h
Includes upstream fix for bug that we had already fixed in
22e1f69c2b.
Was: f944f28b1edc38345de5fd65c49ddde6f82496c4
Fix the mixing tab and space problem in tron.cpp.
Conflicts:
sklearn/svm/src/liblinear/tron.cpp
Was: 1601eb1e25e2dec7330fa6945922ea63b6310f3a
fix a bug: use "delete[] C" instead of "delete C" in train_one
Conflicts:
sklearn/svm/src/liblinear/linear.cpp
Pulled to make pulling in patches from upstream easier, but disabled with
an #if 0 block because I didn't know how this would interact with our own
modifications. --LB
Was: a932c3fe99fe03a69197dcd0c89df1e6fa86cc24
Modify function group_classes in linear.cpp to ensure label[0] = 1 if class labels are +1 and -1
Conflicts:
sklearn/svm/src/liblinear/linear.cpp
Yu Feng