From d592690cf7d00a494092686e1a97c074bbb5abc2 Mon Sep 17 00:00:00 2001 From: Zhangmei Li Date: Thu, 13 Jul 2017 18:02:55 +0800 Subject: [PATCH] HugeGraph-254: improve utils class perf with final(inline) Change-Id: I625be2f4691a7821dbf3107d0f28ce079d46dfee --- src/main/java/com/baidu/hugegraph/util/CheckSocket.java | 2 +- src/main/java/com/baidu/hugegraph/util/CollectionUtil.java | 2 +- src/main/java/com/baidu/hugegraph/util/E.java | 5 +++-- src/main/java/com/baidu/hugegraph/util/HashUtil.java | 2 +- src/main/java/com/baidu/hugegraph/util/LongEncoding.java | 2 +- src/main/java/com/baidu/hugegraph/util/ReflectionUtil.java | 2 +- src/main/java/com/baidu/hugegraph/util/TimeUtil.java | 2 +- 7 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/main/java/com/baidu/hugegraph/util/CheckSocket.java b/src/main/java/com/baidu/hugegraph/util/CheckSocket.java index 3f104f83d..3cece67db 100644 --- a/src/main/java/com/baidu/hugegraph/util/CheckSocket.java +++ b/src/main/java/com/baidu/hugegraph/util/CheckSocket.java @@ -29,7 +29,7 @@ import java.net.Socket; * to keep the JanusGraph distribution self-contained insofar as is * reasonable. */ -public class CheckSocket { +public final class CheckSocket { public static final int E_USAGE = 1; public static final int E_FAILED = 2; diff --git a/src/main/java/com/baidu/hugegraph/util/CollectionUtil.java b/src/main/java/com/baidu/hugegraph/util/CollectionUtil.java index e35ad460f..7d83051fd 100644 --- a/src/main/java/com/baidu/hugegraph/util/CollectionUtil.java +++ b/src/main/java/com/baidu/hugegraph/util/CollectionUtil.java @@ -5,7 +5,7 @@ import java.util.Collection; /** * Created by liningrui on 2017/3/30. */ -public class CollectionUtil { +public final class CollectionUtil { @SuppressWarnings({ "unchecked", "rawtypes" }) public static boolean containsAll(Collection a, Collection b) { diff --git a/src/main/java/com/baidu/hugegraph/util/E.java b/src/main/java/com/baidu/hugegraph/util/E.java index cefe26a95..b627036b3 100644 --- a/src/main/java/com/baidu/hugegraph/util/E.java +++ b/src/main/java/com/baidu/hugegraph/util/E.java @@ -9,14 +9,15 @@ import com.google.common.base.Preconditions; /** * Created by liningrui on 2017/5/26. */ -public class E { +public final class E { public static void checkNotNull(Object object, String elem) { Preconditions.checkNotNull(object, "The '%s' can't be null", elem); } public static void checkNotNull(Object object, String elem, String owner) { - Preconditions.checkNotNull(object, "The '%s' of '%s' can't be null", + Preconditions.checkNotNull(object, + "The '%s' of '%s' can't be null", elem, owner); } diff --git a/src/main/java/com/baidu/hugegraph/util/HashUtil.java b/src/main/java/com/baidu/hugegraph/util/HashUtil.java index 4ee1acdb3..293678cd1 100644 --- a/src/main/java/com/baidu/hugegraph/util/HashUtil.java +++ b/src/main/java/com/baidu/hugegraph/util/HashUtil.java @@ -7,7 +7,7 @@ import com.google.common.hash.Hashing; /** * Created by jishilei on 2017/3/26. */ -public class HashUtil { +public final class HashUtil { public static byte[] hash(byte[] bytes) { return Hashing.murmur3_32().hashBytes(bytes).asBytes(); diff --git a/src/main/java/com/baidu/hugegraph/util/LongEncoding.java b/src/main/java/com/baidu/hugegraph/util/LongEncoding.java index 214256b49..817cfbc0e 100644 --- a/src/main/java/com/baidu/hugegraph/util/LongEncoding.java +++ b/src/main/java/com/baidu/hugegraph/util/LongEncoding.java @@ -24,7 +24,7 @@ import com.google.common.base.Preconditions; * {@linktourl http://stackoverflow.com/questions/2938482/encode-decode-a-long-to-a-string-using-a-fixed-set-of-letters-in-java} * */ -public class LongEncoding { +public final class LongEncoding { private static final String BASE_SYMBOLS = "0123456789abcdefghijklmnopqrstuvwxyz"; diff --git a/src/main/java/com/baidu/hugegraph/util/ReflectionUtil.java b/src/main/java/com/baidu/hugegraph/util/ReflectionUtil.java index 40d5e6a33..7fcdd7dbb 100644 --- a/src/main/java/com/baidu/hugegraph/util/ReflectionUtil.java +++ b/src/main/java/com/baidu/hugegraph/util/ReflectionUtil.java @@ -17,7 +17,7 @@ import javassist.CtClass; import javassist.CtMethod; import javassist.NotFoundException; -public class ReflectionUtil { +public final class ReflectionUtil { public static List getMethodsAnnotatedWith( Class type, diff --git a/src/main/java/com/baidu/hugegraph/util/TimeUtil.java b/src/main/java/com/baidu/hugegraph/util/TimeUtil.java index 29ce4f12f..1b76b28c0 100644 --- a/src/main/java/com/baidu/hugegraph/util/TimeUtil.java +++ b/src/main/java/com/baidu/hugegraph/util/TimeUtil.java @@ -2,7 +2,7 @@ package com.baidu.hugegraph.util; import java.util.Date; -public class TimeUtil { +public final class TimeUtil { public static long twepoch = 1288834974657L;