Jason A. Donenfeld fef0035c0f netlink: do not proceed if dump's start() errs ... Drivers that use the start method for netlink dumping rely on dumpit not being called if start fails. For example, ila_xlat.c allocates memory and assigns it to cb->args[0] in its start() function. It might fail to do that and return -ENOMEM instead. However, even when returning an error, dumpit will be called, which, in the example above, quickly dereferences the memory in cb->args[0], which will OOPS the kernel. This is but one example of how this goes wrong. Since start() has always been a function with an int return type, it therefore makes sense to use it properly, rather than ignoring it. This patch thus returns early and does not call dumpit() when start() fails. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Cc: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-09-30 16:13:31 +01:00
..
6lowpan	…
9p	net/9p: switch p9_fd_read to kernel_write	2017-09-04 19:05:16 -04:00
802	net: introduce __skb_put_[zero, data, u8]	2017-06-20 13:30:14 -04:00
8021q	net: add netlink_ext_ack argument to rtnl_link_ops.validate	2017-06-26 23:13:22 -04:00
appletalk	networking: make skb_push & __skb_push return void pointers	2017-06-16 11:48:40 -04:00
atm	net: atm: make atmdev_ops const	2017-08-09 22:43:50 -07:00
ax25	net, ax25: convert ax25_cb.refcount from atomic_t to refcount_t	2017-07-04 22:35:19 +01:00
batman-adv	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-08-09 16:28:45 -07:00
bluetooth	Bluetooth: Properly check L2CAP config option output buffer length	2017-09-09 17:56:05 -07:00
bpf	…
bridge	bridge: switchdev: Use an helper to clear forward mark	2017-09-05 11:51:47 -07:00
caif	net: convert sock.sk_wmem_alloc from atomic_t to refcount_t	2017-07-01 07:39:08 -07:00
can	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
ceph	libceph: don't allow bidirectional swap of pg-upmap-items	2017-09-19 20:34:29 +02:00
core	net: Set sk_prot_creator when cloning sockets to the right proto	2017-09-28 10:33:22 -07:00
dcb	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
dccp	net: dccp: Add handling of IPV6_PKTOPTIONS to dccp_v6_do_rcv()	2017-08-31 11:43:47 -07:00
decnet	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2017-09-03 17:08:42 -07:00
dns_resolver	…
dsa	net: dsa: Fix network device registration order	2017-09-28 10:12:53 -07:00
ethernet	networking: make skb_push & __skb_push return void pointers	2017-06-16 11:48:40 -04:00
hsr	net/hsr: Check skb_put_padto() return value	2017-08-22 13:40:23 -07:00
ieee802154	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-09-05 20:03:35 -07:00
ife	…
ipv4	inetpeer: fix RCU lookup() again	2017-09-28 09:39:34 -07:00
ipv6	vti: fix use after free in vti_tunnel_xmit/vti6_tnl_xmit	2017-09-26 09:58:21 -07:00
ipx	net, ipx: convert ipx_route.refcnt from atomic_t to refcount_t	2017-07-04 22:35:17 +01:00
iucv	iucv: Convert sk_wmem_alloc accesses to refcount_t.	2017-07-03 02:31:22 -07:00
kcm	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-09-01 17:42:05 -07:00
key	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-08-15 20:23:23 -07:00
l2tp	l2tp: fix race condition in l2tp_tunnel_delete	2017-09-26 10:24:34 -07:00
l3mdev	…
lapb	net, lapb: convert lapb_cb.refcnt from atomic_t to refcount_t	2017-07-04 22:35:16 +01:00
llc	net, llc: convert llc_sap.refcnt from atomic_t to refcount_t	2017-07-04 22:35:15 +01:00
mac80211	mac80211: fix deadlock in driver-managed RX BA session start	2017-09-06 15:22:02 +02:00
mac802154	net: Fix inconsistent teardown and release of private netdev state.	2017-06-07 15:53:24 -04:00
mpls	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
ncsi	net/ncsi: fix ncsi_vlan_rx_{add,kill}_vid references	2017-09-05 09:11:45 -07:00
netfilter	netfilter: ipset: ipset list may return wrong member count for set with timeout	2017-09-18 17:35:32 +02:00
netlabel	…
netlink	netlink: do not proceed if dump's start() errs	2017-09-30 16:13:31 +01:00
netrom	net, netrom: convert nr_node.refcount from atomic_t to refcount_t	2017-07-04 22:35:17 +01:00
nfc	NFC: Add sockaddr length checks before accessing sa_family in bind handlers	2017-06-23 00:38:31 +02:00
nsh	nsh: add GSO support	2017-08-29 15:16:52 -07:00
openvswitch	openvswitch: Fix an error handling path in 'ovs_nla_init_match_and_action()'	2017-09-12 20:37:31 -07:00
packet	packet: only test po->has_vnet_hdr once in packet_snd	2017-09-28 10:24:31 -07:00
phonet	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
psample	networking: make skb_put & friends return void pointers	2017-06-16 11:48:39 -04:00
qrtr	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
rds	rds: Fix incorrect statistics counting	2017-09-07 20:07:13 -07:00
rfkill	net: rfkill: gpio: Switch to devm_acpi_dev_add_driver_gpios()	2017-06-13 11:07:51 +02:00
rose	…
rxrpc	rxrpc: Make service connection lookup always check for retry	2017-09-05 14:39:17 -07:00
sched	net_sched: remove cls_flower idr on failure	2017-09-21 15:13:52 -07:00
sctp	sctp: Fix a big endian bug in sctp_diag_dump()	2017-09-26 21:16:29 -07:00
smc	net/smc: no close wait in case of process shut down	2017-09-21 15:31:03 -07:00
strparser	strparser: initialize all callbacks	2017-08-24 21:57:50 -07:00
sunrpc	NFS client updates for Linux 4.14	2017-09-11 22:01:44 -07:00
switchdev	net: switchdev: Remove bridge bypass support from switchdev	2017-08-07 14:48:48 -07:00
tipc	tipc: remove unnecessary call to dev_net()	2017-09-06 21:25:52 -07:00
tls	tls: make tls_sw_free_resources static	2017-09-14 09:55:21 -07:00
unix	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-08-21 17:06:42 -07:00
vmw_vsock	hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)	2017-08-28 15:38:18 -07:00
wimax	…
wireless	nl80211: fix null-ptr dereference on invalid mesh configuration	2017-09-18 22:51:07 +02:00
x25	X25: constify null_x25_address	2017-08-03 09:13:51 -07:00
xfrm	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-09-01 17:42:05 -07:00
Kconfig	net: Remove CONFIG_NETFILTER_DEBUG and _ASSERT() macros.	2017-09-04 13:25:20 +02:00
Makefile	nsh: add GSO support	2017-08-29 15:16:52 -07:00
compat.c	net: compat: assert the size of cmsg copied in is as expected	2017-09-20 15:36:18 -07:00
socket.c	net: fixes for skb_send_sock	2017-08-16 11:27:52 -07:00
sysctl_net.c	…