OpenCloudOS-Kernel/drivers/crypto/caam
Horia Geantă 48f89d2a29 crypto: caam - fix concurrency issue in givencrypt descriptor
IV transfer from ofifo to class2 (set up at [29][30]) is not guaranteed
to be scheduled before the data transfer from ofifo to external memory
(set up at [38]:

[29] 10FA0004           ld: ind-nfifo (len=4) imm
[30] 81F00010               <nfifo_entry: ofifo->class2 type=msg len=16>
[31] 14820004           ld: ccb2-datasz len=4 offs=0 imm
[32] 00000010               data:0x00000010
[33] 8210010D    operation: cls1-op aes cbc init-final enc
[34] A8080B04         math: (seqin + math0)->vseqout len=4
[35] 28000010    seqfifold: skip len=16
[36] A8080A04         math: (seqin + math0)->vseqin len=4
[37] 2F1E0000    seqfifold: both msg1->2-last2-last1 len=vseqinsz
[38] 69300000   seqfifostr: msg len=vseqoutsz
[39] 5C20000C      seqstr: ccb2 ctx len=12 offs=0

If ofifo -> external memory transfer happens first, DECO will hang
(issuing a Watchdog Timeout error, if WDOG is enabled) waiting for
data availability in ofifo for the ofifo -> c2 ififo transfer.

Make sure IV transfer happens first by waiting for all CAAM internal
transfers to end before starting payload transfer.

New descriptor with jump command inserted at [37]:

[..]
[36] A8080A04         math: (seqin + math0)->vseqin len=4
[37] A1000401         jump: jsl1 all-match[!nfifopend] offset=[01] local->[38]
[38] 2F1E0000    seqfifold: both msg1->2-last2-last1 len=vseqinsz
[39] 69300000   seqfifostr: msg len=vseqoutsz
[40] 5C20000C      seqstr: ccb2 ctx len=12 offs=0

[Note: the issue is present in the descriptor from the very beginning
(cf. Fixes tag). However I've marked it v4.19+ since it's the oldest
maintained kernel that the patch applies clean against.]

Cc: <stable@vger.kernel.org> # v4.19+
Fixes: 1acebad3d8 ("crypto: caam - faster aead implementation")
Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-08-09 15:05:34 +10:00
..
Kconfig crypto: caam - convert top level drivers to libraries 2019-05-23 14:01:03 +08:00
Makefile crypto: caam/qi2 - Add printing dpseci fq stats using debugfs 2019-08-02 14:44:01 +10:00
caamalg.c crypto: caam - update IV using HW support 2019-06-20 14:18:33 +08:00
caamalg_desc.c crypto: caam - fix concurrency issue in givencrypt descriptor 2019-08-09 15:05:34 +10:00
caamalg_desc.h crypto: caam - fix concurrency issue in givencrypt descriptor 2019-08-09 15:05:34 +10:00
caamalg_qi.c crypto: caam - update IV using HW support 2019-06-20 14:18:33 +08:00
caamalg_qi2.c crypto: caam/qi2 - Add printing dpseci fq stats using debugfs 2019-08-02 14:44:01 +10:00
caamalg_qi2.h crypto: caam/qi2 - Add printing dpseci fq stats using debugfs 2019-08-02 14:44:01 +10:00
caamhash.c crypto: caam - use len instead of nents for bulding HW S/G table 2019-06-20 14:18:33 +08:00
caamhash_desc.c crypto: caam - add support for cmac(aes) 2019-02-01 14:42:03 +08:00
caamhash_desc.h crypto: caam - add support for cmac(aes) 2019-02-01 14:42:03 +08:00
caampkc.c crypto: drivers - Use kmemdup rather than duplicating its implementation 2019-07-26 15:03:59 +10:00
caampkc.h crypto: caam - strip input without changing crypto request 2019-06-06 14:38:57 +08:00
caamrng.c crypto: caam - print debug messages at debug level 2019-05-30 15:35:45 +08:00
compat.h crypto: caam - add ecb(*) support 2019-02-15 13:21:55 +08:00
ctrl.c crypto: caam - defer probing until QMan is available 2019-08-02 14:45:14 +10:00
ctrl.h crypto: caam - staticize caam_get_era() 2018-04-21 00:58:36 +08:00
desc.h crypto: caam - fix SHA support detection 2019-01-10 21:37:31 +08:00
desc_constr.h crypto: caam - fix S/G table passing page boundary 2019-05-23 14:01:03 +08:00
dpseci-debugfs.c crypto: caam/qi2 - Add printing dpseci fq stats using debugfs 2019-08-02 14:44:01 +10:00
dpseci-debugfs.h crypto: caam/qi2 - Add printing dpseci fq stats using debugfs 2019-08-02 14:44:01 +10:00
dpseci.c crypto: caam - add DPAA2-CAAM (DPSECI) backend API 2018-09-21 13:24:51 +08:00
dpseci.h crypto: caam - add DPAA2-CAAM (DPSECI) backend API 2018-09-21 13:24:51 +08:00
dpseci_cmd.h crypto: caam - add DPAA2-CAAM (DPSECI) backend API 2018-09-21 13:24:51 +08:00
error.c crypto: caam - print messages in caam_dump_sg at debug level 2019-05-30 15:35:45 +08:00
error.h crypto: caam - print messages in caam_dump_sg at debug level 2019-05-30 15:35:45 +08:00
intern.h crypto: caam/qi - fix address translations with IOMMU enabled 2019-05-23 14:01:04 +08:00
jr.c crypto: caam - convert top level drivers to libraries 2019-05-23 14:01:03 +08:00
jr.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
key_gen.c crypto: caam - print debug messages at debug level 2019-05-30 15:35:45 +08:00
key_gen.h crypto: caam - add Derived Key Protocol (DKP) support 2017-12-28 17:56:48 +11:00
pdb.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
pkc_desc.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
qi.c crypto: caam/qi - fix address translations with IOMMU enabled 2019-05-23 14:01:04 +08:00
qi.h crypto: caam/qi - simplify CGR allocation, freeing 2018-10-17 14:14:46 +08:00
regs.h Revert "crypto: caam/jr - Remove extra memory barrier during job ring dequeue" 2019-05-09 13:20:48 +08:00
sg_sw_qm.h crypto: caam - use len instead of nents for bulding HW S/G table 2019-06-20 14:18:33 +08:00
sg_sw_qm2.h crypto: caam - use len instead of nents for bulding HW S/G table 2019-06-20 14:18:33 +08:00
sg_sw_sec4.h crypto: caam - use len instead of nents for bulding HW S/G table 2019-06-20 14:18:33 +08:00