Marc Zyngier e78ad18ba3 drm/meson: Unbind all connectors on module removal ... Removing the meson DRM module results in the following splats: [ 42.689228] WARNING: CPU: 0 PID: 572 at drivers/gpu/drm/drm_irq.c:192 drm_irq_uninstall+0x130/0x160 [drm] [...] [ 42.812820] Hardware name: , BIOS 2021.01-rc2-00012-gde865f7ee1 11/16/2020 [ 42.819723] pstate: 80400089 (Nzcv daIf +PAN -UAO -TCO BTYPE=--) [ 42.825737] pc : drm_irq_uninstall+0x130/0x160 [drm] [ 42.830647] lr : drm_irq_uninstall+0xc4/0x160 [drm] [...] [ 42.917614] Call trace: [ 42.920086] drm_irq_uninstall+0x130/0x160 [drm] [ 42.924612] meson_drv_unbind+0x68/0xa4 [meson_drm] [ 42.929436] component_del+0xc0/0x180 [ 42.933058] meson_dw_hdmi_remove+0x28/0x40 [meson_dw_hdmi] [ 42.938576] platform_drv_remove+0x38/0x60 [ 42.942628] __device_release_driver+0x190/0x23c [ 42.947198] driver_detach+0xcc/0x160 [ 42.950822] bus_remove_driver+0x68/0xe0 [ 42.954702] driver_unregister+0x3c/0x6c [ 42.958583] platform_driver_unregister+0x20/0x2c [ 42.963243] meson_dw_hdmi_platform_driver_exit+0x18/0x4a8 [meson_dw_hdmi] [ 42.970057] __arm64_sys_delete_module+0x1bc/0x294 [ 42.974801] el0_svc_common.constprop.0+0x80/0x240 [ 42.979542] do_el0_svc+0x30/0xa0 [ 42.982821] el0_svc+0x18/0x50 [ 42.985839] el0_sync_handler+0x198/0x404 [ 42.989806] el0_sync+0x158/0x180 immediatelly followed by [ 43.002296] WARNING: CPU: 0 PID: 572 at drivers/gpu/drm/drm_mode_config.c:504 drm_mode_config_cleanup+0x2a8/0x304 [drm] [...] [ 43.128150] Hardware name: , BIOS 2021.01-rc2-00012-gde865f7ee1 11/16/2020 [ 43.135052] pstate: 80400009 (Nzcv daif +PAN -UAO -TCO BTYPE=--) [ 43.141062] pc : drm_mode_config_cleanup+0x2a8/0x304 [drm] [ 43.146492] lr : drm_mode_config_cleanup+0xac/0x304 [drm] [...] [ 43.233979] Call trace: [ 43.236451] drm_mode_config_cleanup+0x2a8/0x304 [drm] [ 43.241538] drm_mode_config_init_release+0x1c/0x2c [drm] [ 43.246886] drm_managed_release+0xa8/0x120 [drm] [ 43.251543] drm_dev_put+0x94/0xc0 [drm] [ 43.255380] meson_drv_unbind+0x78/0xa4 [meson_drm] [ 43.260204] component_del+0xc0/0x180 [ 43.263829] meson_dw_hdmi_remove+0x28/0x40 [meson_dw_hdmi] [ 43.269344] platform_drv_remove+0x38/0x60 [ 43.273398] __device_release_driver+0x190/0x23c [ 43.277967] driver_detach+0xcc/0x160 [ 43.281590] bus_remove_driver+0x68/0xe0 [ 43.285471] driver_unregister+0x3c/0x6c [ 43.289352] platform_driver_unregister+0x20/0x2c [ 43.294011] meson_dw_hdmi_platform_driver_exit+0x18/0x4a8 [meson_dw_hdmi] [ 43.300826] __arm64_sys_delete_module+0x1bc/0x294 [ 43.305570] el0_svc_common.constprop.0+0x80/0x240 [ 43.310312] do_el0_svc+0x30/0xa0 [ 43.313590] el0_svc+0x18/0x50 [ 43.316608] el0_sync_handler+0x198/0x404 [ 43.320574] el0_sync+0x158/0x180 [ 43.323852] ---[ end trace d796a3072dab01da ]--- [ 43.328561] [drm:drm_mode_config_cleanup [drm]] *ERROR* connector HDMI-A-1 leaked! both triggered by the fact that the HDMI subsystem is still active, and the DRM removal doesn't result in the connectors being torn down. Call drm_atomic_helper_shutdown() and component_unbind_all() to safely tear the module down. Fixes: 2d8f92897a ("drm/meson: Uninstall IRQ handler") Signed-off-by: Marc Zyngier <maz@kernel.org> Acked-by: Neil Armstrong <narmstrong@baylibre.com> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Link: https://patchwork.freedesktop.org/patch/msgid/20201116200744.495826-3-maz@kernel.org		2020-11-17 14:47:08 +01:00
..
Kconfig	Merge remote-tracking branch 'drm/drm-next' into drm-misc-next	2019-05-28 09:39:08 +02:00
Makefile	drm/meson: Add AFBCD module driver	2019-12-10 10:09:01 +01:00
meson_crtc.c	drm/atomic: Pass the full state to CRTC atomic begin and flush	2020-11-02 12:37:49 +01:00
meson_crtc.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
meson_drv.c	drm/meson: Unbind all connectors on module removal	2020-11-17 14:47:08 +01:00
meson_drv.h	drm/meson: overlay: setup overlay for Amlogic FBC	2020-07-03 10:12:29 +02:00
meson_dw_hdmi.c	Backmerge remote-tracking branch 'drm/drm-next' into drm-misc-next	2020-06-29 12:16:26 +02:00
meson_dw_hdmi.h	drm: meson: global clean-up	2019-08-09 12:06:14 +02:00
meson_osd_afbcd.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
meson_osd_afbcd.h	drm/meson: Add AFBCD module driver	2019-12-10 10:09:01 +01:00
meson_overlay.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
meson_overlay.h	drm/meson: Support Overlay plane for video rendering	2018-11-13 13:27:51 +01:00
meson_plane.c	drm/meson: Remove unneeded semicolon	2020-04-28 11:17:27 +02:00
meson_plane.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
meson_rdma.c	drm: meson: fix address type confusion	2020-01-08 13:51:56 +01:00
meson_rdma.h	drm/meson: add RDMA module driver	2019-12-10 10:08:45 +01:00
meson_registers.h	Linux 5.8-rc6	2020-07-24 08:48:05 +10:00
meson_vclk.c	drm/meson: add mode selection limits against specific SoC revisions	2020-05-05 10:19:33 +02:00
meson_vclk.h	drm/meson: add mode selection limits against specific SoC revisions	2020-05-05 10:19:33 +02:00
meson_venc.c	drm/meson: venc: add support for YUV420 setup	2020-03-10 10:51:24 +01:00
meson_venc.h	drm/meson: venc: add support for YUV420 setup	2020-03-10 10:51:24 +01:00
meson_venc_cvbs.c	drm: Nuke mode->vrefresh	2020-05-27 14:31:42 +03:00
meson_venc_cvbs.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
meson_viu.c	drm/meson: viu: fix setting the OSD burst length in VIU_OSD1_FIFO_CTRL_STAT	2020-07-02 10:36:56 +02:00
meson_viu.h	drm/meson: viu: add AFBC modules routing functions	2019-12-10 10:09:38 +01:00
meson_vpp.c	drm: meson: use match data to detect vpu compatibility	2019-08-22 17:54:05 +02:00
meson_vpp.h	drm/meson: drop use of drmP.h	2019-07-17 12:47:57 +02:00