Baokun Li 38e9216163 cachefiles: fix memory leak in cachefiles_add_cache() ... commit e21a2f17566cbd64926fb8f16323972f7a064444 upstream. The following memory leak was reported after unbinding /dev/cachefiles: ================================================================== unreferenced object 0xffff9b674176e3c0 (size 192): comm "cachefilesd2", pid 680, jiffies 4294881224 hex dump (first 32 bytes): 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace (crc ea38a44b): [<ffffffff8eb8a1a5>] kmem_cache_alloc+0x2d5/0x370 [<ffffffff8e917f86>] prepare_creds+0x26/0x2e0 [<ffffffffc002eeef>] cachefiles_determine_cache_security+0x1f/0x120 [<ffffffffc00243ec>] cachefiles_add_cache+0x13c/0x3a0 [<ffffffffc0025216>] cachefiles_daemon_write+0x146/0x1c0 [<ffffffff8ebc4a3b>] vfs_write+0xcb/0x520 [<ffffffff8ebc5069>] ksys_write+0x69/0xf0 [<ffffffff8f6d4662>] do_syscall_64+0x72/0x140 [<ffffffff8f8000aa>] entry_SYSCALL_64_after_hwframe+0x6e/0x76 ================================================================== Put the reference count of cache_cred in cachefiles_daemon_unbind() to fix the problem. And also put cache_cred in cachefiles_add_cache() error branch to avoid memory leaks. Fixes: 9ae326a690 ("CacheFiles: A cache that backs onto a mounted filesystem") CC: stable@vger.kernel.org Signed-off-by: Baokun Li <libaokun1@huawei.com> Link: https://lore.kernel.org/r/20240217081431.796809-1-libaokun1@huawei.com Acked-by: David Howells <dhowells@redhat.com> Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-03-01 13:35:00 +01:00
..
Kconfig	cachefiles: notify the user daemon when looking up cookie	2022-05-18 00:11:17 +08:00
Makefile	cachefiles: notify the user daemon when looking up cookie	2022-05-18 00:11:17 +08:00
cache.c	cachefiles: fix memory leak in cachefiles_add_cache()	2024-03-01 13:35:00 +01:00
daemon.c	cachefiles: fix memory leak in cachefiles_add_cache()	2024-03-01 13:35:00 +01:00
error_inject.c	fs/cachefiles: simplify one-level sysctl registration for cachefiles_sysctls	2023-04-13 11:49:35 -07:00
interface.c	fs: port vfs_*() helpers to struct mnt_idmap	2023-01-18 17:51:45 +01:00
internal.h	cachefiles: make on-demand request distribution fairer	2022-08-31 16:41:10 +01:00
io.c	cachefiles: use kiocb_{start,end}_write() helpers	2023-08-21 17:27:27 +02:00
key.c	cachefiles: Implement key to filename encoding	2022-01-07 13:42:16 +00:00
main.c	cachefiles: Implement object lifecycle funcs	2022-01-07 13:42:08 +00:00
namei.c	mm, netfs, fscache: stop read optimisation when folio removed from pagecache	2023-08-18 10:12:13 -07:00
ondemand.c	cachefiles: make on-demand request distribution fairer	2022-08-31 16:41:10 +01:00
security.c	cachefiles: Add security derivation	2022-01-07 13:41:14 +00:00
volume.c	fscache, cachefiles: Store the volume coherency data	2022-01-07 13:43:03 +00:00
xattr.c	fs: port ->permission() to pass mnt_idmap	2023-01-19 09:24:28 +01:00