Chris Wilson dfd2812e6d drm/i915: Remove the vma from the object list upon close ... Currently, the vma is being unlink from the object lookup on destroy. However, we are meant to be decoupling it upon close so that the user cannot access the closed vma whilst it remains active on the GPU. [ 34.074858] kernel BUG at drivers/gpu/drm/i915/i915_gem_gtt.c:3561! [ 34.074875] invalid opcode: 0000 [#1] PREEMPT SMP [ 34.074888] Modules linked in: snd_hda_intel i915 x86_pkg_temp_thermal coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel lpc_ich mei_me mei snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec_hdmi snd_hda_codec snd_hwdep snd_hda_core i2c_designware_platform i2c_designware_core snd_pcm e1000e ptp pps_core sdhci_acpi sdhci mmc_core i2c_hid [last unloaded: i915] [ 34.075010] CPU: 1 PID: 6224 Comm: gem_close_race Tainted: G U 4.9.0-rc3-CI-CI_DRM_1800+ #1 [ 34.075034] Hardware name: /NUC5i7RYB, BIOS RYBDWi35.86A.0355.2016.0224.1501 02/24/2016 [ 34.075057] task: ffff8802459a8040 task.stack: ffffc90000524000 [ 34.075074] RIP: 0010:[<ffffffffa0392cbc>] [<ffffffffa0392cbc>] i915_gem_obj_lookup_or_create_vma+0x8c/0xc0 [i915] [ 34.075118] RSP: 0018:ffffc90000527b68 EFLAGS: 00010202 [ 34.075135] RAX: ffff8802426c5e40 RBX: 0000000000000000 RCX: ffff8802447fc2a8 [ 34.075158] RDX: 0000000000000000 RSI: ffff8802447fc2a8 RDI: ffff880248a4a880 [ 34.075181] RBP: ffffc90000527b88 R08: 0000000000000008 R09: 0000000000000000 [ 34.075203] R10: 0000000000000001 R11: 0000000000000000 R12: ffff880248a4a880 [ 34.075225] R13: ffff8802447fc2a8 R14: ffff880243e9afa8 R15: ffff880248a4a9c8 [ 34.075248] FS: 00007f9b43e59740(0000) GS:ffff880256c80000(0000) knlGS:0000000000000000 [ 34.075273] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 34.075292] CR2: 00007f9b43419140 CR3: 000000024455d000 CR4: 00000000003406e0 [ 34.075314] Stack: [ 34.075323] 0000000000000000 ffffc90000527bd0 ffff880243cb8008 ffff880243e9afa8 [ 34.075353] ffffc90000527c08 ffffffffa03874c7 ffffc90000527bb8 ffff880243e9afa8 [ 34.075383] ffff880243e9afb0 ffffc90000527e10 ffff8802447fc2a8 ffff880243cb8040 [ 34.075414] Call Trace: [ 34.075435] [<ffffffffa03874c7>] eb_lookup_vmas.isra.7+0x247/0x330 [i915] [ 34.075468] [<ffffffffa0388c34>] i915_gem_do_execbuffer.isra.15+0x604/0x1a10 [i915] [ 34.075507] [<ffffffffa039c957>] ? i915_gem_object_get_sg+0x347/0x380 [i915] [ 34.075532] [<ffffffff811a69ce>] ? __might_fault+0x3e/0x90 [ 34.075562] [<ffffffffa038a430>] i915_gem_execbuffer2+0xc0/0x250 [i915] [ 34.075585] [<ffffffff81552926>] drm_ioctl+0x1f6/0x480 [ 34.075604] [<ffffffff8100107a>] ? trace_hardirqs_on_thunk+0x1a/0x1c [ 34.075635] [<ffffffffa038a370>] ? i915_gem_execbuffer+0x330/0x330 [i915] [ 34.075658] [<ffffffff81202d2e>] do_vfs_ioctl+0x8e/0x690 [ 34.075677] [<ffffffff8181582d>] ? _raw_spin_unlock_irqrestore+0x3d/0x60 [ 34.075700] [<ffffffff810fcd51>] ? SyS_timer_settime+0x141/0x1e0 [ 34.075721] [<ffffffff810d6de2>] ? trace_hardirqs_on_caller+0x122/0x1b0 [ 34.075742] [<ffffffff8120336c>] SyS_ioctl+0x3c/0x70 [ 34.075760] [<ffffffff8181602e>] entry_SYSCALL_64_fastpath+0x1c/0xb1 [ 34.075781] Code: 44 a0 48 c7 c2 9a 7e 43 a0 be e0 0d 00 00 48 c7 c7 a0 45 44 a0 e8 55 b8 ce e0 48 85 db 74 a3 49 83 bd f8 03 00 00 00 74 99 0f 0b <0f> 0b 48 89 da 4c 89 ee 4c 89 e7 e8 04 a9 ff ff 48 89 da 49 89 [ 34.075955] RIP [<ffffffffa0392cbc>] i915_gem_obj_lookup_or_create_vma+0x8c/0xc0 [i915] [ 34.075994] RSP <ffffc90000527b68> Testcase: igt/gem_close_race/basic-threads Fixes: db6c2b4151 ("drm/i915: Store the vma in an rbtree...") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/20161104161241.25871-1-chris@chris-wilson.co.uk Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>		2016-11-07 11:32:24 +00:00
..
accessibility	…
acpi	More ACPI updates for v4.9-rc1	2016-10-14 12:50:05 -07:00
amba	…
android	…
ata	ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a SoC"	2016-09-30 10:28:51 +02:00
atm	…
auxdisplay	auxdisplay: img-ascii-lcd: driver for simple ASCII LCD displays	2016-10-06 17:03:41 +02:00
base	dma-buf: Rename struct fence to dma_fence	2016-10-25 14:40:39 +02:00
bcma	…
block	rbd: don't retry watch reregistration if header object is gone	2016-10-15 23:22:09 +02:00
bluetooth	Bluetooth: btusb: Fix atheros firmware download error	2016-10-07 09:46:56 +02:00
bus	ARM: SoC driver updates for v4.9	2016-10-07 21:23:40 -07:00
cdrom	…
char	A small bug fix and a new driver for acting as an IPMI device.	2016-10-23 15:56:23 -07:00
clk	ARM: SoC: late DT updates for v4.9	2016-10-07 21:34:49 -07:00
clocksource	Revert "clocksource/drivers/timer_sun5i: Replace code by clocksource_mmio_init"	2016-10-20 21:58:58 +02:00
connector	…
cpufreq	More power management updates for v4.9-rc1	2016-10-14 12:46:13 -07:00
cpuidle	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2016-10-15 09:26:12 -07:00
crypto	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2016-10-10 14:04:16 -07:00
dax	Merge branch 'for-4.9/dax' into libnvdimm-for-next	2016-10-07 16:46:30 -07:00
dca	…
devfreq	PM / devfreq: Skip status update on uninitialized previous_freq	2016-10-11 00:01:20 +02:00
dio	…
dma	dmaengine updates for 4.8-rc1	2016-10-06 17:13:54 -07:00
dma-buf	dma-buf: Rename struct fence to dma_fence	2016-10-25 14:40:39 +02:00
edac	* Altera Arria10 enablement of NAND, DMA, USB, QSPI and SD-MMC FIFO	2016-10-04 12:06:26 -07:00
eisa	…
extcon	…
firewire	firewire: nosy: do not ignore errors in ioremap_nocache()	2016-10-09 11:38:11 +02:00
firmware	efi/arm: Fix absolute relocation detection for older toolchains	2016-10-19 14:49:44 +02:00
fmc	…
fpga	…
gpio	gpio: pca953x: add a comment explaining the need for a lockdep subclass	2016-10-11 23:17:08 +02:00
gpu	drm/i915: Remove the vma from the object list upon close	2016-11-07 11:32:24 +00:00
hid	HID: add quirk for Akai MIDImix.	2016-10-10 10:58:22 +02:00
hsi	…
hv	Drivers: hv: get rid of id in struct vmbus_channel	2016-09-27 12:35:49 +02:00
hwmon	hwmon: (max31790) potential ERR_PTR dereference	2016-10-17 10:16:20 -07:00
hwspinlock	…
hwtracing	…
i2c	i2c: 'i2c-bus' node support for v4.8-rc1	2016-10-11 23:37:26 +02:00
ide	…
idle	nmi_backtrace: generate one-line reports for idle cpus	2016-10-07 18:46:30 -07:00
iio	Staging/IIO patches for 4.9-rc1	2016-10-05 14:50:51 -07:00
infiniband	Merge branch 'gup_flag-cleanups'	2016-10-19 08:39:47 -07:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2016-10-14 13:19:30 -07:00
iommu	IOMMU Updates for Linux v4.9	2016-10-11 12:52:41 -07:00
ipack	…
irqchip	GIC updates for Linux 4.9-rc2	2016-10-21 21:40:29 +02:00
isdn	…
leds	leds: triggers: Check return value of kobject_uevent_env()	2016-09-20 10:22:10 +02:00
lguest	…
lightnvm	Merge branch 'for-4.9/block' of git://git.kernel.dk/linux-block	2016-10-07 14:42:05 -07:00
macintosh	powerpc: Remove all usages of NO_IRQ	2016-09-20 20:57:12 +10:00
mailbox	Merge branch 'mailbox-for-next' of git://git.linaro.org/landing-teams/working/fujitsu/integration	2016-10-06 17:36:53 -07:00
mcb	mcb: Add a dma_device to mcb_device	2016-09-27 12:33:47 +02:00
md	kthread: kthread worker API cleanup	2016-10-11 15:06:33 -07:00
media	Merge branch 'gup_flag-cleanups'	2016-10-19 08:39:47 -07:00
memory	ARM: SoC driver updates for v4.9	2016-10-07 21:23:40 -07:00
memstick	memstick: rtsx_usb_ms: Manage runtime PM when accessing the device	2016-10-17 15:43:05 +02:00
message	…
mfd	- Core Frameworks	2016-10-07 08:35:35 -07:00
misc	powerpc fixes for 4.9 #3	2016-10-21 19:13:00 -07:00
mmc	mmc: rtsx_usb_sdmmc: Handle runtime PM while changing the led	2016-10-17 15:43:03 +02:00
mtd	UBI: Fix crash in try_recover_peb()	2016-10-20 00:06:06 +02:00
net	Merge of the qedr RoCE driver	2016-10-14 13:43:08 -07:00
nfc	…
ntb	…
nubus	…
nvdimm	Merge branch 'for-4.9/dax' into libnvdimm-for-next	2016-10-07 16:46:30 -07:00
nvme	Merge branch 'for-linus' of git://git.kernel.dk/linux-block	2016-10-21 10:54:01 -07:00
nvmem	ARM: SoC driver updates for v4.9	2016-10-07 21:23:40 -07:00
of	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2016-10-15 09:26:12 -07:00
oprofile	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
parisc	…
parport	…
pci	PCI: designware-plat: Update author email address	2016-10-21 09:54:46 -05:00
pcmcia	pcmcia: soc_common: add driver-data pointer	2016-09-22 09:39:16 +01:00
perf	perf: xgene: Remove bogus IS_ERR() check	2016-10-17 15:50:07 +01:00
phy	…
pinctrl	pinctrl: intel: Only restore pins that are used by the driver	2016-10-18 14:38:16 +02:00
platform	platform-drivers-x86 for 4.9-2	2016-10-19 11:45:06 -07:00
pnp	…
power	power supply and reset changes for the v4.9 series	2016-10-06 18:21:15 -07:00
powercap	…
pps	pps: kc: fix non-tickless system config dependency	2016-10-11 15:06:32 -07:00
ps3	powerpc: Remove all usages of NO_IRQ	2016-09-20 20:57:12 +10:00
ptp	drivers/ptp: Fix kernel memory disclosure	2016-10-13 10:20:06 -04:00
pwm	…
rapidio	mm: replace get_user_pages() write/force parameters with gup_flags	2016-10-19 08:11:43 -07:00
ras	…
regulator	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux	2016-10-12 11:05:23 -07:00
remoteproc	rpmsg updates for v4.9	2016-10-06 17:03:49 -07:00
reset	…
rpmsg	…
rtc	RTC for 4.9	2016-10-14 13:13:44 -07:00
s390	scsi: zfcp: spin_lock_irqsave() is not nestable	2016-10-14 16:21:08 -04:00
sbus	…
scsi	SCSI fixes on 20161021	2016-10-21 10:57:09 -07:00
sfi	…
sh	…
sn	…
soc	powerpc updates for 4.9 #2	2016-10-14 11:07:42 -07:00
spi	kthread: kthread worker API cleanup	2016-10-11 15:06:33 -07:00
spmi	spmi: pmic-arb: Return an error code if sanity check fails	2016-09-27 12:43:34 +02:00
ssb	…
staging	mm: replace get_user_pages() write/force parameters with gup_flags	2016-10-19 08:11:43 -07:00
target	target/tcm_fc: use CPU affinity for responses	2016-10-21 01:19:44 -07:00
tc	…
thermal	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux	2016-10-12 11:05:23 -07:00
thunderbolt	…
tty	kthread: kthread worker API cleanup	2016-10-11 15:06:33 -07:00
uio	…
usb	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2016-10-15 09:26:12 -07:00
uwb	…
vfio	vfio_pci: use pci_alloc_irq_vectors	2016-09-29 13:36:38 -06:00
vhost	…
video	Merge tag 'topic/drm-misc-2016-10-24' of git://anongit.freedesktop.org/drm-intel into drm-next	2016-10-25 16:35:20 +10:00
virt	mm: replace get_user_pages() write/force parameters with gup_flags	2016-10-19 08:11:43 -07:00
virtio	…
vlynq	…
vme	vme: fake: remove unexpected unlock in fake_master_set()	2016-09-27 12:43:35 +02:00
w1	…
watchdog	Merge branches 'acpi-wdat' and 'acpi-cppc'	2016-10-21 22:24:23 +02:00
xen	xen: features and fixes for 4.9-rc0	2016-10-06 11:19:10 -07:00
zorro	…
Kconfig	…
Makefile	A small bug fix and a new driver for acting as an IPMI device.	2016-10-23 15:56:23 -07:00