H Hartley Sweeten 2704f807f9 staging: comedi: usbdux: bug fix for accessing 'ao_chanlist' in private data ... In usbdux_ao_cmd(), the channels for the command are transfered from the cmd->chanlist and stored in the private data 'ao_chanlist'. The channel numbers are bit-shifted when stored so that they become the "command" that is transfered to the device. The channel to command conversion results in the 'ao_chanlist' having these values for the channels: channel 0 -> ao_chanlist = 0x00 channel 1 -> ao_chanlist = 0x40 channel 2 -> ao_chanlist = 0x80 channel 3 -> ao_chanlist = 0xc0 The problem is, the usbduxsub_ao_isoc_irq() function uses the 'chan' value from 'ao_chanlist' to access the 'ao_readback' array in the private data. So instead of accessing the array as 0, 1, 2, 3, it accesses it as 0x00, 0x40, 0x80, 0xc0. Fix this by storing the raw channel number in 'ao_chanlist' and doing the bit-shift when creating the command. Fixes: a998a3db53 "staging: comedi: usbdux: cleanup the private data 'outBuffer'" Cc: stable <stable@vger.kernel.org> # 3.12 Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Acked-by: Bernd Porr <mail@berndporr.me.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2014-04-23 16:20:15 -07:00
..
android	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2014-04-02 16:23:38 -07:00
bcm	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2014-04-02 16:23:38 -07:00
ced1401	Staging: ced1401: Fix no new typedef warning in ced_ioctl.h	2014-03-18 13:30:44 -07:00
comedi	staging: comedi: usbdux: bug fix for accessing 'ao_chanlist' in private data	2014-04-23 16:20:15 -07:00
cptm1217	…
crystalhd	staging: crystalhd: Fix no space before tabs	2014-03-16 21:32:32 -07:00
cxt1e1	Staging: cxt1e1: Fix externs should be avoided in .c files in comet.c	2014-03-19 09:17:23 -07:00
dgap	staging: dgap: fix the rest of the checkpatch warnings in dgap.c	2014-03-19 13:54:39 -07:00
dgnc	staging:dgnc: Removed assignments from if statements.	2014-03-17 16:42:47 -07:00
dgrp	drivers/staging/dgrp:dgrp_tty.c: Fix line over 80 characters.	2014-03-18 10:53:21 -07:00
et131x	Staging: et131x: Fix warning of prefer ether_addr_copy() in et131x.c	2014-03-08 20:27:48 -08:00
frontier	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2014-04-02 16:23:38 -07:00
ft1000	staging: ft1000: Fix line over 80 characters.	2014-03-19 13:41:28 -07:00
fwserial	staging/fwserial: don't use PREPARE_WORK	2014-03-07 10:24:50 -05:00
gdm72xx	staging: gdm72xx: remove completed TODO item	2014-03-16 19:53:58 -07:00
gdm724x	Staging: gdm724x: Fix unchecked sscanf values in gdm_lte.c	2014-03-18 11:35:53 -07:00
goldfish	staging: goldfish: Call free_irq in error path	2014-04-16 11:41:44 -07:00
gs_fpgaboot	staging: gs_fpgaboot: remove __TIMESTAMP__ macro	2014-04-15 14:46:43 -07:00
iio	First found of IIO fixes for the 3.15 cycle.	2014-04-22 21:29:20 -07:00
imx-drm	Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux	2014-04-08 09:52:16 -07:00
keucr	staging:keucr: Remove typedefs	2014-03-16 22:01:41 -07:00
line6	Staging driver pull request for 3.15-rc1	2014-04-01 16:45:00 -07:00
lustre	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2014-04-12 17:31:22 -07:00
media	[media] msi3101: check I/O return values on stop streaming	2014-04-06 11:08:19 -03:00
mt29f_spinand	…
netlogic	Staging:netlogic: Correct double assignment in xlr_net.c	2014-03-08 20:31:53 -08:00
nokia_h4p	staging: nokia_h4p: Fix quoted string split across lines	2014-03-19 13:50:23 -07:00
nvec	staging:nvec: Introduce the use of the managed version of kzalloc	2014-03-07 15:19:36 -08:00
octeon	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2014-04-02 20:53:45 -07:00
octeon-usb	staging: octeon-usb: prevent memory corruption	2014-03-20 01:51:12 +00:00
olpc_dcon	…
ozwpan	staging:ozwpan:Fix sparse warning of cast to restricted __le16	2014-03-18 11:58:45 -07:00
panel	Staging: panel: Fix quoted string split across line in panel.c	2014-02-27 12:29:24 -08:00
phison	…
quickstart	…
rtl8188eu	staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0	2014-04-16 13:07:19 -07:00
rtl8192e	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2014-04-02 16:23:38 -07:00
rtl8192u	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2014-04-02 16:23:38 -07:00
rtl8712	staging: r8712u: Fix case where ethtype was never obtained and always be checked against 0	2014-04-16 13:07:19 -07:00
rtl8723au	staging: r8723au: Add missing initialization of change_inx in sort algorithm	2014-04-16 11:41:45 -07:00
rtl8821ae	staging/rtl8821ae: Fix OOM handling in _rtl_init_deferred_work()	2014-04-15 11:39:09 -07:00
rts5139	staging: rts5139: Added in sd_cprm.c an include to fix a sparse warning	2014-03-16 17:41:13 -07:00
rts5208	staging: rts5208: Fix line over 80 characters.	2014-03-18 11:56:51 -07:00
sbe-2t3e3	/drivers/staging/sbe2t3e3: Fixed left brace to be on the previous line	2014-03-10 15:06:22 -07:00
sep	staging: sep: Add fallthrough comment	2014-03-16 17:52:00 -07:00
serqt_usb2	drivers/staging/serqt_usb2:serqt_usb2.c Fix line over 80 characters.	2014-03-18 11:18:05 -07:00
silicom	staging/silicom/bypasslib/bp_ioctl.h Fix do not add new typedefs.	2014-03-18 11:55:31 -07:00
slicoss	staging: slicoss: free IO remapping on failure	2014-03-18 12:11:55 -07:00
speakup	staging: speakup: fix misuse of kstrtol() in handle_goto()	2014-04-16 11:41:44 -07:00
ste_rmi4	…
tidspbridge	staging/tidspbridge/rmgr/mgr.c Fix quoted string split across lines	2014-03-19 09:27:39 -07:00
unisys	Staging: unisys: use after free in list_for_each()	2014-04-16 11:41:45 -07:00
usbip	staging/usbip: fix store_attach() sscanf return value check	2014-04-15 14:43:01 -07:00
vme	staging: vme: fix memory leak in vme_user_probe()	2014-04-15 14:46:43 -07:00
vt6655	staging:vt6655: Fix sparse warnings of using plain integer as NULL pointer	2014-03-18 11:01:21 -07:00
vt6656	staging: vt6656: s_uGetRTSCTSRsvTime fix return.	2014-03-19 09:00:19 -07:00
winbond	staging: winbond: Fix line over 80 characters.	2014-03-19 09:27:39 -07:00
wlags49_h2	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2014-04-02 20:53:45 -07:00
wlags49_h25	…
wlan-ng	Staging: wlan-ng: Fix smatch warning potential null reference	2014-03-19 13:41:27 -07:00
xgifb	video: move fbdev to drivers/video/fbdev	2014-04-17 08:10:19 +03:00
xillybus	staging: xillybus: XILLYBUS_PCIE depends on PCI_MSI	2014-03-21 12:24:09 -07:00
Kconfig	staging: delete rtl8187se wireless driver	2014-04-16 11:35:54 -07:00
Makefile	staging: delete rtl8187se wireless driver	2014-04-16 11:35:54 -07:00
staging.c	…