OpenCloudOS-Kernel/drivers/gpu/drm/mxsfb
Maxime Ripard 37418bf14c
drm: Use state helper instead of the plane state pointer
Many drivers reference the plane->state pointer in order to get the
current plane state in their atomic_update or atomic_disable hooks,
which would be the new plane state in the global atomic state since
_swap_state happened when those hooks are run.

Use the drm_atomic_get_new_plane_state helper to get that state to make it
more obvious.

This was made using the coccinelle script below:

@ plane_atomic_func @
identifier helpers;
identifier func;
@@

(
 static const struct drm_plane_helper_funcs helpers = {
 	...,
 	.atomic_disable = func,
	...,
 };
|
 static const struct drm_plane_helper_funcs helpers = {
 	...,
 	.atomic_update = func,
	...,
 };
)

@ adds_new_state @
identifier plane_atomic_func.func;
identifier plane, state;
identifier new_state;
@@

 func(struct drm_plane *plane, struct drm_atomic_state *state)
 {
 	...
-	struct drm_plane_state *new_state = plane->state;
+	struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state, plane);
	...
 }

@ include depends on adds_new_state @
@@

 #include <drm/drm_atomic.h>

@ no_include depends on !include && adds_new_state @
@@

+ #include <drm/drm_atomic.h>
  #include <drm/...>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20210219120032.260676-1-maxime@cerno.tech
2021-02-25 08:05:28 +01:00
..
Kconfig drm: mxsfb: Add i.MX7 and i.MX8M to the list of supported SoCs in Kconfig 2020-07-28 17:21:33 +02:00
Makefile drm: mxsfb: Rename mxsfb_crtc.c to mxsfb_kms.c 2020-07-28 17:21:01 +02:00
mxsfb_drv.c drm: mxsfb: Silence -EPROBE_DEFER while waiting for bridge 2020-12-15 11:01:10 +01:00
mxsfb_drv.h drm: mxsfb: Support the alpha plane 2020-07-28 17:21:58 +02:00
mxsfb_kms.c drm: Use state helper instead of the plane state pointer 2021-02-25 08:05:28 +01:00
mxsfb_regs.h drm: mxsfb: Support the alpha plane 2020-07-28 17:21:58 +02:00