OpenCloudOS-Kernel/drivers/gpu/drm/kmb
Maxime Ripard 37418bf14c
drm: Use state helper instead of the plane state pointer
Many drivers reference the plane->state pointer in order to get the
current plane state in their atomic_update or atomic_disable hooks,
which would be the new plane state in the global atomic state since
_swap_state happened when those hooks are run.

Use the drm_atomic_get_new_plane_state helper to get that state to make it
more obvious.

This was made using the coccinelle script below:

@ plane_atomic_func @
identifier helpers;
identifier func;
@@

(
 static const struct drm_plane_helper_funcs helpers = {
 	...,
 	.atomic_disable = func,
	...,
 };
|
 static const struct drm_plane_helper_funcs helpers = {
 	...,
 	.atomic_update = func,
	...,
 };
)

@ adds_new_state @
identifier plane_atomic_func.func;
identifier plane, state;
identifier new_state;
@@

 func(struct drm_plane *plane, struct drm_atomic_state *state)
 {
 	...
-	struct drm_plane_state *new_state = plane->state;
+	struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state, plane);
	...
 }

@ include depends on adds_new_state @
@@

 #include <drm/drm_atomic.h>

@ no_include depends on !include && adds_new_state @
@@

+ #include <drm/drm_atomic.h>
  #include <drm/...>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20210219120032.260676-1-maxime@cerno.tech
2021-02-25 08:05:28 +01:00
..
Kconfig drm/Kconfig: rename keembay config 2020-11-13 14:53:34 +10:00
Makefile drm/kmb: Build files for KeemBay Display driver 2020-11-05 19:20:38 +01:00
kmb_crtc.c drm/kmb: fix spelling mistakes in drm_info and drm_dbg messages 2020-11-11 22:00:05 +01:00
kmb_drv.c - Add default modes for connectors in unknown state 2021-01-07 13:02:57 +01:00
kmb_drv.h
kmb_dsi.c drm/kmb: Mipi DSI part of the display driver 2020-11-05 19:20:23 +01:00
kmb_dsi.h drm/kmb: Mipi DSI part of the display driver 2020-11-05 19:20:23 +01:00
kmb_plane.c drm: Use state helper instead of the plane state pointer 2021-02-25 08:05:28 +01:00
kmb_plane.h drm/kmb: Fix build warnings 2020-11-11 21:34:18 +01:00
kmb_regs.h