Florian Westphal cd38d9cdf4 netfilter: nf_tables: avoid false-positive lockdep splat on rule deletion ... [ Upstream commit 9adbb4198bf6cf3634032871118a7052aeaa573f ] On rule delete we get: WARNING: suspicious RCU usage net/netfilter/nf_tables_api.c:3420 RCU-list traversed in non-reader section!! 1 lock held by iptables/134: #0: ffff888008c4fcc8 (&nft_net->commit_mutex){+.+.}-{3:3}, at: nf_tables_valid_genid (include/linux/jiffies.h:101) nf_tables Code is fine, no other CPU can change the list because we're holding transaction mutex. Pass the needed lockdep annotation to the iterator and fix two comments for functions that are no longer restricted to rcu-only context. This is enough to resolve rule delete, but there are several other missing annotations, added in followup-patches. Fixes: 28875945ba ("rcu: Add support for consolidated-RCU reader checking") Reported-by: Matthieu Baerts <matttbe@kernel.org> Tested-by: Matthieu Baerts <matttbe@kernel.org> Closes: https://lore.kernel.org/netfilter-devel/da27f17f-3145-47af-ad0f-7fd2a823623e@kernel.org/ Signed-off-by: Florian Westphal <fw@strlen.de> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-12-09 10:32:08 +01:00
..
6lowpan	…
9p	9p: fix slab cache name creation for real	2024-11-17 15:08:59 +01:00
802	…
8021q	net: gro: fix udp bad offset in socket lookup by adding {inner_}network_offset to napi_gro_cb	2024-05-17 12:02:07 +02:00
appletalk	appletalk: Fix Use-After-Free in atalk_ioctl	2023-12-20 17:01:50 +01:00
atm	atm: Fix Use-After-Free in do_vcc_ioctl	2023-12-20 17:01:48 +01:00
ax25	ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put()	2024-06-21 14:38:14 +02:00
batman-adv	batman-adv: Don't accept TT entries for out-of-spec VIDs	2024-07-05 09:34:04 +02:00
bluetooth	Bluetooth: hci_core: Fix calling mgmt_device_connected	2024-11-22 15:38:32 +01:00
bpf	bpf, test_run: Fix LIVE_FRAME frame update after a page has been recycled	2024-11-08 16:28:19 +01:00
bpfilter	net: Use umd_cleanup_helper()	2023-05-31 13:06:57 +02:00
bridge	bridge: Handle error of rtnl_register_module().	2024-10-17 15:24:29 +02:00
caif	sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)	2023-06-24 15:50:13 -07:00
can	can: bcm: Clear bo->bcm_proc_read after remove_proc_entry().	2024-10-04 16:28:58 +02:00
ceph	libceph: init the cursor when preparing sparse read in msgr2	2024-10-17 15:24:10 +02:00
core	bpf: Fix mismatched RCU unlock flavour in bpf_out_neigh_v6	2024-11-17 15:08:57 +01:00
dcb	net: dcb: choose correct policy to parse DCB_ATTR_BCN	2023-08-01 21:07:46 -07:00
dccp	tcp/dccp: do not care about families in inet_twsk_purge()	2024-08-29 17:33:46 +02:00
devlink	devlink: fix port new reply cmd type	2024-03-26 18:20:11 -04:00
dns_resolver	keys, dns: Fix size check of V1 server-list header	2024-01-25 15:35:41 -08:00
dsa	net: dsa: fix netdev_priv() dereference before check on non-DSA netdevice events	2024-10-10 11:58:07 +02:00
ethernet	ethernet: Add helper for assigning packet type when dest address does not match device address	2024-05-02 16:32:46 +02:00
ethtool	ethtool: check device is present when getting link settings	2024-09-04 13:28:26 +02:00
handshake	net/handshake: Fix handshake_req_destroy_test1	2024-02-23 09:24:50 +01:00
hsr	hsr: Simplify code for announcing HSR nodes timer setup	2024-05-17 12:02:24 +02:00
ieee802154	sysctl-6.6-rc1	2023-08-29 17:39:15 -07:00
ife	net: sched: ife: fix potential use-after-free	2024-01-01 12:42:30 +00:00
ipv4	ipmr: Fix access to mfc_cache_list without lock held	2024-12-09 10:31:40 +01:00
ipv6	netfilter: nf_reject_ipv6: fix potential crash in nf_send_reset6()	2024-11-08 16:28:19 +01:00
iucv	s390/iucv: fix receive buffer virtual vs physical address confusion	2024-08-29 17:33:39 +02:00
kcm	kcm: Serialise kcm_sendmsg() for the same socket.	2024-08-29 17:33:46 +02:00
key	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-08-18 12:44:56 -07:00
l2tp	genetlink: hold RCU in genlmsg_mcast()	2024-11-01 01:58:23 +01:00
l3mdev	…
lapb	…
llc	llc: call sock_orphan() at release time	2024-02-05 20:14:36 +00:00
mac80211	mac80211: fix user-power when emulating chanctx	2024-12-09 10:31:36 +01:00
mac802154	mac802154: Fix potential RCU dereference issue in mac802154_scan_worker	2024-10-10 11:57:59 +02:00
mctp	mctp: Handle error of rtnl_register_module().	2024-10-17 15:24:29 +02:00
mpls	mpls: Handle error of rtnl_register_module().	2024-10-17 15:24:30 +02:00
mptcp	mptcp: fix possible integer overflow in mptcp_reset_tout_timer	2024-12-09 10:31:42 +01:00
ncsi	net/ncsi: Fix the multi thread manner of NCSI driver	2024-06-21 14:38:14 +02:00
netfilter	netfilter: nf_tables: avoid false-positive lockdep splat on rule deletion	2024-12-09 10:32:08 +01:00
netlabel	calipso: fix memory leak in netlbl_calipso_add_pass()	2024-01-25 15:35:14 -08:00
netlink	netlink: terminate outstanding dump on socket close	2024-11-22 15:38:30 +01:00
netrom	netrom: Fix a memory leak in nr_heartbeat_expiry()	2024-06-27 13:49:06 +02:00
nfc	nfc: llcp: fix nfc_llcp_setsockopt() unsafe copies	2024-08-19 06:04:28 +02:00
nsh	nsh: Restore skb->{protocol,data,mac_header} for outer header in nsh_gso_segment().	2024-05-17 12:02:02 +02:00
openvswitch	net: ovs: fix ovs_drop_reasons error	2024-08-29 17:33:50 +02:00
packet	af_packet: Handle outgoing VLAN packets without hardware offloading	2024-08-03 08:54:13 +02:00
phonet	phonet: Handle error of rtnl_register_module().	2024-10-17 15:24:30 +02:00
psample	psample: Require 'CAP_NET_ADMIN' when joining "packets" group	2023-12-13 18:45:10 +01:00
qrtr	net: qrtr: Update packets cloning when broadcasting	2024-10-04 16:29:41 +02:00
rds	net:rds: Fix possible deadlock in rds_message_put	2024-08-19 06:04:27 +02:00
rfkill	net: rfkill: gpio: set GPIO direction	2024-01-01 12:42:41 +00:00
rose	net/rose: fix races in rose_kill_by_device()	2024-01-01 12:42:31 +00:00
rxrpc	rxrpc: Fix missing locking causing hanging calls	2024-11-14 13:19:32 +01:00
sched	net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes.	2024-11-22 15:38:32 +01:00
sctp	sctp: fix possible UAF in sctp_v6_available()	2024-11-22 15:38:30 +01:00
smc	net/smc: Fix searching in list of known pnetids in smc_pnet_add_pnetid	2024-11-01 01:58:22 +01:00
strparser	…
sunrpc	sunrpc: handle -ENOTCONN in xs_tcp_setup_socket()	2024-11-14 13:19:30 +01:00
switchdev	net: bridge: switchdev: Skip MDB replays of deferred events on offload	2024-03-01 13:35:06 +01:00
tipc	tipc: guard against string buffer overrun	2024-10-10 11:57:25 +02:00
tls	tls: fix missing memory barrier in tls_init	2024-06-12 11:12:50 +02:00
unix	af_unix: Remove put_pid()/put_cred() in copy_peercred().	2024-09-12 11:11:29 +02:00
vmw_vsock	virtio/vsock: Fix accept_queue memory leak	2024-11-22 15:38:32 +01:00
wireless	wifi: cfg80211: clear wdev->cqm_config pointer on free	2024-11-08 16:28:23 +01:00
x25	net/x25: fix incorrect parameter validation in the x25_getsockopt() function	2024-03-26 18:19:41 -04:00
xdp	xsk: validate user input for XDP_{UMEM|COMPLETION}_FILL_RING	2024-04-17 11:19:28 +02:00
xfrm	xfrm: validate new SA's prefixlen using SA family when sel.family is unset	2024-11-01 01:58:34 +01:00
Kconfig	bpf: Add fd-based tcx multi-prog infra with link support	2023-07-19 10:07:27 -07:00
Kconfig.debug	…
Makefile	…
compat.c	…
devres.c	…
socket.c	net: explicitly clear the sk pointer, when pf->create fails	2024-10-17 15:24:35 +02:00
sysctl_net.c	sysctl: treewide: drop unused argument ctl_table_root::set_ownership(table)	2024-08-11 12:47:13 +02:00