Lorenzo Bianconi c09551c6ff net: ipv4: use a dedicated counter for icmp_v4 redirect packets ... According to the algorithm described in the comment block at the beginning of ip_rt_send_redirect, the host should try to send 'ip_rt_redirect_number' ICMP redirect packets with an exponential backoff and then stop sending them at all assuming that the destination ignores redirects. If the device has previously sent some ICMP error packets that are rate-limited (e.g TTL expired) and continues to receive traffic, the redirect packets will never be transmitted. This happens since peer->rate_tokens will be typically greater than 'ip_rt_redirect_number' and so it will never be reset even if the redirect silence timeout (ip_rt_redirect_silence) has elapsed without receiving any packet requiring redirects. Fix it by using a dedicated counter for the number of ICMP redirect packets that has been sent by the host I have not been able to identify a given commit that introduced the issue since ip_rt_send_redirect implements the same rate-limiting algorithm from commit 1da177e4c3 ("Linux-2.6.12-rc2") Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-02-08 21:50:15 -08:00
..
6lowpan	6lowpan: convert to DEFINE_SHOW_ATTRIBUTE	2018-12-19 00:28:05 +01:00
9p	9p/net: put a lower bound on msize	2018-12-25 17:07:49 +09:00
802	…
8021q	net: core: dev: Add extack argument to dev_change_flags()	2018-12-06 13:26:07 -08:00
appletalk	…
atm	Revert "net: simplify sock_poll_wait"	2018-10-23 10:57:06 -07:00
ax25	ax25: fix possible use-after-free	2019-01-23 11:18:00 -08:00
batman-adv	Here are some batman-adv bugfixes:	2019-02-01 10:19:26 -08:00
bluetooth	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2018-12-27 13:53:32 -08:00
bpf	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2018-12-10 18:00:43 -08:00
bpfilter	net: bpfilter: change section name of bpfilter UMH blob.	2019-01-16 15:46:46 -08:00
bridge	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf	2019-01-28 10:51:51 -08:00
caif	Revert "net: simplify sock_poll_wait"	2018-10-23 10:57:06 -07:00
can	can: bcm: check timer values before ktime conversion	2019-01-22 11:33:46 +01:00
ceph	libceph: avoid KEEPALIVE_PENDING races in ceph_con_keepalive()	2019-01-21 14:53:12 +01:00
core	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2019-02-01 15:28:07 -08:00
dcb	net: dcb: Add priority-to-DSCP map getters	2018-07-27 13:17:50 -07:00
dccp	dccp: fool proof ccid_hc_[rt]x_parse_options()	2019-02-01 14:49:10 -08:00
decnet	decnet: fix DN_IFREQ_SIZE	2019-01-27 23:11:55 -08:00
dns_resolver	dns: Allow the dns resolver to retrieve a server set	2018-10-04 09:40:52 -07:00
dsa	net: dsa: Fix NULL checking in dsa_slave_set_eee()	2019-02-06 13:42:54 -08:00
ethernet	net: ethernet: provide nvmem_get_mac_address()	2018-12-03 15:40:30 -08:00
hsr	…
ieee802154	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-12-24 16:19:56 -08:00
ife	…
ipv4	net: ipv4: use a dedicated counter for icmp_v4 redirect packets	2019-02-08 21:50:15 -08:00
ipv6	sit: check if IPv6 enabled before calling ip6_err_gen_icmpv6_unreach()	2019-02-07 10:48:42 -08:00
iucv	iucv: Remove SKB list assumptions.	2018-11-10 16:55:11 -08:00
kcm	Revert "kcm: remove any offset before parsing messages"	2018-09-17 18:43:42 -07:00
key	af_key: fix indentation on declaration statement	2018-11-15 18:09:32 +01:00
l2tp	l2tp: copy 4 more bytes to linear part if necessary	2019-01-31 08:58:46 -08:00
l3mdev	l3mdev: add function to retreive upper master	2018-12-03 14:15:26 -08:00
lapb	…
llc	llc: do not use sk_eat_skb()	2018-10-22 19:59:20 -07:00
mac80211	mac80211: ensure that mgmt tx skbs have tailroom for encryption	2019-02-01 11:08:02 +01:00
mac802154	mac802154: Remove VLA usage of skcipher	2018-09-28 12:46:07 +08:00
mpls	net/mpls: Handle kernel side filtering of route dumps	2018-10-16 00:14:07 -07:00
ncsi	net/ncsi: Add NCSI Mellanox OEM command	2018-11-27 16:37:20 -08:00
netfilter	netfilter: nft_compat: don't use refcount_inc on newly allocated entry	2019-02-05 14:10:33 +01:00
netlabel	netlabel: check for IPV4MASK in addrinfo_get	2018-09-21 18:58:34 -07:00
netlink	net: netlink: rename NETLINK_DUMP_STRICT_CHK -> NETLINK_GET_STRICT_CHK	2018-12-14 11:44:31 -08:00
netrom	netrom: switch to sock timer API	2019-01-27 10:38:04 -08:00
nfc	net: Revert recent Spectre-v1 patches.	2018-12-23 16:01:35 -08:00
nsh	nsh: set mac len based on inner packet	2018-07-12 16:55:29 -07:00
openvswitch	openvswitch: Avoid OOB read when parsing flow nlattrs	2019-01-16 13:35:21 -08:00
packet	af_packet: fix raw sockets over 6in4 tunnel	2019-01-17 15:54:45 -08:00
phonet	net: Revert recent Spectre-v1 patches.	2018-12-23 16:01:35 -08:00
psample	…
qrtr	…
rds	rds: fix refcount bug in rds_sock_addref	2019-01-31 09:43:27 -08:00
rfkill	rfkill: gpio: Remove unused include	2018-12-18 13:13:56 +01:00
rose	net/rose: fix NULL ax25_cb kernel panic	2019-01-27 10:40:01 -08:00
rxrpc	rxrpc: bad unlock balance in rxrpc_recvmsg	2019-02-06 10:54:07 -08:00
sched	net: cls_flower: Remove filter from mask before freeing it	2019-02-04 09:19:14 -08:00
sctp	sctp: check and update stream->out_curr when allocating stream_out	2019-02-03 14:27:47 -08:00
smc	net/smc: correct state change for peer closing	2019-02-04 09:11:19 -08:00
strparser	bpf, sockmap: convert to generic sk_msg interface	2018-10-15 12:23:19 -07:00
sunrpc	svcrdma: Remove max_sge check at connect time	2019-02-06 15:32:34 -05:00
switchdev	net: switchdev: Add extack to switchdev_handle_port_obj_add() callback	2018-12-12 16:34:22 -08:00
tipc	tipc: fix uninit-value in tipc_nl_compat_doit	2019-01-15 20:29:21 -08:00
tls	net: tls: Fix deadlock in free_resources tx	2019-01-28 23:07:08 -08:00
unix	Revert "net: simplify sock_poll_wait"	2018-10-23 10:57:06 -07:00
vmw_vsock	vsock/virtio: reset connected sockets on device removal	2019-02-03 11:06:25 -08:00
wimax	wimax: remove blank lines at EOF	2018-07-24 14:10:42 -07:00
wireless	cfg80211: call disconnect_wk when AP stops	2019-02-01 11:12:50 +01:00
x25	net/x25: handle call collisions	2018-11-29 14:25:36 -08:00
xdp	xsk: Check if a queue exists during umem setup	2019-01-15 20:51:57 +01:00
xfrm	xfrm: Make set-mark default behavior backward compatible	2019-01-16 13:10:55 +01:00
Kconfig	net: convert bridge_nf to use skb extension infrastructure	2018-12-19 11:21:37 -08:00
Makefile	…
compat.c	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
socket.c	net: socket: make bond ioctls go through compat_ifreq_ioctl()	2019-01-30 10:19:31 -08:00
sysctl_net.c	…