George Cherian 1ecbd7170d ACPI / CPPC: Fix KASAN global out of bounds warning ... Default value of pcc_subspace_idx is -1. Make sure to check pcc_subspace_idx before using the same as array index. This will avoid following KASAN warnings too. [ 15.113449] ================================================================== [ 15.116983] BUG: KASAN: global-out-of-bounds in cppc_get_perf_caps+0xf3/0x3b0 [ 15.116983] Read of size 8 at addr ffffffffb9a5c0d8 by task swapper/0/1 [ 15.116983] CPU: 3 PID: 1 Comm: swapper/0 Not tainted 4.15.0-rc2+ #2 [ 15.116983] Hardware name: Dell Inc. OptiPlex 7040/0Y7WYT, BIOS 1.2.8 01/26/2016 [ 15.116983] Call Trace: [ 15.116983] dump_stack+0x7c/0xbb [ 15.116983] print_address_description+0x1df/0x290 [ 15.116983] kasan_report+0x28a/0x370 [ 15.116983] ? cppc_get_perf_caps+0xf3/0x3b0 [ 15.116983] cppc_get_perf_caps+0xf3/0x3b0 [ 15.116983] ? cpc_read+0x210/0x210 [ 15.116983] ? __rdmsr_on_cpu+0x90/0x90 [ 15.116983] ? rdmsrl_on_cpu+0xa9/0xe0 [ 15.116983] ? rdmsr_on_cpu+0x100/0x100 [ 15.116983] ? wrmsrl_on_cpu+0x9c/0xd0 [ 15.116983] ? wrmsrl_on_cpu+0x9c/0xd0 [ 15.116983] ? wrmsr_on_cpu+0xe0/0xe0 [ 15.116983] __intel_pstate_cpu_init.part.16+0x3a2/0x530 [ 15.116983] ? intel_pstate_init_cpu+0x197/0x390 [ 15.116983] ? show_no_turbo+0xe0/0xe0 [ 15.116983] ? __lockdep_init_map+0xa0/0x290 [ 15.116983] intel_pstate_cpu_init+0x30/0x60 [ 15.116983] cpufreq_online+0x155/0xac0 [ 15.116983] cpufreq_add_dev+0x9b/0xb0 [ 15.116983] subsys_interface_register+0x1ae/0x290 [ 15.116983] ? bus_unregister_notifier+0x40/0x40 [ 15.116983] ? mark_held_locks+0x83/0xb0 [ 15.116983] ? _raw_write_unlock_irqrestore+0x32/0x60 [ 15.116983] ? intel_pstate_setup+0xc/0x104 [ 15.116983] ? intel_pstate_setup+0xc/0x104 [ 15.116983] ? cpufreq_register_driver+0x1ce/0x2b0 [ 15.116983] cpufreq_register_driver+0x1ce/0x2b0 [ 15.116983] ? intel_pstate_setup+0x104/0x104 [ 15.116983] intel_pstate_register_driver+0x3a/0xa0 [ 15.116983] intel_pstate_init+0x3c4/0x434 [ 15.116983] ? intel_pstate_setup+0x104/0x104 [ 15.116983] ? intel_pstate_setup+0x104/0x104 [ 15.116983] do_one_initcall+0x9c/0x206 [ 15.116983] ? parameq+0xa0/0xa0 [ 15.116983] ? initcall_blacklisted+0x150/0x150 [ 15.116983] ? lock_downgrade+0x2c0/0x2c0 [ 15.116983] kernel_init_freeable+0x327/0x3f0 [ 15.116983] ? start_kernel+0x612/0x612 [ 15.116983] ? _raw_spin_unlock_irq+0x29/0x40 [ 15.116983] ? finish_task_switch+0xdd/0x320 [ 15.116983] ? finish_task_switch+0x8e/0x320 [ 15.116983] ? rest_init+0xd0/0xd0 [ 15.116983] kernel_init+0xf/0x11a [ 15.116983] ? rest_init+0xd0/0xd0 [ 15.116983] ret_from_fork+0x24/0x30 [ 15.116983] The buggy address belongs to the variable: [ 15.116983] __key.36299+0x38/0x40 [ 15.116983] Memory state around the buggy address: [ 15.116983] ffffffffb9a5bf80: fa fa fa fa 00 fa fa fa fa fa fa fa 00 fa fa fa [ 15.116983] ffffffffb9a5c000: fa fa fa fa 00 fa fa fa fa fa fa fa 00 fa fa fa [ 15.116983] >ffffffffb9a5c080: fa fa fa fa 00 fa fa fa fa fa fa fa 00 00 00 00 [ 15.116983] ^ [ 15.116983] ffffffffb9a5c100: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 15.116983] ffffffffb9a5c180: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 15.116983] ================================================================== Fixes: 85b1407bf6 (ACPI / CPPC: Make CPPC ACPI driver aware of PCC subspace IDs) Reported-by: Changbin Du <changbin.du@intel.com> Signed-off-by: George Cherian <george.cherian@cavium.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>		2017-12-05 23:25:49 +01:00
..
acpica	Merge branch 'acpica'	2017-11-13 01:36:58 +01:00
apei	ACPI updates for v4.15-rc1	2017-11-13 20:08:22 -08:00
arm64	arm64 updates for 4.15	2017-11-15 10:56:56 -08:00
dptf	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfit	libnvdimm for 4.15	2017-11-17 09:51:57 -08:00
pmic	- New Drivers	2017-11-16 09:15:57 -08:00
x86	ACPI / x86: Extend KIOX000A quirk to cover all affected BIOS versions	2017-10-21 13:24:53 +02:00
Kconfig	- New Drivers	2017-11-16 09:15:57 -08:00
Makefile	- New Drivers	2017-11-16 09:15:57 -08:00
ac.c	ACPI: Mark expected switch fall-throughs	2017-11-09 00:55:16 +01:00
acpi_amba.c	ACPI / amba: Remove CLK_IS_ROOT	2016-04-27 23:42:57 +02:00
acpi_apd.c	ACPI / APD: Add clock frequency for ThunderX2 I2C controller	2017-10-17 23:52:54 +02:00
acpi_cmos_rtc.c	char/genrtc: x86: remove remnants of asm/rtc.h	2016-06-04 00:20:07 +02:00
acpi_configfs.c	ACPI: configfs: make config_item_type const	2017-10-19 16:15:29 +02:00
acpi_dbg.c	ACPI: fix whitespace in pr_fmt() to align log entries	2017-06-22 02:18:20 +02:00
acpi_extlog.c	ACPI: Switch to use generic guid_t in acpi_evaluate_dsm()	2017-06-07 12:20:49 +02:00
acpi_ipmi.c	ACPI / IPMI: change warning to debug on timeout	2017-04-07 12:25:37 -05:00
acpi_lpat.c	ACPI / lpat: Fix typos in comments and kerneldoc style	2017-07-24 22:52:00 +02:00
acpi_lpit.c	ACPI / LPIT: Add Low Power Idle Table (LPIT) support	2017-10-11 15:38:10 +02:00
acpi_lpss.c	ACPI updates for v4.15-rc1	2017-11-13 20:08:22 -08:00
acpi_memhotplug.c	ACPI: Remove FSF mailing addresses	2015-07-08 02:27:32 +02:00
acpi_pad.c	sched/headers: Prepare for new header dependencies before moving code to <uapi/linux/sched/types.h>	2017-03-02 08:42:27 +01:00
acpi_platform.c	ACPI / platform: Update platform device NUMA node based on _PXM method	2017-04-18 16:56:39 +02:00
acpi_pnp.c	ACPI / PNP: constify device IDs	2016-01-04 22:10:30 +01:00
acpi_processor.c	ACPI: Mark expected switch fall-throughs	2017-11-09 00:55:16 +01:00
acpi_video.c	dmi: Mark all struct dmi_system_id instances const	2017-09-14 11:59:30 +02:00
acpi_watchdog.c	ACPI / watchdog: properly initialize resources	2017-09-19 01:49:02 +02:00
battery.c	ACPI: make device_attribute const	2017-08-24 03:38:25 +02:00
battery.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
bgrt.c	ACPI: BGRT: constify attribute_group structures	2017-07-04 22:15:20 +02:00
blacklist.c	dmi: Mark all struct dmi_system_id instances const	2017-09-14 11:59:30 +02:00
bus.c	dmi: Mark all struct dmi_system_id instances const	2017-09-14 11:59:30 +02:00
button.c	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
cm_sbs.c	ACPI: Remove FSF mailing addresses	2015-07-08 02:27:32 +02:00
container.c	ACPI: Remove FSF mailing addresses	2015-07-08 02:27:32 +02:00
cppc_acpi.c	ACPI / CPPC: Fix KASAN global out of bounds warning	2017-12-05 23:25:49 +01:00
custom_method.c	…
debugfs.c	ACPI: fix acpi_debugfs_init prototype	2015-08-07 02:55:18 +02:00
device_pm.c	Merge branch 'pm-core'	2017-11-13 01:41:26 +01:00
device_sysfs.c	ACPI / bus: Leave modalias empty for devices which are not present	2017-11-20 23:48:51 +01:00
dock.c	ACPI: Mark expected switch fall-throughs	2017-11-09 00:55:16 +01:00
ec.c	Merge branch 'acpi-ec' into acpi	2017-11-30 13:37:29 +01:00
ec_sys.c	ACPI / EC: Deny write access unless requested by module param	2016-03-09 23:26:15 +01:00
event.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
evged.c	ACPI / GED: make evged.c explicitly non-modular	2016-05-09 22:59:25 +02:00
fan.c	ACPI / fan: Fix error reading cur_state	2016-10-10 02:20:43 +02:00
glue.c	IOMMU Updates for Linux v4.12	2017-05-09 15:15:47 -07:00
hed.c	ACPI: Remove FSF mailing addresses	2015-07-08 02:27:32 +02:00
internal.h	Merge branch 'acpi-ec' into acpi	2017-11-30 13:37:29 +01:00
ioapic.c	ACPI: fix whitespace in pr_fmt() to align log entries	2017-06-22 02:18:20 +02:00
irq.c	ACPI / irq: Fix return code of acpi_gsi_to_irq()	2017-07-12 13:11:49 +02:00
numa.c	ACPI: NUMA: Fix typo in the full name of SRAT	2017-07-24 22:27:44 +02:00
nvs.c	…
osi.c	dmi: Mark all struct dmi_system_id instances const	2017-09-14 11:59:30 +02:00
osl.c	ACPI / LPIT: Add Low Power Idle Table (LPIT) support	2017-10-11 15:38:10 +02:00
pci_irq.c	ACPI / PCI: fix GIC irq model default PCI IRQ polarity	2016-09-10 02:50:50 +02:00
pci_link.c	ACPI/PCI: pci_link: Include PIRQ_PENALTY_PCI_USING for ISA IRQs	2016-10-24 14:18:14 +02:00
pci_mcfg.c	PCI/ACPI: Add ThunderX pass2.x 2nd node MCFG quirk	2017-04-24 11:58:56 -05:00
pci_root.c	treewide: Consolidate Apple DMI checks	2017-08-03 23:26:22 +02:00
pci_slot.c	dmi: Mark all struct dmi_system_id instances const	2017-09-14 11:59:30 +02:00
power.c	ACPI / power: constify attribute_group structures	2017-07-04 22:15:14 +02:00
proc.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
processor_core.c	Revert"x86/acpi: Enable MADT APIs to return disabled apicids"	2017-03-11 14:41:18 +01:00
processor_driver.c	ACPI: processor: use dev_dbg() instead of dev_warn() when CPPC probe failed	2017-07-27 01:51:06 +02:00
processor_idle.c	Revert "x86/mm: Stop calling leave_mm() in idle code"	2017-11-04 15:01:50 +01:00
processor_pdc.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
processor_perflib.c	ACPI: processor_perflib: Simplify code and stop using CPUFREQ_START	2017-02-04 00:05:29 +01:00
processor_thermal.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
processor_throttling.c	acpi/processor: Prevent cpu hotplug deadlock	2017-05-26 10:10:47 +02:00
property.c	ACPI: properties: Fix __acpi_node_get_property_reference() return codes	2017-10-11 21:16:37 +02:00
reboot.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
resource.c	ACPI: Mark expected switch fall-throughs	2017-11-09 00:55:16 +01:00
sbs.c	Merge branches 'acpi-video', 'acpi-battery', 'acpi-spcr' and 'acpi-misc'	2017-09-03 23:54:29 +02:00
sbshc.c	Revert "ACPI / SBS: Add 5 us delay to fix SBS hangs on MacBook"	2015-11-16 23:26:45 +01:00
sbshc.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
scan.c	Merge branch 'acpi-ec' into acpi	2017-11-30 13:37:29 +01:00
sleep.c	ACPI / PM: Blacklist Low Power S0 Idle _DSM for Dell XPS13 9360	2017-11-06 23:56:57 +01:00
sleep.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
spcr.c	Merge branches 'acpi-video', 'acpi-battery', 'acpi-spcr' and 'acpi-misc'	2017-09-03 23:54:29 +02:00
sysfs.c	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
tables.c	ACPICA: Tables: Change table duplication check to be related to acpi_gbl_verify_table_checksum	2017-07-20 16:38:25 +02:00
thermal.c	dmi: Mark all struct dmi_system_id instances const	2017-09-14 11:59:30 +02:00
utils.c	ACPI / utils: Fix memory leak in acpi_evaluate_reference() error path	2017-11-14 12:54:55 +01:00
video_detect.c	ACPI / video: Add force_none quirk for Dell OptiPlex 9020M	2017-07-16 02:27:23 +02:00
wakeup.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00