Luke Nelson 489553dd13 riscv, bpf: Fix offset range checking for auipc+jalr on RV64 ... The existing code in emit_call on RV64 checks that the PC-relative offset to the function fits in 32 bits before calling emit_jump_and_link to emit an auipc+jalr pair. However, this check is incorrect because offsets in the range [2^31 - 2^11, 2^31 - 1] cannot be encoded using auipc+jalr on RV64 (see discussion [1]). The RISC-V spec has recently been updated to reflect this fact [2, 3]. This patch fixes the problem by moving the check on the offset into emit_jump_and_link and modifying it to the correct range of encodable offsets, which is [-2^31 - 2^11, 2^31 - 2^11). This also enforces the check on the offset to other uses of emit_jump_and_link (e.g., BPF_JA) as well. Currently, this bug is unlikely to be triggered, because the memory region from which JITed images are allocated is close enough to kernel text for the offsets to not become too large; and because the bounds on BPF program size are small enough. This patch prevents this problem from becoming an issue if either of these change. [1]: https://groups.google.com/a/groups.riscv.org/forum/#!topic/isa-dev/bwWFhBnnZFQ [2]: b1e42e09ac [3]: 4c1b2066eb Signed-off-by: Luke Nelson <luke.r.nels@gmail.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: https://lore.kernel.org/bpf/20200406221604.18547-1-luke.r.nels@gmail.com		2020-04-08 00:53:41 +02:00
..
Makefile	riscv, bpf: Add RV32G eBPF JIT	2020-03-05 16:13:47 +01:00
bpf_jit.h	riscv, bpf: Add RV32G eBPF JIT	2020-03-05 16:13:47 +01:00
bpf_jit_comp32.c	riscv, bpf: Add RV32G eBPF JIT	2020-03-05 16:13:47 +01:00
bpf_jit_comp64.c	riscv, bpf: Fix offset range checking for auipc+jalr on RV64	2020-04-08 00:53:41 +02:00
bpf_jit_core.c	riscv, bpf: Factor common RISC-V JIT code	2020-03-05 16:13:47 +01:00