Marco Pinna 065012bb77 vsock/virtio: fix packet delivery to tap device ... commit b32a09ea7c38849ff925489a6bf5bd8914bc45df upstream. Commit 82dfb540ae ("VSOCK: Add virtio vsock vsockmon hooks") added virtio_transport_deliver_tap_pkt() for handing packets to the vsockmon device. However, in virtio_transport_send_pkt_work(), the function is called before actually sending the packet (i.e. before placing it in the virtqueue with virtqueue_add_sgs() and checking whether it returned successfully). Queuing the packet in the virtqueue can fail even multiple times. However, in virtio_transport_deliver_tap_pkt() we deliver the packet to the monitoring tap interface only the first time we call it. This certainly avoids seeing the same packet replicated multiple times in the monitoring interface, but it can show the packet sent with the wrong timestamp or even before we succeed to queue it in the virtqueue. Move virtio_transport_deliver_tap_pkt() after calling virtqueue_add_sgs() and making sure it returned successfully. Fixes: 82dfb540ae ("VSOCK: Add virtio vsock vsockmon hooks") Cc: stable@vge.kernel.org Signed-off-by: Marco Pinna <marco.pinn95@gmail.com> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Link: https://lore.kernel.org/r/20240329161259.411751-1-marco.pinn95@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-04-10 16:35:50 +02:00
..
Kconfig	vsock: add vsock_loopback transport	2019-12-11 15:01:23 -08:00
Makefile	vsock: support sockmap	2023-03-29 08:19:38 +01:00
af_vsock.c	virtio/vsock: send credit update during setting SO_RCVLOWAT	2024-01-25 15:35:26 -08:00
af_vsock_tap.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
diag.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 321	2019-06-05 17:37:05 +02:00
hyperv_transport.c	virtio/vsock: send credit update during setting SO_RCVLOWAT	2024-01-25 15:35:26 -08:00
virtio_transport.c	vsock/virtio: fix packet delivery to tap device	2024-04-10 16:35:50 +02:00
virtio_transport_common.c	virtio/vsock: send credit update during setting SO_RCVLOWAT	2024-01-25 15:35:26 -08:00
vmci_transport.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-04-06 12:01:20 -07:00
vmci_transport.h	vsock: Remove unused function declarations	2023-07-31 14:41:08 -07:00
vmci_transport_notify.c	vmci/vsock: check SO_RCVLOWAT before wake up reader	2022-08-23 10:43:12 +02:00
vmci_transport_notify.h	vsock: remove include/linux/vm_sockets.h file	2019-11-14 18:12:17 -08:00
vmci_transport_notify_qstate.c	vmci/vsock: check SO_RCVLOWAT before wake up reader	2022-08-23 10:43:12 +02:00
vsock_addr.c	vsock_addr: Check for supported flag values	2020-12-14 19:33:39 -08:00
vsock_bpf.c	vsock: support sockmap	2023-03-29 08:19:38 +01:00
vsock_loopback.c	virtio/vsock: send credit update during setting SO_RCVLOWAT	2024-01-25 15:35:26 -08:00