UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity
OpenCloudOS-Kernel/drivers/hwtracing/coresight
History
Suzuki K Poulose 257c7a3909 coresight: tmc: sg: Do not leak sg_table 
[ Upstream commit c58dc5a1f886f2fcc1133746d0cbaa1fe7fd44ff ]

Running perf with cs_etm on Juno triggers the following kmemleak warning !

:~# cat /sys/kernel/debug/kmemleak
 unreferenced object 0xffffff8806b6d720 (size 96):
 comm "perf", pid 562, jiffies 4297810960
 hex dump (first 32 bytes):
 38 d8 13 07 88 ff ff ff 00 d0 9e 85 c0 ff ff ff  8...............
 00 10 00 88 c0 ff ff ff 00 f0 ff f7 ff 00 00 00  ................
 backtrace (crc 1dbf6e00):
 [<ffffffc08107381c>] kmemleak_alloc+0xbc/0xd8
 [<ffffffc0802f9798>] kmalloc_trace_noprof+0x220/0x2e8
 [<ffffffc07bb71948>] tmc_alloc_sg_table+0x48/0x208 [coresight_tmc]
 [<ffffffc07bb71cbc>] tmc_etr_alloc_sg_buf+0xac/0x240 [coresight_tmc]
 [<ffffffc07bb72538>] tmc_alloc_etr_buf.constprop.0+0x1f0/0x260 [coresight_tmc]
 [<ffffffc07bb7280c>] alloc_etr_buf.constprop.0.isra.0+0x74/0xa8 [coresight_tmc]
 [<ffffffc07bb72950>] tmc_alloc_etr_buffer+0x110/0x260 [coresight_tmc]
 [<ffffffc07bb38afc>] etm_setup_aux+0x204/0x3b0 [coresight]
 [<ffffffc08025837c>] rb_alloc_aux+0x20c/0x318
 [<ffffffc08024dd84>] perf_mmap+0x2e4/0x7a0
 [<ffffffc0802cceb0>] mmap_region+0x3b0/0xa08
 [<ffffffc0802cd8a8>] do_mmap+0x3a0/0x500
 [<ffffffc080295328>] vm_mmap_pgoff+0x100/0x1d0
 [<ffffffc0802cadf8>] ksys_mmap_pgoff+0xb8/0x110
 [<ffffffc080020688>] __arm64_sys_mmap+0x38/0x58
 [<ffffffc080028fc0>] invoke_syscall.constprop.0+0x58/0x100

This due to the fact that we do not free the "sg_table" itself while
freeing up  the SG table and data pages. Fix this by freeing the sg_table
in tmc_free_sg_table().

Fixes: 99443ea19e ("coresight: Add generic TMC sg table framework")
Cc: Mike Leach <mike.leach@linaro.org>
Cc: James Clark <james.clark@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Link: https://lore.kernel.org/r/20240702132846.1677261-1-suzuki.poulose@arm.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
 		2024-10-04 16:29:40 +02:00
..
Kconfig Coresight: Add coresight dummy driver 2023-06-15 08:50:23 +01:00
Makefile Coresight: Add coresight dummy driver 2023-06-15 08:50:23 +01:00
coresight-catu.c coresight: Enable and disable helper devices adjacent to the path 2023-06-05 15:46:47 +01:00
coresight-catu.h coresight: Make new csdev_access offsets unsigned 2022-08-31 10:56:36 -06:00
coresight-cfg-afdo.c coresight: config: Add preloaded configurations 2021-08-18 22:33:28 +02:00
coresight-cfg-preload.c coresight: configuration: Update API to introduce load owner concept 2021-11-26 11:27:21 -07:00
coresight-cfg-preload.h coresight: config: Add preloaded configurations 2021-08-18 22:33:28 +02:00
coresight-config.c coresight: config: Add configuration and feature generic functions 2021-08-18 22:33:27 +02:00
coresight-config.h coresight: syscfg: Update load and unload operations 2022-06-29 09:35:58 -06:00
coresight-core.c coresight: Fix issue where a source device's helpers aren't disabled 2024-03-26 18:20:05 -04:00
coresight-cpu-debug.c coresight: cpu-debug: Replace mutex with mutex_trylock on panic notifier 2022-05-09 16:03:24 +01:00
coresight-cti-core.c coresight: Fix all W=1 build warnings 2023-07-26 18:01:52 +01:00
coresight-cti-platform.c coresight: cti: Reduce scope for the variable 'cs_fwnode' in cti_plat_create_connection() 2021-02-04 17:00:32 +01:00
coresight-cti-sysfs.c coresight: Fix CTI module refcount leak by making it a helper device 2023-06-05 15:46:47 +01:00
coresight-cti.h coresight: Fix CTI module refcount leak by making it a helper device 2023-06-05 15:46:47 +01:00
coresight-dummy.c coresight: dummy: simplify the code with module_platform_driver 2023-08-04 14:17:30 +01:00
coresight-etb10.c coresight: Make refcount a property of the connection 2023-06-05 15:46:46 +01:00
coresight-etm-cp14.c
…
coresight-etm-perf.c coresight: Fix issue where a source device's helpers aren't disabled 2024-03-26 18:20:05 -04:00
coresight-etm-perf.h coresight: perf: Output trace id only once 2023-01-24 10:41:46 +00:00
coresight-etm.h coresight: etmX.X: stm: Remove trace_id() callback 2023-01-19 10:16:47 +00:00
coresight-etm3x-core.c coresight: Use enum type for cs_mode wherever possible 2023-06-05 15:46:45 +01:00
coresight-etm3x-sysfs.c coresight: etm3x: Update ETM3 driver to use Trace ID API 2023-01-19 10:16:47 +00:00
coresight-etm4x-cfg.c coresight: Fix all W=1 build warnings 2023-07-26 18:01:52 +01:00
coresight-etm4x-cfg.h coresight: config: Add preloaded configurations 2021-08-18 22:33:28 +02:00
coresight-etm4x-core.c coresight: etm4x: Fix access to resource selector registers 2024-06-12 11:12:22 +02:00
coresight-etm4x-sysfs.c coresight: etm4x: Fix missing trctraceidr file in sysfs 2023-06-06 10:39:15 +01:00
coresight-etm4x.h coresight: etm4x: Safe access for TRCQCLTR 2024-06-12 11:12:22 +02:00
coresight-funnel.c coresight: Make refcount a property of the connection 2023-06-05 15:46:46 +01:00
coresight-platform.c coresight: Fix ref leak when of_coresight_parse_endpoint() fails 2024-08-03 08:53:57 +02:00
coresight-priv.h coresight: Fix issue where a source device's helpers aren't disabled 2024-03-26 18:20:05 -04:00
coresight-replicator.c coresight: Make refcount a property of the connection 2023-06-05 15:46:46 +01:00
coresight-self-hosted-trace.h coresight: trbe: Prohibit trace before disabling TRBE 2021-10-27 11:45:33 -06:00
coresight-stm.c coresight: Use enum type for cs_mode wherever possible 2023-06-05 15:46:45 +01:00
coresight-syscfg-configfs.c coresight: configfs: Allow configfs to activate configuration 2021-11-26 11:34:27 -07:00
coresight-syscfg-configfs.h coresight: configfs: Allow configfs to activate configuration 2021-11-26 11:34:27 -07:00
coresight-syscfg.c coresight: syscfg: Update load and unload operations 2022-06-29 09:35:58 -06:00
coresight-syscfg.h coresight: syscfg: Update load and unload operations 2022-06-29 09:35:58 -06:00
coresight-sysfs.c coresight: Fix CTI module refcount leak by making it a helper device 2023-06-05 15:46:47 +01:00
coresight-tmc-core.c coresight: tmc: Don't enable TMC when it's not ready. 2023-01-30 11:45:32 +00:00
coresight-tmc-etf.c coresight: tmc: Explicit type conversions to prevent integer overflow 2023-08-04 10:52:32 +01:00
coresight-tmc-etr.c coresight: tmc: sg: Do not leak sg_table 2024-10-04 16:29:40 +02:00
coresight-tmc.h coresight: tmc: Explicit type conversions to prevent integer overflow 2023-08-04 10:52:32 +01:00
coresight-tpda.c coresight: Make refcount a property of the connection 2023-06-05 15:46:46 +01:00
coresight-tpda.h Coresight: Add TPDA link driver 2023-01-20 11:39:03 +00:00
coresight-tpdm.c coresight: Use enum type for cs_mode wherever possible 2023-06-05 15:46:45 +01:00
coresight-tpdm.h coresight-tpdm: Add integration test support 2023-01-20 11:39:03 +00:00
coresight-tpiu.c coresight: Make refcount a property of the connection 2023-06-05 15:46:46 +01:00
coresight-trace-id.c coresight: trace-id: Add debug & test macros to Trace ID allocation 2023-01-19 10:16:47 +00:00
coresight-trace-id.h coresight: trace-id: Add API to dynamically assign Trace ID values 2023-01-19 10:16:46 +00:00
coresight-trbe.c coresight: trbe: Fix TRBE potential sleep in atomic context 2023-08-18 16:42:26 +01:00
coresight-trbe.h coresight: trbe: Directly use ID_AA64DFR0_EL1_TraceBuffer_IMP 2023-08-02 12:53:28 +01:00
ultrasoc-smb.c coresight: ultrasoc-smb: Fix uninitialized before use buf_hw_base 2023-12-13 18:45:29 +01:00
ultrasoc-smb.h coresight: ultrasoc-smb: Fix sleep while close preempt in enable_smb 2023-12-13 18:45:28 +01:00