59ae1d127a
A common pattern with skb_put() is to just want to memcpy()
some data into the new space, introduce skb_put_data() for
this.
An spatch similar to the one for skb_put_zero() converts many
of the places using it:
@@
identifier p, p2;
expression len, skb, data;
type t, t2;
@@
(
-p = skb_put(skb, len);
+p = skb_put_data(skb, data, len);
|
-p = (t)skb_put(skb, len);
+p = skb_put_data(skb, data, len);
)
(
p2 = (t2)p;
-memcpy(p2, data, len);
|
-memcpy(p, data, len);
)
@@
type t, t2;
identifier p, p2;
expression skb, data;
@@
t *p;
...
(
-p = skb_put(skb, sizeof(t));
+p = skb_put_data(skb, data, sizeof(t));
|
-p = (t *)skb_put(skb, sizeof(t));
+p = skb_put_data(skb, data, sizeof(t));
)
(
p2 = (t2)p;
-memcpy(p2, data, sizeof(*p));
|
-memcpy(p, data, sizeof(*p));
)
@@
expression skb, len, data;
@@
-memcpy(skb_put(skb, len), data, len);
+skb_put_data(skb, data, len);
(again, manually post-processed to retain some comments)
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| TODO | ||
| basic_types.h | ||
| drv_types.h | ||
| ethernet.h | ||
| hal_init.c | ||
| ieee80211.c | ||
| ieee80211.h | ||
| mlme_linux.c | ||
| mlme_osdep.h | ||
| mp_custom_oid.h | ||
| os_intfs.c | ||
| osdep_intf.h | ||
| osdep_service.h | ||
| recv_linux.c | ||
| recv_osdep.h | ||
| rtl871x_cmd.c | ||
| rtl871x_cmd.h | ||
| rtl871x_debug.h | ||
| rtl871x_eeprom.c | ||
| rtl871x_eeprom.h | ||
| rtl871x_event.h | ||
| rtl871x_ht.h | ||
| rtl871x_io.c | ||
| rtl871x_io.h | ||
| rtl871x_ioctl.h | ||
| rtl871x_ioctl_linux.c | ||
| rtl871x_ioctl_rtl.c | ||
| rtl871x_ioctl_rtl.h | ||
| rtl871x_ioctl_set.c | ||
| rtl871x_ioctl_set.h | ||
| rtl871x_led.h | ||
| rtl871x_mlme.c | ||
| rtl871x_mlme.h | ||
| rtl871x_mp.c | ||
| rtl871x_mp.h | ||
| rtl871x_mp_ioctl.c | ||
| rtl871x_mp_ioctl.h | ||
| rtl871x_mp_phy_regdef.h | ||
| rtl871x_pwrctrl.c | ||
| rtl871x_pwrctrl.h | ||
| rtl871x_recv.c | ||
| rtl871x_recv.h | ||
| rtl871x_rf.h | ||
| rtl871x_security.c | ||
| rtl871x_security.h | ||
| rtl871x_sta_mgt.c | ||
| rtl871x_wlan_sme.h | ||
| rtl871x_xmit.c | ||
| rtl871x_xmit.h | ||
| rtl8712_bitdef.h | ||
| rtl8712_cmd.c | ||
| rtl8712_cmd.h | ||
| rtl8712_cmdctrl_bitdef.h | ||
| rtl8712_cmdctrl_regdef.h | ||
| rtl8712_debugctrl_bitdef.h | ||
| rtl8712_debugctrl_regdef.h | ||
| rtl8712_edcasetting_bitdef.h | ||
| rtl8712_edcasetting_regdef.h | ||
| rtl8712_efuse.c | ||
| rtl8712_efuse.h | ||
| rtl8712_event.h | ||
| rtl8712_fifoctrl_bitdef.h | ||
| rtl8712_fifoctrl_regdef.h | ||
| rtl8712_gp_bitdef.h | ||
| rtl8712_gp_regdef.h | ||
| rtl8712_hal.h | ||
| rtl8712_interrupt_bitdef.h | ||
| rtl8712_io.c | ||
| rtl8712_led.c | ||
| rtl8712_macsetting_bitdef.h | ||
| rtl8712_macsetting_regdef.h | ||
| rtl8712_powersave_bitdef.h | ||
| rtl8712_powersave_regdef.h | ||
| rtl8712_ratectrl_bitdef.h | ||
| rtl8712_ratectrl_regdef.h | ||
| rtl8712_recv.c | ||
| rtl8712_recv.h | ||
| rtl8712_regdef.h | ||
| rtl8712_security_bitdef.h | ||
| rtl8712_spec.h | ||
| rtl8712_syscfg_bitdef.h | ||
| rtl8712_syscfg_regdef.h | ||
| rtl8712_timectrl_bitdef.h | ||
| rtl8712_timectrl_regdef.h | ||
| rtl8712_wmac_bitdef.h | ||
| rtl8712_wmac_regdef.h | ||
| rtl8712_xmit.c | ||
| rtl8712_xmit.h | ||
| sta_info.h | ||
| usb_halinit.c | ||
| usb_intf.c | ||
| usb_ops.c | ||
| usb_ops.h | ||
| usb_ops_linux.c | ||
| usb_osintf.h | ||
| wifi.h | ||
| wlan_bssdef.h | ||
| xmit_linux.c | ||
| xmit_osdep.h | ||