OpenCloudOS-Kernel/drivers/scsi/cxgbi/cxgb3i
Colin Ian King ea63e60f7a scsi: cxgbi: remove redundant __kfree_skb call on skb and free cst->atid
The error return path via label rel_resource checks for a non-null skb
before free'ing it.  However, skb is always null at this exit path, so the
null check and the free are redundant and can be removed.  Removing this
allows the original goto's to rel_resource to be cleaned up; the first can
be replaced by a return of -EINVAL, the second can be replaced by a more
appropriate -ENOMEM return and fix a memory leak by freeing csk->atid.

Addresses-Coverity: ("Logically Dead Code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2019-04-12 20:05:31 -04:00
..
Kbuild cxgb4i,libcxgbi: add iSCSI DDP support 2016-07-25 10:31:08 -07:00
Kconfig cxgb4i,libcxgbi: add iSCSI DDP support 2016-07-25 10:31:08 -07:00
cxgb3i.c scsi: cxgbi: remove redundant __kfree_skb call on skb and free cst->atid 2019-04-12 20:05:31 -04:00
cxgb3i.h cxgbi: update copyright to 2015 2015-05-25 08:46:25 -07:00