Yonghong Song 8cc32a9bbf kallsyms: strip LTO-only suffixes from promoted global functions ... Commit 6eb4bd92c1 ("kallsyms: strip LTO suffixes from static functions") stripped all function/variable suffixes started with '.' regardless of whether those suffixes are generated at LTO mode or not. In fact, as far as I know, in LTO mode, when a static function/variable is promoted to the global scope, '.llvm.<...>' suffix is added. The existing mechanism breaks live patch for a LTO kernel even if no <symbol>.llvm.<...> symbols are involved. For example, for the following kernel symbols: $ grep bpf_verifier_vlog /proc/kallsyms ffffffff81549f60 t bpf_verifier_vlog ffffffff8268b430 d bpf_verifier_vlog._entry ffffffff8282a958 d bpf_verifier_vlog._entry_ptr ffffffff82e12a1f d bpf_verifier_vlog.__already_done 'bpf_verifier_vlog' is a static function. '_entry', '_entry_ptr' and '__already_done' are static variables used inside 'bpf_verifier_vlog', so llvm promotes them to file-level static with prefix 'bpf_verifier_vlog.'. Note that the func-level to file-level static function promotion also happens without LTO. Given a symbol name 'bpf_verifier_vlog', with LTO kernel, current mechanism will return 4 symbols to live patch subsystem which current live patching subsystem cannot handle it. With non-LTO kernel, only one symbol is returned. In [1], we have a lengthy discussion, the suggestion is to separate two cases: (1). new symbols with suffix which are generated regardless of whether LTO is enabled or not, and (2). new symbols with suffix generated only when LTO is enabled. The cleanup_symbol_name() should only remove suffixes for case (2). Case (1) should not be changed so it can work uniformly with or without LTO. This patch removed LTO-only suffix '.llvm.<...>' so live patching and tracing should work the same way for non-LTO kernel. The cleanup_symbol_name() in scripts/kallsyms.c is also changed to have the same filtering pattern so both kernel and kallsyms tool have the same expectation on the order of symbols. [1] https://lore.kernel.org/live-patching/20230615170048.2382735-1-song@kernel.org/T/#u Fixes: 6eb4bd92c1 ("kallsyms: strip LTO suffixes from static functions") Reported-by: Song Liu <song@kernel.org> Signed-off-by: Yonghong Song <yhs@fb.com> Reviewed-by: Zhen Lei <thunder.leizhen@huawei.com> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Acked-by: Song Liu <song@kernel.org> Link: https://lore.kernel.org/r/20230628181926.4102448-1-yhs@fb.com Signed-off-by: Kees Cook <keescook@chromium.org>		2023-07-12 15:39:34 -07:00
..
atomic	locking/atomic: scripts: fix ${atomic}_dec_if_positive() kerneldoc	2023-06-16 16:46:30 +02:00
basic	kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion	2023-06-22 21:21:06 +09:00
clang-tools	scripts: handle BrokenPipeError for python scripts	2023-01-26 12:43:33 +09:00
coccinelle	coccinelle: api/atomic_as_refcounter: include message type in output	2022-12-26 21:47:12 +01:00
dtc	dts: add riscv include prefix link	2023-03-27 22:45:22 +02:00
dummy-tools	kbuild: dummy-tools: pretend we understand __LONG_DOUBLE_128__	2022-08-21 02:47:48 +09:00
gcc-plugins	Merge branch 'for-linus/hardening' into for-next/hardening	2023-02-02 18:43:28 +00:00
gdb	scripts/gdb: fix SB_* constants parsing	2023-06-19 13:19:32 -07:00
genksyms	genksyms: adjust the output format to modpost	2022-05-24 16:33:20 +09:00
kconfig	streamline_config.pl: handle also ${CONFIG_FOO}	2023-06-08 11:11:32 +09:00
ksymoops	…
mod	Kbuild updates for v6.5	2023-07-01 09:24:31 -07:00
package	kbuild: deb-pkg: remove the CONFIG_MODULES check in buildeb	2023-06-27 08:31:27 +09:00
selinux	selinux: remove runtime disable message in the install_policy.sh script	2022-09-20 14:12:25 -04:00
tracing	tracing: Always use canonical ftrace path	2023-02-18 14:34:09 -05:00
.gitignore	kbuild: use git-archive for source package creation	2023-03-16 22:46:12 +09:00
Kbuild.include	kbuild: replace $(dot-target).tmp in filechk with $(tmp-target)	2023-01-22 23:43:33 +09:00
Kconfig.include	kbuild: Update assembler calls to use proper flags and language target	2023-01-26 12:41:38 +09:00
Lindent	…
Makefile	kbuild: use git-archive for source package creation	2023-03-16 22:46:12 +09:00
Makefile.asm-generic	kbuild: add kbuild-file macro	2022-11-22 23:40:02 +09:00
Makefile.build	Kbuild updates for v6.5	2023-07-01 09:24:31 -07:00
Makefile.clang	Kbuild updates for v6.5	2023-07-01 09:24:31 -07:00
Makefile.clean	kbuild: make clean rule robust against too long argument error	2023-06-25 23:12:20 +09:00
Makefile.compiler	Kbuild updates for v6.5	2023-07-01 09:24:31 -07:00
Makefile.debug	Makefile.debug: support for -gz=zstd	2022-11-21 10:18:39 +09:00
Makefile.defconf	kbuild: Provide a version of merge_into_defconfig without override warnings	2023-02-13 20:18:28 +01:00
Makefile.dtbinst	kbuild: Support flat DTBs install	2023-06-21 07:51:08 -06:00
Makefile.extrawarn	kbuild: add -Wundef to KBUILD_CPPFLAGS for W=1 builds	2022-12-11 17:28:32 +09:00
Makefile.gcc-plugins	gcc-plugins: Undefine LATENT_ENTROPY_PLUGIN when plugin disabled for a file	2022-08-16 12:25:53 -07:00
Makefile.headersinst	…
Makefile.host	kbuild: remove sed commands after rustc rules	2023-01-22 23:43:33 +09:00
Makefile.kasan	kasan: remove hwasan-kernel-mem-intrinsic-prefix=1 for clang-14	2023-04-18 16:29:43 -07:00
Makefile.kcov	…
Makefile.kcsan	kcsan: Ignore GCC 11+ warnings about TSan runtime support	2021-12-09 16:42:27 -08:00
Makefile.kmsan	kmsan: add KMSAN runtime core	2022-10-03 14:03:19 -07:00
Makefile.lib	kbuild: Disallow DTB overlays to built from .dts named source files	2023-05-22 10:34:37 +09:00
Makefile.modfinal	kbuild: Disable GCOV for *.mod.o	2023-06-25 23:12:20 +09:00
Makefile.modinst	modules-6.3-rc1	2023-02-23 14:05:08 -08:00
Makefile.modpost	kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion	2023-06-22 21:21:06 +09:00
Makefile.package	Kbuild updates for v6.4	2023-04-30 11:32:53 -07:00
Makefile.randstruct	randstruct: Enable Clang support	2022-05-08 01:33:07 -07:00
Makefile.ubsan	ubsan: Tighten UBSAN_BOUNDS on GCC	2023-05-16 13:57:14 -07:00
Makefile.userprogs	…
Makefile.vmlinux	kbuild: Fix CFI failures with GCOV	2023-06-25 23:12:20 +09:00
Makefile.vmlinux_o	kbuild: move modules.builtin(.modinfo) rules to Makefile.vmlinux_o	2022-10-03 03:52:58 +09:00
as-version.sh	kbuild: Update assembler calls to use proper flags and language target	2023-01-26 12:41:38 +09:00
asn1_compiler.c	ASN.1: Fix check for strdup() success	2023-04-21 08:58:00 -07:00
bloat-o-meter	scripts/bloat-o-meter: use the reverse flag for sort	2023-02-02 22:50:03 -08:00
bootgraph.pl	…
bpf_doc.py	bpf: Remove extra whitespace in SPDX tag for syscall/helpers man pages	2023-04-11 17:45:57 +02:00
cc-can-link.sh	…
cc-version.sh	scripts: Remove ICC-related dead code	2023-04-24 10:18:32 -07:00
check-git	kbuild: use git-archive for source package creation	2023-03-16 22:46:12 +09:00
check-sysctl-docs	sysctl: Remove register_sysctl_table	2023-05-23 21:43:26 -07:00
check_extable.sh	scripts: check_extable: fix typo in user error message	2021-09-08 11:50:28 -07:00
checkdeclares.pl	scripts: make some scripts executable	2021-08-10 09:13:25 +09:00
checkincludes.pl	…
checkkconfigsymbols.py	scripts: handle BrokenPipeError for python scripts	2023-01-26 12:43:33 +09:00
checkpatch.pl	Scope-based Resource Management infrastructure	2023-07-04 13:50:38 -07:00
checkstack.pl	sh: remove sh5/sh64 last fragments	2023-03-23 10:02:02 +01:00
checksyscalls.sh	checksyscalls: ignore fstat to silence build warning on LoongArch	2023-03-23 17:18:32 -07:00
checkversion.pl	scripts: checkversion: modernize linux/version.h search strings	2021-08-05 20:55:39 +09:00
cleanfile	…
cleanpatch	…
coccicheck	scripts: coccicheck: Use /usr/bin/env	2023-02-25 20:11:06 +01:00
config	…
const_structs.checkpatch	const_structs.checkpatch.pl: add kobj_type	2023-02-08 13:33:29 +01:00
decode_stacktrace.sh	scripts: decode_stacktrace: demangle Rust symbols	2022-09-28 09:01:40 +02:00
decodecode	scripts/decodecode: Add support for RISC-V	2023-02-21 16:53:54 -08:00
depmod.sh	…
dev-needs.sh	…
diffconfig	scripts: handle BrokenPipeError for python scripts	2023-01-26 12:43:33 +09:00
documentation-file-ref-check	scripts: documentation-file-ref-check: fix bpf selftests path	2021-10-26 09:42:29 -06:00
export_report.pl	…
extract-ikconfig	scripts/extract-ikconfig: add zstd compression support	2022-08-29 13:58:47 +09:00
extract-module-sig.pl	…
extract-sys-certs.pl	…
extract-vmlinux	…
extract_xc3028.pl	…
faddr2line	scripts/faddr2line: Fix regression in name resolution on ppc64le	2022-11-16 10:42:10 +01:00
file-size.sh	…
find-unused-docs.sh	…
gcc-x86_32-has-stack-protector.sh	…
gcc-x86_64-has-stack-protector.sh	…
gen-randstruct-seed.sh	randstruct: Move seed generation into scripts/basic/	2022-05-08 01:33:07 -07:00
generate_initcall_order.pl	…
generate_rust_analyzer.py	scripts: generate_rust_analyzer: Handle sub-modules with no Makefile	2023-04-07 00:53:34 +02:00
generate_rust_target.rs	x86: enable initial Rust support	2022-09-28 09:02:45 +02:00
get_abi.pl	scripts/get_abi: Fix wrong script file name in the help message	2022-04-24 10:38:44 +02:00
get_dvb_firmware	…
get_feat.pl	scripts: get_feat.pl: use /usr/bin/env to find perl	2022-06-30 12:22:17 -06:00
get_maintainer.pl	get_maintainer: Honor mailmap for in file emails	2022-04-29 14:38:00 -07:00
gfp-translate	scripts: fix the gfp flags header path in gfp-translate	2023-06-19 13:19:32 -07:00
head-object-list.txt	powerpc/64: Rename entry_64.S to prom_entry_64.S	2023-06-15 14:04:19 +10:00
headerdep.pl	…
headers_install.sh	scripts: Update the CONFIG_* ignore list in headers_install.sh	2023-03-10 21:05:16 +01:00
insert-sys-cert.c	…
install.sh	kbuild: factor out the common installation code into scripts/install.sh	2022-05-11 21:45:53 +09:00
is_rust_module.sh	rust: fix regexp in scripts/is_rust_module.sh	2023-04-19 19:28:49 +02:00
jobserver-exec	scripts: support GNU make 4.4 in jobserver-exec	2023-01-16 20:15:20 +09:00
kallsyms.c	kallsyms: strip LTO-only suffixes from promoted global functions	2023-07-12 15:39:34 -07:00
kernel-doc	A half-dozen late arriving docs patches. They are mostly fixes, but we	2023-07-06 22:15:38 -07:00
ld-version.sh	kbuild: collect minimum tool versions into scripts/min-tool-version.sh	2021-04-25 05:14:26 +09:00
leaking_addresses.pl	leaking_addresses: also skip canonical ftrace path	2023-03-29 06:52:08 -04:00
link-vmlinux.sh	Kbuild updates for v6.4	2023-04-30 11:32:53 -07:00
makelst	…
markup_oops.pl	…
min-tool-version.sh	parisc: Raise minimal GCC version to 12.0.0	2023-07-03 18:56:03 +02:00
misc-check	kbuild: make W=1 warn files that are tracked but ignored by git	2023-01-22 23:43:33 +09:00
mkcompile_h	Revert "kbuild: Make scripts/compile.h when sh != bash"	2022-09-29 04:40:15 +09:00
mksysmap	scripts/mksysmap: Ignore prefixed KCFI symbols	2023-06-27 08:35:43 +09:00
mkuboot.sh	…
module.lds.S	arm64: unwind: add asynchronous unwind tables to kernel and modules	2022-11-09 18:06:35 +00:00
modules-check.sh	kbuild: change module.order to list *.o instead of *.ko	2022-12-14 15:42:40 +09:00
nsdeps	scripts/nsdeps: adjust to the format change of *.mod files	2022-06-08 20:14:13 +09:00
objdiff	kbuild: clean .tmp_* pattern by make clean	2022-06-05 06:20:57 +09:00
objdump-func	scripts/objdump-func: Support multiple functions	2023-04-14 16:08:28 +02:00
orc_hash.sh	x86/unwind/orc: Add ELF section with ORC version identifier	2023-06-16 17:17:42 +02:00
pahole-flags.sh	bpf: Add --skip_encoding_btf_inconsistent_proto, --btf_gen_optimized to pahole flags for v1.25	2023-05-12 11:47:05 -07:00
pahole-version.sh	kbuild: Add CONFIG_PAHOLE_VERSION	2022-02-02 11:19:33 +01:00
parse-maintainers.pl	…
patch-kernel	…
profile2linkerlist.pl	…
prune-kernel	scripts/prune-kernel: Use kernel-install if available	2022-05-11 21:46:38 +09:00
recordmcount.c	recordmcount: Fix memory leaks in the uwrite function	2023-04-25 21:10:20 -04:00
recordmcount.h	recordmcount: Correct st_shndx handling	2021-06-18 09:09:17 -04:00
recordmcount.pl	nds32: Remove the architecture	2022-03-07 13:54:59 +01:00
relocs_check.sh	powerpc: Move script to check relocations at compile time in scripts/	2023-04-19 07:46:31 -07:00
remove-stale-files	kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion	2023-06-22 21:21:06 +09:00
rust_is_available.sh	scripts: add `rust_is_available.sh`	2022-09-28 09:02:06 +02:00
rust_is_available_bindgen_libclang.h	scripts: add `rust_is_available.sh`	2022-09-28 09:02:06 +02:00
setlocalversion	kbuild: use git-archive for source package creation	2023-03-16 22:46:12 +09:00
show_delta	…
sign-file.c	sign-file: Fix confusing error messages	2022-08-03 23:56:20 +03:00
sorttable.c	LoongArch: extable: Add `type` and `data` fields	2022-12-14 08:36:11 +08:00
sorttable.h	x86,objtool: Split UNWIND_HINT_EMPTY in two	2023-03-23 23:18:58 +01:00
spdxcheck-test.sh	docs: move Linux logo into a new `images` folder	2022-06-01 09:32:45 -06:00
spdxcheck.py	scripts/spdxcheck: Put excluded files and directories into a separate file	2022-05-18 15:34:33 +02:00
spdxexclude	scripts/spdxcheck: Exclude top-level README	2022-05-18 15:35:42 +02:00
spelling.txt	scripts/spelling.txt: add more spellings to spelling.txt	2023-06-09 17:44:13 -07:00
sphinx-pre-install	docs: sphinx-pre-install: don't require the RTD theme	2022-10-13 11:14:43 -06:00
split-man.pl	…
stackdelta	…
stackusage	…
subarch.include	LoongArch: Add build infrastructure	2022-06-03 20:09:27 +08:00
syscallhdr.sh	scripts: check duplicated syscall number in syscall table	2021-07-09 04:00:39 +09:00
syscallnr.sh	scripts: make some scripts executable	2021-08-10 09:13:25 +09:00
syscalltbl.sh	scripts: check duplicated syscall number in syscall table	2021-07-09 04:00:39 +09:00
tags.sh	Char/Misc and other driver subsystem updates for 6.5-rc1	2023-07-03 12:46:47 -07:00
test_fortify.sh	fortify: Update compile-time tests for Clang 14	2022-02-13 16:50:06 -08:00
tools-support-relr.sh	Makefile: use -z pack-relative-relocs	2023-04-17 11:23:06 +09:00
unifdef.c	…
ver_linux	Removed the oprofiled version option	2021-05-03 17:23:06 -06:00
xen-hypercalls.sh	scripts: make some scripts executable	2021-08-10 09:13:25 +09:00
xz_wrap.sh	…